From d28790072b2a8f48062232b8c4e70adf4d88e0d9 Mon Sep 17 00:00:00 2001 From: ota-meshi Date: Mon, 20 Nov 2023 17:45:18 +0900 Subject: [PATCH 01/12] feat: (experimental) partial support for Svelte v5 --- .changeset/pre.json | 8 ++++++++ .github/workflows/NodeCI.yml | 27 +++++++++++++++++++++++++-- README.md | 6 ++++++ docs/README.md | 6 ++++++ package.json | 2 +- src/types-for-node.ts | 4 ++++ 6 files changed, 50 insertions(+), 3 deletions(-) create mode 100644 .changeset/pre.json diff --git a/.changeset/pre.json b/.changeset/pre.json new file mode 100644 index 000000000..ad4a76649 --- /dev/null +++ b/.changeset/pre.json @@ -0,0 +1,8 @@ +{ + "mode": "pre", + "tag": "next", + "initialVersions": { + "eslint-plugin-svelte": "2.35.0" + }, + "changesets": [] +} diff --git a/.github/workflows/NodeCI.yml b/.github/workflows/NodeCI.yml index c27cf13bc..377d64674 100644 --- a/.github/workflows/NodeCI.yml +++ b/.github/workflows/NodeCI.yml @@ -34,13 +34,13 @@ jobs: pnpm run update pnpm run build test: - name: 'Test for ESLint ${{ matrix.eslint }} on ${{ matrix.node }} OS: ${{matrix.os}}' + name: 'Test for ESLint ${{ matrix.eslint }} on Node.js: ${{ matrix.node }} OS: ${{matrix.os}}' runs-on: ${{ matrix.os }} strategy: matrix: os: [ubuntu-latest] eslint: [7, 8] - node: [16, 17, 18, 20] + node: [20] steps: - name: Checkout uses: actions/checkout@v4 @@ -58,6 +58,29 @@ jobs: run: pnpm install - name: Test run: pnpm run test + test-for-svelte-v4: + name: 'Test for Svelte v4 on Node.js: ${{ matrix.node }} OS: ${{matrix.os}}' + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ubuntu-latest] + node: [16, 17, 18, 20] + steps: + - name: Checkout + uses: actions/checkout@v4 + - uses: pnpm/action-setup@v2 + - name: Setup Node.js ${{ matrix.node }} + uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node }} + - name: Install svelte@4 + run: |+ + pnpm install -D svelte@4 + rm -rf node_modules + - name: Install Packages + run: pnpm install + - name: Test + run: pnpm run test test-for-svelte-v3: name: Test for Svelte v3 runs-on: ${{ matrix.os }} diff --git a/README.md b/README.md index 151fad7a0..51fdef1d2 100644 --- a/README.md +++ b/README.md @@ -25,11 +25,17 @@ It provides many unique check rules using the AST generated by [svelte-eslint-pa ### ❗ Attention +#### Cannot be used with eslint-plugin-svelte3 + The [svelte-eslint-parser] and the `eslint-plugin-svelte` can not be used with the [eslint-plugin-svelte3]. [svelte-eslint-parser]: https://github.com/sveltejs/svelte-eslint-parser [eslint-plugin-svelte3]: https://github.com/sveltejs/eslint-plugin-svelte3 +#### Experimental support for Svelte v5 + +We are working on support for Svelte v5, but it is still an experimental feature. Please note that rules and features related to Svelte v5 may be changed or removed in minor versions without notice. + ## Migration Guide diff --git a/docs/README.md b/docs/README.md index b7aa3bfee..1df054ea3 100644 --- a/docs/README.md +++ b/docs/README.md @@ -29,11 +29,17 @@ It provides many unique check rules using the AST generated by [svelte-eslint-pa ### ❗ Attention +#### Cannot be used with eslint-plugin-svelte3 + The [svelte-eslint-parser] and the `eslint-plugin-svelte` can not be used with the [eslint-plugin-svelte3]. [svelte-eslint-parser]: https://github.com/sveltejs/svelte-eslint-parser [eslint-plugin-svelte3]: https://github.com/sveltejs/eslint-plugin-svelte3 +#### Experimental support for Svelte v5 + +We are working on support for Svelte v5, but it is still an experimental feature. Please note that rules and features related to Svelte v5 may be changed or removed in minor versions without notice. + ## :book: Usage See [User Guide](./user-guide.md). diff --git a/package.json b/package.json index 20974fb82..a58839645 100644 --- a/package.json +++ b/package.json @@ -77,7 +77,7 @@ "postcss-safe-parser": "^6.0.0", "postcss-selector-parser": "^6.0.11", "semver": "^7.5.3", - "svelte-eslint-parser": ">=0.33.0 <1.0.0" + "svelte-eslint-parser": ">=0.34.0-next.2 <1.0.0" }, "devDependencies": { "@1stg/browserslist-config": "^1.2.3", diff --git a/src/types-for-node.ts b/src/types-for-node.ts index 76cbfb109..ec2d5ff8a 100644 --- a/src/types-for-node.ts +++ b/src/types-for-node.ts @@ -221,6 +221,7 @@ export type ASTNodeListener = { SvelteMustacheTag?: (node: AST.SvelteMustacheTag & ASTNodeWithParent) => void; SvelteDebugTag?: (node: AST.SvelteDebugTag & ASTNodeWithParent) => void; SvelteConstTag?: (node: AST.SvelteConstTag & ASTNodeWithParent) => void; + SvelteRenderTag?: (node: AST.SvelteRenderTag & ASTNodeWithParent) => void; SvelteIfBlock?: (node: AST.SvelteIfBlock & ASTNodeWithParent) => void; SvelteElseBlock?: (node: AST.SvelteElseBlock & ASTNodeWithParent) => void; SvelteEachBlock?: (node: AST.SvelteEachBlock & ASTNodeWithParent) => void; @@ -229,6 +230,7 @@ export type ASTNodeListener = { SvelteAwaitThenBlock?: (node: AST.SvelteAwaitThenBlock & ASTNodeWithParent) => void; SvelteAwaitCatchBlock?: (node: AST.SvelteAwaitCatchBlock & ASTNodeWithParent) => void; SvelteKeyBlock?: (node: AST.SvelteKeyBlock & ASTNodeWithParent) => void; + SvelteSnippetBlock?: (node: AST.SvelteSnippetBlock & ASTNodeWithParent) => void; SvelteAttribute?: (node: AST.SvelteAttribute & ASTNodeWithParent) => void; SvelteShorthandAttribute?: (node: AST.SvelteShorthandAttribute & ASTNodeWithParent) => void; SvelteSpreadAttribute?: (node: AST.SvelteSpreadAttribute & ASTNodeWithParent) => void; @@ -439,6 +441,7 @@ export type SvelteNodeListener = { SvelteMustacheTag?: (node: AST.SvelteMustacheTag & ASTNodeWithParent) => void; SvelteDebugTag?: (node: AST.SvelteDebugTag & ASTNodeWithParent) => void; SvelteConstTag?: (node: AST.SvelteConstTag & ASTNodeWithParent) => void; + SvelteRenderTag?: (node: AST.SvelteRenderTag & ASTNodeWithParent) => void; SvelteIfBlock?: (node: AST.SvelteIfBlock & ASTNodeWithParent) => void; SvelteElseBlock?: (node: AST.SvelteElseBlock & ASTNodeWithParent) => void; SvelteEachBlock?: (node: AST.SvelteEachBlock & ASTNodeWithParent) => void; @@ -447,6 +450,7 @@ export type SvelteNodeListener = { SvelteAwaitThenBlock?: (node: AST.SvelteAwaitThenBlock & ASTNodeWithParent) => void; SvelteAwaitCatchBlock?: (node: AST.SvelteAwaitCatchBlock & ASTNodeWithParent) => void; SvelteKeyBlock?: (node: AST.SvelteKeyBlock & ASTNodeWithParent) => void; + SvelteSnippetBlock?: (node: AST.SvelteSnippetBlock & ASTNodeWithParent) => void; SvelteAttribute?: (node: AST.SvelteAttribute & ASTNodeWithParent) => void; SvelteShorthandAttribute?: (node: AST.SvelteShorthandAttribute & ASTNodeWithParent) => void; SvelteSpreadAttribute?: (node: AST.SvelteSpreadAttribute & ASTNodeWithParent) => void; From 0579f5f5563cb16d9f609a3295e32337d617a3c5 Mon Sep 17 00:00:00 2001 From: Yosuke Ota Date: Mon, 20 Nov 2023 17:47:26 +0900 Subject: [PATCH 02/12] Create cuddly-cats-beam.md --- .changeset/cuddly-cats-beam.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/cuddly-cats-beam.md diff --git a/.changeset/cuddly-cats-beam.md b/.changeset/cuddly-cats-beam.md new file mode 100644 index 000000000..dc0c41896 --- /dev/null +++ b/.changeset/cuddly-cats-beam.md @@ -0,0 +1,5 @@ +--- +"eslint-plugin-svelte": minor +--- + +feat: (experimental) partial support for Svelte v5 From 0d445b28a68b4222232b598a3c7300e6ab834a23 Mon Sep 17 00:00:00 2001 From: ota-meshi Date: Mon, 20 Nov 2023 17:48:43 +0900 Subject: [PATCH 03/12] fix: deps --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index a58839645..ff0bb3c93 100644 --- a/package.json +++ b/package.json @@ -58,7 +58,7 @@ }, "peerDependencies": { "eslint": "^7.0.0 || ^8.0.0-0", - "svelte": "^3.37.0 || ^4.0.0" + "svelte": "^3.37.0 || ^4.0.0 || ^5.0.0-next.8" }, "peerDependenciesMeta": { "svelte": { @@ -164,7 +164,7 @@ "stylelint": "^15.0.0", "stylelint-config-standard": "^34.0.0", "stylus": "^0.62.0", - "svelte": "^4.0.0", + "svelte": "^5.0.0-next.8", "svelte-adapter-ghpages": "0.1.0", "svelte-i18n": "^4.0.0", "tslib": "^2.5.0", From a0a2ea0ef84da3bcac694dc1449206f09000c09e Mon Sep 17 00:00:00 2001 From: ota-meshi Date: Mon, 20 Nov 2023 19:14:01 +0900 Subject: [PATCH 04/12] fix --- src/rules/indent-helpers/commons.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rules/indent-helpers/commons.ts b/src/rules/indent-helpers/commons.ts index ba21cf964..4ea95089a 100644 --- a/src/rules/indent-helpers/commons.ts +++ b/src/rules/indent-helpers/commons.ts @@ -90,6 +90,7 @@ export function isBeginningOfElement(node: AST.SvelteText): boolean { node.parent.type === 'SvelteElseBlock' || node.parent.type === 'SvelteIfBlock' || node.parent.type === 'SvelteKeyBlock' || + node.parent.type === 'SvelteSnippetBlock' || node.parent.type === 'SvelteStyleElement' ) { return node.parent.children[0] === node; From 0f098750492256df9f023e27b07e769fd07f9ce0 Mon Sep 17 00:00:00 2001 From: ota-meshi Date: Mon, 20 Nov 2023 19:20:23 +0900 Subject: [PATCH 05/12] fix --- .../rules/valid-compile/invalid/ts/enum01-errors.yaml | 6 +++--- .../rules/valid-compile/invalid/ts/enum01-requirements.json | 3 +++ .../valid-compile/invalid/ts/enum01-svelte4-errors.yaml | 5 +++++ .../valid-compile/invalid/ts/enum01-svelte4-input.svelte | 6 ++++++ .../invalid/ts/enum01-svelte4-requirements.json | 3 +++ 5 files changed, 20 insertions(+), 3 deletions(-) create mode 100644 tests/fixtures/rules/valid-compile/invalid/ts/enum01-requirements.json create mode 100644 tests/fixtures/rules/valid-compile/invalid/ts/enum01-svelte4-errors.yaml create mode 100644 tests/fixtures/rules/valid-compile/invalid/ts/enum01-svelte4-input.svelte create mode 100644 tests/fixtures/rules/valid-compile/invalid/ts/enum01-svelte4-requirements.json diff --git a/tests/fixtures/rules/valid-compile/invalid/ts/enum01-errors.yaml b/tests/fixtures/rules/valid-compile/invalid/ts/enum01-errors.yaml index 3372d3c97..8e4ffba5d 100644 --- a/tests/fixtures/rules/valid-compile/invalid/ts/enum01-errors.yaml +++ b/tests/fixtures/rules/valid-compile/invalid/ts/enum01-errors.yaml @@ -1,5 +1,5 @@ -- message: The $ prefix is reserved, and cannot be used for variable and import - names(illegal-declaration) +- message: The $ prefix is reserved, and cannot be used for variables and + imports(invalid-dollar-prefix) line: 2 - column: 3 + column: 8 suggestions: null diff --git a/tests/fixtures/rules/valid-compile/invalid/ts/enum01-requirements.json b/tests/fixtures/rules/valid-compile/invalid/ts/enum01-requirements.json new file mode 100644 index 000000000..0192b1098 --- /dev/null +++ b/tests/fixtures/rules/valid-compile/invalid/ts/enum01-requirements.json @@ -0,0 +1,3 @@ +{ + "svelte": ">=5.0.0-0" +} diff --git a/tests/fixtures/rules/valid-compile/invalid/ts/enum01-svelte4-errors.yaml b/tests/fixtures/rules/valid-compile/invalid/ts/enum01-svelte4-errors.yaml new file mode 100644 index 000000000..3372d3c97 --- /dev/null +++ b/tests/fixtures/rules/valid-compile/invalid/ts/enum01-svelte4-errors.yaml @@ -0,0 +1,5 @@ +- message: The $ prefix is reserved, and cannot be used for variable and import + names(illegal-declaration) + line: 2 + column: 3 + suggestions: null diff --git a/tests/fixtures/rules/valid-compile/invalid/ts/enum01-svelte4-input.svelte b/tests/fixtures/rules/valid-compile/invalid/ts/enum01-svelte4-input.svelte new file mode 100644 index 000000000..708c91773 --- /dev/null +++ b/tests/fixtures/rules/valid-compile/invalid/ts/enum01-svelte4-input.svelte @@ -0,0 +1,6 @@ + diff --git a/tests/fixtures/rules/valid-compile/invalid/ts/enum01-svelte4-requirements.json b/tests/fixtures/rules/valid-compile/invalid/ts/enum01-svelte4-requirements.json new file mode 100644 index 000000000..b650cc296 --- /dev/null +++ b/tests/fixtures/rules/valid-compile/invalid/ts/enum01-svelte4-requirements.json @@ -0,0 +1,3 @@ +{ + "svelte": "^3.0.0 || ^4.0.0" +} From 92ce3bdd6180db5903399a1e15d44914da97c624 Mon Sep 17 00:00:00 2001 From: ota-meshi Date: Mon, 20 Nov 2023 19:40:16 +0900 Subject: [PATCH 06/12] fix --- src/rules/valid-compile.ts | 8 ++- .../invalid/script-comment01-errors.yaml | 6 +-- .../invalid/script-comment01-input.svelte | 14 ++--- .../invalid/script-comment01-requirement.json | 3 ++ .../script-comment01-svelte4-errors.yaml | 8 +++ .../script-comment01-svelte4-input.svelte | 9 ++++ ...script-comment01-svelte4-requirements.json | 3 ++ ...l => script-comment02-svelte4-errors.yaml} | 0 ... => script-comment02-svelte4-input.svelte} | 0 ...script-comment02-svelte4-requirements.json | 3 ++ .../invalid-svelte-ignore03-errors.yaml | 8 --- .../invalid-svelte-ignore03-input.svelte | 2 + .../invalid-svelte-ignore03-requirements.json | 3 ++ ...nvalid-svelte-ignore03-svelte4-errors.yaml | 53 +++++++++++++++++++ ...valid-svelte-ignore03-svelte4-input.svelte | 22 ++++++++ ...-svelte-ignore03-svelte4-requirements.json | 3 ++ .../invalid/style-lang01-requirements.json | 3 ++ 17 files changed, 128 insertions(+), 20 deletions(-) create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-requirement.json create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-svelte4-errors.yaml create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-svelte4-input.svelte create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-svelte4-requirements.json rename tests/fixtures/rules/no-unused-svelte-ignore/invalid/{script-comment02-errors.yaml => script-comment02-svelte4-errors.yaml} (100%) rename tests/fixtures/rules/no-unused-svelte-ignore/invalid/{script-comment02-input.svelte => script-comment02-svelte4-input.svelte} (100%) create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment02-svelte4-requirements.json create mode 100644 tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-requirements.json create mode 100644 tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-svelte4-errors.yaml create mode 100644 tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-svelte4-input.svelte create mode 100644 tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-svelte4-requirements.json create mode 100644 tests/fixtures/rules/valid-compile/invalid/style-lang01-requirements.json diff --git a/src/rules/valid-compile.ts b/src/rules/valid-compile.ts index 0701d52ef..e56e6ec7b 100644 --- a/src/rules/valid-compile.ts +++ b/src/rules/valid-compile.ts @@ -28,7 +28,13 @@ export default createRule('valid-compile', { } const ignoreWarnings = Boolean(context.options[0]?.ignoreWarnings); - const ignores = ['missing-declaration', 'dynamic-slot-name']; + const ignores = [ + 'missing-declaration', + // Svelte v4 + 'dynamic-slot-name', + // Svelte v5 + 'invalid-slot-name' + ]; /** * report diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-errors.yaml b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-errors.yaml index f0d33cb16..ce5087c37 100644 --- a/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-errors.yaml +++ b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-errors.yaml @@ -1,8 +1,4 @@ - message: svelte-ignore comment is used, but not warned - line: 3 - column: 19 - suggestions: null -- message: svelte-ignore comment is used, but not warned - line: 5 + line: 2 column: 19 suggestions: null diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-input.svelte b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-input.svelte index 9cb4e088f..c7e956ece 100644 --- a/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-input.svelte +++ b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-input.svelte @@ -1,9 +1,11 @@ -{used} +{used}{unused} diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-requirement.json b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-requirement.json new file mode 100644 index 000000000..0192b1098 --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-requirement.json @@ -0,0 +1,3 @@ +{ + "svelte": ">=5.0.0-0" +} diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-svelte4-errors.yaml b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-svelte4-errors.yaml new file mode 100644 index 000000000..f0d33cb16 --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-svelte4-errors.yaml @@ -0,0 +1,8 @@ +- message: svelte-ignore comment is used, but not warned + line: 3 + column: 19 + suggestions: null +- message: svelte-ignore comment is used, but not warned + line: 5 + column: 19 + suggestions: null diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-svelte4-input.svelte b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-svelte4-input.svelte new file mode 100644 index 000000000..9cb4e088f --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-svelte4-input.svelte @@ -0,0 +1,9 @@ + + +{used} diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-svelte4-requirements.json b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-svelte4-requirements.json new file mode 100644 index 000000000..b650cc296 --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-svelte4-requirements.json @@ -0,0 +1,3 @@ +{ + "svelte": "^3.0.0 || ^4.0.0" +} diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment02-errors.yaml b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment02-svelte4-errors.yaml similarity index 100% rename from tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment02-errors.yaml rename to tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment02-svelte4-errors.yaml diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment02-input.svelte b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment02-svelte4-input.svelte similarity index 100% rename from tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment02-input.svelte rename to tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment02-svelte4-input.svelte diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment02-svelte4-requirements.json b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment02-svelte4-requirements.json new file mode 100644 index 000000000..b650cc296 --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment02-svelte4-requirements.json @@ -0,0 +1,3 @@ +{ + "svelte": "^3.0.0 || ^4.0.0" +} diff --git a/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-errors.yaml b/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-errors.yaml index 207168f1b..108d833cd 100644 --- a/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-errors.yaml +++ b/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-errors.yaml @@ -1,7 +1,3 @@ -- message: Empty block(empty-block) - line: 2 - column: 30 - suggestions: null - message: 'A11y: noninteractive element cannot have nonnegative tabIndex value(a11y-no-noninteractive-tabindex)' line: 5 @@ -32,10 +28,6 @@ line: 10 column: 3 suggestions: null -- message: Empty block(empty-block) - line: 14 - column: 30 - suggestions: null - message: 'A11y: noninteractive element cannot have nonnegative tabIndex value(a11y-no-noninteractive-tabindex)' line: 17 diff --git a/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-input.svelte b/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-input.svelte index c1c204b26..53c3950db 100644 --- a/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-input.svelte +++ b/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-input.svelte @@ -18,3 +18,5 @@
    {/await} + + diff --git a/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-requirements.json b/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-requirements.json new file mode 100644 index 000000000..0192b1098 --- /dev/null +++ b/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-requirements.json @@ -0,0 +1,3 @@ +{ + "svelte": ">=5.0.0-0" +} diff --git a/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-svelte4-errors.yaml b/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-svelte4-errors.yaml new file mode 100644 index 000000000..207168f1b --- /dev/null +++ b/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-svelte4-errors.yaml @@ -0,0 +1,53 @@ +- message: Empty block(empty-block) + line: 2 + column: 30 + suggestions: null +- message: 'A11y: noninteractive element cannot have nonnegative tabIndex + value(a11y-no-noninteractive-tabindex)' + line: 5 + column: 3 + suggestions: null +- message: 'A11y: A form label must be associated with a + control.(a11y-label-has-associated-control)' + line: 5 + column: 3 + suggestions: null +- message: 'A11y: noninteractive element cannot have nonnegative tabIndex + value(a11y-no-noninteractive-tabindex)' + line: 6 + column: 3 + suggestions: null +- message: 'A11y: noninteractive element cannot have nonnegative tabIndex + value(a11y-no-noninteractive-tabindex)' + line: 9 + column: 3 + suggestions: null +- message: 'A11y: A form label must be associated with a + control.(a11y-label-has-associated-control)' + line: 9 + column: 3 + suggestions: null +- message: 'A11y: noninteractive element cannot have nonnegative tabIndex + value(a11y-no-noninteractive-tabindex)' + line: 10 + column: 3 + suggestions: null +- message: Empty block(empty-block) + line: 14 + column: 30 + suggestions: null +- message: 'A11y: noninteractive element cannot have nonnegative tabIndex + value(a11y-no-noninteractive-tabindex)' + line: 17 + column: 3 + suggestions: null +- message: 'A11y: A form label must be associated with a + control.(a11y-label-has-associated-control)' + line: 17 + column: 3 + suggestions: null +- message: 'A11y: noninteractive element cannot have nonnegative tabIndex + value(a11y-no-noninteractive-tabindex)' + line: 18 + column: 3 + suggestions: null diff --git a/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-svelte4-input.svelte b/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-svelte4-input.svelte new file mode 100644 index 000000000..3ee9d56c4 --- /dev/null +++ b/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-svelte4-input.svelte @@ -0,0 +1,22 @@ +
    + {#await Promise.resolve(42)} + + {:then name} + +
      + + {:catch name} + +
        + {/await} +
    +
    + {#await Promise.resolve(42)} + + {:then name} + +
      + {/await} +
    + + diff --git a/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-svelte4-requirements.json b/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-svelte4-requirements.json new file mode 100644 index 000000000..b650cc296 --- /dev/null +++ b/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore03-svelte4-requirements.json @@ -0,0 +1,3 @@ +{ + "svelte": "^3.0.0 || ^4.0.0" +} diff --git a/tests/fixtures/rules/valid-compile/invalid/style-lang01-requirements.json b/tests/fixtures/rules/valid-compile/invalid/style-lang01-requirements.json new file mode 100644 index 000000000..b650cc296 --- /dev/null +++ b/tests/fixtures/rules/valid-compile/invalid/style-lang01-requirements.json @@ -0,0 +1,3 @@ +{ + "svelte": "^3.0.0 || ^4.0.0" +} From 7d5b294421f133685ecd08e39a08e876141f49e3 Mon Sep 17 00:00:00 2001 From: ota-meshi Date: Mon, 20 Nov 2023 19:47:35 +0900 Subject: [PATCH 07/12] fix --- .../invalid/script-comment01-errors.yaml | 2 +- .../invalid/script-comment01-input.svelte | 8 ++++---- .../valid/ts-lang01-input.svelte | 12 +++++++++--- .../valid/ts-lang01-requirements.json | 3 +++ .../valid/ts-lang01-svelte4-input.svelte | 4 ++++ .../valid/ts-lang01-svelte4-requirements.json | 3 +++ 6 files changed, 24 insertions(+), 8 deletions(-) create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/valid/ts-lang01-requirements.json create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/valid/ts-lang01-svelte4-input.svelte create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/valid/ts-lang01-svelte4-requirements.json diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-errors.yaml b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-errors.yaml index ce5087c37..828b7a9b8 100644 --- a/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-errors.yaml +++ b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-errors.yaml @@ -1,4 +1,4 @@ - message: svelte-ignore comment is used, but not warned - line: 2 + line: 4 column: 19 suggestions: null diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-input.svelte b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-input.svelte index c7e956ece..af67bb87e 100644 --- a/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-input.svelte +++ b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-input.svelte @@ -1,11 +1,11 @@ -{used}{unused} +{mutable}{immutable} diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/ts-lang01-input.svelte b/tests/fixtures/rules/no-unused-svelte-ignore/valid/ts-lang01-input.svelte index 059de337a..a0eca9930 100644 --- a/tests/fixtures/rules/no-unused-svelte-ignore/valid/ts-lang01-input.svelte +++ b/tests/fixtures/rules/no-unused-svelte-ignore/valid/ts-lang01-input.svelte @@ -1,4 +1,10 @@ - + +{mutable}{immutable} diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/ts-lang01-requirements.json b/tests/fixtures/rules/no-unused-svelte-ignore/valid/ts-lang01-requirements.json new file mode 100644 index 000000000..0192b1098 --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/valid/ts-lang01-requirements.json @@ -0,0 +1,3 @@ +{ + "svelte": ">=5.0.0-0" +} diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/ts-lang01-svelte4-input.svelte b/tests/fixtures/rules/no-unused-svelte-ignore/valid/ts-lang01-svelte4-input.svelte new file mode 100644 index 000000000..059de337a --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/valid/ts-lang01-svelte4-input.svelte @@ -0,0 +1,4 @@ + diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/ts-lang01-svelte4-requirements.json b/tests/fixtures/rules/no-unused-svelte-ignore/valid/ts-lang01-svelte4-requirements.json new file mode 100644 index 000000000..b650cc296 --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/valid/ts-lang01-svelte4-requirements.json @@ -0,0 +1,3 @@ +{ + "svelte": "^3.0.0 || ^4.0.0" +} From a2af05435f55bde530c1fde5aa2b854950253781 Mon Sep 17 00:00:00 2001 From: ota-meshi Date: Mon, 20 Nov 2023 20:00:56 +0900 Subject: [PATCH 08/12] fix --- .../valid/script-comment-input.svelte | 15 +++++++-------- .../valid/script-comment-requirements.json | 3 +++ .../valid/script-comment-svelte4-input.svelte | 10 ++++++++++ .../script-comment-svelte4-requirements.json | 3 +++ .../valid/style-lang01-requirements.json | 4 ++++ .../valid/style-lang02-requirements.json | 4 ++++ .../valid/style-lang03-requirements.json | 4 ++++ .../valid/style-lang04-requirements.json | 4 ++++ .../valid/style-lang05-requirements.json | 4 ++++ .../valid/style-lang06-requirements.json | 4 ++++ tests/utils/utils.ts | 1 + 11 files changed, 48 insertions(+), 8 deletions(-) create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-requirements.json create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-svelte4-input.svelte create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-svelte4-requirements.json create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang01-requirements.json create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang02-requirements.json create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang03-requirements.json create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang04-requirements.json create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang05-requirements.json create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang06-requirements.json diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-input.svelte b/tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-input.svelte index 4a8e38e57..7418c0fdc 100644 --- a/tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-input.svelte +++ b/tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-input.svelte @@ -1,10 +1,9 @@ - - + +{immutable} diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-requirements.json b/tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-requirements.json new file mode 100644 index 000000000..0192b1098 --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-requirements.json @@ -0,0 +1,3 @@ +{ + "svelte": ">=5.0.0-0" +} diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-svelte4-input.svelte b/tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-svelte4-input.svelte new file mode 100644 index 000000000..4a8e38e57 --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-svelte4-input.svelte @@ -0,0 +1,10 @@ + + + diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-svelte4-requirements.json b/tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-svelte4-requirements.json new file mode 100644 index 000000000..b650cc296 --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-svelte4-requirements.json @@ -0,0 +1,3 @@ +{ + "svelte": "^3.0.0 || ^4.0.0" +} diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang01-requirements.json b/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang01-requirements.json new file mode 100644 index 000000000..e18fe1560 --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang01-requirements.json @@ -0,0 +1,4 @@ +{ + "FIXME": "It seems that unused selectors are not checked yet in Svelte v5.", + "svelte": "^4 || ^3" +} diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang02-requirements.json b/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang02-requirements.json new file mode 100644 index 000000000..e18fe1560 --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang02-requirements.json @@ -0,0 +1,4 @@ +{ + "FIXME": "It seems that unused selectors are not checked yet in Svelte v5.", + "svelte": "^4 || ^3" +} diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang03-requirements.json b/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang03-requirements.json new file mode 100644 index 000000000..e18fe1560 --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang03-requirements.json @@ -0,0 +1,4 @@ +{ + "FIXME": "It seems that unused selectors are not checked yet in Svelte v5.", + "svelte": "^4 || ^3" +} diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang04-requirements.json b/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang04-requirements.json new file mode 100644 index 000000000..e18fe1560 --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang04-requirements.json @@ -0,0 +1,4 @@ +{ + "FIXME": "It seems that unused selectors are not checked yet in Svelte v5.", + "svelte": "^4 || ^3" +} diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang05-requirements.json b/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang05-requirements.json new file mode 100644 index 000000000..e18fe1560 --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang05-requirements.json @@ -0,0 +1,4 @@ +{ + "FIXME": "It seems that unused selectors are not checked yet in Svelte v5.", + "svelte": "^4 || ^3" +} diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang06-requirements.json b/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang06-requirements.json new file mode 100644 index 000000000..e18fe1560 --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/valid/style-lang06-requirements.json @@ -0,0 +1,4 @@ +{ + "FIXME": "It seems that unused selectors are not checked yet in Svelte v5.", + "svelte": "^4 || ^3" +} diff --git a/tests/utils/utils.ts b/tests/utils/utils.ts index 2f445ad42..90fdfe7c8 100644 --- a/tests/utils/utils.ts +++ b/tests/utils/utils.ts @@ -92,6 +92,7 @@ export function loadTestCases( const requirements = getRequirements(inputFile); if ( Object.entries(requirements).some(([pkgName, pkgVersion]) => { + if (pkgName === 'FIXME') return false; // Comments const pkg = pkgName === 'node' ? { version: process.version } From 4ae1f85ed431f1f631b92ddab3921581f2aff00a Mon Sep 17 00:00:00 2001 From: ota-meshi Date: Mon, 20 Nov 2023 20:05:04 +0900 Subject: [PATCH 09/12] fix --- .../valid/has-error-svelte4-input-requirements.json | 3 +++ .../{has-error-input.svelte => has-error-svelte4-input.svelte} | 0 .../no-unused-svelte-ignore/valid/script-comment-input.svelte | 3 --- 3 files changed, 3 insertions(+), 3 deletions(-) create mode 100644 tests/fixtures/rules/no-unused-svelte-ignore/valid/has-error-svelte4-input-requirements.json rename tests/fixtures/rules/no-unused-svelte-ignore/valid/{has-error-input.svelte => has-error-svelte4-input.svelte} (100%) diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/has-error-svelte4-input-requirements.json b/tests/fixtures/rules/no-unused-svelte-ignore/valid/has-error-svelte4-input-requirements.json new file mode 100644 index 000000000..b650cc296 --- /dev/null +++ b/tests/fixtures/rules/no-unused-svelte-ignore/valid/has-error-svelte4-input-requirements.json @@ -0,0 +1,3 @@ +{ + "svelte": "^3.0.0 || ^4.0.0" +} diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/has-error-input.svelte b/tests/fixtures/rules/no-unused-svelte-ignore/valid/has-error-svelte4-input.svelte similarity index 100% rename from tests/fixtures/rules/no-unused-svelte-ignore/valid/has-error-input.svelte rename to tests/fixtures/rules/no-unused-svelte-ignore/valid/has-error-svelte4-input.svelte diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-input.svelte b/tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-input.svelte index 7418c0fdc..951dd9d97 100644 --- a/tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-input.svelte +++ b/tests/fixtures/rules/no-unused-svelte-ignore/valid/script-comment-input.svelte @@ -1,9 +1,6 @@ {immutable} From 37a27a23b389fa6df609e5b3b2e0b6692aaa8264 Mon Sep 17 00:00:00 2001 From: ota-meshi Date: Mon, 20 Nov 2023 20:26:56 +0900 Subject: [PATCH 10/12] fix --- tests/fixtures/rules/indent/invalid/await01-input.svelte | 2 ++ tests/fixtures/rules/indent/invalid/await01-output.svelte | 2 ++ tests/fixtures/rules/indent/invalid/await01-requirements.json | 4 ++++ tests/fixtures/rules/indent/invalid/each01-requirements.json | 4 ++++ tests/fixtures/rules/indent/invalid/if01-requirements.json | 4 ++++ tests/fixtures/rules/indent/invalid/key01-requirements.json | 4 ++++ .../rules/mustache-spacing/invalid/always/test01-input.svelte | 2 ++ .../mustache-spacing/invalid/always/test01-output.svelte | 2 ++ .../rules/mustache-spacing/invalid/test01-input.svelte | 2 ++ .../rules/mustache-spacing/invalid/test01-output.svelte | 2 ++ .../rules/mustache-spacing/invalid/test01-requirements.json | 4 ++++ ...-requirements.json => has-error-svelte4-requirements.json} | 0 12 files changed, 32 insertions(+) create mode 100644 tests/fixtures/rules/indent/invalid/await01-requirements.json create mode 100644 tests/fixtures/rules/indent/invalid/each01-requirements.json create mode 100644 tests/fixtures/rules/indent/invalid/if01-requirements.json create mode 100644 tests/fixtures/rules/indent/invalid/key01-requirements.json create mode 100644 tests/fixtures/rules/mustache-spacing/invalid/test01-requirements.json rename tests/fixtures/rules/no-unused-svelte-ignore/valid/{has-error-svelte4-input-requirements.json => has-error-svelte4-requirements.json} (100%) diff --git a/tests/fixtures/rules/indent/invalid/await01-input.svelte b/tests/fixtures/rules/indent/invalid/await01-input.svelte index e974a395c..e6d74ecf5 100644 --- a/tests/fixtures/rules/indent/invalid/await01-input.svelte +++ b/tests/fixtures/rules/indent/invalid/await01-input.svelte @@ -83,3 +83,5 @@ name /await } + + diff --git a/tests/fixtures/rules/indent/invalid/await01-output.svelte b/tests/fixtures/rules/indent/invalid/await01-output.svelte index 99f0fa713..828ba7817 100644 --- a/tests/fixtures/rules/indent/invalid/await01-output.svelte +++ b/tests/fixtures/rules/indent/invalid/await01-output.svelte @@ -83,3 +83,5 @@ /await } + + diff --git a/tests/fixtures/rules/indent/invalid/await01-requirements.json b/tests/fixtures/rules/indent/invalid/await01-requirements.json new file mode 100644 index 000000000..3217ed4a2 --- /dev/null +++ b/tests/fixtures/rules/indent/invalid/await01-requirements.json @@ -0,0 +1,4 @@ +{ + "FIXME": "It seems to return the wrong location in Svelte v5.", + "svelte": "^4 || ^3" +} diff --git a/tests/fixtures/rules/indent/invalid/each01-requirements.json b/tests/fixtures/rules/indent/invalid/each01-requirements.json new file mode 100644 index 000000000..3217ed4a2 --- /dev/null +++ b/tests/fixtures/rules/indent/invalid/each01-requirements.json @@ -0,0 +1,4 @@ +{ + "FIXME": "It seems to return the wrong location in Svelte v5.", + "svelte": "^4 || ^3" +} diff --git a/tests/fixtures/rules/indent/invalid/if01-requirements.json b/tests/fixtures/rules/indent/invalid/if01-requirements.json new file mode 100644 index 000000000..3217ed4a2 --- /dev/null +++ b/tests/fixtures/rules/indent/invalid/if01-requirements.json @@ -0,0 +1,4 @@ +{ + "FIXME": "It seems to return the wrong location in Svelte v5.", + "svelte": "^4 || ^3" +} diff --git a/tests/fixtures/rules/indent/invalid/key01-requirements.json b/tests/fixtures/rules/indent/invalid/key01-requirements.json new file mode 100644 index 000000000..3217ed4a2 --- /dev/null +++ b/tests/fixtures/rules/indent/invalid/key01-requirements.json @@ -0,0 +1,4 @@ +{ + "FIXME": "It seems to return the wrong location in Svelte v5.", + "svelte": "^4 || ^3" +} diff --git a/tests/fixtures/rules/mustache-spacing/invalid/always/test01-input.svelte b/tests/fixtures/rules/mustache-spacing/invalid/always/test01-input.svelte index dec41e0b9..a47613804 100644 --- a/tests/fixtures/rules/mustache-spacing/invalid/always/test01-input.svelte +++ b/tests/fixtures/rules/mustache-spacing/invalid/always/test01-input.svelte @@ -46,3 +46,5 @@ {#await expression}...{:then}...{:catch}...{/await} {#key expression}...{/key} + + diff --git a/tests/fixtures/rules/mustache-spacing/invalid/always/test01-output.svelte b/tests/fixtures/rules/mustache-spacing/invalid/always/test01-output.svelte index 8eec437c1..113d6aefd 100644 --- a/tests/fixtures/rules/mustache-spacing/invalid/always/test01-output.svelte +++ b/tests/fixtures/rules/mustache-spacing/invalid/always/test01-output.svelte @@ -46,3 +46,5 @@ { #await expression }...{ :then}...{ :catch}...{ /await } { #key expression }...{ /key } + + diff --git a/tests/fixtures/rules/mustache-spacing/invalid/test01-input.svelte b/tests/fixtures/rules/mustache-spacing/invalid/test01-input.svelte index e6d19dcd4..10ec4b852 100644 --- a/tests/fixtures/rules/mustache-spacing/invalid/test01-input.svelte +++ b/tests/fixtures/rules/mustache-spacing/invalid/test01-input.svelte @@ -46,3 +46,5 @@ { #key expression }...{ /key } + + diff --git a/tests/fixtures/rules/mustache-spacing/invalid/test01-output.svelte b/tests/fixtures/rules/mustache-spacing/invalid/test01-output.svelte index aefac172f..23515c7fb 100644 --- a/tests/fixtures/rules/mustache-spacing/invalid/test01-output.svelte +++ b/tests/fixtures/rules/mustache-spacing/invalid/test01-output.svelte @@ -46,3 +46,5 @@ {#key expression}...{/key} + + diff --git a/tests/fixtures/rules/mustache-spacing/invalid/test01-requirements.json b/tests/fixtures/rules/mustache-spacing/invalid/test01-requirements.json new file mode 100644 index 000000000..3217ed4a2 --- /dev/null +++ b/tests/fixtures/rules/mustache-spacing/invalid/test01-requirements.json @@ -0,0 +1,4 @@ +{ + "FIXME": "It seems to return the wrong location in Svelte v5.", + "svelte": "^4 || ^3" +} diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/valid/has-error-svelte4-input-requirements.json b/tests/fixtures/rules/no-unused-svelte-ignore/valid/has-error-svelte4-requirements.json similarity index 100% rename from tests/fixtures/rules/no-unused-svelte-ignore/valid/has-error-svelte4-input-requirements.json rename to tests/fixtures/rules/no-unused-svelte-ignore/valid/has-error-svelte4-requirements.json From 9dd62a3c772cca9fda66a7885a5464c0003c2ee2 Mon Sep 17 00:00:00 2001 From: ota-meshi Date: Mon, 20 Nov 2023 20:29:25 +0900 Subject: [PATCH 11/12] fix --- ...ment01-requirement.json => script-comment01-requirements.json} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename tests/fixtures/rules/no-unused-svelte-ignore/invalid/{script-comment01-requirement.json => script-comment01-requirements.json} (100%) diff --git a/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-requirement.json b/tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-requirements.json similarity index 100% rename from tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-requirement.json rename to tests/fixtures/rules/no-unused-svelte-ignore/invalid/script-comment01-requirements.json From 7ba5eb7b853296a119440b5b74d630265ffb4af3 Mon Sep 17 00:00:00 2001 From: ota-meshi Date: Mon, 20 Nov 2023 20:33:01 +0900 Subject: [PATCH 12/12] fix lint error --- .eslintignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.eslintignore b/.eslintignore index b95b8f503..e895477e0 100644 --- a/.eslintignore +++ b/.eslintignore @@ -16,6 +16,7 @@ /tests/fixtures/rules/valid-compile/valid/ts /tests/fixtures/rules/prefer-style-directive /tests/fixtures/rules/@typescript-eslint +/tests/fixtures/rules/valid-compile/valid/svelte3-options-custom-element-input.svelte /.svelte-kit /svelte.config-dist.js /build