Skip to content

Commit ec2d47d

Browse files
committed
fix: review comment
1 parent a6686e4 commit ec2d47d

File tree

3 files changed

+30
-1
lines changed

3 files changed

+30
-1
lines changed

src/rules/require-store-callbacks-use-set-param.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,11 @@ export default createRule("require-store-callbacks-use-set-param", {
2222
"writable",
2323
])) {
2424
const [_, fn] = node.arguments
25-
if (!fn || fn.type !== "ArrowFunctionExpression") {
25+
if (
26+
!fn ||
27+
(fn.type !== "ArrowFunctionExpression" &&
28+
fn.type !== "FunctionExpression")
29+
) {
2630
continue
2731
}
2832
const param = fn.params[0]
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
- message: Store callbacks must use `set` param.
2+
line: 4
3+
column: 19
4+
suggestions: null
5+
- message: Store callbacks must use `set` param.
6+
line: 5
7+
column: 19
8+
suggestions: null
9+
- message: Store callbacks must use `set` param.
10+
line: 7
11+
column: 19
12+
suggestions: null
13+
- message: Store callbacks must use `set` param.
14+
line: 8
15+
column: 19
16+
suggestions: null
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
<script>
2+
import { readable, writable } from "svelte/store"
3+
4+
readable(false, function () {})
5+
readable(false, (foo) => function () {})
6+
7+
writable(false, () => function () {})
8+
writable(false, (foo) => function () {})
9+
</script>

0 commit comments

Comments
 (0)