From 9f3061e280d618ac39a38c5349a19a1bcf973134 Mon Sep 17 00:00:00 2001 From: puku0x Date: Wed, 1 Dec 2021 00:07:59 +0900 Subject: [PATCH 1/7] Fix workflow --- .github/workflows/nodejs.yml | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index fae0612..135dd1c 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -27,12 +27,10 @@ jobs: - uses: actions/checkout@v2 - name: Use Node.js ${{ matrix.node }} - uses: actions/setup-node@v1 + uses: actions/setup-node@v2 with: node-version: ${{ matrix.node }} - - - name: Install latest npm - run: npm install --global npm@latest + cache: 'npm' - name: Install dependencies run: npm ci @@ -54,12 +52,10 @@ jobs: - uses: actions/checkout@v2 - name: Use Node.js ${{ matrix.node }} - uses: actions/setup-node@v1 + uses: actions/setup-node@v2 with: node-version: ${{ matrix.node }} - - - name: Install latest npm - run: npm install --global npm@latest + cache: 'npm' - name: Install dependencies run: npm ci From 2b1fa35118ebb7eefe53758578b5b673909ee9b3 Mon Sep 17 00:00:00 2001 From: puku0x Date: Thu, 2 Dec 2021 13:32:33 +0900 Subject: [PATCH 2/7] Revert removing installing the latest npm --- .github/workflows/nodejs.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 135dd1c..daf6f0c 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -32,6 +32,9 @@ jobs: node-version: ${{ matrix.node }} cache: 'npm' + - name: Install latest npm + run: npm install --global npm@latest + - name: Install dependencies run: npm ci @@ -57,6 +60,9 @@ jobs: node-version: ${{ matrix.node }} cache: 'npm' + - name: Install latest npm + run: npm install --global npm@latest + - name: Install dependencies run: npm ci From 8f31db4527201a4c48bff2a5ebf05aac79388078 Mon Sep 17 00:00:00 2001 From: puku0x Date: Thu, 2 Dec 2021 13:33:30 +0900 Subject: [PATCH 3/7] Run test on Node.js v12, v14 and v16 --- .github/workflows/nodejs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index daf6f0c..5b17a1f 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -49,7 +49,7 @@ jobs: strategy: fail-fast: false matrix: - node: [10, 12] + node: [12, 14, 16] steps: - uses: actions/checkout@v2 From 74fbad208ac6b855d5bb2646abf250a5d16cb4d7 Mon Sep 17 00:00:00 2001 From: puku0x Date: Thu, 2 Dec 2021 13:42:41 +0900 Subject: [PATCH 4/7] Remove env.CI --- .github/workflows/nodejs.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 5b17a1f..a603b45 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -9,9 +9,6 @@ on: branches: - '**' -env: - CI: true - jobs: lint: name: Lint on Node.js ${{ matrix.node }} and ${{ matrix.os }} From 2887e50d16c1cbd6994b256a008438d7f91175c0 Mon Sep 17 00:00:00 2001 From: puku0x Date: Thu, 2 Dec 2021 13:45:44 +0900 Subject: [PATCH 5/7] Use Node.js LTS for lint job --- .github/workflows/nodejs.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index a603b45..d48f504 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -23,11 +23,11 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Use Node.js ${{ matrix.node }} + - name: Use LTS Node.js uses: actions/setup-node@v2 with: - node-version: ${{ matrix.node }} - cache: 'npm' + node-version: 'lts/*' + cache: npm - name: Install latest npm run: npm install --global npm@latest @@ -55,7 +55,7 @@ jobs: uses: actions/setup-node@v2 with: node-version: ${{ matrix.node }} - cache: 'npm' + cache: npm - name: Install latest npm run: npm install --global npm@latest From e95f5cb64511d43673497f07ff85d2b98883ddb6 Mon Sep 17 00:00:00 2001 From: puku0x Date: Thu, 2 Dec 2021 13:56:03 +0900 Subject: [PATCH 6/7] Remove matrix for lint job --- .github/workflows/nodejs.yml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index d48f504..809fcd5 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -11,14 +11,9 @@ on: jobs: lint: - name: Lint on Node.js ${{ matrix.node }} and ${{ matrix.os }} + name: Lint on Node.js LTS - runs-on: ${{ matrix.os }} - - strategy: - matrix: - node: [12] - os: [ubuntu-latest] + runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 From 5cf73a267c691aa0e96f3c7ace578b2b7d8c15a9 Mon Sep 17 00:00:00 2001 From: Noriyuki Shinpuku Date: Thu, 2 Dec 2021 14:23:51 +0900 Subject: [PATCH 7/7] Update name Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com> --- .github/workflows/nodejs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 809fcd5..2a38d36 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -18,7 +18,7 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Use LTS Node.js + - name: Use Node.js LTS uses: actions/setup-node@v2 with: node-version: 'lts/*'