From 4e9cfecce5cf4edac0e1b8ef27681719f57ea56b Mon Sep 17 00:00:00 2001 From: Jacob Parker Date: Thu, 18 Oct 2018 15:59:00 +0100 Subject: [PATCH 1/2] Set flex-basis to `auto` --- src/transforms/flex.js | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/transforms/flex.js b/src/transforms/flex.js index 7aaad9c..b54c06f 100644 --- a/src/transforms/flex.js +++ b/src/transforms/flex.js @@ -6,8 +6,6 @@ const defaultFlexGrow = 1 const defaultFlexShrink = 1 const defaultFlexBasis = 0 -const FLEX_BASIS_AUTO = {} // Used for reference equality - export default tokenStream => { let flexGrow let flexShrink @@ -15,12 +13,12 @@ export default tokenStream => { if (tokenStream.matches(NONE)) { tokenStream.expectEmpty() - return { $merge: { flexGrow: 0, flexShrink: 0 } } + return { $merge: { flexGrow: 0, flexShrink: 0, flexBasis: 'auto' } } } tokenStream.saveRewindPoint() if (tokenStream.matches(AUTO) && !tokenStream.hasTokens()) { - return { $merge: { flexGrow: 1, flexShrink: 1 } } + return { $merge: { flexGrow: 1, flexShrink: 1, flexBasis: 'auto' } } } tokenStream.rewind() @@ -40,7 +38,7 @@ export default tokenStream => { } else if (flexBasis === undefined && tokenStream.matches(LENGTH)) { flexBasis = tokenStream.lastValue } else if (flexBasis === undefined && tokenStream.matches(AUTO)) { - flexBasis = FLEX_BASIS_AUTO + flexBasis = 'auto' } else { tokenStream.throw() } @@ -54,7 +52,5 @@ export default tokenStream => { if (flexShrink === undefined) flexShrink = defaultFlexShrink if (flexBasis === undefined) flexBasis = defaultFlexBasis - return flexBasis !== FLEX_BASIS_AUTO - ? { $merge: { flexGrow, flexShrink, flexBasis } } - : { $merge: { flexGrow, flexShrink } } + return { $merge: { flexGrow, flexShrink, flexBasis } } } From f48a256d7440123dab1677659b2cc80c487735bf Mon Sep 17 00:00:00 2001 From: Jacob Parker Date: Thu, 18 Oct 2018 16:12:27 +0100 Subject: [PATCH 2/2] Update tests --- src/__tests__/flex.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/__tests__/flex.js b/src/__tests__/flex.js index aa12943..571f3a9 100644 --- a/src/__tests__/flex.js +++ b/src/__tests__/flex.js @@ -73,6 +73,7 @@ it('transforms flex shorthand with flex-basis set to auto', () => { expect(transformCss([['flex', '0 1 auto']])).toEqual({ flexGrow: 0, flexShrink: 1, + flexBasis: 'auto', }) }) @@ -80,6 +81,7 @@ it('transforms flex shorthand with flex-basis set to auto appearing first', () = expect(transformCss([['flex', 'auto 0 1']])).toEqual({ flexGrow: 0, flexShrink: 1, + flexBasis: 'auto', }) }) @@ -87,6 +89,7 @@ it('transforms flex auto keyword', () => { expect(transformCss([['flex', 'auto']])).toEqual({ flexGrow: 1, flexShrink: 1, + flexBasis: 'auto', }) }) @@ -94,6 +97,7 @@ it('transforms flex none keyword', () => { expect(transformCss([['flex', 'none']])).toEqual({ flexGrow: 0, flexShrink: 0, + flexBasis: 'auto', }) })