From 1f40fcb91a10cbd1a2583fff9fc09d66ec140b2d Mon Sep 17 00:00:00 2001
From: Ethan Marsh <emarsh55@gmail.com>
Date: Thu, 19 Mar 2020 12:13:40 -0700
Subject: [PATCH] fix(cookies): set default cookie path to /

---
 .size-snapshot.json                   | 20 ++++++++++----------
 integration/fixtures/streamsql.min.js |  2 +-
 src/Cookies.ts                        |  2 ++
 src/test/cookies.test.ts              |  8 ++++++++
 4 files changed, 21 insertions(+), 11 deletions(-)

diff --git a/.size-snapshot.json b/.size-snapshot.json
index 679b06a..2297646 100644
--- a/.size-snapshot.json
+++ b/.size-snapshot.json
@@ -1,26 +1,26 @@
 {
   "dist/streamsql.esm.js": {
-    "bundled": 8662,
-    "minified": 4273,
-    "gzipped": 1705,
+    "bundled": 8725,
+    "minified": 4301,
+    "gzipped": 1721,
     "treeshaked": {
       "rollup": {
         "code": 75,
         "import_statements": 0
       },
       "webpack": {
-        "code": 4866
+        "code": 4894
       }
     }
   },
   "dist/streamsql.cjs.js": {
-    "bundled": 10213,
-    "minified": 4843,
-    "gzipped": 1782
+    "bundled": 10276,
+    "minified": 4871,
+    "gzipped": 1798
   },
   "dist/streamsql.min.js": {
-    "bundled": 11154,
-    "minified": 4647,
-    "gzipped": 1748
+    "bundled": 11227,
+    "minified": 4675,
+    "gzipped": 1765
   }
 }
diff --git a/integration/fixtures/streamsql.min.js b/integration/fixtures/streamsql.min.js
index e0d506a..dcb4fc0 100644
--- a/integration/fixtures/streamsql.min.js
+++ b/integration/fixtures/streamsql.min.js
@@ -1 +1 @@
-!function(t){"function"==typeof define&&define.amd?define("streamsql",t):t()}((function(){"use strict";var t,e=function(t){return new Error("[StreamSQL] Error: "+t)},i=function(t){return t&&t.length?t[0].toUpperCase()+t.slice(1).toLowerCase():t},n=function(){function t(t,e){this.url=t,this.apiKey=e,this.xhr=void 0,this.xhr=this.buildRequest(this.url,this.apiKey)}var i=t.prototype;return i.send=function(t,i){var n=this;return this.xhr=this.buildRequest(this.url,this.apiKey),new Promise((function(r,s){n.xhr.onreadystatechange=function(){if(this.readyState===this.DONE)if(i&&i(this.status,this.responseText),this.status>=200&&this.status<400)try{r(this.response)}catch(t){s(t)}else if(this.status)try{s(this.response)}catch(t){s(t)}else s(e("something went wrong sending XMLHttpRequest"))};try{n.xhr.send(JSON.stringify(t))}catch(t){s(t)}}))},i.buildRequest=function(t,e){var i=new XMLHttpRequest;return i.open("POST",t,!0),i.setRequestHeader("Content-Type","application/json; charset=UTF-8"),i.setRequestHeader("x-streamsql-key",e),i.withCredentials=!0,i.timeout=3e3,i},t}();!function(t){t.None="None",t.Lax="Lax",t.Strict="Strict"}(t||(t={}));var r=function(){function e(){this.simpleCookies=new Map}var n=e.prototype;return n.setCookie=function(e){if(!e.maxAge&&!e.expires){var i=new Date;i.setFullYear(i.getFullYear()+1),e.expires=i.toUTCString()}e.secure=!0,e.sameSite=t.None,this.simpleCookies.set(e.name,e.value),document.cookie=this.toCookieString(e)},n.getCookie=function(t){if(this.simpleCookies.has(t))return this.simpleCookies.get(t);var e="";try{for(var i=t+"=",n=document.cookie.split(";"),r=0;r<n.length;r++){for(var s=n[r];" "===s.charAt(0);)s=s.substring(1);if(0===s.indexOf(i)){e=s.substring(i.length,s.length);break}}return e}catch(t){return e}},n.clearCookie=function(t){this.simpleCookies.delete(t);var e=new Date;e.setTime(0),this.setCookie({name:t,value:"",maxAge:0,expires:e.toUTCString()})},n.toCookieString=function(t){var e=[t.name+"="+t.value];delete t.name,delete t.value;for(var n=0,r=Object.entries(t);n<r.length;n++){var s=r[n],o=s[0],u=s[1];"httpOnly"===o?e.push("HttpOnly"):"sameSite"===o?e.push("SameSite="+u):"maxAge"===o?e.push("MaxAge="+u):"boolean"==typeof u&&u?e.push(""+i(o)):e.push(i(o)+"="+u)}return e.join("; ")},e}(),s=function(){function t(){this.userId="",this.ch=new r}var e=t.prototype;return e.setUser=function(t){this.userId=t,this.ch.setCookie({name:"__ssqlclient_uid",value:t})},e.getUser=function(){return this.userId||this.ch.getCookie("__ssqlclient_uid")},e.deleteUser=function(){this.userId="",this.ch.clearCookie("__ssqlclient_uid")},t}(),o=function(){function t(){}var e=t.prototype;return e.location=function(){return this.isWindow("location")&&window.location.href||""},e.referrer=function(){return this.isDocument()&&document.referrer||""},e.title=function(){return this.isDocument()&&document.title||""},e.language=function(){return this.isNavigator()&&navigator.language||""},e.userAgent=function(){return this.isNavigator()&&navigator.userAgent||""},e.isWindow=function(t){return"undefined"!=typeof window&&window.hasOwnProperty(t)},e.isDocument=function(){return this.isWindow("document")&&"undefined"!=typeof document},e.isNavigator=function(){return this.isWindow("navigator")&&"undefined"!=typeof navigator},t}(),u=new(function(){function t(){this.fetcher=void 0,this.identifier=void 0,this.pageCtx=void 0}var i=t.prototype;return i.init=function(t){if(!function(t){return!!t}(t))throw e("api key is invalid");return this.fetcher=new n("https://wildcard.localhost.com:9001/api/send/pixel",t),this.identifier=new s,this.pageCtx=new o,this},i.identify=function(t){return this.identifier||this.throwNoInitError(),this.identifier.setUser(t),this.onIdentify(t),this},i.unidentify=function(){return this.identifier||this.throwNoInitError(),this.identifier.deleteUser(),this.onUnidentify(),this},i.sendEvent=function(t,e,i){this.fetcher||this.throwNoInitError(),this.fetcher.send(this.buildData(t,e),i).catch((function(t){}))},i.buildData=function(t,e){this.pageCtx&&this.identifier||this.throwNoInitError();var i={timestamp:(new Date).getTime(),apiVersion:this.version(),context:{language:this.pageCtx.language(),referrer:this.pageCtx.referrer(),title:this.pageCtx.title(),userAgent:this.pageCtx.userAgent(),url:this.pageCtx.location()},user:{id:this.identifier.getUser()}},n=e?Object.assign({},i,{event:e}):i;return{stream:t.toLowerCase(),data:n}},i.throwNoInitError=function(){throw e("api key must be set first: streamsql.init(apiKey)")},i.version=function(){return"v1-beta"},i.onIdentify=function(t){},i.onUnidentify=function(){},t}());!function(t,e,i){t.streamsql=t.streamsql||u}(window)}));
+!function(t){"function"==typeof define&&define.amd?define("streamsql",t):t()}((function(){"use strict";var t,e=function(t){return new Error("[StreamSQL] Error: "+t)},i=function(t){return t&&t.length?t[0].toUpperCase()+t.slice(1).toLowerCase():t},n=function(){function t(t,e){this.url=t,this.apiKey=e,this.xhr=void 0,this.xhr=this.buildRequest(this.url,this.apiKey)}var i=t.prototype;return i.send=function(t,i){var n=this;return this.xhr=this.buildRequest(this.url,this.apiKey),new Promise((function(r,s){n.xhr.onreadystatechange=function(){if(this.readyState===this.DONE)if(i&&i(this.status,this.responseText),this.status>=200&&this.status<400)try{r(this.response)}catch(t){s(t)}else if(this.status)try{s(this.response)}catch(t){s(t)}else s(e("something went wrong sending XMLHttpRequest"))};try{n.xhr.send(JSON.stringify(t))}catch(t){s(t)}}))},i.buildRequest=function(t,e){var i=new XMLHttpRequest;return i.open("POST",t,!0),i.setRequestHeader("Content-Type","application/json; charset=UTF-8"),i.setRequestHeader("x-streamsql-key",e),i.withCredentials=!0,i.timeout=3e3,i},t}();!function(t){t.None="None",t.Lax="Lax",t.Strict="Strict"}(t||(t={}));var r=function(){function e(){this.simpleCookies=new Map}var n=e.prototype;return n.setCookie=function(e){if(!e.maxAge&&!e.expires){var i=new Date;i.setFullYear(i.getFullYear()+1),e.expires=i.toUTCString()}e.path=e.path||"/",e.secure=!0,e.sameSite=t.None,this.simpleCookies.set(e.name,e.value),document.cookie=this.toCookieString(e)},n.getCookie=function(t){if(this.simpleCookies.has(t))return this.simpleCookies.get(t);var e="";try{for(var i=t+"=",n=document.cookie.split(";"),r=0;r<n.length;r++){for(var s=n[r];" "===s.charAt(0);)s=s.substring(1);if(0===s.indexOf(i)){e=s.substring(i.length,s.length);break}}return e}catch(t){return e}},n.clearCookie=function(t){this.simpleCookies.delete(t);var e=new Date;e.setTime(0),this.setCookie({name:t,value:"",path:"/",maxAge:0,expires:e.toUTCString()})},n.toCookieString=function(t){var e=[t.name+"="+t.value];delete t.name,delete t.value;for(var n=0,r=Object.entries(t);n<r.length;n++){var s=r[n],o=s[0],u=s[1];"httpOnly"===o?e.push("HttpOnly"):"sameSite"===o?e.push("SameSite="+u):"maxAge"===o?e.push("MaxAge="+u):"boolean"==typeof u&&u?e.push(""+i(o)):e.push(i(o)+"="+u)}return e.join("; ")},e}(),s=function(){function t(){this.userId="",this.ch=new r}var e=t.prototype;return e.setUser=function(t){this.userId=t,this.ch.setCookie({name:"__ssqlclient_uid",value:t})},e.getUser=function(){return this.userId||this.ch.getCookie("__ssqlclient_uid")},e.deleteUser=function(){this.userId="",this.ch.clearCookie("__ssqlclient_uid")},t}(),o=function(){function t(){}var e=t.prototype;return e.location=function(){return this.isWindow("location")&&window.location.href||""},e.referrer=function(){return this.isDocument()&&document.referrer||""},e.title=function(){return this.isDocument()&&document.title||""},e.language=function(){return this.isNavigator()&&navigator.language||""},e.userAgent=function(){return this.isNavigator()&&navigator.userAgent||""},e.isWindow=function(t){return"undefined"!=typeof window&&window.hasOwnProperty(t)},e.isDocument=function(){return this.isWindow("document")&&"undefined"!=typeof document},e.isNavigator=function(){return this.isWindow("navigator")&&"undefined"!=typeof navigator},t}(),u=new(function(){function t(){this.fetcher=void 0,this.identifier=void 0,this.pageCtx=void 0}var i=t.prototype;return i.init=function(t){if(!function(t){return!!t}(t))throw e("api key is invalid");return this.fetcher=new n("https://wildcard.localhost.com:9001/api/send/pixel",t),this.identifier=new s,this.pageCtx=new o,this},i.identify=function(t){return this.identifier||this.throwNoInitError(),this.identifier.setUser(t),this.onIdentify(t),this},i.unidentify=function(){return this.identifier||this.throwNoInitError(),this.identifier.deleteUser(),this.onUnidentify(),this},i.sendEvent=function(t,e,i){this.fetcher||this.throwNoInitError(),this.fetcher.send(this.buildData(t,e),i).catch((function(t){}))},i.buildData=function(t,e){this.pageCtx&&this.identifier||this.throwNoInitError();var i={timestamp:(new Date).getTime(),apiVersion:this.version(),context:{language:this.pageCtx.language(),referrer:this.pageCtx.referrer(),title:this.pageCtx.title(),userAgent:this.pageCtx.userAgent(),url:this.pageCtx.location()},user:{id:this.identifier.getUser()}},n=e?Object.assign({},i,{event:e}):i;return{stream:t.toLowerCase(),data:n}},i.throwNoInitError=function(){throw e("api key must be set first: streamsql.init(apiKey)")},i.version=function(){return"v1-beta"},i.onIdentify=function(t){},i.onUnidentify=function(){},t}());!function(t,e,i){t.streamsql=t.streamsql||u}(window)}));
diff --git a/src/Cookies.ts b/src/Cookies.ts
index e771cbe..7522040 100644
--- a/src/Cookies.ts
+++ b/src/Cookies.ts
@@ -47,6 +47,7 @@ export default class CookieJar implements CookieHandler {
       oneYearFromNow.setFullYear(oneYearFromNow.getFullYear() + 1)
       cookieOpts.expires = oneYearFromNow.toUTCString()
     }
+    cookieOpts.path = cookieOpts.path || '/'
     cookieOpts.secure = true
     cookieOpts.sameSite = SameSite.None
     this.simpleCookies.set(cookieOpts.name, cookieOpts.value)
@@ -85,6 +86,7 @@ export default class CookieJar implements CookieHandler {
     this.setCookie({
       name,
       value: '',
+      path: '/',
       maxAge: 0,
       expires: epoch.toUTCString()
     })
diff --git a/src/test/cookies.test.ts b/src/test/cookies.test.ts
index e128e24..8035b5b 100644
--- a/src/test/cookies.test.ts
+++ b/src/test/cookies.test.ts
@@ -76,6 +76,14 @@ describe('CookieHandler', () => {
     expect(document.cookie).toMatch('Secure')
   })
 
+  it('sets default cookie path to /', () => {
+    ch.setCookie({
+      name: 'name',
+      value: 'value',
+    })
+    expect(document.cookie).toMatch('Path=/')
+  })
+
   it('overrides default domain and path when set in options', () => {
     ch.setCookie({
       name: 'name',