Skip to content

Commit d831eda

Browse files
authored
Merge pull request #21 from dhebbeker/feature/enhance_getting_system_time
Replace VL53L1_GetTickCount() by millis().
2 parents 035113e + 8e74bce commit d831eda

File tree

3 files changed

+4
-30
lines changed

3 files changed

+4
-30
lines changed

src/vl53l1_class.cpp

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -3879,18 +3879,6 @@ VL53L1_Error VL53L1::VL53L1_I2CRead(uint8_t DeviceAddr, uint16_t RegisterAddr, u
38793879
return 0;
38803880
}
38813881

3882-
VL53L1_Error VL53L1::VL53L1_GetTickCount(uint32_t *ptick_count_ms)
3883-
{
3884-
/* Returns current tick count in [ms] */
3885-
3886-
VL53L1_Error status = VL53L1_ERROR_NONE;
3887-
3888-
//*ptick_count_ms = timeGetTime();
3889-
*ptick_count_ms = 0;
3890-
3891-
return status;
3892-
}
3893-
38943882
VL53L1_Error VL53L1::VL53L1_WaitUs(VL53L1_Dev_t *pdev, int32_t wait_us)
38953883
{
38963884
VL53L1_WaitMs(pdev, wait_us / 1000);
@@ -3919,18 +3907,11 @@ VL53L1_Error VL53L1::VL53L1_WaitValueMaskEx(VL53L1_Dev_t *pdev, uint32_t timeout
39193907
*/
39203908

39213909
VL53L1_Error status = VL53L1_ERROR_NONE;
3922-
uint32_t start_time_ms = 0;
3923-
uint32_t current_time_ms = 0;
3910+
const auto start_time_ms = millis();
39243911
uint32_t polling_time_ms = 0;
39253912
uint8_t byte_value = 0;
39263913
uint8_t found = 0;
39273914

3928-
3929-
3930-
/* calculate time limit in absolute time */
3931-
3932-
VL53L1_GetTickCount(&start_time_ms);
3933-
39343915
/* remember current trace functions and temporarily disable
39353916
* function logging
39363917
*/
@@ -3961,8 +3942,7 @@ VL53L1_Error VL53L1::VL53L1_WaitValueMaskEx(VL53L1_Dev_t *pdev, uint32_t timeout
39613942

39623943
/* Update polling time (Compare difference rather than absolute to
39633944
negate 32bit wrap around issue) */
3964-
VL53L1_GetTickCount(&current_time_ms);
3965-
polling_time_ms = current_time_ms - start_time_ms;
3945+
polling_time_ms = static_cast<std::uint32_t>(millis() - start_time_ms);
39663946

39673947
}
39683948

src/vl53l1_class.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5299,7 +5299,6 @@ class VL53L1 : public RangeSensor {
52995299

53005300
VL53L1_Error VL53L1_I2CWrite(uint8_t DeviceAddr, uint16_t RegisterAddr, uint8_t *pBuffer, uint16_t NumByteToWrite);
53015301
VL53L1_Error VL53L1_I2CRead(uint8_t DeviceAddr, uint16_t RegisterAddr, uint8_t *pBuffer, uint16_t NumByteToRead);
5302-
VL53L1_Error VL53L1_GetTickCount(uint32_t *ptick_count_ms);
53035302
VL53L1_Error VL53L1_WaitUs(VL53L1_Dev_t *pdev, int32_t wait_us);
53045303
VL53L1_Error VL53L1_WaitMs(VL53L1_Dev_t *pdev, int32_t wait_ms);
53055304

src/vl53l1_wait.cpp

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -425,14 +425,10 @@ VL53L1_Error VL53L1::VL53L1_poll_for_firmware_ready(
425425
VL53L1_Error status = VL53L1_ERROR_NONE;
426426
VL53L1_LLDriverData_t *pdev = VL53L1DevStructGetLLDriverHandle(Dev);
427427

428-
uint32_t start_time_ms = 0;
429-
uint32_t current_time_ms = 0;
428+
const auto start_time_ms = millis();
430429
int32_t poll_delay_ms = VL53L1_POLLING_DELAY_MS;
431430
uint8_t fw_ready = 0;
432431

433-
434-
435-
VL53L1_GetTickCount(&start_time_ms);
436432
pdev->fw_ready_poll_duration_ms = 0;
437433

438434

@@ -454,9 +450,8 @@ VL53L1_Error VL53L1::VL53L1_poll_for_firmware_ready(
454450
}
455451

456452

457-
VL53L1_GetTickCount(&current_time_ms);
458453
pdev->fw_ready_poll_duration_ms =
459-
current_time_ms - start_time_ms;
454+
static_cast<std::uint32_t>(millis() - start_time_ms);
460455
}
461456

462457
if (fw_ready == 0 && status == VL53L1_ERROR_NONE) {

0 commit comments

Comments
 (0)