Skip to content

Commit 20e6e72

Browse files
committed
[stm32variant] Rename ND by PNUM_NOT_DEFINED
ND is used by some Arduino Library (ex: Ethernet) Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
1 parent 8366f41 commit 20e6e72

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

CI/utils/stm32variant.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1130,7 +1130,7 @@ def print_pinamevar():
11301130

11311131
# Variant files generation
11321132
def spi_pins_variant():
1133-
ss_pin = ss1_pin = ss2_pin = ss3_pin = mosi_pin = miso_pin = sck_pin = "ND"
1133+
ss_pin = ss1_pin = ss2_pin = ss3_pin = mosi_pin = miso_pin = sck_pin = "PNUM_NOT_DEFINED"
11341134

11351135
# Iterate to find match instance if any
11361136
for mosi in spimosi_list:
@@ -1155,13 +1155,13 @@ def spi_pins_variant():
11551155
for ss in spissel_list:
11561156
ss_inst = ss[2].split("_", 1)[0]
11571157
if mosi_inst == ss_inst:
1158-
if "ND" == ss_pin:
1158+
if "PNUM_NOT_DEFINED" == ss_pin:
11591159
ss_pin = ss[0].replace("_", "", 1)
1160-
elif "ND" == ss1_pin:
1160+
elif "PNUM_NOT_DEFINED" == ss1_pin:
11611161
ss1_pin = ss[0].replace("_", "", 1)
1162-
elif "ND" == ss2_pin:
1162+
elif "PNUM_NOT_DEFINED" == ss2_pin:
11631163
ss2_pin = ss[0].replace("_", "", 1)
1164-
elif "ND" == ss3_pin:
1164+
elif "PNUM_NOT_DEFINED" == ss3_pin:
11651165
ss3_pin = ss[0].replace("_", "", 1)
11661166
break
11671167
break
@@ -1179,7 +1179,7 @@ def spi_pins_variant():
11791179

11801180

11811181
def i2c_pins_variant():
1182-
sda_pin = scl_pin = "ND"
1182+
sda_pin = scl_pin = "PNUM_NOT_DEFINED"
11831183
# Iterate to find match instance if any
11841184
for sda in i2csda_list:
11851185
sda_inst = sda[2].split("_", 1)[0]
@@ -1229,7 +1229,7 @@ def serial_pins_variant():
12291229
print("No serial instance number found!")
12301230
serialnum = "-1"
12311231
else:
1232-
serialtx_pin = serialtx_pin = "ND"
1232+
serialtx_pin = serialtx_pin = "PNUM_NOT_DEFINED"
12331233
serialnum = "-1"
12341234
print("No serial found!")
12351235
return dict(instance=serialnum, rx=serialrx_pin, tx=serialtx_pin)

CI/utils/templates/variant_generic.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,12 @@
3737

3838
// On-board LED pin number
3939
#ifndef LED_BUILTIN
40-
#define LED_BUILTIN ND
40+
#define LED_BUILTIN PNUM_NOT_DEFINED
4141
#endif
4242

4343
// On-board user button
4444
#ifndef USER_BTN
45-
#define USER_BTN ND
45+
#define USER_BTN PNUM_NOT_DEFINED
4646
#endif
4747

4848
// SPI definitions

cores/arduino/pins_arduino.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
#define PNUM_MASK 0xFF
3333

3434
/* Pin not defined */
35-
#define ND NUM_DIGITAL_PINS
35+
#define PNUM_NOT_DEFINED NUM_DIGITAL_PINS
3636

3737
/* Avoid PortName issue */
3838
_Static_assert(LastPort <= 0x0F, "PortName must be less than 16");

keywords.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -735,7 +735,7 @@ ALT5 LITERAL1
735735
ALT6 LITERAL1
736736
ALT7 LITERAL1
737737
ATLX_MASK LITERAL1
738-
ND LITERAL1
738+
PNUM_NOT_DEFINED LITERAL1
739739
PNUM_MASK LITERAL1
740740
PNUM_ANALOG_BASE LITERAL1
741741
PNUM_ANALOG_INDEX LITERAL1

0 commit comments

Comments
 (0)