From 85ddf9992ef82ca7e544aec6f09f16e2ac9a5425 Mon Sep 17 00:00:00 2001 From: Hecker165 Date: Mon, 3 Mar 2025 19:56:45 +0530 Subject: [PATCH 01/11] Fix stdlib-bot comments: reordered declarations, moved section, and used SQRT2 --- .../stats/base/dists/normal/quantile/README.md | 15 ++++++++++++--- .../dists/normal/quantile/benchmark/c/benchmark.c | 10 +++++----- .../stats/base/dists/normal/quantile/src/main.c | 3 ++- 3 files changed, 19 insertions(+), 9 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/README.md b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/README.md index a7a07a0ab581..c807c7ade160 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/README.md +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/README.md @@ -152,9 +152,6 @@ for ( i = 0; i < 10; i++ ) { - - -
@@ -249,6 +246,18 @@ int main( void ) {
+ + + + + + + + +
+ +
+ diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c index 06efcf2aaca6..fc891762c384 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c @@ -93,13 +93,13 @@ static double random_uniform( const double min, const double max ) { * @return elapsed time in seconds */ static double benchmark( void ) { - double elapsed; - double p[ 100 ]; - double mu[ 100 ]; - double sigma[ 100 ]; + int i; double y; double t; - int i; + double elapsed; + double p[100]; + double mu[100]; + double sigma[100]; for ( i = 0; i < 100; i++ ) { p[ i ] = random_uniform( 0.0, 1.0 ); diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c index 86e8c5b8fd30..74dde2848e64 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c @@ -20,6 +20,7 @@ #include "stdlib/math/base/assert/is_nan.h" #include "stdlib/math/base/special/sqrt.h" #include "stdlib/math/base/special/erfinv.h" +#include "@stdlib/constants/float64/sqrt-two.h" /** * Evaluates the quantile function for a normal distribution with mean `mu` and standard deviation `sigma` at a probability `p`. @@ -47,5 +48,5 @@ double stdlib_base_dists_normal_quantile( const double p, const double mu, const if ( sigma == 0.0 ) { return mu; } - return mu + ( ( sigma * stdlib_base_sqrt( 2.0 ) ) * stdlib_base_erfinv( ( 2.0 * p ) - 1.0 ) ); + return mu + ( ( sigma * SQRT2 ) * stdlib_base_erfinv( ( 2.0 * p ) - 1.0 ) ); } From 2f82810d9046a6a6149cf08bc45cb75f2caad3cb Mon Sep 17 00:00:00 2001 From: Hecker165 Date: Mon, 3 Mar 2025 21:58:49 +0530 Subject: [PATCH 02/11] Fixed compilation issue in main.c --- .../@stdlib/stats/base/dists/normal/quantile/src/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c index 74dde2848e64..086c0d6ff486 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c @@ -20,7 +20,7 @@ #include "stdlib/math/base/assert/is_nan.h" #include "stdlib/math/base/special/sqrt.h" #include "stdlib/math/base/special/erfinv.h" -#include "@stdlib/constants/float64/sqrt-two.h" +#include "@stdlib\constants\float64\sqrt-two\include\stdlib\constants\float64\sqrt_two.h" /** * Evaluates the quantile function for a normal distribution with mean `mu` and standard deviation `sigma` at a probability `p`. @@ -48,5 +48,5 @@ double stdlib_base_dists_normal_quantile( const double p, const double mu, const if ( sigma == 0.0 ) { return mu; } - return mu + ( ( sigma * SQRT2 ) * stdlib_base_erfinv( ( 2.0 * p ) - 1.0 ) ); + return mu + ( ( sigma * STDLIB_CONSTANT_FLOAT64_SQRT2 ) * stdlib_base_erfinv( ( 2.0 * p ) - 1.0 ) ); } From 48e5e12752e74ec518866f30b08d044f2670b4a3 Mon Sep 17 00:00:00 2001 From: Abhay Punia <156515195+Hecker165@users.noreply.github.com> Date: Mon, 3 Mar 2025 22:03:03 +0530 Subject: [PATCH 03/11] Updated main.c Signed-off-by: Abhay Punia <156515195+Hecker165@users.noreply.github.com> --- .../@stdlib/stats/base/dists/normal/quantile/src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c index 086c0d6ff486..fcc8b31c4459 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c @@ -20,7 +20,7 @@ #include "stdlib/math/base/assert/is_nan.h" #include "stdlib/math/base/special/sqrt.h" #include "stdlib/math/base/special/erfinv.h" -#include "@stdlib\constants\float64\sqrt-two\include\stdlib\constants\float64\sqrt_two.h" +#include "stdlib\constants\float64\sqrt-two\include\stdlib\constants\float64\sqrt_two.h" /** * Evaluates the quantile function for a normal distribution with mean `mu` and standard deviation `sigma` at a probability `p`. From 52b9e378553af1acfc909d092a2fc67f02a7918c Mon Sep 17 00:00:00 2001 From: Abhay Punia <156515195+Hecker165@users.noreply.github.com> Date: Mon, 3 Mar 2025 22:07:21 +0530 Subject: [PATCH 04/11] Updated main.c Signed-off-by: Abhay Punia <156515195+Hecker165@users.noreply.github.com> --- .../@stdlib/stats/base/dists/normal/quantile/src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c index fcc8b31c4459..039d7d8b12d3 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c @@ -20,7 +20,7 @@ #include "stdlib/math/base/assert/is_nan.h" #include "stdlib/math/base/special/sqrt.h" #include "stdlib/math/base/special/erfinv.h" -#include "stdlib\constants\float64\sqrt-two\include\stdlib\constants\float64\sqrt_two.h" +#include "stdlib/constants/float64/sqrt_two.h" /** * Evaluates the quantile function for a normal distribution with mean `mu` and standard deviation `sigma` at a probability `p`. From f2a4dc8edf062745483929f80c34c16d7ef26cbb Mon Sep 17 00:00:00 2001 From: Hecker165 Date: Mon, 3 Mar 2025 22:15:11 +0530 Subject: [PATCH 05/11] Update main.c --- .../@stdlib/stats/base/dists/normal/quantile/src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c index 086c0d6ff486..2ed10bbc39d8 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c @@ -20,7 +20,7 @@ #include "stdlib/math/base/assert/is_nan.h" #include "stdlib/math/base/special/sqrt.h" #include "stdlib/math/base/special/erfinv.h" -#include "@stdlib\constants\float64\sqrt-two\include\stdlib\constants\float64\sqrt_two.h" +#include "lib/node_modules/@stdlib/constants/float64/sqrt-two/include/stdlib/constants/float64/sqrt_two.h" /** * Evaluates the quantile function for a normal distribution with mean `mu` and standard deviation `sigma` at a probability `p`. From 4e70aaf46ab12d485e081cb4b373123b06ea6ee3 Mon Sep 17 00:00:00 2001 From: Abhay Punia <156515195+Hecker165@users.noreply.github.com> Date: Tue, 4 Mar 2025 00:16:17 +0530 Subject: [PATCH 06/11] Update main.c Signed-off-by: Abhay Punia <156515195+Hecker165@users.noreply.github.com> --- .../@stdlib/stats/base/dists/normal/quantile/src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c index 2ed10bbc39d8..3327432ca94e 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c @@ -20,7 +20,7 @@ #include "stdlib/math/base/assert/is_nan.h" #include "stdlib/math/base/special/sqrt.h" #include "stdlib/math/base/special/erfinv.h" -#include "lib/node_modules/@stdlib/constants/float64/sqrt-two/include/stdlib/constants/float64/sqrt_two.h" +#include "../../../../../constants/float64/sqrt-two/include/stdlib/constants/float64/sqrt_two.h" /** * Evaluates the quantile function for a normal distribution with mean `mu` and standard deviation `sigma` at a probability `p`. From 308526f9aa9b2086511609ad8b58e6a6c5fb30aa Mon Sep 17 00:00:00 2001 From: Hecker165 Date: Tue, 4 Mar 2025 23:33:41 +0530 Subject: [PATCH 07/11] Implemented the changes suggested --- .../dists/normal/quantile/benchmark/c/benchmark.c | 12 ++++++------ .../stats/base/dists/normal/quantile/manifest.json | 9 ++++++--- .../stats/base/dists/normal/quantile/src/main.c | 2 +- 3 files changed, 13 insertions(+), 10 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c index fc891762c384..8624f45cc80c 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c @@ -93,13 +93,13 @@ static double random_uniform( const double min, const double max ) { * @return elapsed time in seconds */ static double benchmark( void ) { - int i; - double y; - double t; - double elapsed; - double p[100]; - double mu[100]; double sigma[100]; + double mu[100]; + double p[100]; + double elapsed; + double t; + double y; + int i; for ( i = 0; i < 100; i++ ) { p[ i ] = random_uniform( 0.0, 1.0 ); diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json index 749019a51b48..dbbaa83b14a7 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json @@ -41,7 +41,8 @@ "@stdlib/math/base/napi/ternary", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/special/sqrt", - "@stdlib/math/base/special/erfinv" + "@stdlib/math/base/special/erfinv", + "@stdlib/constants/float64/sqrt_two" ] }, { @@ -59,7 +60,8 @@ "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/special/sqrt", "@stdlib/math/base/special/erfinv", - "@stdlib/constants/float64/eps" + "@stdlib/constants/float64/eps", + "@stdlib/constants/float64/sqrt_two" ] }, { @@ -77,7 +79,8 @@ "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/special/sqrt", "@stdlib/math/base/special/erfinv", - "@stdlib/constants/float64/eps" + "@stdlib/constants/float64/eps", + "@stdlib/constants/float64/sqrt_two" ] } ] diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c index 3327432ca94e..039d7d8b12d3 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c @@ -20,7 +20,7 @@ #include "stdlib/math/base/assert/is_nan.h" #include "stdlib/math/base/special/sqrt.h" #include "stdlib/math/base/special/erfinv.h" -#include "../../../../../constants/float64/sqrt-two/include/stdlib/constants/float64/sqrt_two.h" +#include "stdlib/constants/float64/sqrt_two.h" /** * Evaluates the quantile function for a normal distribution with mean `mu` and standard deviation `sigma` at a probability `p`. From 86005f54557e9c8ae2d96eb9efc1d3804692721d Mon Sep 17 00:00:00 2001 From: Hecker165 Date: Wed, 5 Mar 2025 00:39:51 +0530 Subject: [PATCH 08/11] Update manifest.json --- .../@stdlib/stats/base/dists/normal/quantile/manifest.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json index dbbaa83b14a7..abeb1587eb1a 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json @@ -41,8 +41,7 @@ "@stdlib/math/base/napi/ternary", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/special/sqrt", - "@stdlib/math/base/special/erfinv", - "@stdlib/constants/float64/sqrt_two" + "@stdlib/math/base/special/erfinv" ] }, { From 23bb042891c8bb5674322aeeaf7402f587743086 Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Tue, 4 Mar 2025 20:58:05 -0500 Subject: [PATCH 09/11] chore: add spaces and fix dependency Signed-off-by: Philipp Burckhardt --- .../base/dists/normal/quantile/benchmark/c/benchmark.c | 6 +++--- .../@stdlib/stats/base/dists/normal/quantile/manifest.json | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c index 8624f45cc80c..71c427b88375 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c @@ -93,9 +93,9 @@ static double random_uniform( const double min, const double max ) { * @return elapsed time in seconds */ static double benchmark( void ) { - double sigma[100]; - double mu[100]; - double p[100]; + double sigma[ 100 ]; + double mu[ 100 ]; + double p[ 100 ]; double elapsed; double t; double y; diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json index abeb1587eb1a..63f947af36e9 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json @@ -60,7 +60,7 @@ "@stdlib/math/base/special/sqrt", "@stdlib/math/base/special/erfinv", "@stdlib/constants/float64/eps", - "@stdlib/constants/float64/sqrt_two" + "@stdlib/constants/float64/sqrt-two" ] }, { @@ -79,7 +79,7 @@ "@stdlib/math/base/special/sqrt", "@stdlib/math/base/special/erfinv", "@stdlib/constants/float64/eps", - "@stdlib/constants/float64/sqrt_two" + "@stdlib/constants/float64/sqrt-two" ] } ] From 2bccaa3794df33877cdef9efe7bf6617e378eaac Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Tue, 4 Mar 2025 21:00:45 -0500 Subject: [PATCH 10/11] fix: add sqrt-two dependency to main manifest.json config --- .../@stdlib/stats/base/dists/normal/quantile/manifest.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json index 63f947af36e9..709351d4c22f 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json @@ -41,7 +41,8 @@ "@stdlib/math/base/napi/ternary", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/special/sqrt", - "@stdlib/math/base/special/erfinv" + "@stdlib/math/base/special/erfinv", + "@stdlib/constants/float64/sqrt-two" ] }, { From acd201684a8c69745bcec2e011c4c904f0a52ab8 Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Tue, 4 Mar 2025 21:08:17 -0500 Subject: [PATCH 11/11] chore: remove trailing whitespace in benchmark.c --- .../stats/base/dists/normal/quantile/benchmark/c/benchmark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c index 71c427b88375..8e4d9e7bf461 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c @@ -99,7 +99,7 @@ static double benchmark( void ) { double elapsed; double t; double y; - int i; + int i; for ( i = 0; i < 100; i++ ) { p[ i ] = random_uniform( 0.0, 1.0 );