From 1a5070d70376fe04b7bb92422680eee8db41e45d Mon Sep 17 00:00:00 2001 From: Karan Anand Date: Mon, 17 Feb 2025 11:27:52 -0800 Subject: [PATCH 1/2] refactor: benchmarks and test messages --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- .../math/base/special/acosd/benchmark/benchmark.js | 7 ++++--- .../base/special/acosd/benchmark/benchmark.native.js | 7 ++++--- .../base/special/acosd/benchmark/c/native/benchmark.c | 9 ++++++--- .../@stdlib/math/base/special/acosd/test/test.js | 6 +++--- .../@stdlib/math/base/special/acosd/test/test.native.js | 6 +++--- 5 files changed, 20 insertions(+), 15 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/acosd/benchmark/benchmark.js b/lib/node_modules/@stdlib/math/base/special/acosd/benchmark/benchmark.js index 049df9f305ea..cf7000f26476 100644 --- a/lib/node_modules/@stdlib/math/base/special/acosd/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/math/base/special/acosd/benchmark/benchmark.js @@ -21,7 +21,7 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/array/uniform' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pkg = require( './../package.json' ).name; var acosd = require( './../lib' ); @@ -34,10 +34,11 @@ bench( pkg, function benchmark( b ) { var y; var i; + x = uniform( 100, -1.0, 1.0 ); + b.tic(); for ( i = 0; i < b.iterations; i++ ) { - x = ( randu()*2.0 ) - 1.0; - y = acosd( x ); + y = acosd( x[ i % x.length ] ); if ( isnan( y ) ) { b.fail( 'should not return NaN' ); } diff --git a/lib/node_modules/@stdlib/math/base/special/acosd/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/math/base/special/acosd/benchmark/benchmark.native.js index 34f2c0030956..643f7e92ccc1 100644 --- a/lib/node_modules/@stdlib/math/base/special/acosd/benchmark/benchmark.native.js +++ b/lib/node_modules/@stdlib/math/base/special/acosd/benchmark/benchmark.native.js @@ -22,7 +22,7 @@ var resolve = require( 'path' ).resolve; var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/array/uniform' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var tryRequire = require( '@stdlib/utils/try-require' ); var pkg = require( './../package.json' ).name; @@ -43,10 +43,11 @@ bench( pkg+'::native', opts, function benchmark( b ) { var y; var i; + x = uniform( 100, -1.0, 1.0 ); + b.tic(); for ( i = 0; i < b.iterations; i++ ) { - x = ( randu() * 2.0 ) - 1.0; - y = acosd( x ); + y = acosd( x[ i % x.length ] ); if ( isnan( y ) ) { b.fail( 'should not return NaN' ); } diff --git a/lib/node_modules/@stdlib/math/base/special/acosd/benchmark/c/native/benchmark.c b/lib/node_modules/@stdlib/math/base/special/acosd/benchmark/c/native/benchmark.c index 964d0e89c2e4..04a9fce34470 100644 --- a/lib/node_modules/@stdlib/math/base/special/acosd/benchmark/c/native/benchmark.c +++ b/lib/node_modules/@stdlib/math/base/special/acosd/benchmark/c/native/benchmark.c @@ -90,16 +90,19 @@ static double rand_double( void ) { * @return elapsed time in seconds */ static double benchmark( void ) { + double x[ 100 ]; double elapsed; - double x; double y; double t; int i; + for ( i = 0; i < 100; i++ ) { + x[ i ] = ( 2.0 * rand_double() ) - 1.0; + } + t = tic(); for ( i = 0; i < ITERATIONS; i++ ) { - x = ( 2.0 * rand_double() ) - 1.0; - y = stdlib_base_acosd( x ); + y = stdlib_base_acosd( x[ i % 100 ] ); if ( y != y ) { printf( "should not return NaN\n" ); break; diff --git a/lib/node_modules/@stdlib/math/base/special/acosd/test/test.js b/lib/node_modules/@stdlib/math/base/special/acosd/test/test.js index a006cd428d4b..a33a86676259 100644 --- a/lib/node_modules/@stdlib/math/base/special/acosd/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/acosd/test/test.js @@ -44,7 +44,7 @@ tape( 'main export is a function', function test( t ) { tape( 'the function returns `NaN` if provided `NaN`', function test( t ) { var v = acosd( NaN ); - t.equal( isnan( v ), true, 'returns NaN' ); + t.equal( isnan( v ), true, 'returns expected value' ); t.end(); }); @@ -102,7 +102,7 @@ tape( 'the function returns `NaN` if provided a value less than `-1`', function for ( i = 0; i < 1e3; i++ ) { v = -(randu()*1.0e6) - (1.0-EPS); - t.equal( isnan( acosd( v ) ), true, 'returns NaN when provided '+v ); + t.equal( isnan( acosd( v ) ), true, 'returns expected value' ); } t.end(); }); @@ -113,7 +113,7 @@ tape( 'the function returns `NaN` if provided a value greater than `+1`', functi for ( i = 0; i < 1e3; i++ ) { v = (randu()*1.0e6) + 1.0 + EPS; - t.equal( isnan( acosd( v ) ), true, 'returns NaN when provided '+v ); + t.equal( isnan( acosd( v ) ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/math/base/special/acosd/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/acosd/test/test.native.js index 6568dcd1a7e1..0a47b0f409a8 100644 --- a/lib/node_modules/@stdlib/math/base/special/acosd/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/acosd/test/test.native.js @@ -53,7 +53,7 @@ tape( 'main export is a function', opts, function test( t ) { tape( 'the function returns `NaN` if provided `NaN`', opts, function test( t ) { var v = acosd( NaN ); - t.equal( isnan( v ), true, 'returns NaN' ); + t.equal( isnan( v ), true, 'returns expected value' ); t.end(); }); @@ -111,7 +111,7 @@ tape( 'the function returns `NaN` if provided a value less than `-1`', opts, fun for ( i = 0; i < 1e3; i++ ) { v = -(randu()*1.0e6) - (1.0-EPS); - t.equal( isnan( acosd( v ) ), true, 'returns NaN when provided '+v ); + t.equal( isnan( acosd( v ) ), true, 'returns expected value' ); } t.end(); }); @@ -122,7 +122,7 @@ tape( 'the function returns `NaN` if provided a value greater than `+1`', opts, for ( i = 0; i < 1e3; i++ ) { v = (randu()*1.0e6) + 1.0 + EPS; - t.equal( isnan( acosd( v ) ), true, 'returns NaN when provided '+v ); + t.equal( isnan( acosd( v ) ), true, 'returns expected value' ); } t.end(); }); From 89cd4d8fcd22f898bfebcb5d29d6bf3a264bdc59 Mon Sep 17 00:00:00 2001 From: Karan Anand Date: Mon, 17 Feb 2025 11:42:32 -0800 Subject: [PATCH 2/2] refactor: test messages --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed --- --- lib/node_modules/@stdlib/math/base/special/acosd/test/test.js | 4 ++-- .../@stdlib/math/base/special/acosd/test/test.native.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/acosd/test/test.js b/lib/node_modules/@stdlib/math/base/special/acosd/test/test.js index a33a86676259..c2974ea893f9 100644 --- a/lib/node_modules/@stdlib/math/base/special/acosd/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/acosd/test/test.js @@ -102,7 +102,7 @@ tape( 'the function returns `NaN` if provided a value less than `-1`', function for ( i = 0; i < 1e3; i++ ) { v = -(randu()*1.0e6) - (1.0-EPS); - t.equal( isnan( acosd( v ) ), true, 'returns expected value' ); + t.equal( isnan( acosd( v ) ), true, 'returns expected value when provided '+v ); } t.end(); }); @@ -113,7 +113,7 @@ tape( 'the function returns `NaN` if provided a value greater than `+1`', functi for ( i = 0; i < 1e3; i++ ) { v = (randu()*1.0e6) + 1.0 + EPS; - t.equal( isnan( acosd( v ) ), true, 'returns expected value' ); + t.equal( isnan( acosd( v ) ), true, 'returns expected value when provided '+v ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/math/base/special/acosd/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/acosd/test/test.native.js index 0a47b0f409a8..5f8f3cd38fd6 100644 --- a/lib/node_modules/@stdlib/math/base/special/acosd/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/acosd/test/test.native.js @@ -111,7 +111,7 @@ tape( 'the function returns `NaN` if provided a value less than `-1`', opts, fun for ( i = 0; i < 1e3; i++ ) { v = -(randu()*1.0e6) - (1.0-EPS); - t.equal( isnan( acosd( v ) ), true, 'returns expected value' ); + t.equal( isnan( acosd( v ) ), true, 'returns expected value when provided '+v ); } t.end(); }); @@ -122,7 +122,7 @@ tape( 'the function returns `NaN` if provided a value greater than `+1`', opts, for ( i = 0; i < 1e3; i++ ) { v = (randu()*1.0e6) + 1.0 + EPS; - t.equal( isnan( acosd( v ) ), true, 'returns expected value' ); + t.equal( isnan( acosd( v ) ), true, 'returns expected value when provided '+v ); } t.end(); });