From a10c57515716459690f14d984fa466edcf2de4f8 Mon Sep 17 00:00:00 2001 From: ekambains Date: Fri, 7 Feb 2025 16:00:48 -0500 Subject: [PATCH 1/3] rayleigh: moved random number generation outside the benchmarking loops and used uniform instead of randu Signed-off-by: ekambains --- .../dists/rayleigh/cdf/benchmark/benchmark.js | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/cdf/benchmark/benchmark.js b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/cdf/benchmark/benchmark.js index 6ecb2357afe7..918477315a12 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/cdf/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/cdf/benchmark/benchmark.js @@ -22,7 +22,7 @@ var bench = require( '@stdlib/bench' ); var Float64Array = require( '@stdlib/array/float64' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/base/uniform' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var EPS = require( '@stdlib/constants/float64/eps' ); var pkg = require( './../package.json' ).name; @@ -42,8 +42,8 @@ bench( pkg, function benchmark( b ) { x = new Float64Array( len ); sigma = new Float64Array( len ); for ( i = 0; i < len; i++ ) { - x[ i ] = ( randu() * 100.0 ) - 100.0; - sigma[ i ] = ( randu() * 20.0 ) + EPS; + x[ i ] = uniform( -100.0, 100.0 ); + sigma[ i ] = uniform( EPS, 20.0 ); } b.tic(); @@ -64,17 +64,22 @@ bench( pkg, function benchmark( b ) { bench( pkg+':factory', function benchmark( b ) { var sigma; var mycdf; + var len; var x; var y; var i; sigma = 4.0; mycdf = cdf.factory( sigma ); - + len = 100; + x = new Float64Array( len ); + for ( i = 0; i < len; i++ ) { + x[ i ] = uniform( -25.0, 50.0 ); + } + b.tic(); for ( i = 0; i < b.iterations; i++ ) { - x = ( randu()*50.0 ) - 25.0; - y = mycdf( x ); + y = mycdf( x[ i % len ] ); if ( isnan( y ) ) { b.fail( 'should not return NaN' ); } From 7e1e46ed7930abb623ed526bc92d141a4e01b4fd Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Fri, 7 Feb 2025 21:15:22 -0500 Subject: [PATCH 2/3] chore: update maximum value Signed-off-by: Philipp Burckhardt --- .../stats/base/dists/rayleigh/cdf/benchmark/benchmark.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/cdf/benchmark/benchmark.js b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/cdf/benchmark/benchmark.js index 918477315a12..d78d165bec7b 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/cdf/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/cdf/benchmark/benchmark.js @@ -74,7 +74,7 @@ bench( pkg+':factory', function benchmark( b ) { len = 100; x = new Float64Array( len ); for ( i = 0; i < len; i++ ) { - x[ i ] = uniform( -25.0, 50.0 ); + x[ i ] = uniform( -25.0, 25.0 ); } b.tic(); From 7cdfcd95251d308c37684c5c4c87ca73e67bf470 Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Fri, 7 Feb 2025 21:19:33 -0500 Subject: [PATCH 3/3] chore: remove trailing whitespace in benchmark.js --- .../stats/base/dists/rayleigh/cdf/benchmark/benchmark.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/cdf/benchmark/benchmark.js b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/cdf/benchmark/benchmark.js index d78d165bec7b..9d5c93627aaf 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/cdf/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/cdf/benchmark/benchmark.js @@ -76,7 +76,7 @@ bench( pkg+':factory', function benchmark( b ) { for ( i = 0; i < len; i++ ) { x[ i ] = uniform( -25.0, 25.0 ); } - + b.tic(); for ( i = 0; i < b.iterations; i++ ) { y = mycdf( x[ i % len ] );