From a78481d4aa5601467fd7d11776d6e77ac2a3b982 Mon Sep 17 00:00:00 2001 From: aayush0325 Date: Thu, 16 Jan 2025 19:31:34 +0000 Subject: [PATCH 1/2] refactor: refactor examples of --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../@stdlib/stats/base/dnanmax/README.md | 21 ++++++++----------- .../stats/base/dnanmax/examples/index.js | 21 ++++++++----------- 2 files changed, 18 insertions(+), 24 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dnanmax/README.md b/lib/node_modules/@stdlib/stats/base/dnanmax/README.md index cc415efacf2a..4e66291982e5 100644 --- a/lib/node_modules/@stdlib/stats/base/dnanmax/README.md +++ b/lib/node_modules/@stdlib/stats/base/dnanmax/README.md @@ -129,22 +129,19 @@ var v = dnanmax.ndarray( 4, x, 2, 1 ); ```javascript -var randu = require( '@stdlib/random/base/randu' ); -var round = require( '@stdlib/math/base/special/round' ); -var Float64Array = require( '@stdlib/array/float64' ); +var uniform = require( '@stdlib/random/base/uniform' ); +var filledarrayBy = require( '@stdlib/array/filled-by' ); +var bernoulli = require( '@stdlib/random/base/bernoulli' ); var dnanmax = require( '@stdlib/stats/base/dnanmax' ); -var x; -var i; - -x = new Float64Array( 10 ); -for ( i = 0; i < x.length; i++ ) { - if ( randu() < 0.2 ) { - x[ i ] = NaN; - } else { - x[ i ] = round( (randu()*100.0) - 50.0 ); +function rand() { + if ( bernoulli( 0.2 ) ) { + return NaN; } + return uniform( -50.0, 50.0 ); } + +var x = filledarrayBy( 10, 'float64', rand ); console.log( x ); var v = dnanmax( x.length, x, 1 ); diff --git a/lib/node_modules/@stdlib/stats/base/dnanmax/examples/index.js b/lib/node_modules/@stdlib/stats/base/dnanmax/examples/index.js index b851d6b67aab..7cc6d24dae5c 100644 --- a/lib/node_modules/@stdlib/stats/base/dnanmax/examples/index.js +++ b/lib/node_modules/@stdlib/stats/base/dnanmax/examples/index.js @@ -18,22 +18,19 @@ 'use strict'; -var randu = require( '@stdlib/random/base/randu' ); -var round = require( '@stdlib/math/base/special/round' ); -var Float64Array = require( '@stdlib/array/float64' ); +var uniform = require( '@stdlib/random/base/uniform' ); +var filledarrayBy = require( '@stdlib/array/filled-by' ); +var bernoulli = require( '@stdlib/random/base/bernoulli' ); var dnanmax = require( './../lib' ); -var x; -var i; - -x = new Float64Array( 10 ); -for ( i = 0; i < x.length; i++ ) { - if ( randu() < 0.2 ) { - x[ i ] = NaN; - } else { - x[ i ] = round( (randu()*100.0) - 50.0 ); +function rand() { + if ( bernoulli( 0.2 ) ) { + return NaN; } + return uniform( -50.0, 50.0 ); } + +var x = filledarrayBy( 10, 'float64', rand ); console.log( x ); var v = dnanmax( x.length, x, 1 ); From 14ca702b169c91dd02bd4a9e31451de4bfdd2ae6 Mon Sep 17 00:00:00 2001 From: Athan Date: Thu, 16 Jan 2025 14:06:58 -0800 Subject: [PATCH 2/2] Apply suggestions from code review Signed-off-by: Athan --- lib/node_modules/@stdlib/stats/base/dnanmax/README.md | 2 +- lib/node_modules/@stdlib/stats/base/dnanmax/examples/index.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dnanmax/README.md b/lib/node_modules/@stdlib/stats/base/dnanmax/README.md index 4e66291982e5..490217fc572f 100644 --- a/lib/node_modules/@stdlib/stats/base/dnanmax/README.md +++ b/lib/node_modules/@stdlib/stats/base/dnanmax/README.md @@ -135,7 +135,7 @@ var bernoulli = require( '@stdlib/random/base/bernoulli' ); var dnanmax = require( '@stdlib/stats/base/dnanmax' ); function rand() { - if ( bernoulli( 0.2 ) ) { + if ( bernoulli( 0.2 ) < 1 ) { return NaN; } return uniform( -50.0, 50.0 ); diff --git a/lib/node_modules/@stdlib/stats/base/dnanmax/examples/index.js b/lib/node_modules/@stdlib/stats/base/dnanmax/examples/index.js index 7cc6d24dae5c..7e3fd508039a 100644 --- a/lib/node_modules/@stdlib/stats/base/dnanmax/examples/index.js +++ b/lib/node_modules/@stdlib/stats/base/dnanmax/examples/index.js @@ -24,7 +24,7 @@ var bernoulli = require( '@stdlib/random/base/bernoulli' ); var dnanmax = require( './../lib' ); function rand() { - if ( bernoulli( 0.2 ) ) { + if ( bernoulli( 0.2 ) < 1 ) { return NaN; } return uniform( -50.0, 50.0 );