From f2645dc2f0bb5bd546f5fed3e35227f34ca6bdd3 Mon Sep 17 00:00:00 2001 From: aayush0325 Date: Mon, 23 Dec 2024 11:29:14 +0000 Subject: [PATCH 01/13] feat: add C ndarray interface and refactor implementation --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../@stdlib/stats/base/dmaxabs/README.md | 154 +++++++++++++++--- .../stats/base/dmaxabs/benchmark/benchmark.js | 18 +- .../dmaxabs/benchmark/benchmark.native.js | 14 +- .../dmaxabs/benchmark/benchmark.ndarray.js | 18 +- .../benchmark/benchmark.ndarray.native.js | 14 +- .../dmaxabs/benchmark/c/benchmark.length.c | 50 +++++- .../@stdlib/stats/base/dmaxabs/docs/repl.txt | 28 ++-- .../stats/base/dmaxabs/docs/types/index.d.ts | 12 +- .../stats/base/dmaxabs/examples/c/example.c | 9 +- .../stats/base/dmaxabs/examples/index.js | 14 +- .../include/stdlib/stats/base/dmaxabs.h | 9 +- .../@stdlib/stats/base/dmaxabs/lib/dmaxabs.js | 40 +---- .../stats/base/dmaxabs/lib/dmaxabs.native.js | 9 +- .../@stdlib/stats/base/dmaxabs/lib/index.js | 7 +- .../@stdlib/stats/base/dmaxabs/lib/ndarray.js | 18 +- .../stats/base/dmaxabs/lib/ndarray.native.js | 20 +-- .../@stdlib/stats/base/dmaxabs/manifest.json | 53 ++++-- .../@stdlib/stats/base/dmaxabs/src/addon.c | 25 ++- .../@stdlib/stats/base/dmaxabs/src/dmaxabs.c | 61 ------- .../@stdlib/stats/base/dmaxabs/src/main.c | 72 ++++++++ .../stats/base/dmaxabs/test/test.dmaxabs.js | 13 +- .../base/dmaxabs/test/test.dmaxabs.native.js | 13 +- .../stats/base/dmaxabs/test/test.ndarray.js | 13 +- .../base/dmaxabs/test/test.ndarray.native.js | 13 +- 24 files changed, 410 insertions(+), 287 deletions(-) delete mode 100644 lib/node_modules/@stdlib/stats/base/dmaxabs/src/dmaxabs.c create mode 100644 lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md b/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md index b55840090549..6e7c5d60e3b2 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md @@ -36,7 +36,7 @@ limitations under the License. var dmaxabs = require( '@stdlib/stats/base/dmaxabs' ); ``` -#### dmaxabs( N, x, stride ) +#### dmaxabs( N, x, strideX ) Computes the maximum absolute value of a double-precision floating-point strided array `x`. @@ -44,9 +44,8 @@ Computes the maximum absolute value of a double-precision floating-point strided var Float64Array = require( '@stdlib/array/float64' ); var x = new Float64Array( [ 1.0, -2.0, 2.0 ] ); -var N = x.length; -var v = dmaxabs( N, x, 1 ); +var v = dmaxabs( x.length, x, 1 ); // returns 2.0 ``` @@ -54,18 +53,17 @@ The function has the following parameters: - **N**: number of indexed elements. - **x**: input [`Float64Array`][@stdlib/array/float64]. -- **stride**: index increment for `x`. +- **strideX**: stride length for `x`. -The `N` and `stride` parameters determine which elements in `x` are accessed at runtime. For example, to compute the maximum absolute value of every other element in `x`, +The `N` and stride parameters determine which elements in the strided array are accessed at runtime. For example, to compute the maximum absolute value of every other element in `x`, ```javascript var Float64Array = require( '@stdlib/array/float64' ); var floor = require( '@stdlib/math/base/special/floor' ); var x = new Float64Array( [ 1.0, 2.0, 2.0, -7.0, -2.0, 3.0, 4.0, 2.0 ] ); -var N = floor( x.length / 2 ); -var v = dmaxabs( N, x, 2 ); +var v = dmaxabs( 4, x, 2 ); // returns 4.0 ``` @@ -86,7 +84,7 @@ var v = dmaxabs( N, x1, 2 ); // returns 4.0 ``` -#### dmaxabs.ndarray( N, x, stride, offset ) +#### dmaxabs.ndarray( N, x, strideX, offsetX ) Computes the maximum absolute value of a double-precision floating-point strided array using alternative indexing semantics. @@ -94,26 +92,24 @@ Computes the maximum absolute value of a double-precision floating-point strided var Float64Array = require( '@stdlib/array/float64' ); var x = new Float64Array( [ 1.0, -2.0, 2.0 ] ); -var N = x.length; -var v = dmaxabs.ndarray( N, x, 1, 0 ); +var v = dmaxabs.ndarray( x.length, x, 1, 0 ); // returns 2.0 ``` The function has the following additional parameters: -- **offset**: starting index for `x`. +- **offsetX**: starting index for `x`. -While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying `buffer`, the `offset` parameter supports indexing semantics based on a starting index. For example, to calculate the maximum absolute value for every other value in `x` starting from the second value +While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying buffer, the offset parameter supports indexing semantics based on a starting index. For example, to calculate the maximum absolute value for every other value in `x` starting from the second value ```javascript var Float64Array = require( '@stdlib/array/float64' ); var floor = require( '@stdlib/math/base/special/floor' ); var x = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); -var N = floor( x.length / 2 ); -var v = dmaxabs.ndarray( N, x, 2, 1 ); +var v = dmaxabs.ndarray( 4, x, 2, 1 ); // returns 4.0 ``` @@ -138,18 +134,13 @@ var v = dmaxabs.ndarray( N, x, 2, 1 ); ```javascript -var randu = require( '@stdlib/random/base/randu' ); -var round = require( '@stdlib/math/base/special/round' ); +var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); var Float64Array = require( '@stdlib/array/float64' ); var dmaxabs = require( '@stdlib/stats/base/dmaxabs' ); -var x; -var i; - -x = new Float64Array( 10 ); -for ( i = 0; i < x.length; i++ ) { - x[ i ] = round( (randu()*100.0) - 50.0 ); -} +var x = discreteUniform( 10, -50, 50, { + 'dtype': 'float64' +}); console.log( x ); var v = dmaxabs( x.length, x, 1 ); @@ -160,6 +151,123 @@ console.log( v ); + + +* * * + +
+ +## C APIs + + + +
+ +
+ + + + + +
+ +### Usage + +```c +#include "stdlib/stats/base/dmax.h" +``` + +#### stdlib_strided_dmaxabs( N, \*X, strideX ) + +Computes the maximum absolute value of a double-precision floating-point strided array. + +```c +const double x[] = { 1.0, -2.0, -3.0, 4.0, -5.0, -6.0, 7.0, 8.0 }; + +double v = stdlib_strided_dmaxabs( 4, x, 2 ); +// returns 7.0 +``` + +The function accepts the following arguments: + +- **N**: `[in] CBLAS_INT` number of indexed elements. +- **X**: `[in] double*` input array. +- **strideX**: `[in] CBLAS_INT` stride length for `X`. + +```c +double stdlib_strided_dmaxabs( const CBLAS_INT N, const double *X, const CBLAS_INT strideX ); +``` + +#### stdlib_strided_dmaxabs_ndarray( N, \*X, strideX, offsetX ) + +Computes the maximum absolute value of a double-precision floating-point strided array using alternative indexing semantics. + +```c +const double x[] = { 1.0, -2.0, -3.0, 4.0, -5.0, -6.0, 7.0, 8.0 }; + +double v = stdlib_strided_dmaxabs_ndarray( 4, x, 2, 0 ); +// returns 7.0 +``` + +The function accepts the following arguments: + +- **N**: `[in] CBLAS_INT` number of indexed elements. +- **X**: `[in] double*` input array. +- **strideX**: `[in] CBLAS_INT` stride length for `X`. +- **offsetX**: `[in] CBLAS_INT` starting index for `X`. + +```c +double stdlib_strided_dmaxabs_ndarray( const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const CBLAS_INT offsetX ); +``` + +
+ + + + + +
+ +
+ + + + + +
+ +### Examples + +```c +#include "stdlib/stats/base/dmaxabs.h" +#include + +int main( void ) { + // Create a strided array: + const double x[] = { 1.0, -2.0, -3.0, 4.0, -5.0, -6.0, 7.0, 8.0 }; + + // Specify the number of elements: + const int N = 4; + + // Specify the stride length: + const int strideX = 2; + + // Compute the maximum value: + double v = stdlib_strided_dmaxabs( N, x, strideX ); + + // Print the result: + printf( "maxabs: %lf\n", v ); +} +``` + +
+ + + +
+ + +
diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/benchmark.js b/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/benchmark.js index 0550ac98af6d..289e5f13169a 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/benchmark.js @@ -21,14 +21,20 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/array/uniform' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float64Array = require( '@stdlib/array/float64' ); var pkg = require( './../package.json' ).name; var dmaxabs = require( './../lib/dmaxabs.js' ); +// VARIABLES // + +var options = { + 'dtype': 'float64' +}; + + // FUNCTIONS // /** @@ -39,13 +45,7 @@ var dmaxabs = require( './../lib/dmaxabs.js' ); * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float64Array( len ); - for ( i = 0; i < x.length; i++ ) { - x[ i ] = ( randu()*20.0 ) - 10.0; - } + var x = uniform( len, -10.0, 10.0, options ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/benchmark.native.js index 478954d02f11..eb6298725b08 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/benchmark.native.js +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/benchmark.native.js @@ -22,10 +22,9 @@ var resolve = require( 'path' ).resolve; var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/array/uniform' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float64Array = require( '@stdlib/array/float64' ); var tryRequire = require( '@stdlib/utils/try-require' ); var pkg = require( './../package.json' ).name; @@ -36,6 +35,9 @@ var dmaxabs = tryRequire( resolve( __dirname, './../lib/dmaxabs.native.js' ) ); var opts = { 'skip': ( dmaxabs instanceof Error ) }; +var options = { + 'dtype': 'float64' +}; // FUNCTIONS // @@ -48,13 +50,7 @@ var opts = { * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float64Array( len ); - for ( i = 0; i < x.length; i++ ) { - x[ i ] = ( randu()*20.0 ) - 10.0; - } + var x = uniform( len, -10.0, 10.0, options ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/benchmark.ndarray.js index cfd59c626af2..ef49967771c1 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/benchmark.ndarray.js +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/benchmark.ndarray.js @@ -21,14 +21,20 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/array/uniform' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float64Array = require( '@stdlib/array/float64' ); var pkg = require( './../package.json' ).name; var dmaxabs = require( './../lib/ndarray.js' ); +// VARIABLES // + +var options = { + 'dtype': 'float64' +}; + + // FUNCTIONS // /** @@ -39,13 +45,7 @@ var dmaxabs = require( './../lib/ndarray.js' ); * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float64Array( len ); - for ( i = 0; i < x.length; i++ ) { - x[ i ] = ( randu()*20.0 ) - 10.0; - } + var x = uniform( len, -10.0, 10.0, options ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/benchmark.ndarray.native.js b/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/benchmark.ndarray.native.js index f4265c8d3e18..bfd8ad6196cf 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/benchmark.ndarray.native.js +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/benchmark.ndarray.native.js @@ -22,10 +22,9 @@ var resolve = require( 'path' ).resolve; var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/array/uniform' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float64Array = require( '@stdlib/array/float64' ); var tryRequire = require( '@stdlib/utils/try-require' ); var pkg = require( './../package.json' ).name; @@ -36,6 +35,9 @@ var dmaxabs = tryRequire( resolve( __dirname, './../lib/ndarray.native.js' ) ); var opts = { 'skip': ( dmaxabs instanceof Error ) }; +var options = { + 'dtype': 'float64' +}; // FUNCTIONS // @@ -48,13 +50,7 @@ var opts = { * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float64Array( len ); - for ( i = 0; i < x.length; i++ ) { - x[ i ] = ( randu()*20.0 ) - 10.0; - } + var x = uniform( len, -10.0, 10.0, options ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/c/benchmark.length.c b/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/c/benchmark.length.c index c91ff1dc7ed9..79bbd6aa940d 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/c/benchmark.length.c +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/c/benchmark.length.c @@ -94,7 +94,7 @@ static double rand_double( void ) { * @param len array length * @return elapsed time in seconds */ -static double benchmark( int iterations, int len ) { +static double benchmark1( int iterations, int len ) { double elapsed; double x[ len ]; double v; @@ -107,6 +107,7 @@ static double benchmark( int iterations, int len ) { v = 0.0; t = tic(); for ( i = 0; i < iterations; i++ ) { + // cppcheck-suppress uninitvar v = stdlib_strided_dmaxabs( len, x, 1 ); if ( v != v ) { printf( "should not return NaN\n" ); @@ -120,6 +121,40 @@ static double benchmark( int iterations, int len ) { return elapsed; } +/** +* Runs a benchmark. +* +* @param iterations number of iterations +* @param len array length +* @return elapsed time in seconds +*/ +static double benchmark2( int iterations, int len ) { + double elapsed; + double x[ len ]; + double v; + double t; + int i; + + for ( i = 0; i < len; i++ ) { + x[ i ] = ( rand_double() * 20000.0 ) - 10000.0; + } + v = 0.0; + t = tic(); + for ( i = 0; i < iterations; i++ ) { + // cppcheck-suppress uninitvar + v = stdlib_strided_dmaxabs_ndarray( len, x, 1, 0 ); + if ( v != v ) { + printf( "should not return NaN\n" ); + break; + } + } + elapsed = tic() - t; + if ( v != v ) { + printf( "should not return NaN\n" ); + } + return elapsed; +} + /** * Main execution sequence. */ @@ -142,7 +177,18 @@ int main( void ) { for ( j = 0; j < REPEATS; j++ ) { count += 1; printf( "# c::%s:len=%d\n", NAME, len ); - elapsed = benchmark( iter, len ); + elapsed = benchmark1( iter, len ); + print_results( iter, elapsed ); + printf( "ok %d benchmark finished\n", count ); + } + } + for ( i = MIN; i <= MAX; i++ ) { + len = pow( 10, i ); + iter = ITERATIONS / pow( 10, i-1 ); + for ( j = 0; j < REPEATS; j++ ) { + count += 1; + printf( "# c::%s:ndarray:len=%d\n", NAME, len ); + elapsed = benchmark2( iter, len ); print_results( iter, elapsed ); printf( "ok %d benchmark finished\n", count ); } diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/docs/repl.txt b/lib/node_modules/@stdlib/stats/base/dmaxabs/docs/repl.txt index f00082e8d26a..686eb701351f 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/docs/repl.txt +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/docs/repl.txt @@ -1,10 +1,10 @@ -{{alias}}( N, x, stride ) +{{alias}}( N, x, strideX ) Computes the maximum absolute value of a double-precision floating-point strided array. - The `N` and `stride` parameters determine which elements in `x` are accessed - at runtime. + The `N` and stride parameters determine which elements in the strided arrays + are accessed at runtime. Indexing is relative to the first index. To introduce an offset, use a typed array view. @@ -19,7 +19,7 @@ x: Float64Array Input array. - stride: integer + strideX: integer Index increment. Returns @@ -34,22 +34,19 @@ > {{alias}}( x.length, x, 1 ) 2.0 - // Using `N` and `stride` parameters: + // Using `N` and stride parameters: > x = new {{alias:@stdlib/array/float64}}( [ -2.0, 1.0, 1.0, -5.0, 2.0, -1.0 ] ); - > var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 ); - > var stride = 2; - > {{alias}}( N, x, stride ) + > {{alias}}( 3, x, 2 ) 2.0 // Using view offsets: > var x0 = new {{alias:@stdlib/array/float64}}( [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0 ] ); > var x1 = new {{alias:@stdlib/array/float64}}( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); - > N = {{alias:@stdlib/math/base/special/floor}}( x0.length / 2 ); - > stride = 2; - > {{alias}}( N, x1, stride ) + > {{alias}}( 3, x1, 2 ) 2.0 -{{alias}}.ndarray( N, x, stride, offset ) + +{{alias}}.ndarray( N, x, strideX, offsetX ) Computes the maximum absolute value of a double-precision floating-point strided array using alternative indexing semantics. @@ -65,10 +62,10 @@ x: Float64Array Input array. - stride: integer + strideX: integer Index increment. - offset: integer + offsetX: integer Starting index. Returns @@ -85,8 +82,7 @@ // Using offset parameter: > var x = new {{alias:@stdlib/array/float64}}( [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0 ] ); - > var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 ); - > {{alias}}.ndarray( N, x, 2, 1 ) + > {{alias}}.ndarray( 3, x, 2, 1 ) 2.0 See Also diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/docs/types/index.d.ts b/lib/node_modules/@stdlib/stats/base/dmaxabs/docs/types/index.d.ts index 7763b3cdc365..6c149e4254ed 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/docs/types/index.d.ts +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/docs/types/index.d.ts @@ -27,7 +27,7 @@ interface Routine { * * @param N - number of indexed elements * @param x - input array - * @param stride - stride length + * @param strideX - stride length * @returns maximum absolute value * * @example @@ -38,15 +38,15 @@ interface Routine { * var v = dmaxabs( x.length, x, 1 ); * // returns 2.0 */ - ( N: number, x: Float64Array, stride: number ): number; + ( N: number, x: Float64Array, strideX: number ): number; /** * Computes the maximum absolute value of a double-precision floating-point strided array using alternative indexing semantics. * * @param N - number of indexed elements * @param x - input array - * @param stride - stride length - * @param offset - starting index + * @param strideX - stride length + * @param offsetX - starting index * @returns maximum absolute value * * @example @@ -57,7 +57,7 @@ interface Routine { * var v = dmaxabs.ndarray( x.length, x, 1, 0 ); * // returns 2.0 */ - ndarray( N: number, x: Float64Array, stride: number, offset: number ): number; + ndarray( N: number, x: Float64Array, strideX: number, offsetX: number ): number; } /** @@ -65,7 +65,7 @@ interface Routine { * * @param N - number of indexed elements * @param x - input array -* @param stride - stride length +* @param strideX - stride length * @returns maximum absolute value * * @example diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/examples/c/example.c b/lib/node_modules/@stdlib/stats/base/dmaxabs/examples/c/example.c index 191cb0b4f3e8..49d9eb71c36e 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/examples/c/example.c +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/examples/c/example.c @@ -17,21 +17,20 @@ */ #include "stdlib/stats/base/dmaxabs.h" -#include #include int main( void ) { // Create a strided array: - double x[] = { 1.0, -2.0, -3.0, 4.0, -5.0, -6.0, 7.0, 8.0 }; + const double x[] = { 1.0, -2.0, -3.0, 4.0, -5.0, -6.0, 7.0, 8.0 }; // Specify the number of elements: - int64_t N = 4; + const int N = 4; // Specify the stride length: - int64_t stride = 2; + const int strideX = 2; // Compute the maximum value: - double v = stdlib_strided_dmaxabs( N, x, stride ); + double v = stdlib_strided_dmaxabs( N, x, strideX ); // Print the result: printf( "maxabs: %lf\n", v ); diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/examples/index.js b/lib/node_modules/@stdlib/stats/base/dmaxabs/examples/index.js index f843b2dd62c6..5d521521e4c2 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/examples/index.js +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/examples/index.js @@ -18,18 +18,12 @@ 'use strict'; -var randu = require( '@stdlib/random/base/randu' ); -var round = require( '@stdlib/math/base/special/round' ); -var Float64Array = require( '@stdlib/array/float64' ); +var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); var dmaxabs = require( './../lib' ); -var x; -var i; - -x = new Float64Array( 10 ); -for ( i = 0; i < x.length; i++ ) { - x[ i ] = round( (randu()*100.0) - 50.0 ); -} +var x = discreteUniform( 10, -50, 50, { + 'dtype': 'float64' +}); console.log( x ); var v = dmaxabs( x.length, x, 1 ); diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/include/stdlib/stats/base/dmaxabs.h b/lib/node_modules/@stdlib/stats/base/dmaxabs/include/stdlib/stats/base/dmaxabs.h index b17cca979cfc..f9964208a23f 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/include/stdlib/stats/base/dmaxabs.h +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/include/stdlib/stats/base/dmaxabs.h @@ -19,7 +19,7 @@ #ifndef STDLIB_STATS_BASE_DMAXABS_H #define STDLIB_STATS_BASE_DMAXABS_H -#include +#include "stdlib/blas/base/shared.h" /* * If C++, prevent name mangling so that the compiler emits a binary file having undecorated names, thus mirroring the behavior of a C compiler. @@ -31,7 +31,12 @@ extern "C" { /** * Computes the maximum absolute value of a double-precision floating-point strided array. */ -double stdlib_strided_dmaxabs( const int64_t N, const double *X, const int64_t stride ); +double API_SUFFIX(stdlib_strided_dmaxabs)( const CBLAS_INT N, const double *X, const CBLAS_INT strideX ); + +/** +* Computes the maximum absolute value of a double-precision floating-point strided array using alternative indexing semantics. +*/ +double API_SUFFIX(stdlib_strided_dmaxabs_ndarray)( const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const CBLAS_INT offsetX ); #ifdef __cplusplus } diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/dmaxabs.js b/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/dmaxabs.js index 1991cc6ce949..3fb3edd19223 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/dmaxabs.js +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/dmaxabs.js @@ -20,8 +20,8 @@ // MODULES // -var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var stride2offset = require( '@stdlib/strided/base/stride2offset' ); +var ndarray = require( './ndarray.js' ); // MAIN // @@ -31,47 +31,19 @@ var abs = require( '@stdlib/math/base/special/abs' ); * * @param {PositiveInteger} N - number of indexed elements * @param {Float64Array} x - input array -* @param {integer} stride - stride length +* @param {integer} strideX - stride length for X * @returns {number} maximum absolute value * * @example * var Float64Array = require( '@stdlib/array/float64' ); * * var x = new Float64Array( [ 1.0, -2.0, 2.0 ] ); -* var N = x.length; * -* var v = dmaxabs( N, x, 1 ); +* var v = dmaxabs( x.length, x, 1 ); * // returns 2.0 */ -function dmaxabs( N, x, stride ) { - var max; - var ix; - var v; - var i; - - if ( N <= 0 ) { - return NaN; - } - if ( N === 1 || stride === 0 ) { - return abs( x[ 0 ] ); - } - if ( stride < 0 ) { - ix = (1-N) * stride; - } else { - ix = 0; - } - max = abs( x[ ix ] ); - for ( i = 1; i < N; i++ ) { - ix += stride; - v = abs( x[ ix ] ); - if ( isnan( v ) ) { - return v; - } - if ( v > max ) { - max = v; - } - } - return max; +function dmaxabs( N, x, strideX ) { + return ndarray( N, x, strideX, stride2offset( N, strideX ) ); } diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/dmaxabs.native.js b/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/dmaxabs.native.js index cb1c64df0b1b..de2e3c5df3b6 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/dmaxabs.native.js +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/dmaxabs.native.js @@ -30,20 +30,19 @@ var addon = require( './../src/addon.node' ); * * @param {PositiveInteger} N - number of indexed elements * @param {Float64Array} x - input array -* @param {integer} stride - stride length +* @param {integer} strideX - stride length * @returns {number} maximum absolute value * * @example * var Float64Array = require( '@stdlib/array/float64' ); * * var x = new Float64Array( [ 1.0, -2.0, 2.0 ] ); -* var N = x.length; * -* var v = dmaxabs( N, x, 1 ); +* var v = dmaxabs( x.length, x, 1 ); * // returns 2.0 */ -function dmaxabs( N, x, stride ) { - return addon( N, x, stride ); +function dmaxabs( N, x, strideX ) { + return addon( N, x, strideX ); } diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/index.js b/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/index.js index 7d1776e82a45..2922bbf11eb1 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/index.js +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/index.js @@ -28,20 +28,17 @@ * var dmaxabs = require( '@stdlib/stats/base/dmaxabs' ); * * var x = new Float64Array( [ 1.0, -2.0, 2.0 ] ); -* var N = x.length; * -* var v = dmaxabs( N, x, 1 ); +* var v = dmaxabs( x.length, x, 1 ); * // returns 2.0 * * @example * var Float64Array = require( '@stdlib/array/float64' ); -* var floor = require( '@stdlib/math/base/special/floor' ); * var dmaxabs = require( '@stdlib/stats/base/dmaxabs' ); * * var x = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); -* var N = floor( x.length / 2 ); * -* var v = dmaxabs.ndarray( N, x, 2, 1 ); +* var v = dmaxabs.ndarray( 4, x, 2, 1 ); * // returns 4.0 */ diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/ndarray.js b/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/ndarray.js index fe59d9cfab1a..a349afa553c6 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/ndarray.js +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/ndarray.js @@ -31,21 +31,19 @@ var abs = require( '@stdlib/math/base/special/abs' ); * * @param {PositiveInteger} N - number of indexed elements * @param {Float64Array} x - input array -* @param {integer} stride - stride length -* @param {NonNegativeInteger} offset - starting index +* @param {integer} strideX - stride length +* @param {NonNegativeInteger} offsetX - starting index * @returns {number} maximum absolute value * * @example * var Float64Array = require( '@stdlib/array/float64' ); -* var floor = require( '@stdlib/math/base/special/floor' ); * * var x = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); -* var N = floor( x.length / 2 ); * -* var v = dmaxabs( N, x, 2, 1 ); +* var v = dmaxabs( 4, x, 2, 1 ); * // returns 4.0 */ -function dmaxabs( N, x, stride, offset ) { +function dmaxabs( N, x, strideX, offsetX ) { var max; var ix; var v; @@ -54,13 +52,13 @@ function dmaxabs( N, x, stride, offset ) { if ( N <= 0 ) { return NaN; } - if ( N === 1 || stride === 0 ) { - return abs( x[ offset ] ); + if ( N === 1 || strideX === 0 ) { + return abs( x[ offsetX ] ); } - ix = offset; + ix = offsetX; max = abs( x[ ix ] ); for ( i = 1; i < N; i++ ) { - ix += stride; + ix += strideX; v = abs( x[ ix ] ); if ( isnan( v ) ) { return v; diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/ndarray.native.js b/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/ndarray.native.js index dd2d24e92cf7..341c7ca1c638 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/ndarray.native.js +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/ndarray.native.js @@ -20,8 +20,7 @@ // MODULES // -var Float64Array = require( '@stdlib/array/float64' ); -var addon = require( './dmaxabs.native.js' ); +var addon = require( './../src/addon.node' ); // MAIN // @@ -31,27 +30,20 @@ var addon = require( './dmaxabs.native.js' ); * * @param {PositiveInteger} N - number of indexed elements * @param {Float64Array} x - input array -* @param {integer} stride - stride length -* @param {NonNegativeInteger} offset - starting index +* @param {integer} strideX - stride length +* @param {NonNegativeInteger} offsetX - starting index * @returns {number} maximum absolute value * * @example * var Float64Array = require( '@stdlib/array/float64' ); -* var floor = require( '@stdlib/math/base/special/floor' ); * * var x = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); -* var N = floor( x.length / 2 ); * -* var v = dmaxabs( N, x, 2, 1 ); +* var v = dmaxabs( 4, x, 2, 1 ); * // returns 4.0 */ -function dmaxabs( N, x, stride, offset ) { - var view; - if ( stride < 0 ) { - offset += (N-1) * stride; - } - view = new Float64Array( x.buffer, x.byteOffset+(x.BYTES_PER_ELEMENT*offset), x.length-offset ); // eslint-disable-line max-len - return addon( N, view, stride ); +function dmaxabs( N, x, strideX, offsetX ) { + return addon.ndarray( N, x, strideX, offsetX ); } diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/manifest.json b/lib/node_modules/@stdlib/stats/base/dmaxabs/manifest.json index d498f629ff27..f20b3f18864a 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/manifest.json +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/manifest.json @@ -1,6 +1,7 @@ { "options": { - "task": "build" + "task": "build", + "wasm": false }, "fields": [ { @@ -27,18 +28,20 @@ "confs": [ { "task": "build", + "wasm": false, "src": [ - "./src/dmaxabs.c" + "./src/main.c" ], "include": [ "./include" ], - "libraries": [ - "-lm" - ], + "libraries": [], "libpath": [], "dependencies": [ "@stdlib/math/base/assert/is-nan", + "@stdlib/math/base/special/abs", + "@stdlib/blas/base/shared", + "@stdlib/strided/base/stride2offset", "@stdlib/napi/export", "@stdlib/napi/argv", "@stdlib/napi/argv-int64", @@ -48,34 +51,56 @@ }, { "task": "benchmark", + "wasm": false, "src": [ - "./src/dmaxabs.c" + "./src/main.c" ], "include": [ "./include" ], - "libraries": [ - "-lm" - ], + "libraries": [], "libpath": [], "dependencies": [ - "@stdlib/math/base/assert/is-nan" + "@stdlib/math/base/assert/is-nan", + "@stdlib/math/base/special/abs", + "@stdlib/blas/base/shared", + "@stdlib/strided/base/stride2offset" ] }, { "task": "examples", + "wasm": false, "src": [ - "./src/dmaxabs.c" + "./src/main.c" ], "include": [ "./include" ], - "libraries": [ - "-lm" + "libraries": [], + "libpath": [], + "dependencies": [ + "@stdlib/math/base/assert/is-nan", + "@stdlib/math/base/special/abs", + "@stdlib/blas/base/shared", + "@stdlib/strided/base/stride2offset" + ] + }, + { + "task": "", + "wasm": true, + "src": [ + "./src/main.c" + ], + "include": [ + "./include" ], + "libraries": [], "libpath": [], "dependencies": [ - "@stdlib/math/base/assert/is-nan" + "@stdlib/math/base/assert/is-nan", + "@stdlib/math/base/special/abs", + "@stdlib/blas/base/shared", + "@stdlib/strided/base/stride2offset" ] } ] diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/src/addon.c b/lib/node_modules/@stdlib/stats/base/dmaxabs/src/addon.c index 988dc97b66af..638aec564904 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/src/addon.c +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/src/addon.c @@ -34,10 +34,27 @@ static napi_value addon( napi_env env, napi_callback_info info ) { STDLIB_NAPI_ARGV( env, info, argv, argc, 3 ); STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 ); - STDLIB_NAPI_ARGV_INT64( env, stride, argv, 2 ); - STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, stride, argv, 1 ); - STDLIB_NAPI_CREATE_DOUBLE( env, stdlib_strided_dmaxabs( N, X, stride ), v ); + STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 2 ); + STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 1 ); + STDLIB_NAPI_CREATE_DOUBLE( env, stdlib_strided_dmaxabs( N, X, strideX ), v ); return v; } -STDLIB_NAPI_MODULE_EXPORT_FCN( addon ) +/** +* Receives JavaScript callback invocation data. +* +* @param env environment under which the function is invoked +* @param info callback data +* @return Node-API value +*/ +static napi_value addon_method( napi_env env, napi_callback_info info ) { + STDLIB_NAPI_ARGV( env, info, argv, argc, 4 ); + STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 ); + STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 2 ); + STDLIB_NAPI_ARGV_INT64( env, offsetX, argv, 3 ); + STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 1 ); + STDLIB_NAPI_CREATE_DOUBLE( env, stdlib_strided_dmaxabs_ndarray( N, X, strideX, offsetX ), v ); + return v; +} + +STDLIB_NAPI_MODULE_EXPORT_FCN_WITH_METHOD( addon, "ndarray", addon_method ) diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/src/dmaxabs.c b/lib/node_modules/@stdlib/stats/base/dmaxabs/src/dmaxabs.c deleted file mode 100644 index 15ff0251c199..000000000000 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/src/dmaxabs.c +++ /dev/null @@ -1,61 +0,0 @@ -/** -* @license Apache-2.0 -* -* Copyright (c) 2020 The Stdlib Authors. -* -* Licensed under the Apache License, Version 2.0 (the "License"); -* you may not use this file except in compliance with the License. -* You may obtain a copy of the License at -* -* http://www.apache.org/licenses/LICENSE-2.0 -* -* Unless required by applicable law or agreed to in writing, software -* distributed under the License is distributed on an "AS IS" BASIS, -* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -* See the License for the specific language governing permissions and -* limitations under the License. -*/ - -#include "stdlib/stats/base/dmaxabs.h" -#include "stdlib/math/base/assert/is_nan.h" -#include -#include - -/** -* Computes the maximum absolute value of a double-precision floating-point strided array. -* -* @param N number of indexed elements -* @param X input array -* @param stride stride length -* @return output value -*/ -double stdlib_strided_dmaxabs( const int64_t N, const double *X, const int64_t stride ) { - double max; - int64_t ix; - int64_t i; - double v; - - if ( N <= 0 ) { - return 0.0 / 0.0; // NaN - } - if ( N == 1 || stride == 0 ) { - return fabs( X[ 0 ] ); - } - if ( stride < 0 ) { - ix = (1-N) * stride; - } else { - ix = 0; - } - max = fabs( X[ ix ] ); - for ( i = 1; i < N; i++ ) { - ix += stride; - v = fabs( X[ ix ] ); - if ( stdlib_base_is_nan( v ) ) { - return v; - } - if ( v > max ) { - max = v; - } - } - return max; -} diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c b/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c new file mode 100644 index 000000000000..323b20f43ba4 --- /dev/null +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c @@ -0,0 +1,72 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2020 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +#include "stdlib/stats/base/dmaxabs.h" +#include "stdlib/math/base/assert/is_nan.h" +#include "stdlib/blas/base/shared.h" +#include "stdlib/strided/base/stride2offset.h" +#include "stdlib/math/base/special/abs.h" + +/** +* Computes the maximum absolute value of a double-precision floating-point strided array. +* +* @param N number of indexed elements +* @param X input array +* @param strideX stride length +* @return output value +*/ +double API_SUFFIX(stdlib_strided_dmaxabs)( const CBLAS_INT N, const double *X, const CBLAS_INT strideX ) { + const CBLAS_INT ox = stdlib_strided_stride2offset( N, strideX ); + return API_SUFFIX(stdlib_strided_dmaxabs_ndarray)( N, X, strideX, ox ); +} + +/** +* Computes the maximum absolute value of a double-precision floating-point strided array. +* +* @param N number of indexed elements +* @param X input array +* @param strideX stride length +* @param offsetX stride length +* @return output value +*/ +double API_SUFFIX(stdlib_strided_dmaxabs_ndarray)( const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const CBLAS_INT offsetX ) { + double max; + CBLAS_INT ix; + CBLAS_INT i; + double v; + + if ( N <= 0 ) { + return 0.0 / 0.0; // NaN + } + if ( N == 1 || strideX == 0 ) { + return stdlib_base_abs( X[ 0 ] ); + } + ix = offsetX; + max = stdlib_base_abs( X[ ix ] ); + for ( i = 1; i < N; i++ ) { + ix += strideX; + v = stdlib_base_abs( X[ ix ] ); + if ( stdlib_base_is_nan( v ) ) { + return v; + } + if ( v > max ) { + max = v; + } + } + return max; +} diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/test/test.dmaxabs.js b/lib/node_modules/@stdlib/stats/base/dmaxabs/test/test.dmaxabs.js index c2c4dafc1e2f..9b23cef48ccd 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/test/test.dmaxabs.js +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/test/test.dmaxabs.js @@ -21,7 +21,6 @@ // MODULES // var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' ); var Float64Array = require( '@stdlib/array/float64' ); @@ -96,7 +95,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first }); tape( 'the function supports a `stride` parameter', function test( t ) { - var N; var x; var v; @@ -111,15 +109,13 @@ tape( 'the function supports a `stride` parameter', function test( t ) { 2.0 ]); - N = floor( x.length / 2 ); - v = dmaxabs( N, x, 2 ); + v = dmaxabs( 4, x, 2 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); }); tape( 'the function supports a negative `stride` parameter', function test( t ) { - var N; var x; var v; @@ -134,8 +130,7 @@ tape( 'the function supports a negative `stride` parameter', function test( t ) 2.0 ]); - N = floor( x.length / 2 ); - v = dmaxabs( N, x, -2 ); + v = dmaxabs( 4, x, -2 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); @@ -156,7 +151,6 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f tape( 'the function supports view offsets', function test( t ) { var x0; var x1; - var N; var v; x0 = new Float64Array([ @@ -172,9 +166,8 @@ tape( 'the function supports view offsets', function test( t ) { ]); x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element - N = floor(x1.length / 2); - v = dmaxabs( N, x1, 2 ); + v = dmaxabs( 4, x1, 2 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/test/test.dmaxabs.native.js b/lib/node_modules/@stdlib/stats/base/dmaxabs/test/test.dmaxabs.native.js index d77ced7bfe7a..fe5218ae8870 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/test/test.dmaxabs.native.js +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/test/test.dmaxabs.native.js @@ -22,7 +22,6 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' ); var Float64Array = require( '@stdlib/array/float64' ); @@ -187,7 +186,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first }); tape( 'the function supports a `stride` parameter', opts, function test( t ) { - var N; var x; var v; @@ -202,15 +200,13 @@ tape( 'the function supports a `stride` parameter', opts, function test( t ) { 2.0 ]); - N = floor( x.length / 2 ); - v = dmaxabs( N, x, 2 ); + v = dmaxabs( 4, x, 2 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); }); tape( 'the function supports a negative `stride` parameter', opts, function test( t ) { - var N; var x; var v; @@ -225,8 +221,7 @@ tape( 'the function supports a negative `stride` parameter', opts, function test 2.0 ]); - N = floor( x.length / 2 ); - v = dmaxabs( N, x, -2 ); + v = dmaxabs( 4, x, -2 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); @@ -247,7 +242,6 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f tape( 'the function supports view offsets', opts, function test( t ) { var x0; var x1; - var N; var v; x0 = new Float64Array([ @@ -263,9 +257,8 @@ tape( 'the function supports view offsets', opts, function test( t ) { ]); x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element - N = floor(x1.length / 2); - v = dmaxabs( N, x1, 2 ); + v = dmaxabs( 4, x1, 2 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/test/test.ndarray.js b/lib/node_modules/@stdlib/stats/base/dmaxabs/test/test.ndarray.js index 6928fa28d86b..82262d0e7664 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/test/test.ndarray.js +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/test/test.ndarray.js @@ -21,7 +21,6 @@ // MODULES // var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' ); var Float64Array = require( '@stdlib/array/float64' ); @@ -96,7 +95,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first }); tape( 'the function supports a `stride` parameter', function test( t ) { - var N; var x; var v; @@ -111,15 +109,13 @@ tape( 'the function supports a `stride` parameter', function test( t ) { 2.0 ]); - N = floor( x.length / 2 ); - v = dmaxabs( N, x, 2, 0 ); + v = dmaxabs( 4, x, 2, 0 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); }); tape( 'the function supports a negative `stride` parameter', function test( t ) { - var N; var x; var v; @@ -134,8 +130,7 @@ tape( 'the function supports a negative `stride` parameter', function test( t ) 2.0 ]); - N = floor( x.length / 2 ); - v = dmaxabs( N, x, -2, 6 ); + v = dmaxabs( 4, x, -2, 6 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); @@ -154,7 +149,6 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f }); tape( 'the function supports an `offset` parameter', function test( t ) { - var N; var x; var v; @@ -168,9 +162,8 @@ tape( 'the function supports an `offset` parameter', function test( t ) { 3.0, 4.0 // 3 ]); - N = floor( x.length / 2 ); - v = dmaxabs( N, x, 2, 1 ); + v = dmaxabs( 4, x, 2, 1 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/test/test.ndarray.native.js b/lib/node_modules/@stdlib/stats/base/dmaxabs/test/test.ndarray.native.js index bc416fa3abb5..b069f89079d3 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/test/test.ndarray.native.js +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/test/test.ndarray.native.js @@ -22,7 +22,6 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' ); var Float64Array = require( '@stdlib/array/float64' ); @@ -105,7 +104,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first }); tape( 'the function supports a `stride` parameter', opts, function test( t ) { - var N; var x; var v; @@ -120,15 +118,13 @@ tape( 'the function supports a `stride` parameter', opts, function test( t ) { 2.0 ]); - N = floor( x.length / 2 ); - v = dmaxabs( N, x, 2, 0 ); + v = dmaxabs( 4, x, 2, 0 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); }); tape( 'the function supports a negative `stride` parameter', opts, function test( t ) { - var N; var x; var v; @@ -143,8 +139,7 @@ tape( 'the function supports a negative `stride` parameter', opts, function test 2.0 ]); - N = floor( x.length / 2 ); - v = dmaxabs( N, x, -2, 6 ); + v = dmaxabs( 4, x, -2, 6 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); @@ -163,7 +158,6 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f }); tape( 'the function supports an `offset` parameter', opts, function test( t ) { - var N; var x; var v; @@ -177,9 +171,8 @@ tape( 'the function supports an `offset` parameter', opts, function test( t ) { 3.0, 4.0 // 3 ]); - N = floor( x.length / 2 ); - v = dmaxabs( N, x, 2, 1 ); + v = dmaxabs( 4, x, 2, 1 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); From a6cf770c27385f695130b11c92b999a42361cc16 Mon Sep 17 00:00:00 2001 From: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com> Date: Mon, 23 Dec 2024 11:38:46 +0000 Subject: [PATCH 02/13] chore: update copyright years --- lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c b/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c index 323b20f43ba4..f27c6e176e5c 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c @@ -1,7 +1,7 @@ /** * @license Apache-2.0 * -* Copyright (c) 2020 The Stdlib Authors. +* Copyright (c) 2024 The Stdlib Authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. From ba286eab9a3a5a69d417f14584116a4f48bf24de Mon Sep 17 00:00:00 2001 From: aayush0325 Date: Mon, 23 Dec 2024 11:44:48 +0000 Subject: [PATCH 03/13] chore: error in params description --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c b/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c index f27c6e176e5c..f71571d39ab2 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c @@ -41,7 +41,7 @@ double API_SUFFIX(stdlib_strided_dmaxabs)( const CBLAS_INT N, const double *X, c * @param N number of indexed elements * @param X input array * @param strideX stride length -* @param offsetX stride length +* @param offsetX starting index for X * @return output value */ double API_SUFFIX(stdlib_strided_dmaxabs_ndarray)( const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const CBLAS_INT offsetX ) { From c851c47602d5b86778d09b3bb6d2924fa399d6fc Mon Sep 17 00:00:00 2001 From: aayush0325 Date: Mon, 23 Dec 2024 11:47:29 +0000 Subject: [PATCH 04/13] chore: remove unused module in README.md example --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- lib/node_modules/@stdlib/stats/base/dmaxabs/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md b/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md index 6e7c5d60e3b2..34339364a1a2 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md @@ -59,7 +59,6 @@ The `N` and stride parameters determine which elements in the strided array are ```javascript var Float64Array = require( '@stdlib/array/float64' ); -var floor = require( '@stdlib/math/base/special/floor' ); var x = new Float64Array( [ 1.0, 2.0, 2.0, -7.0, -2.0, 3.0, 4.0, 2.0 ] ); From c09552029ff7fbd2a9346965416f72214ba3d3de Mon Sep 17 00:00:00 2001 From: aayush0325 Date: Mon, 23 Dec 2024 11:48:22 +0000 Subject: [PATCH 05/13] chore: remove unused module in README.md example --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- lib/node_modules/@stdlib/stats/base/dmaxabs/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md b/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md index 34339364a1a2..ea0fc9854a93 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md @@ -104,7 +104,6 @@ While [`typed array`][mdn-typed-array] views mandate a view offset based on the ```javascript var Float64Array = require( '@stdlib/array/float64' ); -var floor = require( '@stdlib/math/base/special/floor' ); var x = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); From fc10385bdb3b26acd3891c6d2f88ac3e1e46552f Mon Sep 17 00:00:00 2001 From: aayush0325 Date: Mon, 23 Dec 2024 11:49:34 +0000 Subject: [PATCH 06/13] chore: use correct import in README.md --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- lib/node_modules/@stdlib/stats/base/dmaxabs/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md b/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md index ea0fc9854a93..97084b267bc8 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md @@ -172,7 +172,7 @@ console.log( v ); ### Usage ```c -#include "stdlib/stats/base/dmax.h" +#include "stdlib/stats/base/dmaxabs.h" ``` #### stdlib_strided_dmaxabs( N, \*X, strideX ) From f0e822f6b0c8232d97b48e292bc6c82b0eb251e2 Mon Sep 17 00:00:00 2001 From: Aayush Khanna <96649223+aayush0325@users.noreply.github.com> Date: Mon, 23 Dec 2024 19:33:16 +0530 Subject: [PATCH 07/13] chore: fix incorrect spacing --- .../@stdlib/stats/base/dmaxabs/benchmark/c/benchmark.length.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/c/benchmark.length.c b/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/c/benchmark.length.c index 79bbd6aa940d..1d5ea138d471 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/c/benchmark.length.c +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/c/benchmark.length.c @@ -126,7 +126,7 @@ static double benchmark1( int iterations, int len ) { * * @param iterations number of iterations * @param len array length -* @return elapsed time in seconds +* @return elapsed time in seconds */ static double benchmark2( int iterations, int len ) { double elapsed; From 6a4d10cb975a4729b5c009812bce385b47848496 Mon Sep 17 00:00:00 2001 From: Aayush Khanna <96649223+aayush0325@users.noreply.github.com> Date: Mon, 23 Dec 2024 19:33:34 +0530 Subject: [PATCH 08/13] chore: fix incorrect spacing --- .../@stdlib/stats/base/dmaxabs/benchmark/c/benchmark.length.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/c/benchmark.length.c b/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/c/benchmark.length.c index 1d5ea138d471..fe0953bf78e5 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/c/benchmark.length.c +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/benchmark/c/benchmark.length.c @@ -92,7 +92,7 @@ static double rand_double( void ) { * * @param iterations number of iterations * @param len array length -* @return elapsed time in seconds +* @return elapsed time in seconds */ static double benchmark1( int iterations, int len ) { double elapsed; From 5f2457ea5e1dc01abcfe175642caa78e1459ad03 Mon Sep 17 00:00:00 2001 From: Aayush Khanna <96649223+aayush0325@users.noreply.github.com> Date: Tue, 24 Dec 2024 17:45:20 +0530 Subject: [PATCH 09/13] chore: update function description --- lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c b/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c index f71571d39ab2..18a02bb92315 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c @@ -36,7 +36,7 @@ double API_SUFFIX(stdlib_strided_dmaxabs)( const CBLAS_INT N, const double *X, c } /** -* Computes the maximum absolute value of a double-precision floating-point strided array. +* Computes the maximum absolute value of a double-precision floating-point strided array using alternative indexing semantics. * * @param N number of indexed elements * @param X input array From ea1555a402932ddf430fdec2e0066329b9bbf0d4 Mon Sep 17 00:00:00 2001 From: Aayush Khanna <96649223+aayush0325@users.noreply.github.com> Date: Wed, 25 Dec 2024 20:09:22 +0530 Subject: [PATCH 10/13] chore: clean up --- lib/node_modules/@stdlib/stats/base/dmaxabs/README.md | 2 +- lib/node_modules/@stdlib/stats/base/dmaxabs/docs/repl.txt | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md b/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md index 97084b267bc8..1f05fd773bd0 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/README.md @@ -100,7 +100,7 @@ The function has the following additional parameters: - **offsetX**: starting index for `x`. -While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying buffer, the offset parameter supports indexing semantics based on a starting index. For example, to calculate the maximum absolute value for every other value in `x` starting from the second value +While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying buffer, the offset parameter supports indexing semantics based on a starting index. For example, to calculate the maximum absolute value for every other element in `x` starting from the second element ```javascript var Float64Array = require( '@stdlib/array/float64' ); diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/docs/repl.txt b/lib/node_modules/@stdlib/stats/base/dmaxabs/docs/repl.txt index 686eb701351f..2e0ebde78143 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/docs/repl.txt +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/docs/repl.txt @@ -20,7 +20,7 @@ Input array. strideX: integer - Index increment. + Stride Length. Returns ------- @@ -63,7 +63,7 @@ Input array. strideX: integer - Index increment. + Stride Length. offsetX: integer Starting index. From 3bf3b7dbf51a60edd7f1534c0a6ff842e0a8bc9c Mon Sep 17 00:00:00 2001 From: Aayush Khanna <96649223+aayush0325@users.noreply.github.com> Date: Thu, 26 Dec 2024 00:08:28 +0530 Subject: [PATCH 11/13] chore: sort vars acc to length --- lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c b/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c index 18a02bb92315..72c29a0b7fa7 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c @@ -45,9 +45,9 @@ double API_SUFFIX(stdlib_strided_dmaxabs)( const CBLAS_INT N, const double *X, c * @return output value */ double API_SUFFIX(stdlib_strided_dmaxabs_ndarray)( const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const CBLAS_INT offsetX ) { - double max; CBLAS_INT ix; CBLAS_INT i; + double max; double v; if ( N <= 0 ) { From 4b884379a895fc159f6ab3fafb9b549b05693f7c Mon Sep 17 00:00:00 2001 From: Athan Date: Fri, 27 Dec 2024 13:17:59 -0800 Subject: [PATCH 12/13] Apply suggestions from code review Signed-off-by: Athan --- lib/node_modules/@stdlib/stats/base/dmaxabs/docs/repl.txt | 2 +- lib/node_modules/@stdlib/stats/base/dmaxabs/lib/dmaxabs.js | 2 +- lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/docs/repl.txt b/lib/node_modules/@stdlib/stats/base/dmaxabs/docs/repl.txt index 2e0ebde78143..824db79503ae 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/docs/repl.txt +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/docs/repl.txt @@ -3,7 +3,7 @@ Computes the maximum absolute value of a double-precision floating-point strided array. - The `N` and stride parameters determine which elements in the strided arrays + The `N` and stride parameters determine which elements in the strided array are accessed at runtime. Indexing is relative to the first index. To introduce an offset, use a typed diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/dmaxabs.js b/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/dmaxabs.js index 3fb3edd19223..a9ab2a65c713 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/dmaxabs.js +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/lib/dmaxabs.js @@ -31,7 +31,7 @@ var ndarray = require( './ndarray.js' ); * * @param {PositiveInteger} N - number of indexed elements * @param {Float64Array} x - input array -* @param {integer} strideX - stride length for X +* @param {integer} strideX - stride length * @returns {number} maximum absolute value * * @example diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c b/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c index 72c29a0b7fa7..8492cbc53bf4 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c @@ -27,7 +27,7 @@ * * @param N number of indexed elements * @param X input array -* @param strideX stride length +* @param strideX stride length for X * @return output value */ double API_SUFFIX(stdlib_strided_dmaxabs)( const CBLAS_INT N, const double *X, const CBLAS_INT strideX ) { From 366d5e536452a54da2e5fb79ee75aac214c22587 Mon Sep 17 00:00:00 2001 From: Athan Date: Fri, 27 Dec 2024 13:19:12 -0800 Subject: [PATCH 13/13] Apply suggestions from code review Signed-off-by: Athan --- lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c b/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c index 8492cbc53bf4..5de40d4f8480 100644 --- a/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c +++ b/lib/node_modules/@stdlib/stats/base/dmaxabs/src/main.c @@ -27,7 +27,7 @@ * * @param N number of indexed elements * @param X input array -* @param strideX stride length for X +* @param strideX stride length * @return output value */ double API_SUFFIX(stdlib_strided_dmaxabs)( const CBLAS_INT N, const double *X, const CBLAS_INT strideX ) { @@ -41,7 +41,7 @@ double API_SUFFIX(stdlib_strided_dmaxabs)( const CBLAS_INT N, const double *X, c * @param N number of indexed elements * @param X input array * @param strideX stride length -* @param offsetX starting index for X +* @param offsetX starting index * @return output value */ double API_SUFFIX(stdlib_strided_dmaxabs_ndarray)( const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const CBLAS_INT offsetX ) {