From bde4bfd0eaa6a1946e75716696b73cde7d62f904 Mon Sep 17 00:00:00 2001 From: saurabhraghuvanshii Date: Tue, 26 Nov 2024 20:06:46 +0530 Subject: [PATCH 1/2] test: add tests to blas/ext/base/dnannsumors --- .../base/dnannsumors/test/test.dnannsumors.js | 17 +++++++++++++++++ .../dnannsumors/test/test.dnannsumors.native.js | 17 +++++++++++++++++ .../ext/base/dnannsumors/test/test.ndarray.js | 17 +++++++++++++++++ .../dnannsumors/test/test.ndarray.native.js | 17 +++++++++++++++++ 4 files changed, 68 insertions(+) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.dnannsumors.js b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.dnannsumors.js index 74265cbba6e3..f0690d16f9ce 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.dnannsumors.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.dnannsumors.js @@ -232,6 +232,23 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns a sum t.end(); }); +tape( 'if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ) { + var expected; + var out; + var x; + var v; + + x = new Float64Array( [ NaN, -2.0, -4.0, 5.0, 3.0 ] ); + + out = new Float64Array( 2 ); + v = dnannsumors( x.length, x, 0, out, 1 ); + + expected = new Float64Array( [ 0.0, 0.0 ] ); + t.deepEqual( v, expected, 'returns expected value' ); + + t.end(); +}); + tape( 'the function supports view offsets', function test( t ) { var expected0; var expected1; diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.dnannsumors.native.js b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.dnannsumors.native.js index 8716af177db7..6110ea399ed6 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.dnannsumors.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.dnannsumors.native.js @@ -241,6 +241,23 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns a sum t.end(); }); +tape( 'if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', opts, function test( t ) { + var expected; + var out; + var x; + var v; + + x = new Float64Array( [ NaN, -2.0, -4.0, 5.0, 3.0 ] ); + + out = new Float64Array( 2 ); + v = dnannsumors( x.length, x, 0, out, 1 ); + + expected = new Float64Array( [ 0.0, 0.0 ] ); + t.deepEqual( v, expected, 'returns expected value' ); + + t.end(); +}); + tape( 'the function supports view offsets', opts, function test( t ) { var expected0; var expected1; diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.ndarray.js index daae94f7a2a4..02502a472bb1 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.ndarray.js @@ -232,6 +232,23 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns a sum t.end(); }); +tape( 'if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ) { + var expected; + var out; + var x; + var v; + + x = new Float64Array( [ NaN, -2.0, -4.0, 5.0, 3.0 ] ); + + out = new Float64Array( 2 ); + v = dnannsumors( x.length, x, 0, 0, out, 1, 0 ); + + expected = new Float64Array( [ 0.0, 0.0 ] ); + t.deepEqual( v, expected, 'returns expected value' ); + + t.end(); +}); + tape( 'the function supports `offset` parameters', function test( t ) { var expected; var out; diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.ndarray.native.js index 85481a880db3..6eadb81c97ec 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.ndarray.native.js @@ -241,6 +241,23 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns a sum t.end(); }); +tape( 'if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', opts, function test( t ) { + var expected; + var out; + var x; + var v; + + x = new Float64Array( [ NaN, -2.0, -4.0, 5.0, 3.0 ] ); + + out = new Float64Array( 2 ); + v = dnannsumors( x.length, x, 0, 0, out, 1, 0 ); + + expected = new Float64Array( [ 0.0, 0.0 ] ); + t.deepEqual( v, expected, 'returns expected value' ); + + t.end(); +}); + tape( 'the function supports `offset` parameters', opts, function test( t ) { var expected; var out; From 82b5fd5d2ee27bed6d7d71df35cbed7cfb6e52c7 Mon Sep 17 00:00:00 2001 From: Athan Date: Wed, 27 Nov 2024 01:50:46 -0800 Subject: [PATCH 2/2] Apply suggestions from code review Signed-off-by: Athan --- .../@stdlib/blas/ext/base/dnannsumors/test/test.dnannsumors.js | 2 +- .../blas/ext/base/dnannsumors/test/test.dnannsumors.native.js | 2 +- .../@stdlib/blas/ext/base/dnannsumors/test/test.ndarray.js | 2 +- .../blas/ext/base/dnannsumors/test/test.ndarray.native.js | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.dnannsumors.js b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.dnannsumors.js index f0690d16f9ce..fc3e743e515b 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.dnannsumors.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.dnannsumors.js @@ -232,7 +232,7 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns a sum t.end(); }); -tape( 'if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ) { +tape( 'if provided a `stride` parameter equal to `0` and the first element is `NaN`, the function returns `0.0`', function test( t ) { var expected; var out; var x; diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.dnannsumors.native.js b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.dnannsumors.native.js index 6110ea399ed6..3e906ab744a3 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.dnannsumors.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.dnannsumors.native.js @@ -241,7 +241,7 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns a sum t.end(); }); -tape( 'if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', opts, function test( t ) { +tape( 'if provided a `stride` parameter equal to `0` and the first element is `NaN`, the function returns `0.0`', opts, function test( t ) { var expected; var out; var x; diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.ndarray.js index 02502a472bb1..09007f1de7c9 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.ndarray.js @@ -232,7 +232,7 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns a sum t.end(); }); -tape( 'if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ) { +tape( 'if provided a `stride` parameter equal to `0` and the first element is `NaN`, the function returns `0.0`', function test( t ) { var expected; var out; var x; diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.ndarray.native.js index 6eadb81c97ec..cb74b729a875 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/test/test.ndarray.native.js @@ -241,7 +241,7 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns a sum t.end(); }); -tape( 'if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', opts, function test( t ) { +tape( 'if provided a `stride` parameter equal to `0` and the first element is `NaN`, the function returns `0.0`', opts, function test( t ) { var expected; var out; var x;