fix: resolve bug with unrecognized keywords in the REPL's syntax-highlighter #2284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
Planeshifter
changed the title
aman-095
pushed a commit
to aman-095/stdlib
that referenced
this pull request
Jun 13, 2024
PR-URL: stdlib-js#2284 Signed-off-by: Snehil Shah <snehilshah.989@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a small bug with unrecognized keywords (that acorn doesn't recognize as a keyword token), ie.
let,async&await, in the syntax highlighter.We were checking if it's a keyword inside the
Identifiervisitor and hence it wasn't working as expected. I have moved the logic to theonTokencallback.@Planeshifter sorry for the oversight. This patch PR fixes it.
Example:
let: let is highlightedlet a: let is not highlightedQuestions
No.
Other
No.
Checklist
@stdlib-js/reviewers