From c679e6f14dd7970866129b539d17d6294f9e3564 Mon Sep 17 00:00:00 2001 From: Jaysukh-409 Date: Sat, 27 Apr 2024 15:31:54 +0530 Subject: [PATCH 1/8] feat: add toLocaleString method to array/complex64 --- .../@stdlib/array/complex64/README.md | 21 +++ .../benchmark/benchmark.to_locale_string.js | 50 ++++++ .../benchmark.to_locale_string.length.js | 102 ++++++++++++ .../array/complex64/docs/types/index.d.ts | 20 +++ .../@stdlib/array/complex64/lib/main.js | 47 ++++++ .../complex64/test/test.to_locale_string.js | 156 ++++++++++++++++++ 6 files changed, 396 insertions(+) create mode 100644 lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.to_locale_string.js create mode 100644 lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.to_locale_string.length.js create mode 100644 lib/node_modules/@stdlib/array/complex64/test/test.to_locale_string.js diff --git a/lib/node_modules/@stdlib/array/complex64/README.md b/lib/node_modules/@stdlib/array/complex64/README.md index 3577db1d4993..10a3d66d0863 100644 --- a/lib/node_modules/@stdlib/array/complex64/README.md +++ b/lib/node_modules/@stdlib/array/complex64/README.md @@ -2192,6 +2192,27 @@ im = imagf( z ); // returns 6.0 ``` + + +#### Complex64Array.prototype.toLocaleString( \[locales\[, options]] ) + +Returns a string representating the elements of a typed array. + +```javascript +var arr = new Complex64Array( 2 ); + +arr.set( [ 1.0, 1.0 ], 0 ); +arr.set( [ 2.0, 2.0 ], 1 ); + +var str = arr.toLocaleString(); +// returns '1 + 1i,2 + 2i' +``` + +By default, the method returns a string representating the typed array element separated by separator `comma(,)`. To specify another locales provide an argument `locales` and `options`. + +- **locales**: A string with a BCP 47 language tag, or an array of such strings. +- **options**: An object with configuration properties. + #### Complex64Array.prototype.toReversed() diff --git a/lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.to_locale_string.js b/lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.to_locale_string.js new file mode 100644 index 000000000000..046fa8fc7c32 --- /dev/null +++ b/lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.to_locale_string.js @@ -0,0 +1,50 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2024 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +'use strict'; + +// MODULES // + +var bench = require( '@stdlib/bench' ); +var pkg = require( './../package.json' ).name; +var Complex64Array = require( './../lib' ); + + +// MAIN // + +bench( pkg+':toLocaleString', function benchmark( b ) { + var out; + var arr; + var i; + + arr = new Complex64Array( [ 1, 2, 3, 4, 5, 6 ] ); + + b.tic(); + for ( i = 0; i < b.iterations; i++ ) { + out = arr.toLocaleString(); + if ( typeof out !== 'string' ) { + b.fail( 'should return a string' ); + } + } + b.toc(); + if ( typeof out !== 'string' ) { + b.fail( 'should return a string' ); + } + b.pass( 'benchmark finished' ); + b.end(); +}); diff --git a/lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.to_locale_string.length.js b/lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.to_locale_string.length.js new file mode 100644 index 000000000000..9dff69b75cc7 --- /dev/null +++ b/lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.to_locale_string.length.js @@ -0,0 +1,102 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2024 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +'use strict'; + +// MODULES // + +var bench = require( '@stdlib/bench' ); +var pow = require( '@stdlib/math/base/special/pow' ); +var Complex64 = require( '@stdlib/complex/float32' ); +var pkg = require( './../package.json' ).name; +var Complex64Array = require( './../lib' ); + + +// FUNCTIONS // + +/** +* Creates a benchmark function. +* +* @private +* @param {PositiveInteger} len - array length +* @returns {Function} benchmark function +*/ +function createBenchmark( len ) { + var arr; + var i; + + arr = []; + for ( i = 0; i < len; i++ ) { + arr.push( new Complex64( i, i ) ); + } + arr = new Complex64Array( arr ); + + return benchmark; + + /** + * Benchmark function. + * + * @private + * @param {Benchmark} b - benchmark instance + */ + function benchmark( b ) { + var out; + var i; + + b.tic(); + for ( i = 0; i < b.iterations; i++ ) { + out = arr.toLocaleString(); + if ( typeof out !== 'string' ) { + b.fail( 'should return a string' ); + } + } + b.toc(); + if ( typeof out !== 'string' ) { + b.fail( 'should return a string' ); + } + b.pass( 'benchmark finished' ); + b.end(); + } +} + + +// MAIN // + +/** +* Main execution sequence. +* +* @private +*/ +function main() { + var len; + var min; + var max; + var f; + var i; + + min = 1; // 10^min + max = 6; // 10^max + + for ( i = min; i <= max; i++ ) { + len = pow( 10, i ); + f = createBenchmark( len ); + bench( pkg+':toLocaleString:len='+len, f ); + } +} + +main(); diff --git a/lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts b/lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts index fd280bd51822..59f47ecad948 100644 --- a/lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts +++ b/lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts @@ -1221,6 +1221,26 @@ declare class Complex64Array implements Complex64ArrayInterface { */ subarray( begin?: number, end?: number ): Complex64Array; + /** + * Returns a string representating the elements of a typed array. + * + * @param locales - a locale identifier + * @param options - an object containing other options + * @throws locales argument must be a string + * @throws options argument must be an object + * @returns string + * + * @example + * var arr = new Complex64Array( 2 ); + * + * arr.set( [ 1.0, 1.0 ], 0 ); + * arr.set( [ 2.0, 2.0 ], 1 ); + * + * var str = arr.toLocaleString(); + * // returns '1 + 1i,2 + 2i' + */ + toLocaleString( locales?: string, options?: object ): string; + /** * Returns a new typed array containing the elements in reversed order. * diff --git a/lib/node_modules/@stdlib/array/complex64/lib/main.js b/lib/node_modules/@stdlib/array/complex64/lib/main.js index b7de1659cb29..6c2986574d5d 100644 --- a/lib/node_modules/@stdlib/array/complex64/lib/main.js +++ b/lib/node_modules/@stdlib/array/complex64/lib/main.js @@ -2491,6 +2491,53 @@ setReadOnly( Complex64Array.prototype, 'subarray', function subarray( begin, end return new this.constructor( buf.buffer, offset, ( len < 0 ) ? 0 : len ); }); +/** +* Returns a string representating the elements of a typed array. +* +* @name toLocaleString +* @memberof Complex64Array.prototype +* @type {Function} +* @param {string} [locales] - a locale identifier +* @param {Object} [options] - an object containing other options +* @throws {TypeError} `this` must be a complex number array +* @throws {TypeError} locales argument must be a string or an array of string +* @throws {TypeError} options argument must be an object +* @returns {string} string representation +* +* @example +* var arr = new Complex64Array( 2 ); +* +* arr.set( [ 1.0, 1.0 ], 0 ); +* arr.set( [ 2.0, 2.0 ], 1 ); +* +* var str = arr.toLocaleString(); +* // returns '1 + 1i,2 + 2i' +*/ +setReadOnly( Complex64Array.prototype, 'toLocaleString', function toLocaleString( locales, options ) { + var out; + var buf; + var i; + if ( !isComplexArray( this ) ) { + throw new TypeError( 'invalid invocation. `this` is not a complex number array.' ); + } + if ( arguments.length === 0 ) { + locales = []; + } else if ( !isString( locales ) && !isArray( locales ) ) { + throw new TypeError( 'invalid argument. Locales argument must be a string or an array of string. Value: `' + locales + '`.' ); + } + if ( arguments.length < 2 ) { + options = {}; + } else if ( !isObject( options ) ) { + throw new TypeError( 'invalid argument. Options argument must be an object. Value: `' + options + '`.' ); + } + buf = this._buffer; + out = []; + for ( i = 0; i < this._length; i++ ) { + out.push( getComplex64( buf, i ).toLocaleString( locales, options ) ); + } + return out.join( ',' ); +}); + /** * Returns a new typed array containing the elements in reversed order. * diff --git a/lib/node_modules/@stdlib/array/complex64/test/test.to_locale_string.js b/lib/node_modules/@stdlib/array/complex64/test/test.to_locale_string.js new file mode 100644 index 000000000000..e15e401cac12 --- /dev/null +++ b/lib/node_modules/@stdlib/array/complex64/test/test.to_locale_string.js @@ -0,0 +1,156 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2024 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +'use strict'; + +// MODULES // + +var tape = require( 'tape' ); +var hasOwnProp = require( '@stdlib/assert/has-own-property' ); +var isFunction = require( '@stdlib/assert/is-function' ); +var Complex64Array = require( './../lib' ); + + +// TESTS // + +tape( 'main export is a function', function test( t ) { + t.ok( true, __filename ); + t.strictEqual( typeof Complex64Array, 'function', 'main export is a function' ); + t.end(); +}); + +tape( 'attached to the prototype of the main export is a `toLocaleString` method', function test( t ) { + t.strictEqual( hasOwnProp( Complex64Array.prototype, 'toLocaleString' ), true, 'has property' ); + t.strictEqual( isFunction( Complex64Array.prototype.toLocaleString ), true, 'has method' ); + t.end(); +}); + +tape( 'the method throws an error if invoked with a `this` context which is not a complex number array instance', function test( t ) { + var values; + var arr; + var i; + + arr = new Complex64Array( 5 ); + + values = [ + '5', + 5, + NaN, + true, + false, + null, + void 0, + {}, + [], + function noop() {} + ]; + for ( i = 0; i < values.length; i++ ) { + t.throws( badValue( values[i] ), TypeError, 'throws an error when provided '+values[i] ); + } + t.end(); + + function badValue( value ) { + return function badValue() { + return arr.toLocaleString.call( value ); + }; + } +}); + +tape( 'the method throws an error if provided a first argument which is not a string or an array of string', function test( t ) { + var values; + var arr; + var i; + + arr = new Complex64Array(); + + values = [ + 5, + NaN, + true, + false, + null, + void 0, + {}, + function noop() {} + ]; + for ( i = 0; i < values.length; i++ ) { + t.throws( badValue( values[i] ), TypeError, 'throws an error when provided '+values[i] ); + } + t.end(); + + function badValue( value ) { + return function badValue() { + return arr.toLocaleString( value ); + }; + } +}); + +tape( 'the method throws an error if provided a second argument which is not an object', function test( t ) { + var values; + var arr; + var i; + + arr = new Complex64Array(); + + values = [ + 5, + NaN, + true, + false, + null, + void 0, + 'beep', + [], + function noop() {} + ]; + for ( i = 0; i < values.length; i++ ) { + t.throws( badValue( values[i] ), TypeError, 'throws an error when provided '+values[i] ); + } + t.end(); + + function badValue( value ) { + return function badValue() { + return arr.toLocaleString( 'en-GB', value ); + }; + } +}); + +tape( 'the method returns an empty string if invoked on an empty array', function test( t ) { + var str; + var arr; + + arr = new Complex64Array(); + str = arr.toLocaleString(); + + t.strictEqual( str, '', 'returns expected value' ); + t.end(); +}); + +tape( 'the method invoked without an argument returns a string representation of a complex number array with elements separated by a separator comma', function test( t ) { + var expected; + var str; + var arr; + + arr = new Complex64Array( [ 1, 2, -3, -4 ] ); + expected = '1 + 2i,-3 - 4i'; + + str = arr.toLocaleString(); + + t.strictEqual( str, expected, 'returns expected value' ); + t.end(); +}); From 04e770307a1dbb6f2582d2c644c16aead57e131e Mon Sep 17 00:00:00 2001 From: Athan Date: Sat, 27 Apr 2024 15:03:45 -0700 Subject: [PATCH 2/8] Apply suggestions from code review Signed-off-by: Athan --- lib/node_modules/@stdlib/array/complex64/README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/node_modules/@stdlib/array/complex64/README.md b/lib/node_modules/@stdlib/array/complex64/README.md index 10a3d66d0863..c16241c4bc62 100644 --- a/lib/node_modules/@stdlib/array/complex64/README.md +++ b/lib/node_modules/@stdlib/array/complex64/README.md @@ -2196,7 +2196,7 @@ im = imagf( z ); #### Complex64Array.prototype.toLocaleString( \[locales\[, options]] ) -Returns a string representating the elements of a typed array. +Serializes an array as a locale-specific string. ```javascript var arr = new Complex64Array( 2 ); @@ -2208,10 +2208,10 @@ var str = arr.toLocaleString(); // returns '1 + 1i,2 + 2i' ``` -By default, the method returns a string representating the typed array element separated by separator `comma(,)`. To specify another locales provide an argument `locales` and `options`. +The method supports the following arguments: -- **locales**: A string with a BCP 47 language tag, or an array of such strings. -- **options**: An object with configuration properties. +- **locales**: a string with a BCP 47 language tag or an array of such strings. +- **options**: configuration properties. From 6b78dab56bab3a327499987c9684ac482c476690 Mon Sep 17 00:00:00 2001 From: Athan Date: Sat, 27 Apr 2024 15:08:48 -0700 Subject: [PATCH 3/8] Apply suggestions from code review Signed-off-by: Athan --- .../@stdlib/array/complex64/docs/types/index.d.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts b/lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts index 59f47ecad948..a2a1b51077dc 100644 --- a/lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts +++ b/lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts @@ -1222,12 +1222,10 @@ declare class Complex64Array implements Complex64ArrayInterface { subarray( begin?: number, end?: number ): Complex64Array; /** - * Returns a string representating the elements of a typed array. + * Serializes an array as a locale-specific string. * - * @param locales - a locale identifier - * @param options - an object containing other options - * @throws locales argument must be a string - * @throws options argument must be an object + * @param locales - locale identifier(s) + * @param options - configuration options * @returns string * * @example @@ -1239,7 +1237,7 @@ declare class Complex64Array implements Complex64ArrayInterface { * var str = arr.toLocaleString(); * // returns '1 + 1i,2 + 2i' */ - toLocaleString( locales?: string, options?: object ): string; + toLocaleString( locales?: string | Array, options?: object ): string; /** * Returns a new typed array containing the elements in reversed order. From 862a1662670631cafa33de325a4f92ba127b4cab Mon Sep 17 00:00:00 2001 From: Athan Date: Sat, 27 Apr 2024 15:11:41 -0700 Subject: [PATCH 4/8] Apply suggestions from code review Signed-off-by: Athan --- lib/node_modules/@stdlib/array/complex64/lib/main.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/node_modules/@stdlib/array/complex64/lib/main.js b/lib/node_modules/@stdlib/array/complex64/lib/main.js index 6c2986574d5d..d203d6398d8c 100644 --- a/lib/node_modules/@stdlib/array/complex64/lib/main.js +++ b/lib/node_modules/@stdlib/array/complex64/lib/main.js @@ -2492,15 +2492,15 @@ setReadOnly( Complex64Array.prototype, 'subarray', function subarray( begin, end }); /** -* Returns a string representating the elements of a typed array. +* Serializes an array as a locale-specific string. * * @name toLocaleString * @memberof Complex64Array.prototype * @type {Function} -* @param {string} [locales] - a locale identifier -* @param {Object} [options] - an object containing other options +* @param {(string|Array)} [locales] - locale identifier(s) +* @param {Object} [options] - configuration options * @throws {TypeError} `this` must be a complex number array -* @throws {TypeError} locales argument must be a string or an array of string +* @throws {TypeError} first argument must be a string or an array of strings * @throws {TypeError} options argument must be an object * @returns {string} string representation * @@ -2523,7 +2523,7 @@ setReadOnly( Complex64Array.prototype, 'toLocaleString', function toLocaleString if ( arguments.length === 0 ) { locales = []; } else if ( !isString( locales ) && !isArray( locales ) ) { - throw new TypeError( 'invalid argument. Locales argument must be a string or an array of string. Value: `' + locales + '`.' ); + throw new TypeError( 'invalid argument. First argument must be a string or an array of strings. Value: `' + locales + '`.' ); } if ( arguments.length < 2 ) { options = {}; From 21117b69d4a3d5452c960da7ae4b5f882d4a5e58 Mon Sep 17 00:00:00 2001 From: Athan Date: Sat, 27 Apr 2024 15:14:00 -0700 Subject: [PATCH 5/8] Apply suggestions from code review Signed-off-by: Athan --- .../@stdlib/array/complex64/test/test.to_locale_string.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/array/complex64/test/test.to_locale_string.js b/lib/node_modules/@stdlib/array/complex64/test/test.to_locale_string.js index e15e401cac12..199209ceb4e2 100644 --- a/lib/node_modules/@stdlib/array/complex64/test/test.to_locale_string.js +++ b/lib/node_modules/@stdlib/array/complex64/test/test.to_locale_string.js @@ -71,7 +71,7 @@ tape( 'the method throws an error if invoked with a `this` context which is not } }); -tape( 'the method throws an error if provided a first argument which is not a string or an array of string', function test( t ) { +tape( 'the method throws an error if provided a first argument which is not a string or an array of strings', function test( t ) { var values; var arr; var i; @@ -86,6 +86,7 @@ tape( 'the method throws an error if provided a first argument which is not a st null, void 0, {}, + [ 1, 2, 3 ], function noop() {} ]; for ( i = 0; i < values.length; i++ ) { @@ -141,7 +142,7 @@ tape( 'the method returns an empty string if invoked on an empty array', functio t.end(); }); -tape( 'the method invoked without an argument returns a string representation of a complex number array with elements separated by a separator comma', function test( t ) { +tape( 'the method invoked without an argument returns a string representation of a complex number array with elements separated by a comma', function test( t ) { var expected; var str; var arr; From bd581e7820bf532b354b118d348c65a2d1410257 Mon Sep 17 00:00:00 2001 From: Athan Reines Date: Sat, 4 May 2024 02:28:15 -0700 Subject: [PATCH 6/8] refactor: check for an array of strings and avoid reassignment when using `arguments` --- .../@stdlib/array/complex64/lib/main.js | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/lib/node_modules/@stdlib/array/complex64/lib/main.js b/lib/node_modules/@stdlib/array/complex64/lib/main.js index d203d6398d8c..31cf5163c2c2 100644 --- a/lib/node_modules/@stdlib/array/complex64/lib/main.js +++ b/lib/node_modules/@stdlib/array/complex64/lib/main.js @@ -28,6 +28,7 @@ var isCollection = require( '@stdlib/assert/is-collection' ); var isArrayBuffer = require( '@stdlib/assert/is-arraybuffer' ); var isObject = require( '@stdlib/assert/is-object' ); var isArray = require( '@stdlib/assert/is-array' ); +var isStringArray = require( '@stdlib/assert/is-string-array' ).primitives; var isString = require( '@stdlib/assert/is-string' ).isPrimitive; var isFunction = require( '@stdlib/assert/is-function' ); var isComplexLike = require( '@stdlib/assert/is-complex-like' ); @@ -2514,6 +2515,8 @@ setReadOnly( Complex64Array.prototype, 'subarray', function subarray( begin, end * // returns '1 + 1i,2 + 2i' */ setReadOnly( Complex64Array.prototype, 'toLocaleString', function toLocaleString( locales, options ) { + var opts; + var loc; var out; var buf; var i; @@ -2521,19 +2524,23 @@ setReadOnly( Complex64Array.prototype, 'toLocaleString', function toLocaleString throw new TypeError( 'invalid invocation. `this` is not a complex number array.' ); } if ( arguments.length === 0 ) { - locales = []; - } else if ( !isString( locales ) && !isArray( locales ) ) { + loc = []; + } else if ( isString( locales ) || isStringArray( locales ) ) { + loc = locales; + } else { throw new TypeError( 'invalid argument. First argument must be a string or an array of strings. Value: `' + locales + '`.' ); } if ( arguments.length < 2 ) { - options = {}; - } else if ( !isObject( options ) ) { + opts = {}; + } else if ( isObject( options ) ) { + opts = options; + } else { throw new TypeError( 'invalid argument. Options argument must be an object. Value: `' + options + '`.' ); } buf = this._buffer; out = []; for ( i = 0; i < this._length; i++ ) { - out.push( getComplex64( buf, i ).toLocaleString( locales, options ) ); + out.push( getComplex64( buf, i ).toLocaleString( loc, opts ) ); } return out.join( ',' ); }); From b5aff57b45c4e415a651ea4ca4b0412775357839 Mon Sep 17 00:00:00 2001 From: Athan Reines Date: Sat, 4 May 2024 02:29:33 -0700 Subject: [PATCH 7/8] test: add tests --- .../complex64/test/test.to_locale_string.js | 32 ++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/array/complex64/test/test.to_locale_string.js b/lib/node_modules/@stdlib/array/complex64/test/test.to_locale_string.js index 199209ceb4e2..e917b7171e07 100644 --- a/lib/node_modules/@stdlib/array/complex64/test/test.to_locale_string.js +++ b/lib/node_modules/@stdlib/array/complex64/test/test.to_locale_string.js @@ -101,6 +101,36 @@ tape( 'the method throws an error if provided a first argument which is not a st } }); +tape( 'the method throws an error if provided a first argument which is not a string or an array of strings (options)', function test( t ) { + var values; + var arr; + var i; + + arr = new Complex64Array(); + + values = [ + 5, + NaN, + true, + false, + null, + void 0, + {}, + [ 1, 2, 3 ], + function noop() {} + ]; + for ( i = 0; i < values.length; i++ ) { + t.throws( badValue( values[i] ), TypeError, 'throws an error when provided '+values[i] ); + } + t.end(); + + function badValue( value ) { + return function badValue() { + return arr.toLocaleString( value, {} ); + }; + } +}); + tape( 'the method throws an error if provided a second argument which is not an object', function test( t ) { var values; var arr; @@ -142,7 +172,7 @@ tape( 'the method returns an empty string if invoked on an empty array', functio t.end(); }); -tape( 'the method invoked without an argument returns a string representation of a complex number array with elements separated by a comma', function test( t ) { +tape( 'the method returns a string representation of a complex number array', function test( t ) { var expected; var str; var arr; From fd7862c2833ae817dbf0b03e65220f353e36a145 Mon Sep 17 00:00:00 2001 From: Athan Reines Date: Sat, 4 May 2024 02:37:43 -0700 Subject: [PATCH 8/8] refactor: increase type specificity --- .../@stdlib/array/complex64/docs/types/index.d.ts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts b/lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts index a2a1b51077dc..05a9b8a947d4 100644 --- a/lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts +++ b/lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts @@ -30,6 +30,16 @@ import ArrayBuffer = require( '@stdlib/array/buffer' ); // Define a union type representing both iterable and non-iterable iterators: type Iterator = Iter | IterableIterator; +/** +* Locale-specific configuration options. +*/ +interface LocaleOptions { + /** + * Configuration property. + */ + [ key: string | symbol | number ]: T | undefined; +}; + /** * Callback invoked for each element in a source object. * @@ -1237,7 +1247,7 @@ declare class Complex64Array implements Complex64ArrayInterface { * var str = arr.toLocaleString(); * // returns '1 + 1i,2 + 2i' */ - toLocaleString( locales?: string | Array, options?: object ): string; + toLocaleString( locales?: string | Array, options?: LocaleOptions ): string; /** * Returns a new typed array containing the elements in reversed order.