From be98504a5e33d7dc4a10e86556910f1f99c36cf1 Mon Sep 17 00:00:00 2001 From: utkarsh_raj <49344502+rajutkarsh07@users.noreply.github.com> Date: Tue, 26 Mar 2024 22:09:13 +0000 Subject: [PATCH 1/8] updated blas/ext/base/dasumpw --- .../blas/ext/base/dsnansumors/README.md | 37 ++---- .../base/dsnansumors/benchmark/benchmark.js | 21 ++-- .../dsnansumors/benchmark/benchmark.native.js | 17 +-- .../benchmark/benchmark.ndarray.js | 21 ++-- .../benchmark/benchmark.ndarray.native.js | 17 +-- .../ext/base/dsnansumors/examples/index.js | 16 +-- .../blas/ext/base/dsnansumors/include.gypi | 2 +- .../blas/ext/base/dsnansumors/lib/index.js | 4 +- .../blas/ext/base/dsnansumors/lib/ndarray.js | 4 +- .../base/dsnansumors/lib/ndarray.native.js | 13 +- .../blas/ext/base/dsnansumors/manifest.json | 109 ++++++++++------ .../blas/ext/base/dsnansumors/src/addon.c | 48 +++++++ .../blas/ext/base/dsnansumors/src/addon.cpp | 117 ------------------ .../base/dsnansumors/test/test.dsnansumors.js | 11 +- .../test/test.dsnansumors.native.js | 9 +- .../ext/base/dsnansumors/test/test.ndarray.js | 9 +- .../dsnansumors/test/test.ndarray.native.js | 9 +- 17 files changed, 180 insertions(+), 284 deletions(-) create mode 100644 lib/node_modules/@stdlib/blas/ext/base/dsnansumors/src/addon.c delete mode 100644 lib/node_modules/@stdlib/blas/ext/base/dsnansumors/src/addon.cpp diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md index dbaecbd3bc52..9e5a1a31f278 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md @@ -56,16 +56,14 @@ The function has the following parameters: - **x**: input [`Float32Array`][@stdlib/array/float32]. - **stride**: index increment for `x`. -The `N` and `stride` parameters determine which elements in `x` are accessed at runtime. For example, to compute the sum of every other element in `x`, +The `N` and stride parameters determine which elements in the strided array are accessed at runtime. For example, to compute the sum of every other element in `x`, ```javascript var Float32Array = require( '@stdlib/array/float32' ); -var floor = require( '@stdlib/math/base/special/floor' ); var x = new Float32Array( [ 1.0, 2.0, NaN, -7.0, NaN, 3.0, 4.0, 2.0 ] ); -var N = floor( x.length / 2 ); -var v = dsnansumors( N, x, 2 ); +var v = dsnansumors( 4, x, 2 ); // returns 5.0 ``` @@ -75,14 +73,11 @@ Note that indexing is relative to the first index. To introduce an offset, use [ ```javascript var Float32Array = require( '@stdlib/array/float32' ); -var floor = require( '@stdlib/math/base/special/floor' ); var x0 = new Float32Array( [ 2.0, 1.0, NaN, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); var x1 = new Float32Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element -var N = floor( x0.length / 2 ); - -var v = dsnansumors( N, x1, 2 ); +var v = dsnansumors( 4, x1, 2 ); // returns 5.0 ``` @@ -94,9 +89,8 @@ Computes the sum of single-precision floating-point strided array elements, igno var Float32Array = require( '@stdlib/array/float32' ); var x = new Float32Array( [ 1.0, -2.0, NaN, 2.0 ] ); -var N = x.length; -var v = dsnansumors.ndarray( N, x, 1, 0 ); +var v = dsnansumors.ndarray( 2, x, 1, 0 ); // returns 1.0 ``` @@ -104,16 +98,14 @@ The function has the following additional parameters: - **offset**: starting index for `x`. -While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying `buffer`, the `offset` parameter supports indexing semantics based on a starting index. For example, to calculate the sum of every other value in `x` starting from the second value +While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying `buffer`, the offset parameter supports indexing semantics based on a starting index. For example, to calculate the sum of every other value in `x` starting from the second value ```javascript var Float32Array = require( '@stdlib/array/float32' ); -var floor = require( '@stdlib/math/base/special/floor' ); var x = new Float32Array( [ 2.0, 1.0, NaN, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); -var N = floor( x.length / 2 ); -var v = dsnansumors.ndarray( N, x, 2, 1 ); +var v = dsnansumors.ndarray( 4, x, 2, 1 ); // returns 5.0 ``` @@ -139,22 +131,11 @@ var v = dsnansumors.ndarray( N, x, 2, 1 ); ```javascript -var randu = require( '@stdlib/random/base/randu' ); -var round = require( '@stdlib/math/base/special/round' ); -var Float32Array = require( '@stdlib/array/float32' ); +var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var dsnansumors = require( '@stdlib/blas/ext/base/dsnansumors' ); -var x; -var i; - -x = new Float32Array( 10 ); -for ( i = 0; i < x.length; i++ ) { - if ( randu() < 0.2 ) { - x[ i ] = NaN; - } else { - x[ i ] = round( randu()*100.0 ); - } -} +var x = filledarrayBy( 10, 'float32', discreteUniform( 0, 100 ) ); console.log( x ); var v = dsnansumors( x.length, x, 1 ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.js index 08f66056c193..48abe33a6ce1 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.js @@ -21,14 +21,19 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/base/uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float32Array = require( '@stdlib/array/float32' ); var pkg = require( './../package.json' ).name; var dsnansumors = require( './../lib/dsnansumors.js' ); +// VARIABLES // + +var rand = uniform( -100.0, 100.0 ); + + // FUNCTIONS // /** @@ -39,17 +44,7 @@ var dsnansumors = require( './../lib/dsnansumors.js' ); * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float32Array( len ); - for ( i = 0; i < x.length; i++ ) { - if ( randu() < 0.2 ) { - x[ i ] = NaN; - } else { - x[ i ] = ( randu()*20.0 ) - 10.0; - } - } + var x = filledarrayBy( len, 'float32', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.native.js index d5dba34aed1c..aaa9087b982c 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.native.js @@ -22,10 +22,10 @@ var resolve = require( 'path' ).resolve; var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/base/uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float32Array = require( '@stdlib/array/float32' ); var tryRequire = require( '@stdlib/utils/try-require' ); var pkg = require( './../package.json' ).name; @@ -36,6 +36,7 @@ var dsnansumors = tryRequire( resolve( __dirname, './../lib/dsnansumors.native.j var opts = { 'skip': ( dsnansumors instanceof Error ) }; +var rand = uniform( -100.0, 100.0 ); // FUNCTIONS // @@ -48,17 +49,7 @@ var opts = { * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float32Array( len ); - for ( i = 0; i < x.length; i++ ) { - if ( randu() < 0.2 ) { - x[ i ] = NaN; - } else { - x[ i ] = ( randu()*20.0 ) - 10.0; - } - } + var x = filledarrayBy( len, 'float32', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.ndarray.js index 8fee0262ca0d..db3da8c4df02 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.ndarray.js @@ -21,14 +21,19 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/base/uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float32Array = require( '@stdlib/array/float32' ); var pkg = require( './../package.json' ).name; var dsnansumors = require( './../lib/ndarray.js' ); +// VARIABLES // + +var rand = uniform( -100.0, 100.0 ); + + // FUNCTIONS // /** @@ -39,17 +44,7 @@ var dsnansumors = require( './../lib/ndarray.js' ); * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float32Array( len ); - for ( i = 0; i < x.length; i++ ) { - if ( randu() < 0.2 ) { - x[ i ] = NaN; - } else { - x[ i ] = ( randu()*20.0 ) - 10.0; - } - } + var x = filledarrayBy( len, 'float32', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.ndarray.native.js index fe74973f2308..679c5b38db4f 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.ndarray.native.js @@ -22,10 +22,10 @@ var resolve = require( 'path' ).resolve; var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/base/uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float32Array = require( '@stdlib/array/float32' ); var tryRequire = require( '@stdlib/utils/try-require' ); var pkg = require( './../package.json' ).name; @@ -36,6 +36,7 @@ var dsnansumors = tryRequire( resolve( __dirname, './../lib/ndarray.native.js' ) var opts = { 'skip': ( dsnansumors instanceof Error ) }; +var rand = uniform( -100.0, 100.0 ); // FUNCTIONS // @@ -48,17 +49,7 @@ var opts = { * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float32Array( len ); - for ( i = 0; i < x.length; i++ ) { - if ( randu() < 0.2 ) { - x[ i ] = NaN; - } else { - x[ i ] = ( randu()*20.0 ) - 10.0; - } - } + var x = filledarrayBy( len, 'float32', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/examples/index.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/examples/index.js index 2fc2239102bc..2f14137af236 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/examples/index.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/examples/index.js @@ -18,22 +18,12 @@ 'use strict'; -var randu = require( '@stdlib/random/base/randu' ); -var round = require( '@stdlib/math/base/special/round' ); -var Float32Array = require( '@stdlib/array/float32' ); +var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var dsnansumors = require( './../lib' ); -var x; -var i; -x = new Float32Array( 10 ); -for ( i = 0; i < x.length; i++ ) { - if ( randu() < 0.2 ) { - x[ i ] = NaN; - } else { - x[ i ] = round( randu()*100.0 ); - } -} +var x = filledarrayBy( 10, 'float32', discreteUniform( -100.0, 100.0 ) ); console.log( x ); var v = dsnansumors( x.length, x, 1 ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/include.gypi b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/include.gypi index 868c5c12e852..26476a8c2655 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/include.gypi +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/include.gypi @@ -36,7 +36,7 @@ # Source files: 'src_files': [ - '<(src_dir)/addon.cpp', + '<(src_dir)/addon.c', ' +#include + +/** +* Receives JavaScript callback invocation data. +* +* @private +* @param env environment under which the function is invoked +* @param info callback data +* @return Node-API value +*/ +static napi_value addon( napi_env env, napi_callback_info info ) { + STDLIB_NAPI_ARGV( env, info, argv, argc, 3 ); + STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 ); + STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 2 ); + STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, N, strideX, argv, 1 ); + + napi_value v; + napi_status status = napi_create_double( env, stdlib_strided_dsnansumors( N, X, strideX ), &v ); + assert( status == napi_ok ); + + return v; +} + +STDLIB_NAPI_MODULE_EXPORT_FCN( addon ) \ No newline at end of file diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/src/addon.cpp b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/src/addon.cpp deleted file mode 100644 index 508541080df2..000000000000 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/src/addon.cpp +++ /dev/null @@ -1,117 +0,0 @@ -/** -* @license Apache-2.0 -* -* Copyright (c) 2020 The Stdlib Authors. -* -* Licensed under the Apache License, Version 2.0 (the "License"); -* you may not use this file except in compliance with the License. -* You may obtain a copy of the License at -* -* http://www.apache.org/licenses/LICENSE-2.0 -* -* Unless required by applicable law or agreed to in writing, software -* distributed under the License is distributed on an "AS IS" BASIS, -* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -* See the License for the specific language governing permissions and -* limitations under the License. -*/ - -#include "stdlib/blas/ext/base/dsnansumors.h" -#include -#include -#include -#include -#include - -/** -* Add-on namespace. -*/ -namespace stdlib_blas_ext_base_dsnansumors { - - /** - * Computes the sum of single-precision floating-point strided array elements, ignoring `NaN` values, using ordinary recursive summation with extended accumulation, and returning an extended precision result. - * - * ## Notes - * - * - When called from JavaScript, the function expects three arguments: - * - * - `N`: number of indexed elements - * - `X`: input array - * - `stride`: stride length - */ - napi_value node_dsnansumors( napi_env env, napi_callback_info info ) { - napi_status status; - - size_t argc = 3; - napi_value argv[ 3 ]; - status = napi_get_cb_info( env, info, &argc, argv, nullptr, nullptr ); - assert( status == napi_ok ); - - if ( argc < 3 ) { - napi_throw_error( env, nullptr, "invalid invocation. Must provide 3 arguments." ); - return nullptr; - } - - napi_valuetype vtype0; - status = napi_typeof( env, argv[ 0 ], &vtype0 ); - assert( status == napi_ok ); - if ( vtype0 != napi_number ) { - napi_throw_type_error( env, nullptr, "invalid argument. First argument must be a number." ); - return nullptr; - } - - bool res; - status = napi_is_typedarray( env, argv[ 1 ], &res ); - assert( status == napi_ok ); - if ( res == false ) { - napi_throw_type_error( env, nullptr, "invalid argument. Second argument must be a Float32Array." ); - return nullptr; - } - - napi_valuetype vtype2; - status = napi_typeof( env, argv[ 2 ], &vtype2 ); - assert( status == napi_ok ); - if ( vtype2 != napi_number ) { - napi_throw_type_error( env, nullptr, "invalid argument. Third argument must be a number." ); - return nullptr; - } - - int64_t N; - status = napi_get_value_int64( env, argv[ 0 ], &N ); - assert( status == napi_ok ); - - int64_t stride; - status = napi_get_value_int64( env, argv[ 2 ], &stride ); - assert( status == napi_ok ); - - napi_typedarray_type vtype1; - size_t xlen; - void *X; - status = napi_get_typedarray_info( env, argv[ 1 ], &vtype1, &xlen, &X, nullptr, nullptr ); - assert( status == napi_ok ); - if ( vtype1 != napi_float32_array ) { - napi_throw_type_error( env, nullptr, "invalid argument. Second argument must be a Float32Array." ); - return nullptr; - } - if ( (N-1)*llabs(stride) >= (int64_t)xlen ) { - napi_throw_range_error( env, nullptr, "invalid argument. Second argument has insufficient elements based on the associated stride and the number of indexed elements." ); - return nullptr; - } - - napi_value v; - status = napi_create_double( env, stdlib_strided_dsnansumors( N, (float *)X, stride ), &v ); - assert( status == napi_ok ); - - return v; - } - - napi_value Init( napi_env env, napi_value exports ) { - napi_status status; - napi_value fcn; - status = napi_create_function( env, "exports", NAPI_AUTO_LENGTH, node_dsnansumors, NULL, &fcn ); - assert( status == napi_ok ); - return fcn; - } - - NAPI_MODULE( NODE_GYP_MODULE_NAME, Init ) -} // end namespace stdlib_blas_ext_base_dsnansumors diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.js index bb87ef970452..0d440c51273a 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.js @@ -21,7 +21,6 @@ // MODULES // var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var Float32Array = require( '@stdlib/array/float32' ); var dsnansumors = require( './../lib/dsnansumors.js' ); @@ -35,7 +34,7 @@ tape( 'main export is a function', function test( t ) { }); tape( 'the function has an arity of 3', function test( t ) { - t.strictEqual( dsnansumors.length, 3, 'has expected arity' ); + t.strictEqual( dsnansumors.length, 3, 'returns expected value' ); t.end(); }); @@ -123,8 +122,7 @@ tape( 'the function supports a `stride` parameter', function test( t ) { NaN ]); - N = floor( x.length / 2 ); - v = dsnansumors( N, x, 2 ); + v = dsnansumors( 5, x, 2 ); t.strictEqual( v, 5.0, 'returns expected value' ); t.end(); @@ -148,8 +146,7 @@ tape( 'the function supports a negative `stride` parameter', function test( t ) 2.0 ]); - N = floor( x.length / 2 ); - v = dsnansumors( N, x, -2 ); + v = dsnansumors( 5, x, -2 ); t.strictEqual( v, 5.0, 'returns expected value' ); t.end(); @@ -187,8 +184,8 @@ tape( 'the function supports view offsets', function test( t ) { NaN ]); + N = 5; x1 = new Float32Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element - N = floor(x1.length / 2); v = dsnansumors( N, x1, 2 ); t.strictEqual( v, 5.0, 'returns expected value' ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.native.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.native.js index 67f75746e8f2..1e7988a501b0 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.native.js @@ -22,7 +22,6 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var Float32Array = require( '@stdlib/array/float32' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -44,7 +43,7 @@ tape( 'main export is a function', opts, function test( t ) { }); tape( 'the function has an arity of 3', opts, function test( t ) { - t.strictEqual( dsnansumors.length, 3, 'has expected arity' ); + t.strictEqual( dsnansumors.length, 3, 'returns expected value' ); t.end(); }); @@ -214,7 +213,7 @@ tape( 'the function supports a `stride` parameter', opts, function test( t ) { NaN ]); - N = floor( x.length / 2 ); + N = 5; v = dsnansumors( N, x, 2 ); t.strictEqual( v, 5.0, 'returns expected value' ); @@ -239,7 +238,7 @@ tape( 'the function supports a negative `stride` parameter', opts, function test 2.0 ]); - N = floor( x.length / 2 ); + N = 5; v = dsnansumors( N, x, -2 ); t.strictEqual( v, 5.0, 'returns expected value' ); @@ -278,8 +277,8 @@ tape( 'the function supports view offsets', opts, function test( t ) { NaN ]); + N = 5; x1 = new Float32Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element - N = floor(x1.length / 2); v = dsnansumors( N, x1, 2 ); t.strictEqual( v, 5.0, 'returns expected value' ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.ndarray.js index d2ab41055ac2..1d4d1ac4e228 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.ndarray.js @@ -21,7 +21,6 @@ // MODULES // var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var Float32Array = require( '@stdlib/array/float32' ); var dsnansumors = require( './../lib/ndarray.js' ); @@ -35,7 +34,7 @@ tape( 'main export is a function', function test( t ) { }); tape( 'the function has an arity of 4', function test( t ) { - t.strictEqual( dsnansumors.length, 4, 'has expected arity' ); + t.strictEqual( dsnansumors.length, 4, 'returns expected value' ); t.end(); }); @@ -123,7 +122,7 @@ tape( 'the function supports a `stride` parameter', function test( t ) { NaN ]); - N = floor( x.length / 2 ); + N = 5; v = dsnansumors( N, x, 2, 0 ); t.strictEqual( v, 5.0, 'returns expected value' ); @@ -148,7 +147,7 @@ tape( 'the function supports a negative `stride` parameter', function test( t ) 2.0 ]); - N = floor( x.length / 2 ); + N = 5; v = dsnansumors( N, x, -2, 8 ); t.strictEqual( v, 5.0, 'returns expected value' ); @@ -184,7 +183,7 @@ tape( 'the function supports an `offset` parameter', function test( t ) { NaN, NaN // 4 ]); - N = floor( x.length / 2 ); + N = 5; v = dsnansumors( N, x, 2, 1 ); t.strictEqual( v, 5.0, 'returns expected value' ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.ndarray.native.js index 2d4bf6ec477c..9727fabbfa53 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.ndarray.native.js @@ -22,7 +22,6 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var Float32Array = require( '@stdlib/array/float32' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -44,7 +43,7 @@ tape( 'main export is a function', opts, function test( t ) { }); tape( 'the function has an arity of 4', opts, function test( t ) { - t.strictEqual( dsnansumors.length, 4, 'has expected arity' ); + t.strictEqual( dsnansumors.length, 4, 'returns expected value' ); t.end(); }); @@ -132,7 +131,7 @@ tape( 'the function supports a `stride` parameter', opts, function test( t ) { NaN ]); - N = floor( x.length / 2 ); + N = 5; v = dsnansumors( N, x, 2, 0 ); t.strictEqual( v, 5.0, 'returns expected value' ); @@ -157,7 +156,7 @@ tape( 'the function supports a negative `stride` parameter', opts, function test 2.0 ]); - N = floor( x.length / 2 ); + N = 5; v = dsnansumors( N, x, -2, 8 ); t.strictEqual( v, 5.0, 'returns expected value' ); @@ -193,7 +192,7 @@ tape( 'the function supports an `offset` parameter', opts, function test( t ) { NaN, NaN // 4 ]); - N = floor( x.length / 2 ); + N = 5; v = dsnansumors( N, x, 2, 1 ); t.strictEqual( v, 5.0, 'returns expected value' ); From c705574a06e1d1c1dad4f8ca2919d21de638e7b1 Mon Sep 17 00:00:00 2001 From: utkarsh_raj <49344502+rajutkarsh07@users.noreply.github.com> Date: Tue, 26 Mar 2024 22:11:58 +0000 Subject: [PATCH 2/8] updated manifest.json --- .../blas/ext/base/dsnansumors/manifest.json | 133 ++++++++---------- 1 file changed, 57 insertions(+), 76 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/manifest.json b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/manifest.json index d1ccac300c80..bcacea431ad6 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/manifest.json +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/manifest.json @@ -1,77 +1,58 @@ { - "options": { - "task": "build" - }, - "fields": [ - { - "field": "src", - "resolve": true, - "relative": true - }, - { - "field": "include", - "resolve": true, - "relative": true - }, - { - "field": "libraries", - "resolve": false, - "relative": false - }, - { - "field": "libpath", - "resolve": true, - "relative": false - } - ], - "confs": [ - { - "task": "build", - "src": [ - "./src/dsnansumors.c" - ], - "include": [ - "./include" - ], - "libraries": [ - "-lm" - ], - "libpath": [], - "dependencies": [ - "@stdlib/napi/export", - "@stdlib/napi/argv", - "@stdlib/napi/argv-int64", - "@stdlib/napi/argv-strided-float32array" - ] - }, - { - "task": "benchmark", - "src": [ - "./src/dsnansumors.c" - ], - "include": [ - "./include" - ], - "libraries": [ - "-lm" - ], - "libpath": [], - "dependencies": [] - }, - { - "task": "examples", - "src": [ - "./src/dsnansumors.c" - ], - "include": [ - "./include" - ], - "libraries": [ - "-lm" - ], - "libpath": [], - "dependencies": [] - } - ] - } - \ No newline at end of file + "options": { + "task": "build" + }, + "fields": [ + { + "field": "src", + "resolve": true, + "relative": true + }, + { + "field": "include", + "resolve": true, + "relative": true + }, + { + "field": "libraries", + "resolve": false, + "relative": false + }, + { + "field": "libpath", + "resolve": true, + "relative": false + } + ], + "confs": [ + { + "task": "build", + "src": ["./src/dsnansumors.c"], + "include": ["./include"], + "libraries": ["-lm"], + "libpath": [], + "dependencies": [ + "@stdlib/napi/export", + "@stdlib/napi/argv", + "@stdlib/napi/argv-int64", + "@stdlib/napi/argv-strided-float64array" + ] + }, + { + "task": "benchmark", + "src": ["./src/dsnansumors.c"], + "include": ["./include"], + "libraries": ["-lm"], + "libpath": [], + "dependencies": [] + }, + { + "task": "examples", + "src": ["./src/dsnansumors.c"], + "include": ["./include"], + "libraries": ["-lm"], + "libpath": [], + "dependencies": [] + } + ] +} From a077d2323363516b4dc2f73a80c374d0ef7bb228 Mon Sep 17 00:00:00 2001 From: utkarsh_raj <49344502+rajutkarsh07@users.noreply.github.com> Date: Tue, 26 Mar 2024 22:45:36 +0000 Subject: [PATCH 3/8] refactoring changes --- lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md | 2 +- .../@stdlib/blas/ext/base/dsnansumors/examples/index.js | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md index 9e5a1a31f278..0eb2a867e8b3 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md @@ -91,7 +91,7 @@ var Float32Array = require( '@stdlib/array/float32' ); var x = new Float32Array( [ 1.0, -2.0, NaN, 2.0 ] ); var v = dsnansumors.ndarray( 2, x, 1, 0 ); -// returns 1.0 +// returns -1 ``` The function has the following additional parameters: diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/examples/index.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/examples/index.js index 2f14137af236..159a85c6d8a8 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/examples/index.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/examples/index.js @@ -22,7 +22,6 @@ var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory; var filledarrayBy = require( '@stdlib/array/filled-by' ); var dsnansumors = require( './../lib' ); - var x = filledarrayBy( 10, 'float32', discreteUniform( -100.0, 100.0 ) ); console.log( x ); From 8c5a4988d21fd0dbec598453c4ab12527da4d01c Mon Sep 17 00:00:00 2001 From: utkarsh_raj <49344502+rajutkarsh07@users.noreply.github.com> Date: Tue, 26 Mar 2024 22:53:28 +0000 Subject: [PATCH 4/8] refactoring changes --- .../@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.js index 0d440c51273a..180f65f07d31 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.js @@ -105,7 +105,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first }); tape( 'the function supports a `stride` parameter', function test( t ) { - var N; var x; var v; @@ -129,7 +128,6 @@ tape( 'the function supports a `stride` parameter', function test( t ) { }); tape( 'the function supports a negative `stride` parameter', function test( t ) { - var N; var x; var v; From 9f4d882543cf90225491a2816b8bc9c5e08c133e Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Sun, 14 Apr 2024 17:37:59 -0400 Subject: [PATCH 5/8] chore: clean-up and changes to get CI to pass --- .../@stdlib/blas/ext/base/dsnansumors/README.md | 12 ++++++++++-- .../ext/base/dsnansumors/benchmark/benchmark.js | 15 +++++++++------ .../dsnansumors/benchmark/benchmark.native.js | 11 +++++++++-- .../dsnansumors/benchmark/benchmark.ndarray.js | 15 +++++++++------ .../benchmark/benchmark.ndarray.native.js | 11 +++++++++-- .../blas/ext/base/dsnansumors/examples/index.js | 12 ++++++++++-- .../ext/base/dsnansumors/test/test.dsnansumors.js | 4 +--- .../dsnansumors/test/test.dsnansumors.native.js | 12 +++--------- .../ext/base/dsnansumors/test/test.ndarray.js | 12 +++--------- .../base/dsnansumors/test/test.ndarray.native.js | 12 +++--------- 10 files changed, 66 insertions(+), 50 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md index 0eb2a867e8b3..32b5f2846b85 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md @@ -131,11 +131,19 @@ var v = dsnansumors.ndarray( 4, x, 2, 1 ); ```javascript -var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory; +var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ); +var bernoulli = require( '@stdlib/random/base/bernoulli' ); var filledarrayBy = require( '@stdlib/array/filled-by' ); var dsnansumors = require( '@stdlib/blas/ext/base/dsnansumors' ); -var x = filledarrayBy( 10, 'float32', discreteUniform( 0, 100 ) ); +function rand() { + if ( bernoulli( 0.8 ) > 0 ) { + return NaN; + } + return discreteUniform( 0, 100 ); +} + +var x = filledarrayBy( 10, 'float32', rand ); console.log( x ); var v = dsnansumors( x.length, x, 1 ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.js index 48abe33a6ce1..b59f5693376c 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.js @@ -21,7 +21,8 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var uniform = require( '@stdlib/random/base/uniform' ).factory; +var uniform = require( '@stdlib/random/base/uniform' ); +var bernoulli = require( '@stdlib/random/base/bernoulli' ); var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); @@ -29,11 +30,6 @@ var pkg = require( './../package.json' ).name; var dsnansumors = require( './../lib/dsnansumors.js' ); -// VARIABLES // - -var rand = uniform( -100.0, 100.0 ); - - // FUNCTIONS // /** @@ -47,6 +43,13 @@ function createBenchmark( len ) { var x = filledarrayBy( len, 'float32', rand ); return benchmark; + function rand() { + if ( bernoulli( 0.8 ) > 0 ) { + return NaN; + } + return uniform( -10, 10 ); + } + function benchmark( b ) { var v; var i; diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.native.js index aaa9087b982c..340e2af0c852 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.native.js @@ -22,7 +22,8 @@ var resolve = require( 'path' ).resolve; var bench = require( '@stdlib/bench' ); -var uniform = require( '@stdlib/random/base/uniform' ).factory; +var uniform = require( '@stdlib/random/base/uniform' ); +var bernoulli = require( '@stdlib/random/base/bernoulli' ); var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); @@ -36,7 +37,6 @@ var dsnansumors = tryRequire( resolve( __dirname, './../lib/dsnansumors.native.j var opts = { 'skip': ( dsnansumors instanceof Error ) }; -var rand = uniform( -100.0, 100.0 ); // FUNCTIONS // @@ -52,6 +52,13 @@ function createBenchmark( len ) { var x = filledarrayBy( len, 'float32', rand ); return benchmark; + function rand() { + if ( bernoulli( 0.8 ) > 0 ) { + return NaN; + } + return uniform( -10, 10 ); + } + function benchmark( b ) { var v; var i; diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.ndarray.js index db3da8c4df02..34bac8f6680f 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.ndarray.js @@ -21,7 +21,8 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var uniform = require( '@stdlib/random/base/uniform' ).factory; +var uniform = require( '@stdlib/random/base/uniform' ); +var bernoulli = require( '@stdlib/random/base/bernoulli' ); var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); @@ -29,11 +30,6 @@ var pkg = require( './../package.json' ).name; var dsnansumors = require( './../lib/ndarray.js' ); -// VARIABLES // - -var rand = uniform( -100.0, 100.0 ); - - // FUNCTIONS // /** @@ -47,6 +43,13 @@ function createBenchmark( len ) { var x = filledarrayBy( len, 'float32', rand ); return benchmark; + function rand() { + if ( bernoulli( 0.8 ) > 0 ) { + return NaN; + } + return uniform( -10, 10 ); + } + function benchmark( b ) { var v; var i; diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.ndarray.native.js index 679c5b38db4f..4dbdab3d80b4 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/benchmark/benchmark.ndarray.native.js @@ -22,7 +22,8 @@ var resolve = require( 'path' ).resolve; var bench = require( '@stdlib/bench' ); -var uniform = require( '@stdlib/random/base/uniform' ).factory; +var uniform = require( '@stdlib/random/base/uniform' ); +var bernoulli = require( '@stdlib/random/base/bernoulli' ); var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); @@ -36,7 +37,6 @@ var dsnansumors = tryRequire( resolve( __dirname, './../lib/ndarray.native.js' ) var opts = { 'skip': ( dsnansumors instanceof Error ) }; -var rand = uniform( -100.0, 100.0 ); // FUNCTIONS // @@ -52,6 +52,13 @@ function createBenchmark( len ) { var x = filledarrayBy( len, 'float32', rand ); return benchmark; + function rand() { + if ( bernoulli( 0.8 ) > 0 ) { + return NaN; + } + return uniform( -10, 10 ); + } + function benchmark( b ) { var v; var i; diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/examples/index.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/examples/index.js index 159a85c6d8a8..299e80873910 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/examples/index.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/examples/index.js @@ -18,11 +18,19 @@ 'use strict'; -var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory; +var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ); +var bernoulli = require( '@stdlib/random/base/bernoulli' ); var filledarrayBy = require( '@stdlib/array/filled-by' ); var dsnansumors = require( './../lib' ); -var x = filledarrayBy( 10, 'float32', discreteUniform( -100.0, 100.0 ) ); +function rand() { + if ( bernoulli( 0.8 ) > 0 ) { + return NaN; + } + return discreteUniform( 0, 100 ); +} + +var x = filledarrayBy( 10, 'float32', rand ); console.log( x ); var v = dsnansumors( x.length, x, 1 ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.js index 180f65f07d31..3a52a153b370 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.js @@ -165,7 +165,6 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f tape( 'the function supports view offsets', function test( t ) { var x0; var x1; - var N; var v; x0 = new Float32Array([ @@ -182,10 +181,9 @@ tape( 'the function supports view offsets', function test( t ) { NaN ]); - N = 5; x1 = new Float32Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element - v = dsnansumors( N, x1, 2 ); + v = dsnansumors( 5, x1, 2 ); t.strictEqual( v, 5.0, 'returns expected value' ); t.end(); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.native.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.native.js index 1e7988a501b0..3ce00ad14d66 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.dsnansumors.native.js @@ -196,7 +196,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first }); tape( 'the function supports a `stride` parameter', opts, function test( t ) { - var N; var x; var v; @@ -213,15 +212,13 @@ tape( 'the function supports a `stride` parameter', opts, function test( t ) { NaN ]); - N = 5; - v = dsnansumors( N, x, 2 ); + v = dsnansumors( 5, x, 2 ); t.strictEqual( v, 5.0, 'returns expected value' ); t.end(); }); tape( 'the function supports a negative `stride` parameter', opts, function test( t ) { - var N; var x; var v; @@ -238,8 +235,7 @@ tape( 'the function supports a negative `stride` parameter', opts, function test 2.0 ]); - N = 5; - v = dsnansumors( N, x, -2 ); + v = dsnansumors( 5, x, -2 ); t.strictEqual( v, 5.0, 'returns expected value' ); t.end(); @@ -260,7 +256,6 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f tape( 'the function supports view offsets', opts, function test( t ) { var x0; var x1; - var N; var v; x0 = new Float32Array([ @@ -277,10 +272,9 @@ tape( 'the function supports view offsets', opts, function test( t ) { NaN ]); - N = 5; x1 = new Float32Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element - v = dsnansumors( N, x1, 2 ); + v = dsnansumors( 5, x1, 2 ); t.strictEqual( v, 5.0, 'returns expected value' ); t.end(); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.ndarray.js index 1d4d1ac4e228..6851c5c60a52 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.ndarray.js @@ -105,7 +105,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first }); tape( 'the function supports a `stride` parameter', function test( t ) { - var N; var x; var v; @@ -122,15 +121,13 @@ tape( 'the function supports a `stride` parameter', function test( t ) { NaN ]); - N = 5; - v = dsnansumors( N, x, 2, 0 ); + v = dsnansumors( 5, x, 2, 0 ); t.strictEqual( v, 5.0, 'returns expected value' ); t.end(); }); tape( 'the function supports a negative `stride` parameter', function test( t ) { - var N; var x; var v; @@ -147,8 +144,7 @@ tape( 'the function supports a negative `stride` parameter', function test( t ) 2.0 ]); - N = 5; - v = dsnansumors( N, x, -2, 8 ); + v = dsnansumors( 5, x, -2, 8 ); t.strictEqual( v, 5.0, 'returns expected value' ); t.end(); @@ -167,7 +163,6 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f }); tape( 'the function supports an `offset` parameter', function test( t ) { - var N; var x; var v; @@ -183,9 +178,8 @@ tape( 'the function supports an `offset` parameter', function test( t ) { NaN, NaN // 4 ]); - N = 5; - v = dsnansumors( N, x, 2, 1 ); + v = dsnansumors( 5, x, 2, 1 ); t.strictEqual( v, 5.0, 'returns expected value' ); t.end(); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.ndarray.native.js index 9727fabbfa53..2308c15d48d8 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/test/test.ndarray.native.js @@ -114,7 +114,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first }); tape( 'the function supports a `stride` parameter', opts, function test( t ) { - var N; var x; var v; @@ -131,15 +130,13 @@ tape( 'the function supports a `stride` parameter', opts, function test( t ) { NaN ]); - N = 5; - v = dsnansumors( N, x, 2, 0 ); + v = dsnansumors( 5, x, 2, 0 ); t.strictEqual( v, 5.0, 'returns expected value' ); t.end(); }); tape( 'the function supports a negative `stride` parameter', opts, function test( t ) { - var N; var x; var v; @@ -156,8 +153,7 @@ tape( 'the function supports a negative `stride` parameter', opts, function test 2.0 ]); - N = 5; - v = dsnansumors( N, x, -2, 8 ); + v = dsnansumors( 5, x, -2, 8 ); t.strictEqual( v, 5.0, 'returns expected value' ); t.end(); @@ -176,7 +172,6 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f }); tape( 'the function supports an `offset` parameter', opts, function test( t ) { - var N; var x; var v; @@ -192,9 +187,8 @@ tape( 'the function supports an `offset` parameter', opts, function test( t ) { NaN, NaN // 4 ]); - N = 5; - v = dsnansumors( N, x, 2, 1 ); + v = dsnansumors( 5, x, 2, 1 ); t.strictEqual( v, 5.0, 'returns expected value' ); t.end(); From 5dce930fabf726993ff20763b094d508f2e15988 Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Sun, 14 Apr 2024 17:43:20 -0400 Subject: [PATCH 6/8] fix: update manifest.json --- .../blas/ext/base/dsnansumors/manifest.json | 87 ++++++++++++------- 1 file changed, 55 insertions(+), 32 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/manifest.json b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/manifest.json index bcacea431ad6..1d4f3e38bb6e 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/manifest.json +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/manifest.json @@ -3,56 +3,79 @@ "task": "build" }, "fields": [ - { - "field": "src", - "resolve": true, - "relative": true - }, - { - "field": "include", - "resolve": true, - "relative": true - }, - { - "field": "libraries", - "resolve": false, - "relative": false - }, - { - "field": "libpath", - "resolve": true, - "relative": false - } + { + "field": "src", + "resolve": true, + "relative": true + }, + { + "field": "include", + "resolve": true, + "relative": true + }, + { + "field": "libraries", + "resolve": false, + "relative": false + }, + { + "field": "libpath", + "resolve": true, + "relative": false + } ], "confs": [ { "task": "build", - "src": ["./src/dsnansumors.c"], - "include": ["./include"], - "libraries": ["-lm"], + "src": [ + "./src/dsnansumors.c" + ], + "include": [ + "./include" + ], + "libraries": [ + "-lm" + ], "libpath": [], "dependencies": [ "@stdlib/napi/export", "@stdlib/napi/argv", "@stdlib/napi/argv-int64", - "@stdlib/napi/argv-strided-float64array" + "@stdlib/napi/argv-strided-float64array", + "@stdlib/math/base/assert/is-nanf" ] }, { "task": "benchmark", - "src": ["./src/dsnansumors.c"], - "include": ["./include"], - "libraries": ["-lm"], + "src": [ + "./src/dsnansumors.c" + ], + "include": [ + "./include" + ], + "libraries": [ + "-lm" + ], "libpath": [], - "dependencies": [] + "dependencies": [ + "@stdlib/math/base/assert/is-nanf" + ] }, { "task": "examples", - "src": ["./src/dsnansumors.c"], - "include": ["./include"], - "libraries": ["-lm"], + "src": [ + "./src/dsnansumors.c" + ], + "include": [ + "./include" + ], + "libraries": [ + "-lm" + ], "libpath": [], - "dependencies": [] + "dependencies": [ + "@stdlib/math/base/assert/is-nanf" + ] } ] } From 436f547f8e3a02f5b642fbaa43e60d09ea3f745d Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Sun, 14 Apr 2024 17:47:43 -0400 Subject: [PATCH 7/8] fix: update dependency in manifest.json --- .../@stdlib/blas/ext/base/dsnansumors/manifest.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/manifest.json b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/manifest.json index 1d4f3e38bb6e..0ace6e04502b 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/manifest.json +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/manifest.json @@ -41,7 +41,7 @@ "@stdlib/napi/export", "@stdlib/napi/argv", "@stdlib/napi/argv-int64", - "@stdlib/napi/argv-strided-float64array", + "@stdlib/napi/argv-strided-float32array", "@stdlib/math/base/assert/is-nanf" ] }, From cbc89f879a49fed3cb3ecbc123fe300de35e2771 Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Sun, 14 Apr 2024 20:25:48 -0400 Subject: [PATCH 8/8] Update lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md Signed-off-by: Philipp Burckhardt --- lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md index 32b5f2846b85..477f900f3292 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md +++ b/lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md @@ -90,8 +90,8 @@ var Float32Array = require( '@stdlib/array/float32' ); var x = new Float32Array( [ 1.0, -2.0, NaN, 2.0 ] ); -var v = dsnansumors.ndarray( 2, x, 1, 0 ); -// returns -1 +var v = dsnansumors.ndarray( 4, x, 1, 0 ); +// returns 1.0 ``` The function has the following additional parameters: