From f42e54258e4fcb27a3d2750c1ac5eeef4cfa38f8 Mon Sep 17 00:00:00 2001 From: Ahmed Atwa Date: Fri, 8 Mar 2024 22:36:55 +0200 Subject: [PATCH 01/15] refactor: update implementation in accordance with current project conventions --- .../@stdlib/blas/ext/base/dapxsum/README.md | 36 ++--- .../ext/base/dapxsum/benchmark/benchmark.js | 17 ++- .../dapxsum/benchmark/benchmark.native.js | 13 +- .../dapxsum/benchmark/benchmark.ndarray.js | 17 ++- .../benchmark/benchmark.ndarray.native.js | 13 +- .../blas/ext/base/dapxsum/docs/repl.txt | 19 ++- .../blas/ext/base/dapxsum/examples/index.js | 13 +- .../blas/ext/base/dapxsum/include.gypi | 2 +- .../ext/base/dapxsum/lib/ndarray.native.js | 6 +- .../blas/ext/base/dapxsum/manifest.json | 4 + .../@stdlib/blas/ext/base/dapxsum/src/addon.c | 48 +++++++ .../blas/ext/base/dapxsum/src/addon.cpp | 130 ------------------ 12 files changed, 103 insertions(+), 215 deletions(-) create mode 100644 lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c delete mode 100644 lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.cpp diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/README.md b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/README.md index be6366e5a8c4..fe7ce986c0ec 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/README.md +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/README.md @@ -56,17 +56,15 @@ The function has the following parameters: - **x**: input [`Float64Array`][@stdlib/array/float64]. - **stride**: index increment for `x`. -The `N` and `stride` parameters determine which elements in `x` are accessed at runtime. For example, to access every other element in `x`, +The `N` and stride parameters determine which elements in the strided array are accessed at runtime. For example, to access every other element in `x`, ```javascript var Float64Array = require( '@stdlib/array/float64' ); -var floor = require( '@stdlib/math/base/special/floor' ); var x = new Float64Array( [ 1.0, 2.0, 2.0, -7.0, -2.0, 3.0, 4.0, 2.0 ] ); -var N = floor( x.length / 2 ); -var v = dapxsum( N, 5.0, x, 2 ); -// returns 25.0 +var v = dapxsum( 3, 5.0, x, 2 ); +// returns 16 ``` Note that indexing is relative to the first index. To introduce an offset, use [`typed array`][mdn-typed-array] views. @@ -75,15 +73,12 @@ Note that indexing is relative to the first index. To introduce an offset, use [ ```javascript var Float64Array = require( '@stdlib/array/float64' ); -var floor = require( '@stdlib/math/base/special/floor' ); var x0 = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); var x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element -var N = floor( x0.length / 2 ); - -var v = dapxsum( N, 5.0, x1, 2 ); -// returns 25.0 +var v = dapxsum( 3, 5.0, x1, 2 ); +// returns 16 ``` #### dapxsum.ndarray( N, alpha, x, stride, offset ) @@ -104,17 +99,15 @@ The function has the following additional parameters: - **offset**: starting index for `x`. -While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying `buffer`, the `offset` parameter supports indexing semantics based on a starting index. For example, to access every other value in `x` starting from the second value +While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying `buffer`, the offset parameter supports indexing semantics based on a starting index. For example, to access every other value in `x` starting from the second value ```javascript var Float64Array = require( '@stdlib/array/float64' ); -var floor = require( '@stdlib/math/base/special/floor' ); var x = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); -var N = floor( x.length / 2 ); -var v = dapxsum.ndarray( N, 5.0, x, 2, 1 ); -// returns 25.0 +var v = dapxsum.ndarray( 3, 5.0, x, 2, 1 ); +// returns 16 ``` @@ -138,18 +131,11 @@ var v = dapxsum.ndarray( N, 5.0, x, 2, 1 ); ```javascript -var randu = require( '@stdlib/random/base/randu' ); -var round = require( '@stdlib/math/base/special/round' ); -var Float64Array = require( '@stdlib/array/float64' ); +var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var dapxsum = require( '@stdlib/blas/ext/base/dapxsum' ); -var x; -var i; - -x = new Float64Array( 10 ); -for ( i = 0; i < x.length; i++ ) { - x[ i ] = round( randu()*100.0 ); -} +var x = filledarrayBy( 10, 'float32', discreteUniform( 0, 100 ) ); console.log( x ); var v = dapxsum( x.length, 5.0, x, 1 ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/benchmark/benchmark.js b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/benchmark/benchmark.js index f07b0af932e8..4ff710173b49 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/benchmark/benchmark.js @@ -21,14 +21,19 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/base/uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float64Array = require( '@stdlib/array/float64' ); var pkg = require( './../package.json' ).name; var dapxsum = require( './../lib/dapxsum.js' ); +// VARIABLES // + +var rand = uniform( -100.0, 100.0 ); + + // FUNCTIONS // /** @@ -39,13 +44,7 @@ var dapxsum = require( './../lib/dapxsum.js' ); * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float64Array( len ); - for ( i = 0; i < x.length; i++ ) { - x[ i ] = ( randu()*20.0 ) - 10.0; - } + var x = filledarrayBy( len, 'float64', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/benchmark/benchmark.native.js index 9db94ed9e77b..24d742e9bcf9 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/benchmark/benchmark.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/benchmark/benchmark.native.js @@ -22,10 +22,10 @@ var resolve = require( 'path' ).resolve; var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/base/uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float64Array = require( '@stdlib/array/float64' ); var tryRequire = require( '@stdlib/utils/try-require' ); var pkg = require( './../package.json' ).name; @@ -36,6 +36,7 @@ var dapxsum = tryRequire( resolve( __dirname, './../lib/dapxsum.native.js' ) ); var opts = { 'skip': ( dapxsum instanceof Error ) }; +var rand = uniform( -100.0, 100.0 ); // FUNCTIONS // @@ -48,13 +49,7 @@ var opts = { * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float64Array( len ); - for ( i = 0; i < x.length; i++ ) { - x[ i ] = ( randu()*20.0 ) - 10.0; - } + var x = filledarrayBy( len, 'float64', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/benchmark/benchmark.ndarray.js index 85d8773fa607..cc83b2dc3a22 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/benchmark/benchmark.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/benchmark/benchmark.ndarray.js @@ -21,14 +21,19 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/base/uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float64Array = require( '@stdlib/array/float64' ); var pkg = require( './../package.json' ).name; var dapxsum = require( './../lib/ndarray.js' ); +// VARIABLES // + +var rand = uniform( -100.0, 100.0 ); + + // FUNCTIONS // /** @@ -39,13 +44,7 @@ var dapxsum = require( './../lib/ndarray.js' ); * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float64Array( len ); - for ( i = 0; i < x.length; i++ ) { - x[ i ] = ( randu()*20.0 ) - 10.0; - } + var x = filledarrayBy( len, 'float64', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/benchmark/benchmark.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/benchmark/benchmark.ndarray.native.js index c6059a456140..a8f1618b4dd6 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/benchmark/benchmark.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/benchmark/benchmark.ndarray.native.js @@ -22,10 +22,10 @@ var resolve = require( 'path' ).resolve; var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/base/uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float64Array = require( '@stdlib/array/float64' ); var tryRequire = require( '@stdlib/utils/try-require' ); var pkg = require( './../package.json' ).name; @@ -36,6 +36,7 @@ var dapxsum = tryRequire( resolve( __dirname, './../lib/ndarray.native.js' ) ); var opts = { 'skip': ( dapxsum instanceof Error ) }; +var rand = uniform( -100.0, 100.0 ); // FUNCTIONS // @@ -48,13 +49,7 @@ var opts = { * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float64Array( len ); - for ( i = 0; i < x.length; i++ ) { - x[ i ] = ( randu()*20.0 ) - 10.0; - } + var x = filledarrayBy( len, 'float64', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt index 42592f2e60a6..9d39053a0111 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt @@ -3,8 +3,8 @@ Adds a constant to each double-precision floating-point strided array element and computes the sum. - The `N` and `stride` parameters determine which elements in `x` are accessed - at runtime. + The `N` and stride parameters determine which elements in the strided + array are accessed at runtime. Indexing is relative to the first index. To introduce an offset, use a typed array view. @@ -37,27 +37,26 @@ > {{alias}}( x.length, 5.0, x, 1 ) 16.0 - // Using `N` and `stride` parameters: + // Using `N` and stride parameters: > x = new {{alias:@stdlib/array/float64}}( [ -2.0, 1.0, 1.0, -5.0, 2.0, -1.0 ] ); - > var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 ); > var stride = 2; - > {{alias}}( N, 5.0, x, stride ) + > {{alias}}( 3, 5.0, x, stride ) 16.0 // Using view offsets: > var x0 = new {{alias:@stdlib/array/float64}}( [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0 ] ); > var x1 = new {{alias:@stdlib/array/float64}}( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); - > N = {{alias:@stdlib/math/base/special/floor}}( x0.length / 2 ); > stride = 2; - > {{alias}}( N, 5.0, x1, stride ) + > {{alias}}( 3, 5.0, x1, stride ) 14.0 + {{alias}}.ndarray( N, alpha, x, stride, offset ) Adds a constant to each double-precision floating-point strided array element and computes the sum using alternative indexing semantics. While typed array views mandate a view offset based on the underlying - buffer, the `offset` parameter supports indexing semantics based on a + buffer, the offset parameter supports indexing semantics based on a starting index. Parameters @@ -91,10 +90,8 @@ // Using offset parameter: > var x = new {{alias:@stdlib/array/float64}}( [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0 ] ); - > var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 ); - > {{alias}}.ndarray( N, 5.0, x, 2, 1 ) + > {{alias}}.ndarray( 3, 5.0, x, 2, 1 ) 14.0 See Also -------- - diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/examples/index.js b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/examples/index.js index cae9f87c6243..ed87ac09a122 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/examples/index.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/examples/index.js @@ -18,18 +18,11 @@ 'use strict'; -var randu = require( '@stdlib/random/base/randu' ); -var round = require( '@stdlib/math/base/special/round' ); -var Float64Array = require( '@stdlib/array/float64' ); +var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var dapxsum = require( './../lib' ); -var x; -var i; - -x = new Float64Array( 10 ); -for ( i = 0; i < x.length; i++ ) { - x[ i ] = round( randu()*100.0 ); -} +var x = filledarrayBy( 10, 'float32', discreteUniform( 0, 100 ) ); console.log( x ); var v = dapxsum( x.length, 5.0, x, 1 ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/include.gypi b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/include.gypi index 868c5c12e852..26476a8c2655 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/include.gypi +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/include.gypi @@ -36,7 +36,7 @@ # Source files: 'src_files': [ - '<(src_dir)/addon.cpp', + '<(src_dir)/addon.c', ' +#include + +/** +* Receives JavaScript callback invocation data. +* +* @private +* @param env environment under which the function is invoked +* @param info callback data +* @return Node-API value +*/ +static napi_value addon( napi_env env, napi_callback_info info ) { + STDLIB_NAPI_ARGV( env, info, argv, argc, 3 ); + STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 ); + STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 2 ); + STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 1 ); + + napi_value v; + napi_status status = napi_create_double( env, stdlib_strided_dapxsum( N, alpha, X, stride ), &v ); + assert( status == napi_ok ); + + return v; +} + +STDLIB_NAPI_MODULE_EXPORT_FCN( addon ) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.cpp b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.cpp deleted file mode 100644 index d03e71ac4f58..000000000000 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.cpp +++ /dev/null @@ -1,130 +0,0 @@ -/** -* @license Apache-2.0 -* -* Copyright (c) 2020 The Stdlib Authors. -* -* Licensed under the Apache License, Version 2.0 (the "License"); -* you may not use this file except in compliance with the License. -* You may obtain a copy of the License at -* -* http://www.apache.org/licenses/LICENSE-2.0 -* -* Unless required by applicable law or agreed to in writing, software -* distributed under the License is distributed on an "AS IS" BASIS, -* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -* See the License for the specific language governing permissions and -* limitations under the License. -*/ - -#include "stdlib/blas/ext/base/dapxsum.h" -#include -#include -#include -#include -#include - -/** -* Add-on namespace. -*/ -namespace stdlib_blas_ext_base_dapxsum { - - /** - * Adds a constant to each double-precision floating-point strided array element and computes the sum. - * - * ## Notes - * - * - When called from JavaScript, the function expects four arguments: - * - * - `N`: number of indexed elements - * - `alpha`: constant - * - `X`: input array - * - `stride`: stride length - */ - napi_value node_dapxsum( napi_env env, napi_callback_info info ) { - napi_status status; - - size_t argc = 4; - napi_value argv[ 4 ]; - status = napi_get_cb_info( env, info, &argc, argv, nullptr, nullptr ); - assert( status == napi_ok ); - - if ( argc < 4 ) { - napi_throw_error( env, nullptr, "invalid invocation. Must provide 4 arguments." ); - return nullptr; - } - - napi_valuetype vtype0; - status = napi_typeof( env, argv[ 0 ], &vtype0 ); - assert( status == napi_ok ); - if ( vtype0 != napi_number ) { - napi_throw_type_error( env, nullptr, "invalid argument. First argument must be a number." ); - return nullptr; - } - - napi_valuetype vtype1; - status = napi_typeof( env, argv[ 1 ], &vtype1 ); - assert( status == napi_ok ); - if ( vtype1 != napi_number ) { - napi_throw_type_error( env, nullptr, "invalid argument. Second argument must be a number." ); - return nullptr; - } - - bool res; - status = napi_is_typedarray( env, argv[ 2 ], &res ); - assert( status == napi_ok ); - if ( res == false ) { - napi_throw_type_error( env, nullptr, "invalid argument. Third argument must be a Float64Array." ); - return nullptr; - } - - napi_valuetype vtype3; - status = napi_typeof( env, argv[ 3 ], &vtype3 ); - assert( status == napi_ok ); - if ( vtype3 != napi_number ) { - napi_throw_type_error( env, nullptr, "invalid argument. Fourth argument must be a number." ); - return nullptr; - } - - int64_t N; - status = napi_get_value_int64( env, argv[ 0 ], &N ); - assert( status == napi_ok ); - - double alpha; - status = napi_get_value_double( env, argv[ 1 ], &alpha ); - assert( status == napi_ok ); - - int64_t stride; - status = napi_get_value_int64( env, argv[ 3 ], &stride ); - assert( status == napi_ok ); - - napi_typedarray_type vtype2; - size_t xlen; - void *X; - status = napi_get_typedarray_info( env, argv[ 2 ], &vtype2, &xlen, &X, nullptr, nullptr ); - assert( status == napi_ok ); - if ( vtype2 != napi_float64_array ) { - napi_throw_type_error( env, nullptr, "invalid argument. Third argument must be a Float64Array." ); - return nullptr; - } - if ( (N-1)*llabs(stride) >= (int64_t)xlen ) { - napi_throw_range_error( env, nullptr, "invalid argument. Third argument has insufficient elements based on the associated stride and the number of indexed elements." ); - return nullptr; - } - - napi_value v; - status = napi_create_double( env, stdlib_strided_dapxsum( N, alpha, (double *)X, stride ), &v ); - assert( status == napi_ok ); - - return v; - } - - napi_value Init( napi_env env, napi_value exports ) { - napi_status status; - napi_value fcn; - status = napi_create_function( env, "exports", NAPI_AUTO_LENGTH, node_dapxsum, NULL, &fcn ); - assert( status == napi_ok ); - return fcn; - } - - NAPI_MODULE( NODE_GYP_MODULE_NAME, Init ) -} // end namespace stdlib_blas_ext_base_dapxsum From cbfef39a258bd5e499e3e7c9c6e3de77b2578598 Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 24 Mar 2024 21:43:19 -0700 Subject: [PATCH 02/15] Apply suggestions from code review Signed-off-by: Athan --- .../@stdlib/blas/ext/base/dapxsum/README.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/README.md b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/README.md index fe7ce986c0ec..1c421942878e 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/README.md +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/README.md @@ -53,6 +53,7 @@ var v = dapxsum( N, 5.0, x, 1 ); The function has the following parameters: - **N**: number of indexed elements. +- **alpha**: scalar constant. - **x**: input [`Float64Array`][@stdlib/array/float64]. - **stride**: index increment for `x`. @@ -77,8 +78,8 @@ var Float64Array = require( '@stdlib/array/float64' ); var x0 = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); var x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element -var v = dapxsum( 3, 5.0, x1, 2 ); -// returns 16 +var v = dapxsum( 4, 5.0, x1, 2 ); +// returns 25.0 ``` #### dapxsum.ndarray( N, alpha, x, stride, offset ) @@ -106,8 +107,8 @@ var Float64Array = require( '@stdlib/array/float64' ); var x = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); -var v = dapxsum.ndarray( 3, 5.0, x, 2, 1 ); -// returns 16 +var v = dapxsum.ndarray( 4, 5.0, x, 2, 1 ); +// returns 25.0 ``` @@ -135,7 +136,7 @@ var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory; var filledarrayBy = require( '@stdlib/array/filled-by' ); var dapxsum = require( '@stdlib/blas/ext/base/dapxsum' ); -var x = filledarrayBy( 10, 'float32', discreteUniform( 0, 100 ) ); +var x = filledarrayBy( 10, 'float64', discreteUniform( 0, 100 ) ); console.log( x ); var v = dapxsum( x.length, 5.0, x, 1 ); From d5e42f3683e2effc5245c3256eb501e56ee441c3 Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 24 Mar 2024 21:43:55 -0700 Subject: [PATCH 03/15] Apply suggestions from code review Signed-off-by: Athan --- lib/node_modules/@stdlib/blas/ext/base/dapxsum/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/README.md b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/README.md index 1c421942878e..59e8e6805645 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/README.md +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/README.md @@ -64,8 +64,8 @@ var Float64Array = require( '@stdlib/array/float64' ); var x = new Float64Array( [ 1.0, 2.0, 2.0, -7.0, -2.0, 3.0, 4.0, 2.0 ] ); -var v = dapxsum( 3, 5.0, x, 2 ); -// returns 16 +var v = dapxsum( 4, 5.0, x, 2 ); +// returns 25.0 ``` Note that indexing is relative to the first index. To introduce an offset, use [`typed array`][mdn-typed-array] views. From f22648c7dacb369611acbc287ff6eb84e149bfba Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 24 Mar 2024 21:46:01 -0700 Subject: [PATCH 04/15] Apply suggestions from code review Signed-off-by: Athan --- .../@stdlib/blas/ext/base/dapxsum/docs/repl.txt | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt index 9d39053a0111..453ddf2253e7 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt @@ -39,15 +39,13 @@ // Using `N` and stride parameters: > x = new {{alias:@stdlib/array/float64}}( [ -2.0, 1.0, 1.0, -5.0, 2.0, -1.0 ] ); - > var stride = 2; - > {{alias}}( 3, 5.0, x, stride ) + > {{alias}}( 3, 5.0, x, 2 ) 16.0 // Using view offsets: > var x0 = new {{alias:@stdlib/array/float64}}( [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0 ] ); > var x1 = new {{alias:@stdlib/array/float64}}( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); - > stride = 2; - > {{alias}}( 3, 5.0, x1, stride ) + > {{alias}}( 3, 5.0, x1, 2 ) 14.0 From a6d964e724fe152f896aac8690dc7eebf4bfc062 Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 24 Mar 2024 21:46:49 -0700 Subject: [PATCH 05/15] Apply suggestions from code review Signed-off-by: Athan --- lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt index 453ddf2253e7..05ef1f13917e 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt @@ -93,3 +93,4 @@ See Also -------- + From 92f0d220bb789c4069098cf0e5ee4337e1f68a2b Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 24 Mar 2024 21:47:11 -0700 Subject: [PATCH 06/15] Apply suggestions from code review Signed-off-by: Athan --- lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt index 05ef1f13917e..b4380e2e5a6c 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/docs/repl.txt @@ -87,7 +87,7 @@ 16.0 // Using offset parameter: - > var x = new {{alias:@stdlib/array/float64}}( [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0 ] ); + > x = new {{alias:@stdlib/array/float64}}( [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0 ] ); > {{alias}}.ndarray( 3, 5.0, x, 2, 1 ) 14.0 From aaaededcbb6c3ba0c4ebc99131a80ce237ab3f24 Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 24 Mar 2024 21:47:35 -0700 Subject: [PATCH 07/15] Apply suggestions from code review Signed-off-by: Athan --- .../@stdlib/blas/ext/base/dapxsum/examples/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/examples/index.js b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/examples/index.js index ed87ac09a122..139c53c4876a 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/examples/index.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/examples/index.js @@ -22,7 +22,7 @@ var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory; var filledarrayBy = require( '@stdlib/array/filled-by' ); var dapxsum = require( './../lib' ); -var x = filledarrayBy( 10, 'float32', discreteUniform( 0, 100 ) ); +var x = filledarrayBy( 10, 'float64', discreteUniform( 0, 100 ) ); console.log( x ); var v = dapxsum( x.length, 5.0, x, 1 ); From ea14302fce9bcea4773c563bb72f350725e6d978 Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 24 Mar 2024 21:48:23 -0700 Subject: [PATCH 08/15] Apply suggestions from code review Signed-off-by: Athan --- .../@stdlib/blas/ext/base/dapxsum/lib/ndarray.native.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/lib/ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/lib/ndarray.native.js index 24cb7d568566..83ff845003b4 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/lib/ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/lib/ndarray.native.js @@ -50,9 +50,6 @@ var addon = require( './dapxsum.native.js' ); function dapxsum( N, alpha, x, stride, offset ) { var view; offset = minViewBufferIndex( N, stride, offset ); - if ( stride < 0 ) { - offset += (N-1) * stride; - } view = offsetView( x, offset ); return addon( N, alpha, view, stride ); } From 4c9f48a5db966a3f46c65f4d759067f56e2acf47 Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 24 Mar 2024 21:50:11 -0700 Subject: [PATCH 09/15] Apply suggestions from code review Signed-off-by: Athan --- lib/node_modules/@stdlib/blas/ext/base/dapxsum/manifest.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/manifest.json b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/manifest.json index 32e11b1786b6..d68ecd714c00 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/manifest.json +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/manifest.json @@ -37,7 +37,7 @@ "dependencies": [ "@stdlib/napi/export", "@stdlib/napi/argv", - "@stdlib/napi/argv-float", + "@stdlib/napi/argv-double", "@stdlib/napi/argv-int64", "@stdlib/blas/ext/base/dapxsumkbn" ] From 7ec749123c855cea391a9e474c3269e9ca579c8f Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 24 Mar 2024 21:50:58 -0700 Subject: [PATCH 10/15] Apply suggestions from code review Signed-off-by: Athan --- lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c index 01f605405829..a2765484f25c 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c @@ -20,6 +20,7 @@ #include "stdlib/napi/export.h" #include "stdlib/napi/argv.h" #include "stdlib/napi/argv_int64.h" +#include "stdlib/napi/argv_double.h" #include "stdlib/napi/argv_strided_float32array.h" #include #include From dd8a81e85d7ad82f6a3250aea551e66beac3c388 Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 24 Mar 2024 21:51:08 -0700 Subject: [PATCH 11/15] Apply suggestions from code review Signed-off-by: Athan --- lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c index a2765484f25c..13572362550a 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c @@ -21,7 +21,7 @@ #include "stdlib/napi/argv.h" #include "stdlib/napi/argv_int64.h" #include "stdlib/napi/argv_double.h" -#include "stdlib/napi/argv_strided_float32array.h" +#include "stdlib/napi/argv_strided_float64array.h" #include #include From 5c922e88239500a2e3306cf9455577d8b2d6e8db Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 24 Mar 2024 21:52:18 -0700 Subject: [PATCH 12/15] Apply suggestions from code review Signed-off-by: Athan --- lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c index 13572362550a..80ad28899c24 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c @@ -34,10 +34,11 @@ * @return Node-API value */ static napi_value addon( napi_env env, napi_callback_info info ) { - STDLIB_NAPI_ARGV( env, info, argv, argc, 3 ); + STDLIB_NAPI_ARGV( env, info, argv, argc, 4 ); STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 ); - STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 2 ); - STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 1 ); + STDLIB_NAPI_ARGV_DOUBLE( env, alpha, argv, 1 ); + STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 3 ); + STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 2 ); napi_value v; napi_status status = napi_create_double( env, stdlib_strided_dapxsum( N, alpha, X, stride ), &v ); From 4a154cf6b719c336b3db2ad08753250eb1d2788e Mon Sep 17 00:00:00 2001 From: Ahmed Atwa Date: Mon, 25 Mar 2024 13:07:29 +0200 Subject: [PATCH 13/15] feat: add missing build configurations --- .../blas/ext/base/dapxsum/manifest.json | 109 +++++++++++------- 1 file changed, 69 insertions(+), 40 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/manifest.json b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/manifest.json index d68ecd714c00..3ce729f15799 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/manifest.json +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/manifest.json @@ -1,46 +1,75 @@ { - "options": {}, - "fields": [ - { - "field": "src", - "resolve": true, - "relative": true - }, - { - "field": "include", - "resolve": true, - "relative": true - }, - { - "field": "libraries", - "resolve": false, - "relative": false - }, - { - "field": "libpath", - "resolve": true, - "relative": false - } - ], - "confs": [ - { - "src": [ - "./src/dapxsum.c" - ], - "include": [ - "./include" - ], - "libraries": [ - "-lm" - ], - "libpath": [], - "dependencies": [ + "options": {}, + "fields": [ + { + "field": "src", + "resolve": true, + "relative": true + }, + { + "field": "include", + "resolve": true, + "relative": true + }, + { + "field": "libraries", + "resolve": false, + "relative": false + }, + { + "field": "libpath", + "resolve": true, + "relative": false + } + ], + "confs": [ + { + "task": "build", + "src": [ + "./src/dapxsum.c" + ], + "include": [ + "./include" + ], + "libraries": [ + "-lm" + ], + "libpath": [], + "dependencies": [ "@stdlib/napi/export", "@stdlib/napi/argv", "@stdlib/napi/argv-double", "@stdlib/napi/argv-int64", - "@stdlib/blas/ext/base/dapxsumkbn" - ] - } - ] + "@stdlib/blas/ext/base/dapxsumkbn" + ] + }, + { + "task": "benchmark", + "src": [ + "./src/dapxsum.c" + ], + "include": [ + "./include" + ], + "libraries": [ + "-lm" + ], + "libpath": [], + "dependencies": [] + }, + { + "task": "examples", + "src": [ + "./src/dapxsum.c" + ], + "include": [ + "./include" + ], + "libraries": [ + "-lm" + ], + "libpath": [], + "dependencies": [] + } + ] } From 8e4995147dad7f74f530c88a3b5856fc7518bc03 Mon Sep 17 00:00:00 2001 From: Ahmed Atwa Date: Mon, 25 Mar 2024 13:24:15 +0200 Subject: [PATCH 14/15] docs: fix remaining missing changes --- .../@stdlib/blas/ext/base/dapxsum/lib/index.js | 7 ++----- .../@stdlib/blas/ext/base/dapxsum/lib/ndarray.js | 4 +--- .../blas/ext/base/dapxsum/lib/ndarray.native.js | 4 +--- .../blas/ext/base/dapxsum/test/test.dapxsum.js | 15 ++++----------- .../ext/base/dapxsum/test/test.dapxsum.native.js | 15 ++++----------- .../blas/ext/base/dapxsum/test/test.ndarray.js | 15 ++++----------- .../ext/base/dapxsum/test/test.ndarray.native.js | 13 +++---------- 7 files changed, 19 insertions(+), 54 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/lib/index.js b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/lib/index.js index 10ce15d0126b..d1369a5758e2 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/lib/index.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/lib/index.js @@ -28,20 +28,17 @@ * var dapxsum = require( '@stdlib/blas/ext/base/dapxsum' ); * * var x = new Float64Array( [ 1.0, -2.0, 2.0 ] ); -* var N = x.length; * -* var v = dapxsum( N, 5.0, x, 1 ); +* var v = dapxsum( 3, 5.0, x, 1 ); * // returns 16.0 * * @example * var Float64Array = require( '@stdlib/array/float64' ); -* var floor = require( '@stdlib/math/base/special/floor' ); * var dapxsum = require( '@stdlib/blas/ext/base/dapxsum' ); * * var x = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); -* var N = floor( x.length / 2 ); * -* var v = dapxsum.ndarray( N, 5.0, x, 2, 1 ); +* var v = dapxsum.ndarray( 4, 5.0, x, 2, 1 ); * // returns 25.0 */ diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/lib/ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/lib/ndarray.js index d4c776e9c7ba..c9c326b9c398 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/lib/ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/lib/ndarray.js @@ -37,12 +37,10 @@ var dapxsumkbn = require( '@stdlib/blas/ext/base/dapxsumkbn' ).ndarray; * * @example * var Float64Array = require( '@stdlib/array/float64' ); -* var floor = require( '@stdlib/math/base/special/floor' ); * * var x = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); -* var N = floor( x.length / 2 ); * -* var v = dapxsum( N, 5.0, x, 2, 1 ); +* var v = dapxsum( 4, 5.0, x, 2, 1 ); * // returns 25.0 */ function dapxsum( N, alpha, x, stride, offset ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/lib/ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/lib/ndarray.native.js index 83ff845003b4..c8fbbabe9dda 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/lib/ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/lib/ndarray.native.js @@ -39,12 +39,10 @@ var addon = require( './dapxsum.native.js' ); * * @example * var Float64Array = require( '@stdlib/array/float64' ); -* var floor = require( '@stdlib/math/base/special/floor' ); * * var x = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); -* var N = floor( x.length / 2 ); * -* var v = dapxsum( N, 5.0, x, 2, 1 ); +* var v = dapxsum( 4, 5.0, x, 2, 1 ); * // returns 25.0 */ function dapxsum( N, alpha, x, stride, offset ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/test/test.dapxsum.js b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/test/test.dapxsum.js index 34aef5bb3159..e1e504910961 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/test/test.dapxsum.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/test/test.dapxsum.js @@ -21,7 +21,6 @@ // MODULES // var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var Float64Array = require( '@stdlib/array/float64' ); var dapxsum = require( './../lib/dapxsum.js' ); @@ -36,7 +35,7 @@ tape( 'main export is a function', function test( t ) { }); tape( 'the function has an arity of 4', function test( t ) { - t.strictEqual( dapxsum.length, 4, 'has expected arity' ); + t.strictEqual( dapxsum.length, 4, 'returns expected value' ); t.end(); }); @@ -95,7 +94,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first }); tape( 'the function supports a `stride` parameter', function test( t ) { - var N; var x; var v; @@ -110,15 +108,13 @@ tape( 'the function supports a `stride` parameter', function test( t ) { 2.0 ]); - N = floor( x.length / 2 ); - v = dapxsum( N, 5.0, x, 2 ); + v = dapxsum( 4, 5.0, x, 2 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); }); tape( 'the function supports a negative `stride` parameter', function test( t ) { - var N; var x; var v; @@ -133,8 +129,7 @@ tape( 'the function supports a negative `stride` parameter', function test( t ) 2.0 ]); - N = floor( x.length / 2 ); - v = dapxsum( N, 5.0, x, -2 ); + v = dapxsum( 4, 5.0, x, -2 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); @@ -155,7 +150,6 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f tape( 'the function supports view offsets', function test( t ) { var x0; var x1; - var N; var v; x0 = new Float64Array([ @@ -171,9 +165,8 @@ tape( 'the function supports view offsets', function test( t ) { ]); x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element - N = floor(x1.length / 2); - v = dapxsum( N, 5.0, x1, 2 ); + v = dapxsum( 4, 5.0, x1, 2 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/test/test.dapxsum.native.js b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/test/test.dapxsum.native.js index ebcdf8f52ea1..517bea646e02 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/test/test.dapxsum.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/test/test.dapxsum.native.js @@ -22,7 +22,6 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var Float64Array = require( '@stdlib/array/float64' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -45,7 +44,7 @@ tape( 'main export is a function', opts, function test( t ) { }); tape( 'the function has an arity of 4', opts, function test( t ) { - t.strictEqual( dapxsum.length, 4, 'has expected arity' ); + t.strictEqual( dapxsum.length, 4, 'returns expected value' ); t.end(); }); @@ -213,7 +212,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first }); tape( 'the function supports a `stride` parameter', opts, function test( t ) { - var N; var x; var v; @@ -228,15 +226,13 @@ tape( 'the function supports a `stride` parameter', opts, function test( t ) { 2.0 ]); - N = floor( x.length / 2 ); - v = dapxsum( N, 5.0, x, 2 ); + v = dapxsum( 4, 5.0, x, 2 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); }); tape( 'the function supports a negative `stride` parameter', opts, function test( t ) { - var N; var x; var v; @@ -251,8 +247,7 @@ tape( 'the function supports a negative `stride` parameter', opts, function test 2.0 ]); - N = floor( x.length / 2 ); - v = dapxsum( N, 5.0, x, -2 ); + v = dapxsum( 4, 5.0, x, -2 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); @@ -273,7 +268,6 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f tape( 'the function supports view offsets', opts, function test( t ) { var x0; var x1; - var N; var v; x0 = new Float64Array([ @@ -289,9 +283,8 @@ tape( 'the function supports view offsets', opts, function test( t ) { ]); x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element - N = floor(x1.length / 2); - v = dapxsum( N, 5.0, x1, 2 ); + v = dapxsum( 4, 5.0, x1, 2 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/test/test.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/test/test.ndarray.js index e8cfe2f682df..541719cb7fb6 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/test/test.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/test/test.ndarray.js @@ -21,7 +21,6 @@ // MODULES // var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var Float64Array = require( '@stdlib/array/float64' ); var dapxsum = require( './../lib/ndarray.js' ); @@ -36,7 +35,7 @@ tape( 'main export is a function', function test( t ) { }); tape( 'the function has an arity of 5', function test( t ) { - t.strictEqual( dapxsum.length, 5, 'has expected arity' ); + t.strictEqual( dapxsum.length, 5, 'returns expected value' ); t.end(); }); @@ -95,7 +94,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first }); tape( 'the function supports a `stride` parameter', function test( t ) { - var N; var x; var v; @@ -110,15 +108,13 @@ tape( 'the function supports a `stride` parameter', function test( t ) { 2.0 ]); - N = floor( x.length / 2 ); - v = dapxsum( N, 5.0, x, 2, 0 ); + v = dapxsum( 4, 5.0, x, 2, 0 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); }); tape( 'the function supports a negative `stride` parameter', function test( t ) { - var N; var x; var v; @@ -133,8 +129,7 @@ tape( 'the function supports a negative `stride` parameter', function test( t ) 2.0 ]); - N = floor( x.length / 2 ); - v = dapxsum( N, 5.0, x, -2, 6 ); + v = dapxsum( 4, 5.0, x, -2, 6 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); @@ -153,7 +148,6 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f }); tape( 'the function supports an `offset` parameter', function test( t ) { - var N; var x; var v; @@ -167,9 +161,8 @@ tape( 'the function supports an `offset` parameter', function test( t ) { 3.0, 4.0 // 3 ]); - N = floor( x.length / 2 ); - v = dapxsum( N, 5.0, x, 2, 1 ); + v = dapxsum( 4, 5.0, x, 2, 1 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/test/test.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/test/test.ndarray.native.js index 6bc30225fcd6..e0d251264d0d 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/test/test.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/test/test.ndarray.native.js @@ -22,7 +22,6 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var Float64Array = require( '@stdlib/array/float64' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -104,7 +103,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first }); tape( 'the function supports a `stride` parameter', opts, function test( t ) { - var N; var x; var v; @@ -119,15 +117,13 @@ tape( 'the function supports a `stride` parameter', opts, function test( t ) { 2.0 ]); - N = floor( x.length / 2 ); - v = dapxsum( N, 5.0, x, 2, 0 ); + v = dapxsum( 4, 5.0, x, 2, 0 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); }); tape( 'the function supports a negative `stride` parameter', opts, function test( t ) { - var N; var x; var v; @@ -142,8 +138,7 @@ tape( 'the function supports a negative `stride` parameter', opts, function test 2.0 ]); - N = floor( x.length / 2 ); - v = dapxsum( N, 5.0, x, -2, 6 ); + v = dapxsum( 4, 5.0, x, -2, 6 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); @@ -162,7 +157,6 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f }); tape( 'the function supports an `offset` parameter', opts, function test( t ) { - var N; var x; var v; @@ -176,9 +170,8 @@ tape( 'the function supports an `offset` parameter', opts, function test( t ) { 3.0, 4.0 // 3 ]); - N = floor( x.length / 2 ); - v = dapxsum( N, 5.0, x, 2, 1 ); + v = dapxsum( 4, 5.0, x, 2, 1 ); t.strictEqual( v, 25.0, 'returns expected value' ); t.end(); From f2a2a9d3b70781dd2b1a49d7ccc15d1c36ea90d9 Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Tue, 26 Mar 2024 09:39:02 -0400 Subject: [PATCH 15/15] Apply suggestions from code review Signed-off-by: Philipp Burckhardt --- lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c index 80ad28899c24..4222fc7cd220 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c +++ b/lib/node_modules/@stdlib/blas/ext/base/dapxsum/src/addon.c @@ -37,8 +37,8 @@ static napi_value addon( napi_env env, napi_callback_info info ) { STDLIB_NAPI_ARGV( env, info, argv, argc, 4 ); STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 ); STDLIB_NAPI_ARGV_DOUBLE( env, alpha, argv, 1 ); - STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 3 ); - STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 2 ); + STDLIB_NAPI_ARGV_INT64( env, stride, argv, 3 ); + STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, stride, argv, 2 ); napi_value v; napi_status status = napi_create_double( env, stdlib_strided_dapxsum( N, alpha, X, stride ), &v );