From de359f4c58102280734212bb3aba812a21c0d1f8 Mon Sep 17 00:00:00 2001 From: kunal Dugar Date: Wed, 6 Mar 2024 10:48:40 +0530 Subject: [PATCH 1/4] I have make the necessary changes to refactor sdssum to follow current project convention --- .../ext/base/sdssum/benchmark/benchmark.js | 17 +- .../base/sdssum/benchmark/benchmark.native.js | 14 +- .../sdssum/benchmark/benchmark.ndarray.js | 19 +-- .../benchmark/benchmark.ndarray.native.js | 15 +- .../blas/ext/base/sdssum/examples/index.js | 16 +- .../@stdlib/blas/ext/base/sdssum/include.gypi | 2 +- .../ext/base/sdssum/lib/ndarray.native.js | 6 +- .../blas/ext/base/sdssum/manifest.json | 146 +++++++++++++++++- .../@stdlib/blas/ext/base/sdssum/src/addon.c | 49 ++++++ .../blas/ext/base/sdssum/src/addon.cpp | 117 -------------- .../blas/ext/base/sdssum/test/test.ndarray.js | 2 +- .../base/sdssum/test/test.ndarray.native.js | 2 +- .../blas/ext/base/sdssum/test/test.sdssum.js | 6 +- .../base/sdssum/test/test.sdssum.native.js | 4 +- 14 files changed, 236 insertions(+), 179 deletions(-) create mode 100644 lib/node_modules/@stdlib/blas/ext/base/sdssum/src/addon.c delete mode 100644 lib/node_modules/@stdlib/blas/ext/base/sdssum/src/addon.cpp diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.js index 45ad56d28e32..3b03897c0b80 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.js @@ -21,14 +21,19 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/base/uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float32Array = require( '@stdlib/array/float32' ); + var pkg = require( './../package.json' ).name; var sdssum = require( './../lib/sdssum.js' ); +// VARIABLES // + +var rand = uniform( -100.0, 100.0 ); + // FUNCTIONS // /** @@ -39,13 +44,7 @@ var sdssum = require( './../lib/sdssum.js' ); * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float32Array( len ); - for ( i = 0; i < x.length; i++ ) { - x[ i ] = ( randu()*10.0 ) - 20.0; - } + var x = filledarrayBy( len, 'float64', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.native.js index 9fc27ec9a9df..82a7abc467a0 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.native.js @@ -22,10 +22,11 @@ var resolve = require( 'path' ).resolve; var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/base/uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float32Array = require( '@stdlib/array/float32' ); + var tryRequire = require( '@stdlib/utils/try-require' ); var pkg = require( './../package.json' ).name; @@ -36,6 +37,7 @@ var sdssum = tryRequire( resolve( __dirname, './../lib/sdssum.native.js' ) ); var opts = { 'skip': ( sdssum instanceof Error ) }; +var rand = uniform( -100.0, 100.0 ); // FUNCTIONS // @@ -48,13 +50,7 @@ var opts = { * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float32Array( len ); - for ( i = 0; i < x.length; i++ ) { - x[ i ] = ( randu()*10.0 ) - 20.0; - } + var x = filledarrayBy( len, 'float64', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.js index 47369512a264..d30787e986b1 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.js @@ -21,14 +21,21 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/base/uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float32Array = require( '@stdlib/array/float32' ); + var pkg = require( './../package.json' ).name; var sdssum = require( './../lib/ndarray.js' ); + +// VARIABLES // + +var rand = uniform( -100.0, 100.0 ); + + // FUNCTIONS // /** @@ -39,13 +46,7 @@ var sdssum = require( './../lib/ndarray.js' ); * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float32Array( len ); - for ( i = 0; i < x.length; i++ ) { - x[ i ] = ( randu()*10.0 ) - 20.0; - } + var x = filledarrayBy( len, 'float64', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.native.js index 5c1eabd5195b..0b4d8a0e9637 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.native.js @@ -22,10 +22,11 @@ var resolve = require( 'path' ).resolve; var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); +var uniform = require( '@stdlib/random/base/uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); -var Float32Array = require( '@stdlib/array/float32' ); + var tryRequire = require( '@stdlib/utils/try-require' ); var pkg = require( './../package.json' ).name; @@ -36,7 +37,7 @@ var sdssum = tryRequire( resolve( __dirname, './../lib/ndarray.native.js' ) ); var opts = { 'skip': ( sdssum instanceof Error ) }; - +var rand = uniform( -100.0, 100.0 ); // FUNCTIONS // @@ -48,13 +49,7 @@ var opts = { * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = new Float32Array( len ); - for ( i = 0; i < x.length; i++ ) { - x[ i ] = ( randu()*10.0 ) - 20.0; - } + var x = filledarrayBy( len, 'float64', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/examples/index.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/examples/index.js index de37a237b1fa..4ae7cdf9ee85 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/examples/index.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/examples/index.js @@ -18,19 +18,13 @@ 'use strict'; -var randu = require( '@stdlib/random/base/randu' ); -var round = require( '@stdlib/math/base/special/round' ); -var Float32Array = require( '@stdlib/array/float32' ); +var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory; +var filledarrayBy = require( '@stdlib/array/filled-by' ); var sdssum = require( './../lib' ); -var x; -var i; -x = new Float32Array( 10 ); -for ( i = 0; i < x.length; i++ ) { - x[ i ] = round( randu()*100.0 ); -} +var x = filledarrayBy( 10, 'float64', discreteUniform( -100, 100 ) ); console.log( x ); -var v = sdssum( x.length, x, 1 ); -console.log( v ); +var y = sdssum( x.length, x, 1 ); +console.log( y ); \ No newline at end of file diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/include.gypi b/lib/node_modules/@stdlib/blas/ext/base/sdssum/include.gypi index 868c5c12e852..26476a8c2655 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/include.gypi +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/include.gypi @@ -36,7 +36,7 @@ # Source files: 'src_files': [ - '<(src_dir)/addon.cpp', + '<(src_dir)/addon.c', ' +#include + +/** + * Receives JavaScript callback invocation data. + * + * @private + * @param env environment under which the function is invoked + * @param info callback data + * @return Node-API value + */ +static napi_value addon(napi_env env, napi_callback_info info) +{ + STDLIB_NAPI_ARGV(env, info, argv, argc, 3); + STDLIB_NAPI_ARGV_INT64(env, N, argv, 0); + STDLIB_NAPI_ARGV_INT64(env, strideX, argv, 2); + STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY(env, X, N, strideX, argv, 1); + + napi_value v; + napi_status status = napi_create_double(env, c_sdssum(N, (double *)X, strideX), &v); + assert(status == napi_ok); + + return v; +} + +STDLIB_NAPI_MODULE_EXPORT_FCN(addon) \ No newline at end of file diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/src/addon.cpp b/lib/node_modules/@stdlib/blas/ext/base/sdssum/src/addon.cpp deleted file mode 100644 index 430e6989a8a9..000000000000 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/src/addon.cpp +++ /dev/null @@ -1,117 +0,0 @@ -/** -* @license Apache-2.0 -* -* Copyright (c) 2020 The Stdlib Authors. -* -* Licensed under the Apache License, Version 2.0 (the "License"); -* you may not use this file except in compliance with the License. -* You may obtain a copy of the License at -* -* http://www.apache.org/licenses/LICENSE-2.0 -* -* Unless required by applicable law or agreed to in writing, software -* distributed under the License is distributed on an "AS IS" BASIS, -* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -* See the License for the specific language governing permissions and -* limitations under the License. -*/ - -#include "stdlib/blas/ext/base/sdssum.h" -#include -#include -#include -#include -#include - -/** -* Add-on namespace. -*/ -namespace stdlib_blas_ext_base_sdssum { - - /** - * Computes the sum of single-precision floating-point strided array elements using extended accumulation. - * - * ## Notes - * - * - When called from JavaScript, the function expects three arguments: - * - * - `N`: number of indexed elements - * - `X`: input array - * - `stride`: stride length - */ - napi_value node_sdssum( napi_env env, napi_callback_info info ) { - napi_status status; - - size_t argc = 3; - napi_value argv[ 3 ]; - status = napi_get_cb_info( env, info, &argc, argv, nullptr, nullptr ); - assert( status == napi_ok ); - - if ( argc < 3 ) { - napi_throw_error( env, nullptr, "invalid invocation. Must provide 3 arguments." ); - return nullptr; - } - - napi_valuetype vtype0; - status = napi_typeof( env, argv[ 0 ], &vtype0 ); - assert( status == napi_ok ); - if ( vtype0 != napi_number ) { - napi_throw_type_error( env, nullptr, "invalid argument. First argument must be a number." ); - return nullptr; - } - - bool res; - status = napi_is_typedarray( env, argv[ 1 ], &res ); - assert( status == napi_ok ); - if ( res == false ) { - napi_throw_type_error( env, nullptr, "invalid argument. Second argument must be a Float32Array." ); - return nullptr; - } - - napi_valuetype vtype2; - status = napi_typeof( env, argv[ 2 ], &vtype2 ); - assert( status == napi_ok ); - if ( vtype2 != napi_number ) { - napi_throw_type_error( env, nullptr, "invalid argument. Third argument must be a number." ); - return nullptr; - } - - int64_t N; - status = napi_get_value_int64( env, argv[ 0 ], &N ); - assert( status == napi_ok ); - - int64_t stride; - status = napi_get_value_int64( env, argv[ 2 ], &stride ); - assert( status == napi_ok ); - - napi_typedarray_type vtype1; - size_t xlen; - void *X; - status = napi_get_typedarray_info( env, argv[ 1 ], &vtype1, &xlen, &X, nullptr, nullptr ); - assert( status == napi_ok ); - if ( vtype1 != napi_float32_array ) { - napi_throw_type_error( env, nullptr, "invalid argument. Second argument must be a Float32Array." ); - return nullptr; - } - if ( (N-1)*llabs(stride) >= (int64_t)xlen ) { - napi_throw_range_error( env, nullptr, "invalid argument. Second argument has insufficient elements based on the associated stride and the number of indexed elements." ); - return nullptr; - } - - napi_value v; - status = napi_create_double( env, (double)stdlib_strided_sdssum( N, (float *)X, stride ), &v ); - assert( status == napi_ok ); - - return v; - } - - napi_value Init( napi_env env, napi_value exports ) { - napi_status status; - napi_value fcn; - status = napi_create_function( env, "exports", NAPI_AUTO_LENGTH, node_sdssum, NULL, &fcn ); - assert( status == napi_ok ); - return fcn; - } - - NAPI_MODULE( NODE_GYP_MODULE_NAME, Init ) -} // end namespace stdlib_blas_ext_base_sdssum diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.js index 104dfe998dd7..e2a858fca5a6 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.js @@ -36,7 +36,7 @@ tape( 'main export is a function', function test( t ) { }); tape( 'the function has an arity of 4', function test( t ) { - t.strictEqual( sdssum.length, 4, 'has expected arity' ); + t.strictEqual( sdssum.length, 4, 'returns expected value' ); t.end(); }); diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.native.js index 0f15411fbc47..9a631047a07e 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.native.js @@ -45,7 +45,7 @@ tape( 'main export is a function', opts, function test( t ) { }); tape( 'the function has an arity of 4', opts, function test( t ) { - t.strictEqual( sdssum.length, 4, 'has expected arity' ); + t.strictEqual( sdssum.length, 4, 'returns expected value' ); t.end(); }); diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.sdssum.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.sdssum.js index e021071a69a7..dad9ce4cb363 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.sdssum.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.sdssum.js @@ -21,7 +21,7 @@ // MODULES // var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); + var isnan = require( '@stdlib/math/base/assert/is-nan' ); var Float32Array = require( '@stdlib/array/float32' ); var sdssum = require( './../lib/sdssum.js' ); @@ -36,7 +36,7 @@ tape( 'main export is a function', function test( t ) { }); tape( 'the function has an arity of 3', function test( t ) { - t.strictEqual( sdssum.length, 3, 'has expected arity' ); + t.strictEqual( sdssum.length, 3, 'returns expected value' ); t.end(); }); @@ -118,7 +118,7 @@ tape( 'the function supports a `stride` parameter', function test( t ) { 2.0 ]); - N = floor( x.length / 2 ); + N = 3; v = sdssum( N, x, 2 ); t.strictEqual( v, 5.0, 'returns expected value' ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.sdssum.native.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.sdssum.native.js index d4768789037f..2cc8b002563e 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.sdssum.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.sdssum.native.js @@ -22,7 +22,7 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); + var isnan = require( '@stdlib/math/base/assert/is-nan' ); var Float32Array = require( '@stdlib/array/float32' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -209,7 +209,7 @@ tape( 'the function supports a `stride` parameter', opts, function test( t ) { 2.0 ]); - N = floor( x.length / 2 ); + N = 3; v = sdssum( N, x, 2 ); t.strictEqual( v, 5.0, 'returns expected value' ); From 2c3c76a69948de4e0cf6ea79f7c96523045831e1 Mon Sep 17 00:00:00 2001 From: kunal Dugar Date: Wed, 6 Mar 2024 21:21:39 +0530 Subject: [PATCH 2/4] Fixed the changes suggested by reviewr --- .../ext/base/sdssum/benchmark/benchmark.js | 3 +- .../benchmark/benchmark.ndarray.native.js | 1 - .../blas/ext/base/sdssum/examples/index.js | 5 ++-- .../ext/base/sdssum/lib/ndarray.native.js | 2 +- .../blas/ext/base/sdssum/manifest.json | 28 +++++++++---------- .../@stdlib/blas/ext/base/sdssum/src/addon.c | 9 +++--- .../blas/ext/base/sdssum/test/test.ndarray.js | 8 +++--- .../base/sdssum/test/test.ndarray.native.js | 7 ++--- .../blas/ext/base/sdssum/test/test.sdssum.js | 1 - .../base/sdssum/test/test.sdssum.native.js | 5 ++-- 10 files changed, 31 insertions(+), 38 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.js index 3b03897c0b80..7f95b2d2d203 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.js @@ -33,7 +33,6 @@ var sdssum = require( './../lib/sdssum.js' ); // VARIABLES // var rand = uniform( -100.0, 100.0 ); - // FUNCTIONS // /** @@ -44,7 +43,7 @@ var rand = uniform( -100.0, 100.0 ); * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x = filledarrayBy( len, 'float64', rand ); + var x = filledarrayBy( len, 'float32', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.native.js index 0b4d8a0e9637..4523662ebc8a 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.native.js @@ -38,7 +38,6 @@ var opts = { 'skip': ( sdssum instanceof Error ) }; var rand = uniform( -100.0, 100.0 ); - // FUNCTIONS // /** diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/examples/index.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/examples/index.js index 4ae7cdf9ee85..6830497ba4fe 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/examples/index.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/examples/index.js @@ -25,6 +25,5 @@ var sdssum = require( './../lib' ); var x = filledarrayBy( 10, 'float64', discreteUniform( -100, 100 ) ); console.log( x ); - -var y = sdssum( x.length, x, 1 ); -console.log( y ); \ No newline at end of file +var v = sdssum( x.length, x, 1 ); +console.log( v ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/lib/ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/lib/ndarray.native.js index 5f0d3b0ca71a..38bb55189ba9 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/lib/ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/lib/ndarray.native.js @@ -50,7 +50,7 @@ function sdssum( N, x, stride, offset ) { var view; offset = minViewBufferIndex( N, stride, offset ); if ( stride < 0 ) { - offset += (N-1) * stride; + stride *= -1; } view = offsetView( x, offset ); return addon( N, view, stride ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/manifest.json b/lib/node_modules/@stdlib/blas/ext/base/sdssum/manifest.json index a0068814ccb5..ae0ab27eef42 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/manifest.json +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/manifest.json @@ -44,8 +44,8 @@ "dependencies": [ "@stdlib/napi/export", "@stdlib/napi/argv", - "@stdlib/napi/argv-int64", - "@stdlib/napi/argv-strided-float64array" + "@stdlib/napi/argv-int32", + "@stdlib/napi/argv-strided-float32array" ] }, { @@ -66,8 +66,8 @@ "dependencies": [ "@stdlib/napi/export", "@stdlib/napi/argv", - "@stdlib/napi/argv-int64", - "@stdlib/napi/argv-strided-float64array" + "@stdlib/napi/argv-int32", + "@stdlib/napi/argv-strided-float32array" ] }, { @@ -87,8 +87,8 @@ "dependencies": [ "@stdlib/napi/export", "@stdlib/napi/argv", - "@stdlib/napi/argv-int64", - "@stdlib/napi/argv-strided-float64array" + "@stdlib/napi/argv-int32", + "@stdlib/napi/argv-strided-float32array" ] }, { @@ -108,8 +108,8 @@ "dependencies": [ "@stdlib/napi/export", "@stdlib/napi/argv", - "@stdlib/napi/argv-int64", - "@stdlib/napi/argv-strided-float64array" + "@stdlib/napi/argv-int32", + "@stdlib/napi/argv-strided-float32array" ] }, { @@ -130,8 +130,8 @@ "dependencies": [ "@stdlib/napi/export", "@stdlib/napi/argv", - "@stdlib/napi/argv-int64", - "@stdlib/napi/argv-strided-float64array" + "@stdlib/napi/argv-int32", + "@stdlib/napi/argv-strided-float32array" ] }, { @@ -151,8 +151,8 @@ "dependencies": [ "@stdlib/napi/export", "@stdlib/napi/argv", - "@stdlib/napi/argv-int64", - "@stdlib/napi/argv-strided-float64array" + "@stdlib/napi/argv-int32", + "@stdlib/napi/argv-strided-float32array" ] }, { @@ -172,8 +172,8 @@ "dependencies": [ "@stdlib/napi/export", "@stdlib/napi/argv", - "@stdlib/napi/argv-int64", - "@stdlib/napi/argv-strided-float64array" + "@stdlib/napi/argv-int32", + "@stdlib/napi/argv-strided-float32array" ] } ] diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/src/addon.c b/lib/node_modules/@stdlib/blas/ext/base/sdssum/src/addon.c index a5fc0f385fa7..fa1d3396ba80 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/src/addon.c +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/src/addon.c @@ -19,8 +19,8 @@ #include "stdlib/blas/base/sdssum.h" #include "stdlib/napi/export.h" #include "stdlib/napi/argv.h" -#include "stdlib/napi/argv_int64.h" -#include "stdlib/napi/argv_strided_float64array.h" +#include "stdlib/napi/argv_int32.h" +#include "stdlib/napi/argv_strided_float32array.h" #include #include @@ -40,10 +40,9 @@ static napi_value addon(napi_env env, napi_callback_info info) STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY(env, X, N, strideX, argv, 1); napi_value v; - napi_status status = napi_create_double(env, c_sdssum(N, (double *)X, strideX), &v); + napi_status status = napi_create_double(env, c_sdssum(N, (float *)X, strideX), &v); assert(status == napi_ok); return v; } - -STDLIB_NAPI_MODULE_EXPORT_FCN(addon) \ No newline at end of file +STDLIB_NAPI_MODULE_EXPORT_FCN(addon) diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.js index e2a858fca5a6..14dd17de770a 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.js @@ -21,7 +21,7 @@ // MODULES // var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); +//var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var Float32Array = require( '@stdlib/array/float32' ); var sdssum = require( './../lib/ndarray.js' ); @@ -118,7 +118,7 @@ tape( 'the function supports a `stride` parameter', function test( t ) { 2.0 ]); - N = floor( x.length / 2 ); + N = 2; v = sdssum( N, x, 2, 0 ); t.strictEqual( v, 5.0, 'returns expected value' ); @@ -142,7 +142,7 @@ tape( 'the function supports a negative `stride` parameter', function test( t ) 2.0 ]); - N = floor( x.length / 2 ); + N = 2; v = sdssum( N, x, -2, 6 ); t.strictEqual( v, 5.0, 'returns expected value' ); @@ -184,7 +184,7 @@ tape( 'the function supports an `offset` parameter', function test( t ) { 3.0, 4.0 // 3 ]); - N = floor( x.length / 2 ); + N = 3; v = sdssum( N, x, 2, 1 ); t.strictEqual( v, 5.0, 'returns expected value' ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.native.js index 9a631047a07e..b89420008031 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.native.js @@ -22,7 +22,6 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var Float32Array = require( '@stdlib/array/float32' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -127,7 +126,7 @@ tape( 'the function supports a `stride` parameter', opts, function test( t ) { 2.0 ]); - N = floor( x.length / 2 ); + N = 2; v = sdssum( N, x, 2, 0 ); t.strictEqual( v, 5.0, 'returns expected value' ); @@ -151,7 +150,7 @@ tape( 'the function supports a negative `stride` parameter', opts, function test 2.0 ]); - N = floor( x.length / 2 ); + N = 2; v = sdssum( N, x, -2, 6 ); t.strictEqual( v, 5.0, 'returns expected value' ); @@ -193,7 +192,7 @@ tape( 'the function supports an `offset` parameter', opts, function test( t ) { 3.0, 4.0 // 3 ]); - N = floor( x.length / 2 ); + N = 3; v = sdssum( N, x, 2, 1 ); t.strictEqual( v, 5.0, 'returns expected value' ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.sdssum.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.sdssum.js index dad9ce4cb363..d7da7765d991 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.sdssum.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.sdssum.js @@ -21,7 +21,6 @@ // MODULES // var tape = require( 'tape' ); - var isnan = require( '@stdlib/math/base/assert/is-nan' ); var Float32Array = require( '@stdlib/array/float32' ); var sdssum = require( './../lib/sdssum.js' ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.sdssum.native.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.sdssum.native.js index 2cc8b002563e..2b1150b4adb5 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.sdssum.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.sdssum.native.js @@ -22,7 +22,6 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); - var isnan = require( '@stdlib/math/base/assert/is-nan' ); var Float32Array = require( '@stdlib/array/float32' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -233,7 +232,7 @@ tape( 'the function supports a negative `stride` parameter', opts, function test 2.0 ]); - N = floor( x.length / 2 ); + N = 2; v = sdssum( N, x, -2 ); t.strictEqual( v, 5.0, 'returns expected value' ); @@ -279,7 +278,7 @@ tape( 'the function supports view offsets', opts, function test( t ) { ]); x1 = new Float32Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element - N = floor(x1.length / 2); + N = 3; v = sdssum( N, x1, 2 ); t.strictEqual( v, 5.0, 'returns expected value' ); From fea52628ddde15e3670489f4bb3178321bc2f03b Mon Sep 17 00:00:00 2001 From: kunal Dugar Date: Thu, 7 Mar 2024 07:57:01 +0530 Subject: [PATCH 3/4] Fixed the spacing changes as suggested --- .../blas/ext/base/sdssum/manifest.json | 356 +++++++++--------- .../blas/ext/base/sdssum/test/test.ndarray.js | 1 - 2 files changed, 178 insertions(+), 179 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/manifest.json b/lib/node_modules/@stdlib/blas/ext/base/sdssum/manifest.json index ae0ab27eef42..4a6f16ee587a 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/manifest.json +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/manifest.json @@ -1,180 +1,180 @@ { - "options": { - "os": "linux", - "blas": "", - "wasm": false - }, - "fields": [ - { - "field": "src", - "resolve": true, - "relative": true - }, - { - "field": "include", - "resolve": true, - "relative": true - }, - { - "field": "libraries", - "resolve": false, - "relative": false - }, - { - "field": "libpath", - "resolve": true, - "relative": false - } - ], - "confs": [ - { - "os": "linux", - "blas": "", - "wasm": false, - "src": [ - "./src/sdssum.f", - "./src/sdssumsub.f", - "./src/sdssum_f.c" - ], - "include": [ - "./include" - ], - "libraries": [], - "libpath": [], - "dependencies": [ - "@stdlib/napi/export", - "@stdlib/napi/argv", - "@stdlib/napi/argv-int32", - "@stdlib/napi/argv-strided-float32array" - ] - }, - { - "os": "linux", - "blas": "openblas", - "wasm": false, - "src": [ - "./src/sdssum_cblas.c" - ], - "include": [ - "./include" - ], - "libraries": [ - "-lopenblas", - "-lpthread" - ], - "libpath": [], - "dependencies": [ - "@stdlib/napi/export", - "@stdlib/napi/argv", - "@stdlib/napi/argv-int32", - "@stdlib/napi/argv-strided-float32array" - ] - }, - { - "os": "mac", - "blas": "", - "wasm": false, - "src": [ - "./src/sdssum.f", - "./src/sdssumsub.f", - "./src/sdssum_f.c" - ], - "include": [ - "./include" - ], - "libraries": [], - "libpath": [], - "dependencies": [ - "@stdlib/napi/export", - "@stdlib/napi/argv", - "@stdlib/napi/argv-int32", - "@stdlib/napi/argv-strided-float32array" - ] - }, - { - "os": "mac", - "blas": "apple_accelerate_framework", - "wasm": false, - "src": [ - "./src/sdssum_cblas.c" - ], - "include": [ - "./include" - ], - "libraries": [ - "-lblas" - ], - "libpath": [], - "dependencies": [ - "@stdlib/napi/export", - "@stdlib/napi/argv", - "@stdlib/napi/argv-int32", - "@stdlib/napi/argv-strided-float32array" - ] - }, - { - "os": "mac", - "blas": "openblas", - "wasm": false, - "src": [ - "./src/sdssum_cblas.c" - ], - "include": [ - "./include" - ], - "libraries": [ - "-lopenblas", - "-lpthread" - ], - "libpath": [], - "dependencies": [ - "@stdlib/napi/export", - "@stdlib/napi/argv", - "@stdlib/napi/argv-int32", - "@stdlib/napi/argv-strided-float32array" - ] - }, - { - "os": "win", - "blas": "", - "wasm": false, - "src": [ - "./src/sdssum.c" - ], - "include": [ - "./include" - ], - "libraries": [ - "-m" - ], - "libpath": [], - "dependencies": [ - "@stdlib/napi/export", - "@stdlib/napi/argv", - "@stdlib/napi/argv-int32", - "@stdlib/napi/argv-strided-float32array" - ] - }, - { - "os": "", - "blas": "", - "wasm": true, - "src": [ - "./src/sdssum.c" - ], - "include": [ - "./include" - ], - "libraries": [ - "-m" - ], - "libpath": [], - "dependencies": [ - "@stdlib/napi/export", - "@stdlib/napi/argv", - "@stdlib/napi/argv-int32", - "@stdlib/napi/argv-strided-float32array" - ] - } - ] + "options": { + "os": "linux", + "blas": "", + "wasm": false + }, + "fields": [ + { + "field": "src", + "resolve": true, + "relative": true + }, + { + "field": "include", + "resolve": true, + "relative": true + }, + { + "field": "libraries", + "resolve": false, + "relative": false + }, + { + "field": "libpath", + "resolve": true, + "relative": false + } + ], + "confs": [ + { + "os": "linux", + "blas": "", + "wasm": false, + "src": [ + "./src/sdssum.f", + "./src/sdssumsub.f", + "./src/sdssum_f.c" + ], + "include": [ + "./include" + ], + "libraries": [], + "libpath": [], + "dependencies": [ + "@stdlib/napi/export", + "@stdlib/napi/argv", + "@stdlib/napi/argv-int32", + "@stdlib/napi/argv-strided-float32array" + ] + }, + { + "os": "linux", + "blas": "openblas", + "wasm": false, + "src": [ + "./src/sdssum_cblas.c" + ], + "include": [ + "./include" + ], + "libraries": [ + "-lopenblas", + "-lpthread" + ], + "libpath": [], + "dependencies": [ + "@stdlib/napi/export", + "@stdlib/napi/argv", + "@stdlib/napi/argv-int32", + "@stdlib/napi/argv-strided-float32array" + ] + }, + { + "os": "mac", + "blas": "", + "wasm": false, + "src": [ + "./src/sdssum.f", + "./src/sdssumsub.f", + "./src/sdssum_f.c" + ], + "include": [ + "./include" + ], + "libraries": [], + "libpath": [], + "dependencies": [ + "@stdlib/napi/export", + "@stdlib/napi/argv", + "@stdlib/napi/argv-int32", + "@stdlib/napi/argv-strided-float32array" + ] + }, + { + "os": "mac", + "blas": "apple_accelerate_framework", + "wasm": false, + "src": [ + "./src/sdssum_cblas.c" + ], + "include": [ + "./include" + ], + "libraries": [ + "-lblas" + ], + "libpath": [], + "dependencies": [ + "@stdlib/napi/export", + "@stdlib/napi/argv", + "@stdlib/napi/argv-int32", + "@stdlib/napi/argv-strided-float32array" + ] + }, + { + "os": "mac", + "blas": "openblas", + "wasm": false, + "src": [ + "./src/sdssum_cblas.c" + ], + "include": [ + "./include" + ], + "libraries": [ + "-lopenblas", + "-lpthread" + ], + "libpath": [], + "dependencies": [ + "@stdlib/napi/export", + "@stdlib/napi/argv", + "@stdlib/napi/argv-int32", + "@stdlib/napi/argv-strided-float32array" + ] + }, + { + "os": "win", + "blas": "", + "wasm": false, + "src": [ + "./src/sdssum.c" + ], + "include": [ + "./include" + ], + "libraries": [ + "-m" + ], + "libpath": [], + "dependencies": [ + "@stdlib/napi/export", + "@stdlib/napi/argv", + "@stdlib/napi/argv-int32", + "@stdlib/napi/argv-strided-float32array" + ] + }, + { + "os": "", + "blas": "", + "wasm": true, + "src": [ + "./src/sdssum.c" + ], + "include": [ + "./include" + ], + "libraries": [ + "-m" + ], + "libpath": [], + "dependencies": [ + "@stdlib/napi/export", + "@stdlib/napi/argv", + "@stdlib/napi/argv-int32", + "@stdlib/napi/argv-strided-float32array" + ] + } + ] } \ No newline at end of file diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.js index 14dd17de770a..36a5f18bf332 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/test/test.ndarray.js @@ -21,7 +21,6 @@ // MODULES // var tape = require( 'tape' ); -//var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var Float32Array = require( '@stdlib/array/float32' ); var sdssum = require( './../lib/ndarray.js' ); From 37c439c5e3224ab02a1e14985f9808939fd420bc Mon Sep 17 00:00:00 2001 From: kunal Dugar Date: Thu, 7 Mar 2024 09:27:25 +0530 Subject: [PATCH 4/4] Fixed the changes as suggested --- .../base/sdssum/benchmark/benchmark.native.js | 3 +- .../sdssum/benchmark/benchmark.ndarray.js | 4 +- .../benchmark/benchmark.ndarray.native.js | 3 +- .../blas/ext/base/sdssum/manifest.json | 144 +----------------- .../@stdlib/blas/ext/base/sdssum/src/addon.c | 20 +-- 5 files changed, 16 insertions(+), 158 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.native.js index 82a7abc467a0..5f012d96e172 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.native.js @@ -26,7 +26,6 @@ var uniform = require( '@stdlib/random/base/uniform' ).factory; var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); - var tryRequire = require( '@stdlib/utils/try-require' ); var pkg = require( './../package.json' ).name; @@ -50,7 +49,7 @@ var rand = uniform( -100.0, 100.0 ); * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x = filledarrayBy( len, 'float64', rand ); + var x = filledarrayBy( len, 'float32', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.js index d30787e986b1..37d236c32d4b 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.js @@ -25,12 +25,10 @@ var uniform = require( '@stdlib/random/base/uniform' ).factory; var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); - var pkg = require( './../package.json' ).name; var sdssum = require( './../lib/ndarray.js' ); - // VARIABLES // var rand = uniform( -100.0, 100.0 ); @@ -46,7 +44,7 @@ var rand = uniform( -100.0, 100.0 ); * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x = filledarrayBy( len, 'float64', rand ); + var x = filledarrayBy( len, 'float32', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.native.js index 4523662ebc8a..77a8c7dc9296 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/benchmark/benchmark.ndarray.native.js @@ -26,7 +26,6 @@ var uniform = require( '@stdlib/random/base/uniform' ).factory; var filledarrayBy = require( '@stdlib/array/filled-by' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); - var tryRequire = require( '@stdlib/utils/try-require' ); var pkg = require( './../package.json' ).name; @@ -48,7 +47,7 @@ var rand = uniform( -100.0, 100.0 ); * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x = filledarrayBy( len, 'float64', rand ); + var x = filledarrayBy( len, 'float32', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/manifest.json b/lib/node_modules/@stdlib/blas/ext/base/sdssum/manifest.json index 4a6f16ee587a..eaf76922d18e 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/manifest.json +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/manifest.json @@ -1,9 +1,5 @@ { - "options": { - "os": "linux", - "blas": "", - "wasm": false - }, + "options": {}, "fields": [ { "field": "src", @@ -28,137 +24,6 @@ ], "confs": [ { - "os": "linux", - "blas": "", - "wasm": false, - "src": [ - "./src/sdssum.f", - "./src/sdssumsub.f", - "./src/sdssum_f.c" - ], - "include": [ - "./include" - ], - "libraries": [], - "libpath": [], - "dependencies": [ - "@stdlib/napi/export", - "@stdlib/napi/argv", - "@stdlib/napi/argv-int32", - "@stdlib/napi/argv-strided-float32array" - ] - }, - { - "os": "linux", - "blas": "openblas", - "wasm": false, - "src": [ - "./src/sdssum_cblas.c" - ], - "include": [ - "./include" - ], - "libraries": [ - "-lopenblas", - "-lpthread" - ], - "libpath": [], - "dependencies": [ - "@stdlib/napi/export", - "@stdlib/napi/argv", - "@stdlib/napi/argv-int32", - "@stdlib/napi/argv-strided-float32array" - ] - }, - { - "os": "mac", - "blas": "", - "wasm": false, - "src": [ - "./src/sdssum.f", - "./src/sdssumsub.f", - "./src/sdssum_f.c" - ], - "include": [ - "./include" - ], - "libraries": [], - "libpath": [], - "dependencies": [ - "@stdlib/napi/export", - "@stdlib/napi/argv", - "@stdlib/napi/argv-int32", - "@stdlib/napi/argv-strided-float32array" - ] - }, - { - "os": "mac", - "blas": "apple_accelerate_framework", - "wasm": false, - "src": [ - "./src/sdssum_cblas.c" - ], - "include": [ - "./include" - ], - "libraries": [ - "-lblas" - ], - "libpath": [], - "dependencies": [ - "@stdlib/napi/export", - "@stdlib/napi/argv", - "@stdlib/napi/argv-int32", - "@stdlib/napi/argv-strided-float32array" - ] - }, - { - "os": "mac", - "blas": "openblas", - "wasm": false, - "src": [ - "./src/sdssum_cblas.c" - ], - "include": [ - "./include" - ], - "libraries": [ - "-lopenblas", - "-lpthread" - ], - "libpath": [], - "dependencies": [ - "@stdlib/napi/export", - "@stdlib/napi/argv", - "@stdlib/napi/argv-int32", - "@stdlib/napi/argv-strided-float32array" - ] - }, - { - "os": "win", - "blas": "", - "wasm": false, - "src": [ - "./src/sdssum.c" - ], - "include": [ - "./include" - ], - "libraries": [ - "-m" - ], - "libpath": [], - "dependencies": [ - "@stdlib/napi/export", - "@stdlib/napi/argv", - "@stdlib/napi/argv-int32", - "@stdlib/napi/argv-strided-float32array" - ] - }, - { - "os": "", - "blas": "", - "wasm": true, "src": [ "./src/sdssum.c" ], @@ -166,14 +31,11 @@ "./include" ], "libraries": [ - "-m" + "-lm" ], "libpath": [], "dependencies": [ - "@stdlib/napi/export", - "@stdlib/napi/argv", - "@stdlib/napi/argv-int32", - "@stdlib/napi/argv-strided-float32array" + "@stdlib/blas/ext/base/sdssumpw" ] } ] diff --git a/lib/node_modules/@stdlib/blas/ext/base/sdssum/src/addon.c b/lib/node_modules/@stdlib/blas/ext/base/sdssum/src/addon.c index fa1d3396ba80..e6c6d2ac959e 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sdssum/src/addon.c +++ b/lib/node_modules/@stdlib/blas/ext/base/sdssum/src/addon.c @@ -19,8 +19,8 @@ #include "stdlib/blas/base/sdssum.h" #include "stdlib/napi/export.h" #include "stdlib/napi/argv.h" -#include "stdlib/napi/argv_int32.h" -#include "stdlib/napi/argv_strided_float32array.h" +#include "stdlib/napi/argv_int64.h" +#include "stdlib/napi/argv_strided_float64array.h" #include #include @@ -34,15 +34,15 @@ */ static napi_value addon(napi_env env, napi_callback_info info) { - STDLIB_NAPI_ARGV(env, info, argv, argc, 3); - STDLIB_NAPI_ARGV_INT64(env, N, argv, 0); - STDLIB_NAPI_ARGV_INT64(env, strideX, argv, 2); - STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY(env, X, N, strideX, argv, 1); + STDLIB_NAPI_ARGV(env, info, argv, argc, 3); + STDLIB_NAPI_ARGV_INT64(env, N, argv, 0); + STDLIB_NAPI_ARGV_INT64(env, strideX, argv, 2); + STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY(env, X, N, strideX, argv, 1); - napi_value v; - napi_status status = napi_create_double(env, c_sdssum(N, (float *)X, strideX), &v); - assert(status == napi_ok); + napi_value v; + napi_status status = napi_create_double(env, c_sdssum(N, (float *)X, strideX), &v); + assert(status == napi_ok); - return v; + return v; } STDLIB_NAPI_MODULE_EXPORT_FCN(addon)