sind API added to @stdlib/math/base/special/sind and closes issue #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@piff-saad Thanks for this initial implementation. Would you be able to add the associated tests, benchmarks, documentation, and other files in order to make this a package? As it stands now, this file is not readily consumable by other packages within the project. |
|
For reference, here is the project dev guide for packages: https://github.com/stdlib-js/stdlib/blob/develop/docs/packages.md. |
|
@pooriyasafaei Checking in to see if you are interested in moving forward with this PR. Let us know when you have a chance! Thanks! |
|
Closing this PR, as proposed changes are incomplete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #844 .
sind API added to @stdlib/math/base/special/sind and closes issue.