Skip to content

Commit e1d5359

Browse files
committed
refactor: avoid assertion duplication and update examples
Ref: 50616dc Ref: #1354
1 parent 090b81a commit e1d5359

File tree

14 files changed

+52
-64
lines changed

14 files changed

+52
-64
lines changed

lib/node_modules/@stdlib/assert/is-nonnegative-finite/README.md

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ var isNonNegativeFinite = require( '@stdlib/assert/is-nonnegative-finite' );
3232

3333
#### isNonNegativeFinite( value )
3434

35-
Tests if a `value` is a `number` having a nonnegative finite value.
35+
Tests if a value is a number having a nonnegative finite value.
3636

3737
<!-- eslint-disable no-new-wrappers -->
3838

@@ -54,13 +54,13 @@ bool = isNonNegativeFinite( -5.0 );
5454
bool = isNonNegativeFinite( null );
5555
// returns false
5656

57-
bool = isNonNegativeFinite( Infinity );
57+
bool = isNonNegativeFinite( 1.0/0.0 );
5858
// returns false
5959
```
6060

6161
#### isNonNegativeFinite.isPrimitive( value )
6262

63-
Tests if a `value` is a primitive `number` having a nonnegative finite value.
63+
Tests if a value is a primitive number having a nonnegative finite value.
6464

6565
<!-- eslint-disable no-new-wrappers -->
6666

@@ -76,7 +76,7 @@ bool = isNonNegativeFinite.isPrimitive( new Number( 3.0 ) );
7676

7777
#### isNonNegativeFinite.isObject( value )
7878

79-
Tests if a `value` is a `Number` object having a nonnegative finite value.
79+
Tests if a value is a `Number` object having a nonnegative finite value.
8080

8181
<!-- eslint-disable no-new-wrappers -->
8282

@@ -112,6 +112,12 @@ var bool = isNonNegativeFinite( 5.0 );
112112
bool = isNonNegativeFinite( new Number( 5.0 ) );
113113
// returns true
114114

115+
bool = isNonNegativeFinite( new Number( 1.0/0.0 ) );
116+
// returns false
117+
118+
bool = isNonNegativeFinite( 1.0/0.0 );
119+
// returns false
120+
115121
bool = isNonNegativeFinite( 0.0 );
116122
// returns true
117123

@@ -136,13 +142,6 @@ bool = isNonNegativeFinite( null );
136142

137143
<section class="related">
138144

139-
* * *
140-
141-
## See Also
142-
143-
- <span class="package-name">[`@stdlib/assert/is-number`][@stdlib/assert/is-number]</span><span class="delimiter">: </span><span class="description">test if a value is a number.</span>
144-
- <span class="package-name">[`@stdlib/assert/is-finite`][@stdlib/assert/is-finite]</span><span class="delimiter">: </span><span class="description">test if a value is a finite number.</span>
145-
146145
</section>
147146

148147
<!-- /.related -->
@@ -151,13 +150,6 @@ bool = isNonNegativeFinite( null );
151150

152151
<section class="links">
153152

154-
<!-- <related-links> -->
155-
156-
[@stdlib/assert/is-number]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/assert/is-number
157-
[@stdlib/assert/is-finite]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/assert/is-finite
158-
159-
<!-- </related-links> -->
160-
161153
</section>
162154

163155
<!-- /.links -->

lib/node_modules/@stdlib/assert/is-nonnegative-finite/benchmark/benchmark.js

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
* limitations under the License.
1717
*/
1818

19-
/* eslint-disable no-undefined, no-empty-function */
19+
/* eslint-disable no-empty-function */
2020

2121
'use strict';
2222

@@ -25,6 +25,8 @@
2525
var bench = require( '@stdlib/bench' );
2626
var Number = require( '@stdlib/number/ctor' );
2727
var isBoolean = require( '@stdlib/assert/is-boolean' ).isPrimitive;
28+
var PINF = require( '@stdlib/constants/float64/pinf' );
29+
var NINF = require( '@stdlib/constants/float64/ninf' );
2830
var pkg = require( './../package.json' ).name;
2931
var isNonNegativeFinite = require( './../lib' );
3032

@@ -47,9 +49,9 @@ bench( pkg+'::primitives', function benchmark( b ) {
4749
true,
4850
false,
4951
null,
50-
Infinity,
51-
-Infinity,
52-
undefined
52+
PINF,
53+
NINF,
54+
void 0
5355
];
5456

5557
b.tic();
@@ -112,9 +114,9 @@ bench( pkg+'::primitives:isPrimitive', function benchmark( b ) {
112114
true,
113115
false,
114116
null,
115-
undefined,
116-
Infinity,
117-
-Infinity
117+
void 0,
118+
PINF,
119+
NINF
118120
];
119121

120122
b.tic();
@@ -177,9 +179,9 @@ bench( pkg+'::primitives:isObject', function benchmark( b ) {
177179
true,
178180
false,
179181
null,
180-
undefined,
181-
Infinity,
182-
-Infinity
182+
void 0,
183+
PINF,
184+
NINF
183185
];
184186

185187
b.tic();
@@ -209,7 +211,7 @@ bench( pkg+'::objects:isObject', function benchmark( b ) {
209211
new Number( 2.0 ),
210212
new Number( -3.0 ),
211213
new Number( 3.14 ),
212-
new Number( Infinity )
214+
new Number( PINF )
213215
];
214216

215217
b.tic();

lib/node_modules/@stdlib/assert/is-nonnegative-finite/docs/repl.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
false
2525
> bool = {{alias}}( null )
2626
false
27-
> bool = {{alias}}( Infinity )
27+
> bool = {{alias}}( {{alias:@stdlib/constants/float64/pinf}} )
2828
false
2929

3030

lib/node_modules/@stdlib/assert/is-nonnegative-finite/docs/types/index.d.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ interface IsNonNegativeFinite {
2626
* Tests if a value is a nonnegative finite number.
2727
*
2828
* @param {*} value - value to test
29-
* @returns {boolean} boolean indicating whether value is a nonnegative number
29+
* @returns {boolean} boolean indicating whether value is a nonnegative finite number
3030
*
3131
* @example
3232
* var bool = isNonNegativeFinite( 5.0 );
@@ -41,7 +41,7 @@ interface IsNonNegativeFinite {
4141
* // returns true
4242
*
4343
* @example
44-
* var bool = isNonNegativeFinite( Infinity );
44+
* var bool = isNonNegativeFinite( 1.0/0.0 );
4545
* // returns false
4646
*
4747
* @example
@@ -73,7 +73,7 @@ interface IsNonNegativeFinite {
7373
* // returns false
7474
*
7575
* @example
76-
* var bool = isNonNegativeFinite( Infinity );
76+
* var bool = isNonNegativeFinite( 1.0/0.0 );
7777
* // returns false
7878
*/
7979
isPrimitive( value: any ): value is number;
@@ -97,7 +97,7 @@ interface IsNonNegativeFinite {
9797
* // returns false
9898
*
9999
* @example
100-
* var bool = isNonNegativeFinite( Infinity );
100+
* var bool = isNonNegativeFinite( 1.0/0.0 );
101101
* // returns false
102102
*/
103103
isObject( value: any ): value is Number;
@@ -107,7 +107,7 @@ interface IsNonNegativeFinite {
107107
* Tests if a value is a nonnegative finite number.
108108
*
109109
* @param {*} value - value to test
110-
* @returns {boolean} boolean indicating whether value is a nonnegative number
110+
* @returns {boolean} boolean indicating whether value is a nonnegative finite number
111111
*
112112
* @example
113113
* var bool = isNonNegativeFinite( 5.0 );
@@ -122,7 +122,7 @@ interface IsNonNegativeFinite {
122122
* // returns true
123123
*
124124
* @example
125-
* var bool = isNonNegativeFinite( Infinity );
125+
* var bool = isNonNegativeFinite( 1.0/0.0 );
126126
* // returns false
127127
*
128128
* @example

lib/node_modules/@stdlib/assert/is-nonnegative-finite/examples/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ console.log( isNonNegativeFinite( 5.0 ) );
2727
console.log( isNonNegativeFinite( new Number( 5.0 ) ) );
2828
// => true
2929

30-
console.log( isNonNegativeFinite( new Number( Infinity ) ) );
30+
console.log( isNonNegativeFinite( new Number( 1.0/0.0 ) ) );
3131
// => false
3232

33-
console.log( isNonNegativeFinite( Infinity ) );
33+
console.log( isNonNegativeFinite( 1.0/0.0 ) );
3434
// => false
3535

3636
console.log( isNonNegativeFinite( 0.0 ) );

lib/node_modules/@stdlib/assert/is-nonnegative-finite/lib/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
* bool = isNonNegativeFinite( 3.14 );
3636
* // returns true
3737
*
38-
* var bool = isNonNegativeFinite( Infinity );
38+
* var bool = isNonNegativeFinite( 1.0/0.0 );
3939
* // returns false
4040
*
4141
* bool = isNonNegativeFinite( -5.0 );
@@ -59,7 +59,7 @@
5959
* var bool = isNonNegativeFinite( 3.0 );
6060
* // returns false
6161
*
62-
* var bool = isNonNegativeFinite( Infinity );
62+
* var bool = isNonNegativeFinite( 1.0/0.0 );
6363
* // returns false
6464
*
6565
* bool = isNonNegativeFinite( new Number( 3.0 ) );

lib/node_modules/@stdlib/assert/is-nonnegative-finite/lib/main.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ var isObject = require( './object.js' );
3030
* Tests if a value is a nonnegative finite number.
3131
*
3232
* @param {*} value - value to test
33-
* @returns {boolean} boolean indicating whether value is a nonnegative number
33+
* @returns {boolean} boolean indicating whether value is a nonnegative finite number
3434
*
3535
* @example
3636
* var bool = isNonNegativeFinite( 5.0 );
@@ -45,7 +45,7 @@ var isObject = require( './object.js' );
4545
* // returns true
4646
*
4747
* @example
48-
* var bool = isNonNegativeFinite( Infinity );
48+
* var bool = isNonNegativeFinite( 1.0/0.0 );
4949
* // returns false
5050
*
5151
* @example

lib/node_modules/@stdlib/assert/is-nonnegative-finite/lib/object.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
// MODULES //
2222

2323
var isNonNegativeNumber = require( '@stdlib/assert/is-nonnegative-number').isObject;
24-
var isFinite = require( '@stdlib/assert/is-finite' ).isObject; // eslint-disable-line stdlib/no-redeclare
24+
var PINF = require( '@stdlib/constants/float64/pinf' );
2525

2626

2727
// MAIN //
@@ -45,13 +45,13 @@ var isFinite = require( '@stdlib/assert/is-finite' ).isObject; // eslint-disable
4545
* // returns false
4646
*
4747
* @example
48-
* var bool = isNonNegativeFinite( Infinity );
48+
* var bool = isNonNegativeFinite( 1.0/0.0 );
4949
* // returns false
5050
*/
5151
function isNonNegativeFinite( value ) {
5252
return (
5353
isNonNegativeNumber( value ) &&
54-
isFinite( value )
54+
value < PINF
5555
);
5656
}
5757

lib/node_modules/@stdlib/assert/is-nonnegative-finite/lib/primitive.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
// MODULES //
2222

2323
var isNonNegativeNumber = require( '@stdlib/assert/is-nonnegative-number' ).isPrimitive;
24-
var isFinite = require( '@stdlib/assert/is-finite' ).isPrimitive; // eslint-disable-line stdlib/no-redeclare
24+
var PINF = require( '@stdlib/constants/float64/pinf' );
2525

2626

2727
// MAIN //
@@ -45,13 +45,13 @@ var isFinite = require( '@stdlib/assert/is-finite' ).isPrimitive; // eslint-disa
4545
* // returns false
4646
*
4747
* @example
48-
* var bool = isNonNegativeFinite( Infinity );
48+
* var bool = isNonNegativeFinite( 1.0/0.0 );
4949
* // returns false
5050
*/
5151
function isNonNegativeFinite( value ) {
5252
return (
5353
isNonNegativeNumber( value ) &&
54-
isFinite( value )
54+
value < PINF
5555
);
5656
}
5757

lib/node_modules/@stdlib/assert/is-nonnegative-finite/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@
6161
"numeric",
6262
"nonnegative",
6363
"finite",
64-
"nonnegativefinite",
6564
"is",
6665
"isnumber",
6766
"isnumeric",

lib/node_modules/@stdlib/assert/is-nonnegative-finite/test/test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ tape( 'main export is a function', function test( t ) {
3232
t.end();
3333
});
3434

35-
tape( 'attached to the main export is a method to test for a primitive number having a nonnegative number value', function test( t ) {
35+
tape( 'attached to the main export is a method to test for a primitive number having a nonnegative finite number value', function test( t ) {
3636
t.equal( typeof isNonNegativeFinite.isPrimitive, 'function', 'export is a function' );
3737
t.end();
3838
});
3939

40-
tape( 'attached to the main export is a method to test for a number object having a nonnegative number value', function test( t ) {
40+
tape( 'attached to the main export is a method to test for a number object having a nonnegative finite number value', function test( t ) {
4141
t.equal( typeof isNonNegativeFinite.isObject, 'function', 'export is a function' );
4242
t.end();
4343
});

lib/node_modules/@stdlib/assert/is-nonnegative-finite/test/test.main.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ tape( 'the function returns `false` if not provided a number having a nonnegativ
5353
[],
5454
{},
5555
function noop() {},
56-
Infinity,
57-
-Infinity
56+
1.0/0.0,
57+
-1.0/0.0
5858
];
5959

6060
for ( i = 0; i < values.length; i++ ) {

lib/node_modules/@stdlib/assert/is-nonnegative-finite/test/test.object.js

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,8 @@ tape( 'the function returns `true` if provided a number object having a nonnegat
3838
t.end();
3939
});
4040

41-
tape( 'the function returns `false` if provided Infinity, even if it is positive infinity', function test( t ) {
42-
t.equal( isNonNegativeFinite( Infinity ), false, 'returns false' );
43-
t.end();
44-
});
45-
46-
tape( 'the function returns `false` if provided Infinity, even if it is positive infinity', function test( t ) {
47-
t.equal( isNonNegativeFinite( Infinity ), false, 'returns false' );
41+
tape( 'the function returns `false` if provided positive infinity', function test( t ) {
42+
t.equal( isNonNegativeFinite( 1.0/0.0 ), false, 'returns false' );
4843
t.end();
4944
});
5045

lib/node_modules/@stdlib/assert/is-nonnegative-finite/test/test.primitive.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,13 @@ tape( 'the function returns `false` if provided a number object, even if the num
4343
t.end();
4444
});
4545

46-
tape( 'the function returns `false` if provided Infinity, even if it is positive infinity', function test( t ) {
47-
t.equal( isNonNegativeFinite( Infinity ), false, 'returns false' );
46+
tape( 'the function returns `false` if provided positive infinity', function test( t ) {
47+
t.equal( isNonNegativeFinite( 1.0/0.0 ), false, 'returns false' );
4848
t.end();
4949
});
5050

51-
tape( 'the function returns `false` if provided a number object with Infinity', function test( t ) {
52-
t.equal( isNonNegativeFinite( new Number( Infinity ) ), false, 'returns false' );
51+
tape( 'the function returns `false` if provided a number object with positive infinity', function test( t ) {
52+
t.equal( isNonNegativeFinite( new Number( 1.0/0.0 ) ), false, 'returns false' );
5353
t.end();
5454
});
5555

0 commit comments

Comments
 (0)