chore: apply suggestions from review

anandkaranubc · anandkaranubc · commit e197e4122b86 · 2025-05-11T23:04:35.000-07:00
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
diff --git a/lib/node_modules/@stdlib/math/base/special/bernoullif/README.md b/lib/node_modules/@stdlib/math/base/special/bernoullif/README.md
@@ -108,15 +108,15 @@ var v = bernoullif( NaN );
 <!-- eslint no-undef: "error" -->
 
 ```javascript
+var logEachMap = require( '@stdlib/console/log-each-map' );
+var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
 var bernoullif = require( '@stdlib/math/base/special/bernoullif' );
 
-var v;
-var i;
+var x = discreteUniform( 100, 0, 70, {
+    'dtype': 'int32'
+});
 
-for ( i = 0; i < 70; i++ ) {
-    v = bernoullif( i );
-    console.log( v );
-}
+logEachMap( 'bernoullif(%d) = %0.4f', x, bernoullif );
 ```
 
 </section>
@@ -155,10 +155,10 @@ Compute the nth [Bernoulli number][bernoulli-number] as a single-precision float
 
 ```c
 float out = stdlib_base_bernoullif( 0 );
-// returns 1.0
+// returns 1.0f
 
 out = stdlib_base_bernoullif( 1 );
-// returns 0.5
+// returns 0.5f
 ```
 
 The function accepts the following arguments:
@@ -196,7 +196,7 @@ int main( void ) {
     int32_t i;
     float v;
 
-    for ( i = 0; i < 130; i++ ) {
+    for ( i = 0; i < 70; i++ ) {
         v = stdlib_base_bernoullif( i );
         printf( "bernoullif(%d) = %f\n", i, v );
     }
diff --git a/lib/node_modules/@stdlib/math/base/special/bernoullif/benchmark/benchmark.js b/lib/node_modules/@stdlib/math/base/special/bernoullif/benchmark/benchmark.js
@@ -21,7 +21,7 @@
 // MODULES //
 
 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/array/discrete-uniform' );
+var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
 var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
 var pkg = require( './../package.json' ).name;
 var bernoullif = require( './../lib' );
@@ -34,7 +34,7 @@ bench( pkg, function benchmark( b ) {
 	var y;
 	var i;
 
-	x = randu( 100, 0, 500 );
+	x = discreteUniform( 100, 0, 100 );
 
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
diff --git a/lib/node_modules/@stdlib/math/base/special/bernoullif/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/math/base/special/bernoullif/benchmark/benchmark.native.js
@@ -22,7 +22,7 @@
 
 var resolve = require( 'path' ).resolve;
 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/array/discrete-uniform' );
+var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
 var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
 var tryRequire = require( '@stdlib/utils/try-require' );
 var pkg = require( './../package.json' ).name;
@@ -43,7 +43,7 @@ bench( pkg+'::native', opts, function benchmark( b ) {
 	var y;
 	var i;
 
-	x = randu( 100, 0, 500 );
+	x = discreteUniform( 100, 0, 100 );
 
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
diff --git a/lib/node_modules/@stdlib/math/base/special/bernoullif/benchmark/c/native/benchmark.c b/lib/node_modules/@stdlib/math/base/special/bernoullif/benchmark/c/native/benchmark.c
@@ -18,6 +18,7 @@
 
 #include "stdlib/math/base/special/bernoullif.h"
 #include <stdlib.h>
+#include <stdint.h>
 #include <stdio.h>
 #include <math.h>
 #include <time.h>
@@ -97,12 +98,12 @@ static double benchmark( void ) {
 	int i;
 
 	for ( i = 0; i < 100; i++ ) {
-		x[ i ] = ( 500.0 * rand_float() );
+		x[ i ] = ( 500.0f * rand_float() );
 	}
 
 	t = tic();
 	for ( i = 0; i < ITERATIONS; i++ ) {
-		y = stdlib_base_bernoullif( (int)( x[ i % 100 ] ) );
+		y = stdlib_base_bernoullif( (int32_t)( x[ i%100 ] ) );
 		if ( y != y ) {
 			printf( "should not return NaN\n" );
 			break;
diff --git a/lib/node_modules/@stdlib/math/base/special/bernoullif/examples/c/example.c b/lib/node_modules/@stdlib/math/base/special/bernoullif/examples/c/example.c
@@ -26,6 +26,6 @@ int main( void ) {
 
 	for ( i = 0; i < 70; i++ ) {
 		v = stdlib_base_bernoullif( i );
-		printf( "bernoulli(%d) = %f\n", i, v );
+		printf( "bernoullif(%d) = %f\n", i, v );
 	}
 }
diff --git a/lib/node_modules/@stdlib/math/base/special/bernoullif/examples/index.js b/lib/node_modules/@stdlib/math/base/special/bernoullif/examples/index.js
@@ -18,12 +18,12 @@
 
 'use strict';
 
+var logEachMap = require( '@stdlib/console/log-each-map' );
+var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
 var bernoullif = require( './../lib' );
 
-var v;
-var i;
+var x = discreteUniform( 100, 0, 70, {
+	'dtype': 'int32'
+});
 
-for ( i = 0; i < 70; i++ ) {
-	v = bernoullif( i );
-	console.log( v );
-}
+logEachMap( 'bernoullif(%d) = %0.4f', x, bernoullif );
diff --git a/lib/node_modules/@stdlib/math/base/special/bernoullif/lib/bernoullif.json b/lib/node_modules/@stdlib/math/base/special/bernoullif/lib/bernoullif.json
@@ -1,35 +1,35 @@
 [
-  1.00000000000000000000000000000000000000000,
-  0.166666666666666666666666666666666666666667,
-  -0.0333333333333333333333333333333333333333333,
-  0.0238095238095238095238095238095238095238095,
-  -0.0333333333333333333333333333333333333333333,
-  0.0757575757575757575757575757575757575757576,
-  -0.253113553113553113553113553113553113553114,
-  1.16666666666666666666666666666666666666667,
-  -7.09215686274509803921568627450980392156863,
-  54.9711779448621553884711779448621553884712,
-  -529.124242424242424242424242424242424242424,
-  6192.12318840579710144927536231884057971014,
-  -86580.2531135531135531135531135531135531136,
-  1.42551716666666666666666666666666666666667e6,
-  -2.72982310678160919540229885057471264367816e7,
-  6.01580873900642368384303868174835916771401e8,
-  -1.51163157670921568627450980392156862745098e10,
-  4.29614643061166666666666666666666666666667e11,
-  -1.37116552050883327721590879485616327721591e13,
-  4.88332318973593166666666666666666666666667e14,
-  -1.92965793419400681486326681448632668144863e16,
-  8.41693047573682615000553709856035437430786e17,
-  -4.03380718540594554130768115942028985507246e19,
-  2.11507486380819916056014539007092198581560e21,
-  -1.20866265222965259346027311937082525317819e23,
-  7.50086674607696436685572007575757575757576e24,
-  -5.03877810148106891413789303052201257861635e26,
-  3.65287764848181233351104308429711779448622e28,
-  -2.84987693024508822262691464329106781609195e30,
-  2.38654274996836276446459819192192149717514e32,
-  -2.13999492572253336658107447651910973926742e34,
-  2.05009757234780975699217330956723102516667e36,
-  -2.09380059113463784090951852900279701847092e38
+  1.0,
+  0.1666666716337204,
+  -0.03333333507180214,
+  0.02380952425301075,
+  -0.03333333507180214,
+  0.07575757801532745,
+  -0.2531135678291321,
+  1.1666666269302368,
+  -7.092156887054443,
+  54.97117614746094,
+  -529.124267578125,
+  6192.123046875,
+  -86580.25,
+  1425517.125,
+  -27298232.0,
+  601580864.0,
+  -15116315648.0,
+  429614628864.0,
+  -13711654780928.0,
+  488332312182784.0,
+  -19296579391324160.0,
+  841693056053805000.0,
+  -40338073359287845000.0,
+  2.1150748918604188e+21,
+  -1.2086626472668042e+23,
+  7.500866956719485e+24,
+  -5.038777949942763e+26,
+  3.652877742276384e+28,
+  -2.849876996904201e+30,
+  2.386542781638813e+32,
+  -2.1399950070596233e+34,
+  2.050097633557977e+36,
+  -2.0938006042234345e+38
 ]
diff --git a/lib/node_modules/@stdlib/math/base/special/bernoullif/lib/main.js b/lib/node_modules/@stdlib/math/base/special/bernoullif/lib/main.js
@@ -20,7 +20,7 @@
 
 // MODULES //
 
-var isNonNegativeInteger = require( '@stdlib/math/base/assert/is-nonnegative-integer' );
+var isNonNegativeIntegerf = require( '@stdlib/math/base/assert/is-nonnegative-integerf' );
 var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
 var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
 var isOdd = require( '@stdlib/math/base/assert/is-odd' );
@@ -83,7 +83,7 @@ var MAX_BERNOULLI = 64|0; // asm type annotation
 * // returns NaN
 */
 function bernoullif( n ) {
-	if ( isnanf( n ) || !isNonNegativeInteger( n ) ) {
+	if ( isnanf( n ) || !isNonNegativeIntegerf( n ) ) {
 		return NaN;
 	}
 	if ( n === 1 ) {
@@ -93,9 +93,9 @@ function bernoullif( n ) {
 		return 0.0;
 	}
 	if ( n > MAX_BERNOULLI ) {
-		return ( ( n / 2 ) & 1 ) ? PINF : NINF;
+		return ( (n/2)&1 ) ? PINF : NINF;
 	}
-	return float64ToFloat32( BERNOULLIF[ n / 2 ] );
+	return float64ToFloat32( BERNOULLIF[ n/2 ] );
 }
 
 
diff --git a/lib/node_modules/@stdlib/math/base/special/bernoullif/lib/native.js b/lib/node_modules/@stdlib/math/base/special/bernoullif/lib/native.js
@@ -28,6 +28,7 @@ var addon = require( './../src/addon.node' );
 /**
 * Computes the nth Bernoulli number as a single-precision floating-point number.
 *
+* @private
 * @param {NonNegativeInteger} n - the Bernoulli number to compute
 * @returns {number} Bernoulli number
 *
diff --git a/lib/node_modules/@stdlib/math/base/special/bernoullif/manifest.json b/lib/node_modules/@stdlib/math/base/special/bernoullif/manifest.json
@@ -37,7 +37,6 @@
       "libpath": [],
       "dependencies": [
         "@stdlib/math/base/napi/unary",
-        "@stdlib/math/base/assert/is-odd",
         "@stdlib/constants/float32/ninf",
         "@stdlib/constants/float32/pinf"
       ]
@@ -53,7 +52,6 @@
       "libraries": [],
       "libpath": [],
       "dependencies": [
-        "@stdlib/math/base/assert/is-odd",
         "@stdlib/constants/float32/ninf",
         "@stdlib/constants/float32/pinf"
       ]
@@ -69,7 +67,6 @@
       "libraries": [],
       "libpath": [],
       "dependencies": [
-        "@stdlib/math/base/assert/is-odd",
         "@stdlib/constants/float32/ninf",
         "@stdlib/constants/float32/pinf"
       ]
diff --git a/lib/node_modules/@stdlib/math/base/special/bernoullif/package.json b/lib/node_modules/@stdlib/math/base/special/bernoullif/package.json
@@ -56,7 +56,6 @@
     "stdmath",
     "mathematics",
     "math",
-    "special functions",
     "special",
     "function",
     "bernoulli",
diff --git a/lib/node_modules/@stdlib/math/base/special/bernoullif/src/addon.c b/lib/node_modules/@stdlib/math/base/special/bernoullif/src/addon.c
@@ -19,5 +19,4 @@
 #include "stdlib/math/base/special/bernoullif.h"
 #include "stdlib/math/base/napi/unary.h"
 
-// cppcheck-suppress shadowFunction
 STDLIB_MATH_BASE_NAPI_MODULE_I_F( stdlib_base_bernoullif )
diff --git a/lib/node_modules/@stdlib/math/base/special/bernoullif/src/main.c b/lib/node_modules/@stdlib/math/base/special/bernoullif/src/main.c
@@ -17,47 +17,46 @@
 */
 
 #include "stdlib/math/base/special/bernoullif.h"
-#include "stdlib/math/base/assert/is_odd.h"
 #include "stdlib/constants/float32/ninf.h"
 #include "stdlib/constants/float32/pinf.h"
+#include <stdint.h>
 
 static const float bernoulli_value[ 33 ] = {
-	1.0000000000000000f,
-	0.1666666666666666f,
-	-0.0333333333333333f,
-	0.0238095238095238f,
-	-0.0333333333333333f,
-	0.0757575757575757f,
-	-0.2531135531135531f,
-	1.1666666666666666f,
-	-7.0921568627450980f,
-	54.9711779448621553f,
-	-529.1242424242424242f,
-	6192.1231884057971014f,
-	-86580.2531135531135531f,
-	1.4255171666666666e+6f,
-	-2.7298231067816091e+7f,
-	6.0158087390064236e+8f,
-	-1.5116315767092156e+10f,
-	4.2961464306116666e+11f,
-	-1.3711655205088332e+13f,
-	4.8833231897359316e+14f,
-	-1.9296579341940068e+16f,
-	8.4169304757368261e+17f,
-	-4.0338071854059455e+19f,
-	2.1150748638081991e+21f,
-	-1.2086626522296525e+23f,
-	7.5008667460769643e+24f,
-	-5.0387781014810689e+26f,
-	3.6528776484818123e+28f,
-	-2.8498769302450882e+30f,
-	2.3865427499683627e+32f,
-	-2.1399949257225333e+34f,
-	2.0500975723478097e+36f,
+	1.0f,
+	0.1666666716337204f,
+	-0.03333333507180214f,
+	0.02380952425301075f,
+	-0.03333333507180214f,
+	0.07575757801532745f,
+	-0.2531135678291321f,
+	1.1666666269302368f,
+	-7.092156887054443f,
+	54.97117614746094f,
+	-529.124267578125f,
+	6192.123046875f,
+	-86580.25f,
+	1425517.125f,
+	-27298232.0f,
+	601580864.0f,
+	-15116315648.0f,
+	429614628864.0f,
+	-13711654780928.0f,
+	488332312182784.0f,
+	-19296579391324160.0f,
+	841693056053805000.0f,
+	-40338073359287845000.0f,
+	2.1150748918604188e+21f,
+	-1.2086626472668042e+23f,
+	7.500866956719485e+24f,
+	-5.038777949942763e+26f,
+	3.652877742276384e+28f,
+	-2.849876996904201e+30f,
+	2.386542781638813e+32f,
+	-2.1399950070596233e+34f,
+	2.050097633557977e+36f,
 	-2.0938006042234345e+38f
 };
 
-
 static const int32_t MAX_BERNOULLI = 64;
 
 /**
@@ -68,17 +67,17 @@ static const int32_t MAX_BERNOULLI = 64;
 *
 * @example
 * float out = stdlib_base_bernoullif( 0 );
-* // returns 1
+* // returns 1.0f
 */
 float stdlib_base_bernoullif( const int32_t n ) {
 	if ( n < 0 ) {
-		return 0.0 / 0.0; // NaN
+		return 0.0f / 0.0f; // NaN
 	}
 	if ( n == 1 ) {
-		return 0.5;
+		return 0.5f;
 	}
-	if ( stdlib_base_is_odd( n ) ) {
-		return 0.0;
+	if ( n & 1 ) {
+		return 0.0f;
 	}
 	if ( n > MAX_BERNOULLI ) {
 		return ( ( n / 2 ) & 1 ) ? STDLIB_CONSTANT_FLOAT32_PINF : STDLIB_CONSTANT_FLOAT32_NINF;
diff --git a/lib/node_modules/@stdlib/math/base/special/bernoullif/test/test.js b/lib/node_modules/@stdlib/math/base/special/bernoullif/test/test.js
diff --git a/lib/node_modules/@stdlib/math/base/special/bernoullif/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/bernoullif/test/test.native.js

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,6 @@ int main( void ) {`
`26`	`26`
`27`	`27`	`for ( i = 0; i < 70; i++ ) {`
`28`	`28`	`v = stdlib_base_bernoullif( i );`
`29`		`- printf( "bernoulli(%d) = %f\n", i, v );`
	`29`	`+ printf( "bernoullif(%d) = %f\n", i, v );`
`30`	`30`	`}`
`31`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`
`21`	`21`	`// MODULES //`
`22`	`22`
`23`		`-var isNonNegativeInteger = require( '@stdlib/math/base/assert/is-nonnegative-integer' );`
	`23`	`+var isNonNegativeIntegerf = require( '@stdlib/math/base/assert/is-nonnegative-integerf' );`
`24`	`24`	`var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );`
`25`	`25`	`var isnanf = require( '@stdlib/math/base/assert/is-nanf' );`
`26`	`26`	`var isOdd = require( '@stdlib/math/base/assert/is-odd' );`
`@@ -83,7 +83,7 @@ var MAX_BERNOULLI = 64\|0; // asm type annotation`
`83`	`83`	`* // returns NaN`
`84`	`84`	`*/`
`85`	`85`	`function bernoullif( n ) {`
`86`		`- if ( isnanf( n ) \|\| !isNonNegativeInteger( n ) ) {`
	`86`	`+ if ( isnanf( n ) \|\| !isNonNegativeIntegerf( n ) ) {`
`87`	`87`	`return NaN;`
`88`	`88`	`}`
`89`	`89`	`if ( n === 1 ) {`
`@@ -93,9 +93,9 @@ function bernoullif( n ) {`
`93`	`93`	`return 0.0;`
`94`	`94`	`}`
`95`	`95`	`if ( n > MAX_BERNOULLI ) {`
`96`		`- return ( ( n / 2 ) & 1 ) ? PINF : NINF;`
	`96`	`+ return ( (n/2)&1 ) ? PINF : NINF;`
`97`	`97`	`}`
`98`		`- return float64ToFloat32( BERNOULLIF[ n / 2 ] );`
	`98`	`+ return float64ToFloat32( BERNOULLIF[ n/2 ] );`
`99`	`99`	`}`
`100`	`100`
`101`	`101`
Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ var addon = require( './../src/addon.node' );`
`28`	`28`	`/**`
`29`	`29`	`* Computes the nth Bernoulli number as a single-precision floating-point number.`
`30`	`30`	`*`
	`31`	`+* @private`
`31`	`32`	`* @param {NonNegativeInteger} n - the Bernoulli number to compute`
`32`	`33`	`* @returns {number} Bernoulli number`
`33`	`34`	`*`