fix: ensure support for real-to-complex casting in boolean and mask array indexing

Author: kgryte

lib/node_modules/@stdlib/array/to-fancy/lib/set_elements.js

@@ -21,12 +21,15 @@
 // MODULES //
 
 var isMostlySafeCast = require( '@stdlib/array/base/assert/is-mostly-safe-data-type-cast' );
+var isRealDataType = require( '@stdlib/array/base/assert/is-real-data-type' );
+var isComplexDataType = require( '@stdlib/array/base/assert/is-complex-floating-point-data-type' );
 var isCollection = require( '@stdlib/assert/is-collection' );
 var scalar2array = require( '@stdlib/array/from-scalar' );
 var dtype = require( '@stdlib/array/dtype' );
 var put = require( '@stdlib/array/put' );
+var place = require( '@stdlib/array/place' );
+var convert = require( '@stdlib/array/convert' );
 var where = require( '@stdlib/array/base/where' ).assign;
-var place = require( '@stdlib/array/base/place' );
 var format = require( '@stdlib/string/format' );
 var prop2array = require( './prop2array.js' );
 var errMessage = require( './error_message.js' );
@@ -88,24 +91,31 @@ function setElements( target, property, value, ctx ) {
 		}
 		return true;
 	}
+	if ( idx.type === 'bool' ) {
+		try {
+			place( target, idx.data, v, {
+				'mode': 'strict_broadcast'
+			});
+		} catch ( err ) {
+			throw new err.constructor( errMessage( err.message ) );
+		}
+		return true;
+	}
 	if ( vdt === void 0 ) {
 		vdt = dtype( value ) || 'generic';
 	}
 	// Safe casts are always allowed and allow same kind casts (i.e., downcasts) only when the target array data type is floating-point...
 	if ( !isMostlySafeCast( vdt, tdt ) ) {
 		throw new TypeError( format( 'invalid operation. Assigned value cannot be safely cast to the target array data type. Data types: [%s, %s].', vdt, tdt ) );
 	}
-	if ( idx.type === 'bool' ) {
-		try {
-			place( target, idx.data, v, 'strict_broadcast' );
-		} catch ( err ) {
-			throw new err.constructor( errMessage( err.message ) );
-		}
-		return true;
+	// When performing a real-to-complex assignment, interpret the real-valued array as containing real components with implied imaginary components equal to zero and explicitly convert to a complex-valued array...
+	if ( isComplexDataType( tdt ) && isRealDataType( vdt ) ) {
+		v = convert( v, tdt );
 	}
 	if ( idx.type === 'mask' ) {
+		// NOTE: we intentionally deviate from boolean array indexing here and interpret the mask as applying to both the target and values array, thus requiring that the assigned value array be broadcast compatible with the target array and NOT just the selected elements as in boolean array indexing
 		try {
-			where( idx.data, target, v, target, 1, 0 ); // note: intentionally deviate from boolean array indexing here and interpret the mask as applying to both the target and values array, thus requiring that the assigned value array be broadcast compatible with the target array and NOT just the selected elements as in boolean array indexing
+			where( idx.data, target, v, target, 1, 0 );
 		} catch ( err ) {
 			throw new err.constructor( errMessage( err.message ) );
 		}

lib/node_modules/@stdlib/array/to-fancy/test/test.set.boolean_array.js

@@ -1052,6 +1052,51 @@ tape( 'the function returns an array-like object supporting casting (complex128,
 	t.end();
 });
 
+tape( 'the function returns an array-like object supporting casting (complex128, float64)', opts, function test( t ) {
+	var expected;
+	var idx;
+	var x;
+	var y;
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	idx = array2fancy.idx( [ true, true, true, true ] );
+	expected = new Complex128Array( [ 9, 0, 10, 0, 11, 0, 12, 0 ] );
+	y[ idx ] = new Float64Array( [ 9, 10, 11, 12 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	idx = array2fancy.idx( new BooleanArray( [ true, true, false, false ] ) );
+	expected = new Complex128Array( [ 17, 0, 18, 0, 5, 6, 7, 8 ] );
+	y[ idx ] = new Float64Array( [ 17, 18 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	idx = array2fancy.idx( [ false, true, true, false ] );
+	expected = new Complex128Array( [ 1, 2, 17, 0, 18, 0, 7, 8 ] );
+	y[ idx ] = new Float64Array( [ 17, 18 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	idx = array2fancy.idx( new BooleanArray( [ true, false, true, false ] ) );
+	expected = new Complex128Array( [ 17, 0, 3, 4, 18, 0, 7, 8 ] );
+	y[ idx ] = new Float64Array( [ 17, 18 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	t.end();
+});
+
 tape( 'the function returns an array-like object supporting downcasting of floating-point arrays (float32, float64)', opts, function test( t ) {
 	var expected;
 	var idx;

lib/node_modules/@stdlib/array/to-fancy/test/test.set.integer_array.js

@@ -1240,6 +1240,60 @@ tape( 'the function returns an array-like object supporting casting (complex128,
 	t.end();
 });
 
+tape( 'the function returns an array-like object supporting casting (complex128, float64)', opts, function test( t ) {
+	var expected;
+	var idx;
+	var x;
+	var y;
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	idx = array2fancy.idx( [ 0, 1, 2, 3 ] );
+	expected = new Complex128Array( [ 9, 0, 10, 0, 11, 0, 12, 0 ] );
+	y[ idx ] = new Float64Array( [ 9, 10, 11, 12 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	idx = array2fancy.idx( [ 0, 1 ] );
+	expected = new Complex128Array( [ 17, 0, 18, 0, 5, 6, 7, 8 ] );
+	y[ idx ] = new Float64Array( [ 17, 18 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	idx = array2fancy.idx( [ 1, 2 ] );
+	expected = new Complex128Array( [ 1, 2, 17, 0, 18, 0, 7, 8 ] );
+	y[ idx ] = new Float64Array( [ 17, 18 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	idx = array2fancy.idx( [ 0, 2 ] );
+	expected = new Complex128Array( [ 17, 0, 3, 4, 18, 0, 7, 8 ] );
+	y[ idx ] = new Float64Array( [ 17, 18 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	idx = array2fancy.idx( [ -1, -3 ] );
+	expected = new Complex128Array( [ 1, 2, 18, 0, 5, 6, 17, 0 ] );
+	y[ idx ] = new Float64Array( [ 17, 18 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	t.end();
+});
+
 tape( 'the function returns an array-like object supporting downcasting of floating-point arrays (float32, float64)', opts, function test( t ) {
 	var expected;
 	var idx;

lib/node_modules/@stdlib/array/to-fancy/test/test.set.mask_array.js

@@ -1052,6 +1052,51 @@ tape( 'the function returns an array-like object supporting casting (complex128,
 	t.end();
 });
 
+tape( 'the function returns an array-like object supporting casting (complex128, float64)', opts, function test( t ) {
+	var expected;
+	var idx;
+	var x;
+	var y;
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	idx = array2fancy.idx( new Uint8Array( [ 0, 0, 0, 0 ] ) );
+	expected = new Complex128Array( [ 9, 0, 10, 0, 11, 0, 12, 0 ] );
+	y[ idx ] = new Float64Array( [ 9, 10, 11, 12 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	idx = array2fancy.idx( new Uint8Array( [ 0, 0, 1, 1 ] ) );
+	expected = new Complex128Array( [ 17, 0, 18, 0, 5, 6, 7, 8 ] );
+	y[ idx ] = new Float64Array( [ 17, 18, 0, 0 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	idx = array2fancy.idx( new Uint8Array( [ 1, 0, 0, 1 ] ) );
+	expected = new Complex128Array( [ 1, 2, 17, 0, 18, 0, 7, 8 ] );
+	y[ idx ] = new Float64Array( [ 0, 17, 18, 0 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	idx = array2fancy.idx( new Uint8Array( [ 0, 1, 0, 1 ] ) );
+	expected = new Complex128Array( [ 17, 0, 3, 4, 18, 0, 7, 8 ] );
+	y[ idx ] = new Float64Array( [ 17, 0, 18, 0 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	t.end();
+});
+
 tape( 'the function returns an array-like object supporting downcasting of floating-point arrays (float32, float64)', opts, function test( t ) {
 	var expected;
 	var idx;

lib/node_modules/@stdlib/array/to-fancy/test/test.set.subsequence.js

@@ -1108,6 +1108,54 @@ tape( 'the function returns an array-like object supporting casting (complex128,
 	t.end();
 });
 
+tape( 'the function returns an array-like object supporting casting (complex128, float64)', opts, function test( t ) {
+	var expected;
+	var x;
+	var y;
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	expected = new Complex128Array( [ 9, 0, 10, 0, 11, 0, 12, 0 ] );
+	y[ ':' ] = new Float64Array( [ 9, 10, 11, 12 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	expected = new Complex128Array( [ 17, 0, 18, 0, 5, 6, 7, 8 ] );
+	y[ ':2' ] = new Float64Array( [ 17, 18 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	expected = new Complex128Array( [ 1, 2, 17, 0, 18, 0, 7, 8 ] );
+	y[ '1:3' ] = new Float64Array( [ 17, 18 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	expected = new Complex128Array( [ 17, 0, 3, 4, 18, 0, 7, 8 ] );
+	y[ '::2' ] = new Float64Array( [ 17, 18 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	x = new Complex128Array( [ 1, 2, 3, 4, 5, 6, 7, 8 ] );
+	y = array2fancy( x );
+
+	expected = new Complex128Array( [ 1, 2, 18, 0, 5, 6, 17, 0 ] );
+	y[ '-1::-2' ] = new Float64Array( [ 17, 18 ] );
+
+	t.strictEqual( isSameComplex128Array( y, expected ), true, 'returns expected value' );
+
+	t.end();
+});
+
 tape( 'the function returns an array-like object supporting downcasting of floating-point arrays (float32, float64)', opts, function test( t ) {
 	var expected;
 	var x;