fix: update math/base/special/tand to match correct reference implementation

anandkaranubc · web-flow · commit 874ec3b31654 · 2025-03-10T21:54:11.000-04:00
PR-URL: #5807 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
diff --git a/lib/node_modules/@stdlib/math/base/special/tand/lib/main.js b/lib/node_modules/@stdlib/math/base/special/tand/lib/main.js
@@ -20,10 +20,8 @@
 
 // MODULES //
 
-var tan = require( '@stdlib/math/base/special/tan' );
-var isInteger = require( '@stdlib/math/base/assert/is-integer' );
-var deg2rad = require( '@stdlib/math/base/special/deg2rad' );
-var isInfinite = require( '@stdlib/assert/is-infinite' );
+var sind = require( '@stdlib/math/base/special/sind' );
+var cosd = require( '@stdlib/math/base/special/cosd' );
 
 
 // MAIN //
@@ -51,23 +49,7 @@ var isInfinite = require( '@stdlib/assert/is-infinite' );
 * // returns NaN
 */
 function tand( x ) {
-	var xRad;
-
-	if ( isInfinite( x ) ) {
-		return NaN;
-	}
-
-	if ( isInteger( ( ( x / 90.0 ) - 1.0 ) / 2.0 ) ) {
-		return Infinity;
-	}
-
-	if ( isInteger( ( x / 90.0 ) / 2.0 ) ) {
-		return 0.0;
-	}
-
-	xRad = deg2rad( x );
-
-	return tan( xRad );
+	return sind( x ) / cosd( x );
 }
 
 
diff --git a/lib/node_modules/@stdlib/math/base/special/tand/manifest.json b/lib/node_modules/@stdlib/math/base/special/tand/manifest.json
@@ -37,10 +37,8 @@
       "libpath": [],
       "dependencies": [
         "@stdlib/math/base/napi/unary",
-        "@stdlib/math/base/special/deg2rad",
-        "@stdlib/math/base/special/tan",
-        "@stdlib/math/base/assert/is-integer",
-        "@stdlib/math/base/assert/is-infinite"
+        "@stdlib/math/base/special/sind",
+        "@stdlib/math/base/special/cosd"
       ]
     },
     {
@@ -54,10 +52,8 @@
       "libraries": [],
       "libpath": [],
       "dependencies": [
-        "@stdlib/math/base/special/deg2rad",
-        "@stdlib/math/base/special/tan",
-        "@stdlib/math/base/assert/is-integer",
-        "@stdlib/math/base/assert/is-infinite"
+        "@stdlib/math/base/special/sind",
+        "@stdlib/math/base/special/cosd"
       ]
     },
     {
@@ -71,10 +67,8 @@
       "libraries": [],
       "libpath": [],
       "dependencies": [
-        "@stdlib/math/base/special/deg2rad",
-        "@stdlib/math/base/special/tan",
-        "@stdlib/math/base/assert/is-integer",
-        "@stdlib/math/base/assert/is-infinite"
+        "@stdlib/math/base/special/sind",
+        "@stdlib/math/base/special/cosd"
       ]
     }
   ]
diff --git a/lib/node_modules/@stdlib/math/base/special/tand/src/main.c b/lib/node_modules/@stdlib/math/base/special/tand/src/main.c
@@ -17,10 +17,8 @@
 */
 
 #include "stdlib/math/base/special/tand.h"
-#include "stdlib/math/base/special/tan.h"
-#include "stdlib/math/base/special/deg2rad.h"
-#include "stdlib/math/base/assert/is_integer.h"
-#include "stdlib/math/base/assert/is_infinite.h"
+#include "stdlib/math/base/special/sind.h"
+#include "stdlib/math/base/special/cosd.h"
 
 /**
 * Computes the tangent of an angle measured in degrees.
@@ -33,16 +31,5 @@
 * // returns 0.0
 */
 double stdlib_base_tand( const double x ) {
-	double xRad;
-	if ( stdlib_base_is_infinite( x ) ) {
-		return 0.0 / 0.0; // NaN
-	}
-	if ( stdlib_base_is_integer( ( ( x / 90.0 ) - 1.0 ) / 2.0 ) ) {
-		return x / 0.0; // Infinity
-	}
-	if ( stdlib_base_is_integer( ( x / 90.0 ) / 2.0 ) ) {
-		return 0.0;
-	}
-	xRad = stdlib_base_deg2rad( x );
-	return stdlib_base_tan( xRad );
+	return stdlib_base_sind( x ) / stdlib_base_cosd( x );
 }
diff --git a/lib/node_modules/@stdlib/math/base/special/tand/test/fixtures/julia/negative.json b/lib/node_modules/@stdlib/math/base/special/tand/test/fixtures/julia/negative.json
diff --git a/lib/node_modules/@stdlib/math/base/special/tand/test/fixtures/julia/positive.json b/lib/node_modules/@stdlib/math/base/special/tand/test/fixtures/julia/positive.json
diff --git a/lib/node_modules/@stdlib/math/base/special/tand/test/fixtures/julia/runner.jl b/lib/node_modules/@stdlib/math/base/special/tand/test/fixtures/julia/runner.jl
@@ -19,7 +19,7 @@
 import JSON
 
 """
-    gen( domain, name )
+	gen( domain, name )
 
 Generate fixture data and write to file.
 
@@ -62,9 +62,9 @@ file = @__FILE__;
 dir = dirname( file );
 
 # Generate fixture data for negative values:
-x = range( -1.0, stop = -10.0, length = 1000 );
+x = range( -180.0, stop = 0.0, length = 1000 );
 gen( x, "negative.json" );
 
 # Generate fixture data for positive values:
-x = range( 1.0, stop = 10.0, length = 1000 );
+x = range( 0.0, stop = 180.0, length = 1000 );
 gen( x, "positive.json" );
diff --git a/lib/node_modules/@stdlib/math/base/special/tand/test/test.js b/lib/node_modules/@stdlib/math/base/special/tand/test/test.js
@@ -60,7 +60,7 @@ tape( 'the function computes the tangent of an angle measured in degrees (negati
 			t.equal( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] );
 		} else {
 			delta = abs( y - expected[i] );
-			tol = 1.4 * EPS * abs( expected[i] );
+			tol = 2.0 * EPS * abs( expected[i] );
 			t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' );
 		}
 	}
@@ -84,7 +84,7 @@ tape( 'the function computes the tangent of an angle measured in degrees (positi
 			t.equal( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] );
 		} else {
 			delta = abs( y - expected[i] );
-			tol = 1.4 * EPS * abs( expected[i] );
+			tol = 2.0 * EPS * abs( expected[i] );
 			t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' );
 		}
 	}
@@ -97,13 +97,13 @@ tape( 'if provided a `NaN`, the function returns `NaN`', function test( t ) {
 	t.end();
 });
 
-tape( 'if provided `+infinity`, the function returns `NaN`', function test( t ) {
+tape( 'if provided `+Infinity`, the function returns `NaN`', function test( t ) {
 	var v = tand( PINF );
 	t.equal( isnan( v ), true, 'returns expected value' );
 	t.end();
 });
 
-tape( 'if provided `-infinity`, the function returns `NaN`', function test( t ) {
+tape( 'if provided `-Infinity`, the function returns `NaN`', function test( t ) {
 	var v = tand( NINF );
 	t.equal( isnan( v ), true, 'returns expected value' );
 	t.end();
@@ -115,8 +115,8 @@ tape( 'if provided `90.0`, the function returns `Infinity`', function test( t )
 	t.end();
 });
 
-tape( 'if provided `180.0`, the function returns `Infinity`', function test( t ) {
-	var v = tand( 180.0 );
-	t.equal( v, 0.0, 'returns expected value' );
+tape( 'if provided `-90.0`, the function returns `-Infinity`', function test( t ) {
+	var v = tand( -90.0 );
+	t.equal( v, NINF, 'returns expected value' );
 	t.end();
 });
diff --git a/lib/node_modules/@stdlib/math/base/special/tand/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/tand/test/test.native.js
@@ -69,7 +69,7 @@ tape( 'the function computes the tangent of an angle measured in degrees (negati
 			t.equal( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] );
 		} else {
 			delta = abs( y - expected[i] );
-			tol = 1.4 * EPS * abs( expected[i] );
+			tol = 2.0 * EPS * abs( expected[i] );
 			t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' );
 		}
 	}
@@ -93,7 +93,7 @@ tape( 'the function computes the tangent of an angle measured in degrees (positi
 			t.equal( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] );
 		} else {
 			delta = abs( y - expected[i] );
-			tol = 1.4 * EPS * abs( expected[i] );
+			tol = 2.0 * EPS * abs( expected[i] );
 			t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' );
 		}
 	}
@@ -106,13 +106,13 @@ tape( 'if provided a `NaN`, the function returns `NaN`', opts, function test( t
 	t.end();
 });
 
-tape( 'if provided `+infinity`, the function returns `NaN`', opts, function test( t ) {
+tape( 'if provided `+Infinity`, the function returns `NaN`', opts, function test( t ) {
 	var v = tand( PINF );
 	t.equal( isnan( v ), true, 'returns expected value' );
 	t.end();
 });
 
-tape( 'if provided `-infinity`, the function returns `NaN`', opts, function test( t ) {
+tape( 'if provided `-Infinity`, the function returns `NaN`', opts, function test( t ) {
 	var v = tand( NINF );
 	t.equal( isnan( v ), true, 'returns expected value' );
 	t.end();
@@ -124,8 +124,8 @@ tape( 'if provided `90.0`, the function returns `Infinity`', opts, function test
 	t.end();
 });
 
-tape( 'if provided `180.0`, the function returns `Infinity`', opts, function test( t ) {
-	var v = tand( 180.0 );
-	t.equal( v, 0.0, 'returns expected value' );
+tape( 'if provided `-90.0`, the function returns `-Infinity`', opts, function test( t ) {
+	var v = tand( -90.0 );
+	t.equal( v, NINF, 'returns expected value' );
 	t.end();
 });

Original file line number	Diff line number	Diff line change
`@@ -37,10 +37,8 @@`
`37`	`37`	`"libpath": [],`
`38`	`38`	`"dependencies": [`
`39`	`39`	`"@stdlib/math/base/napi/unary",`
`40`		`- "@stdlib/math/base/special/deg2rad",`
`41`		`- "@stdlib/math/base/special/tan",`
`42`		`- "@stdlib/math/base/assert/is-integer",`
`43`		`- "@stdlib/math/base/assert/is-infinite"`
	`40`	`+ "@stdlib/math/base/special/sind",`
	`41`	`+ "@stdlib/math/base/special/cosd"`
`44`	`42`	`]`
`45`	`43`	`},`
`46`	`44`	`{`
`@@ -54,10 +52,8 @@`
`54`	`52`	`"libraries": [],`
`55`	`53`	`"libpath": [],`
`56`	`54`	`"dependencies": [`
`57`		`- "@stdlib/math/base/special/deg2rad",`
`58`		`- "@stdlib/math/base/special/tan",`
`59`		`- "@stdlib/math/base/assert/is-integer",`
`60`		`- "@stdlib/math/base/assert/is-infinite"`
	`55`	`+ "@stdlib/math/base/special/sind",`
	`56`	`+ "@stdlib/math/base/special/cosd"`
`61`	`57`	`]`
`62`	`58`	`},`
`63`	`59`	`{`
`@@ -71,10 +67,8 @@`
`71`	`67`	`"libraries": [],`
`72`	`68`	`"libpath": [],`
`73`	`69`	`"dependencies": [`
`74`		`- "@stdlib/math/base/special/deg2rad",`
`75`		`- "@stdlib/math/base/special/tan",`
`76`		`- "@stdlib/math/base/assert/is-integer",`
`77`		`- "@stdlib/math/base/assert/is-infinite"`
	`70`	`+ "@stdlib/math/base/special/sind",`
	`71`	`+ "@stdlib/math/base/special/cosd"`
`78`	`72`	`]`
`79`	`73`	`}`
`80`	`74`	`]`