refactor: use bitwise operation and make casting behavior explicit

gunjjoshi · web-flow · commit 5cd396ff2752 · 2024-08-03T12:29:06.000-07:00
PR-URL: #2733 Ref: 06b8011#r144990986 Ref: 06b8011#r144991031 Ref: 06b8011#r144991056 Reviewed-by: Athan Reines <kgryte@gmail.com>
diff --git a/lib/node_modules/@stdlib/math/base/special/binomcoef/benchmark/c/native/benchmark.c b/lib/node_modules/@stdlib/math/base/special/binomcoef/benchmark/c/native/benchmark.c
@@ -91,8 +91,8 @@ static double rand_double( void ) {
 */
 static double benchmark( void ) {
 	double elapsed;
-	double n;
-	double k;
+	int64_t n;
+	int64_t k;
 	double y;
 	double t;
 	int i;
diff --git a/lib/node_modules/@stdlib/math/base/special/binomcoef/manifest.json b/lib/node_modules/@stdlib/math/base/special/binomcoef/manifest.json
@@ -41,7 +41,6 @@
         "@stdlib/math/base/napi/binary",
         "@stdlib/math/base/special/floor",
         "@stdlib/math/base/special/gcd",
-        "@stdlib/math/base/assert/is-odd",
         "@stdlib/constants/float64/pinf",
         "@stdlib//constants/float64/max-safe-integer"
       ]
@@ -61,7 +60,6 @@
       "dependencies": [
         "@stdlib/math/base/special/floor",
         "@stdlib/math/base/special/gcd",
-        "@stdlib/math/base/assert/is-odd",
         "@stdlib/constants/float64/pinf",
         "@stdlib//constants/float64/max-safe-integer"
       ]
@@ -81,7 +79,6 @@
       "dependencies": [
         "@stdlib/math/base/special/floor",
         "@stdlib/math/base/special/gcd",
-        "@stdlib/math/base/assert/is-odd",
         "@stdlib/constants/float64/pinf",
         "@stdlib//constants/float64/max-safe-integer"
       ]
diff --git a/lib/node_modules/@stdlib/math/base/special/binomcoef/src/main.c b/lib/node_modules/@stdlib/math/base/special/binomcoef/src/main.c
@@ -19,7 +19,6 @@
 #include "stdlib/math/base/special/binomcoef.h"
 #include "stdlib/math/base/special/floor.h"
 #include "stdlib/math/base/special/gcd.h"
-#include "stdlib/math/base/assert/is_odd.h"
 #include "stdlib/constants/float64/pinf.h"
 #include "stdlib//constants/float64/max_safe_integer.h"
 #include <stdint.h>
@@ -53,7 +52,7 @@ double stdlib_base_binomcoef( const int64_t n, const int64_t k ) {
 	nc = n;
 	if ( nc < 0 ) {
 		nc = -nc + k - 1;
-		if ( stdlib_base_is_odd( (double)k ) ) {
+		if ( k & 1 ) {
 			sgn *= -1.0;
 		}
 	}
@@ -64,7 +63,7 @@ double stdlib_base_binomcoef( const int64_t n, const int64_t k ) {
 		return sgn;
 	}
 	if ( k == 1 || k == nc - 1 ) {
-		return sgn * nc;
+		return sgn * (double)nc;
 	}
 
 	// Minimize the number of computed terms by leveraging symmetry:

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@`
`19`	`19`	`#include "stdlib/math/base/special/binomcoef.h"`
`20`	`20`	`#include "stdlib/math/base/special/floor.h"`
`21`	`21`	`#include "stdlib/math/base/special/gcd.h"`
`22`		`-#include "stdlib/math/base/assert/is_odd.h"`
`23`	`22`	`#include "stdlib/constants/float64/pinf.h"`
`24`	`23`	`#include "stdlib//constants/float64/max_safe_integer.h"`
`25`	`24`	`#include <stdint.h>`
`@@ -53,7 +52,7 @@ double stdlib_base_binomcoef( const int64_t n, const int64_t k ) {`
`53`	`52`	`nc = n;`
`54`	`53`	`if ( nc < 0 ) {`
`55`	`54`	`nc = -nc + k - 1;`
`56`		`- if ( stdlib_base_is_odd( (double)k ) ) {`
	`55`	`+ if ( k & 1 ) {`
`57`	`56`	`sgn *= -1.0;`
`58`	`57`	`}`
`59`	`58`	`}`
`@@ -64,7 +63,7 @@ double stdlib_base_binomcoef( const int64_t n, const int64_t k ) {`
`64`	`63`	`return sgn;`
`65`	`64`	`}`
`66`	`65`	`if ( k == 1 \|\| k == nc - 1 ) {`
`67`		`- return sgn * nc;`
	`66`	`+ return sgn * (double)nc;`
`68`	`67`	`}`
`69`	`68`
`70`	`69`	`// Minimize the number of computed terms by leveraging symmetry:`