Skip to content

Commit 47209d7

Browse files
aman-095aman-095
committed
chore: apply review changes
1 parent 128bd2c commit 47209d7

File tree

8 files changed

+247
-44
lines changed

8 files changed

+247
-44
lines changed

‎lib/node_modules/@stdlib/blas/base/cscal/include/stdlib/blas/base/cscal.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
#ifndef CSCAL_H
2323
#define CSCAL_H
2424

25+
#include "stdlib/complex/float32.h"
26+
2527
/*
2628
* If C++, prevent name mangling so that the compiler emits a binary file having undecorated names, thus mirroring the behavior of a C compiler.
2729
*/
@@ -32,7 +34,7 @@ extern "C" {
3234
/**
3335
* Scales a single-precision complex floating-point vector by a single-precision complex floating-point constant.
3436
*/
35-
void c_cscal( const int N, const void *CA, const void *CX, const int strideX );
37+
void c_cscal( const int N, const stdlib_complex64_t CA, const void *CX, const int strideX );
3638

3739
#ifdef __cplusplus
3840
}

‎lib/node_modules/@stdlib/blas/base/cscal/include/stdlib/blas/base/cscal_cblas.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ extern "C" {
3434
/**
3535
* Scales a single-precision complex floating-point vector by a single-precision complex floating-point constant.
3636
*/
37-
void cblas_cscal( const int N, const void *CA, const void *CX, const int strideX );
37+
void cblas_cscal( const int N, const stdlib_complex64_t CA, const void *CX, const int strideX );
3838

3939
#ifdef __cplusplus
4040
}

‎lib/node_modules/@stdlib/blas/base/cscal/include/stdlib/blas/base/cscal_fortran.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ extern "C" {
3434
/**
3535
* Scales a single-precision complex floating-point vector by a single-precision complex floating-point constant.
3636
*/
37-
void cscal( const int *, const void *, const void *, const int * );
37+
void cscal( const int *, const stdlib_complex64_t *, const void *, const int * );
3838

3939
#ifdef __cplusplus
4040
}

‎lib/node_modules/@stdlib/blas/base/cscal/manifest.json

Lines changed: 234 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"options": {
3+
"task": "build",
34
"os": "linux",
45
"blas": "",
56
"wasm": false
@@ -28,6 +29,7 @@
2829
],
2930
"confs": [
3031
{
32+
"task": "build",
3133
"os": "linux",
3234
"blas": "",
3335
"wasm": false,
@@ -45,13 +47,47 @@
4547
"@stdlib/napi/argv",
4648
"@stdlib/napi/argv-int64",
4749
"@stdlib/napi/argv-strided-complex64array",
48-
"@stdlib/napi/argv-complex64array",
49-
"@stdlib/complex/float32",
50-
"@stdlib/math/base/napi/unary",
50+
"@stdlib/napi/argv-complex64",
51+
"stdlib/math/base/ops/cmulf"
52+
]
53+
},
54+
{
55+
"task": "benchmark",
56+
"os": "linux",
57+
"blas": "",
58+
"wasm": false,
59+
"src": [
60+
"./src/cscal.c"
61+
],
62+
"include": [
63+
"./include"
64+
],
65+
"libraries": [],
66+
"libpath": [],
67+
"dependencies": [
68+
"@stdlib/math/base/ops/cmulf"
69+
]
70+
},
71+
{
72+
"task": "examples",
73+
"os": "linux",
74+
"blas": "",
75+
"wasm": false,
76+
"src": [
77+
"./src/cscal.c"
78+
],
79+
"include": [
80+
"./include"
81+
],
82+
"libraries": [],
83+
"libpath": [],
84+
"dependencies": [
5185
"@stdlib/math/base/ops/cmulf"
5286
]
5387
},
88+
5489
{
90+
"task": "build",
5591
"os": "linux",
5692
"blas": "openblas",
5793
"wasm": false,
@@ -71,13 +107,49 @@
71107
"@stdlib/napi/argv",
72108
"@stdlib/napi/argv-int64",
73109
"@stdlib/napi/argv-strided-complex64array",
74-
"@stdlib/napi/argv-complex64array",
75-
"@stdlib/complex/float32",
76-
"@stdlib/math/base/napi/unary",
77-
"@stdlib/math/base/ops/cmulf"
110+
"@stdlib/napi/argv-complex64",
111+
"stdlib/math/base/ops/cmulf"
78112
]
79113
},
80114
{
115+
"task": "benchmark",
116+
"os": "linux",
117+
"blas": "openblas",
118+
"wasm": false,
119+
"src": [
120+
"./src/cscal_cblas.c"
121+
],
122+
"include": [
123+
"./include"
124+
],
125+
"libraries": [
126+
"-lopenblas",
127+
"-lpthread"
128+
],
129+
"libpath": [],
130+
"dependencies": []
131+
},
132+
{
133+
"task": "examples",
134+
"os": "linux",
135+
"blas": "openblas",
136+
"wasm": false,
137+
"src": [
138+
"./src/cscal_cblas.c"
139+
],
140+
"include": [
141+
"./include"
142+
],
143+
"libraries": [
144+
"-lopenblas",
145+
"-lpthread"
146+
],
147+
"libpath": [],
148+
"dependencies": []
149+
},
150+
151+
{
152+
"task": "build",
81153
"os": "mac",
82154
"blas": "",
83155
"wasm": false,
@@ -95,13 +167,47 @@
95167
"@stdlib/napi/argv",
96168
"@stdlib/napi/argv-int64",
97169
"@stdlib/napi/argv-strided-complex64array",
98-
"@stdlib/napi/argv-complex64array",
99-
"@stdlib/complex/float32",
100-
"@stdlib/math/base/napi/unary",
170+
"@stdlib/napi/argv-complex64",
171+
"stdlib/math/base/ops/cmulf"
172+
]
173+
},
174+
{
175+
"task": "benchmark",
176+
"os": "mac",
177+
"blas": "",
178+
"wasm": false,
179+
"src": [
180+
"./src/cscal.c"
181+
],
182+
"include": [
183+
"./include"
184+
],
185+
"libraries": [],
186+
"libpath": [],
187+
"dependencies": [
101188
"@stdlib/math/base/ops/cmulf"
102189
]
103190
},
104191
{
192+
"task": "examples",
193+
"os": "mac",
194+
"blas": "",
195+
"wasm": false,
196+
"src": [
197+
"./src/cscal.c"
198+
],
199+
"include": [
200+
"./include"
201+
],
202+
"libraries": [],
203+
"libpath": [],
204+
"dependencies": [
205+
"@stdlib/math/base/ops/cmulf"
206+
]
207+
},
208+
209+
{
210+
"task": "build",
105211
"os": "mac",
106212
"blas": "apple_accelerate_framework",
107213
"wasm": false,
@@ -120,13 +226,47 @@
120226
"@stdlib/napi/argv",
121227
"@stdlib/napi/argv-int64",
122228
"@stdlib/napi/argv-strided-complex64array",
123-
"@stdlib/napi/argv-complex64array",
124-
"@stdlib/complex/float32",
125-
"@stdlib/math/base/napi/unary",
126-
"@stdlib/math/base/ops/cmulf"
229+
"@stdlib/napi/argv-complex64",
230+
"stdlib/math/base/ops/cmulf"
127231
]
128232
},
129233
{
234+
"task": "benchmark",
235+
"os": "mac",
236+
"blas": "apple_accelerate_framework",
237+
"wasm": false,
238+
"src": [
239+
"./src/cscal_cblas.c"
240+
],
241+
"include": [
242+
"./include"
243+
],
244+
"libraries": [
245+
"-lblas"
246+
],
247+
"libpath": [],
248+
"dependencies": []
249+
},
250+
{
251+
"task": "examples",
252+
"os": "mac",
253+
"blas": "apple_accelerate_framework",
254+
"wasm": false,
255+
"src": [
256+
"./src/cscal_cblas.c"
257+
],
258+
"include": [
259+
"./include"
260+
],
261+
"libraries": [
262+
"-lblas"
263+
],
264+
"libpath": [],
265+
"dependencies": []
266+
},
267+
268+
{
269+
"task": "build",
130270
"os": "mac",
131271
"blas": "openblas",
132272
"wasm": false,
@@ -146,13 +286,49 @@
146286
"@stdlib/napi/argv",
147287
"@stdlib/napi/argv-int64",
148288
"@stdlib/napi/argv-strided-complex64array",
149-
"@stdlib/napi/argv-complex64array",
150-
"@stdlib/complex/float32",
151-
"@stdlib/math/base/napi/unary",
152-
"@stdlib/math/base/ops/cmulf"
289+
"@stdlib/napi/argv-complex64",
290+
"stdlib/math/base/ops/cmulf"
153291
]
154292
},
155293
{
294+
"task": "benchmark",
295+
"os": "mac",
296+
"blas": "openblas",
297+
"wasm": false,
298+
"src": [
299+
"./src/cscal_cblas.c"
300+
],
301+
"include": [
302+
"./include"
303+
],
304+
"libraries": [
305+
"-lopenblas",
306+
"-lpthread"
307+
],
308+
"libpath": [],
309+
"dependencies": []
310+
},
311+
{
312+
"task": "examples",
313+
"os": "mac",
314+
"blas": "openblas",
315+
"wasm": false,
316+
"src": [
317+
"./src/cscal_cblas.c"
318+
],
319+
"include": [
320+
"./include"
321+
],
322+
"libraries": [
323+
"-lopenblas",
324+
"-lpthread"
325+
],
326+
"libpath": [],
327+
"dependencies": []
328+
},
329+
330+
{
331+
"task": "build",
156332
"os": "win",
157333
"blas": "",
158334
"wasm": false,
@@ -169,13 +345,47 @@
169345
"@stdlib/napi/argv",
170346
"@stdlib/napi/argv-int64",
171347
"@stdlib/napi/argv-strided-complex64array",
172-
"@stdlib/napi/argv-complex64array",
173-
"@stdlib/complex/float32",
174-
"@stdlib/math/base/napi/unary",
348+
"@stdlib/napi/argv-complex64",
349+
"stdlib/math/base/ops/cmulf"
350+
]
351+
},
352+
{
353+
"task": "benchmark",
354+
"os": "win",
355+
"blas": "",
356+
"wasm": false,
357+
"src": [
358+
"./src/cscal.c"
359+
],
360+
"include": [
361+
"./include"
362+
],
363+
"libraries": [],
364+
"libpath": [],
365+
"dependencies": [
175366
"@stdlib/math/base/ops/cmulf"
176367
]
177368
},
178369
{
370+
"task": "examples",
371+
"os": "win",
372+
"blas": "",
373+
"wasm": false,
374+
"src": [
375+
"./src/cscal.c"
376+
],
377+
"include": [
378+
"./include"
379+
],
380+
"libraries": [],
381+
"libpath": [],
382+
"dependencies": [
383+
"@stdlib/math/base/ops/cmulf"
384+
]
385+
},
386+
387+
{
388+
"task": "build",
179389
"os": "",
180390
"blas": "",
181391
"wasm": true,
@@ -187,7 +397,9 @@
187397
],
188398
"libraries": [],
189399
"libpath": [],
190-
"dependencies": []
400+
"dependencies": [
401+
"@stdlib/math/base/ops/cmulf"
402+
]
191403
}
192404
]
193405
}

‎lib/node_modules/@stdlib/blas/base/cscal/src/addon.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
#include "stdlib/napi/argv.h"
2222
#include "stdlib/napi/argv_int64.h"
2323
#include "stdlib/napi/argv_strided_complex64array.h"
24-
#include "stdlib/napi/argv_complex64array.h"
24+
#include "stdlib/napi/argv_complex64.h"
2525
#include "stdlib/math/base/napi/unary.h"
2626
#include <node_api.h>
2727

@@ -38,10 +38,9 @@ static napi_value addon( napi_env env, napi_callback_info info ) {
3838
STDLIB_NAPI_ARGV( env, info, argv, argc, 4 );
3939
STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 );
4040
STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 3 );
41-
// STDLIB_MATH_BASE_NAPI_MODULE_C_C( CA );
42-
STDLIB_NAPI_ARGV_COMPLEX64ARRAY( env, CA, CA_len, argv, 1 );
41+
STDLIB_NAPI_ARGV_COMPLEX64( env, CA, argv, 1 );
4342
STDLIB_NAPI_ARGV_STRIDED_COMPLEX64ARRAY( env, CX, N, strideX, argv, 2 );
44-
c_cscal( N, (void *)CA, (void *)CX, strideX );
43+
c_cscal( N, CA, (void *)CX, strideX );
4544
return NULL;
4645
}
4746

0 commit comments

Comments
 (0)