Skip to content

Commit 30fcf84

Browse files
authored
chore: apply suggestions from code review
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
1 parent 5374d17 commit 30fcf84

File tree

3 files changed

+17
-7
lines changed

3 files changed

+17
-7
lines changed

lib/node_modules/@stdlib/stats/base/dists/bernoulli/quantile/README.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ for ( i = 0; i < 10; i++ ) {
173173

174174
#### stdlib_base_dists_bernoulli_quantile( r, p )
175175

176-
Returns the [quantile][quantile-function] of a [Bernoulli][bernoulli-distribution] distribution with input value `r` and success probability `p`.
176+
Evaluates the [quantile][quantile-function] of a [Bernoulli][bernoulli-distribution] distribution with input value `r` and success probability `p`.
177177

178178
```c
179179
double out = stdlib_base_dists_bernoulli_quantile( 0.8, 0.4 );
@@ -212,15 +212,20 @@ double stdlib_base_dists_bernoulli_quantile( const double r, const double p );
212212
#include <stdlib.h>
213213
#include <stdio.h>
214214
215+
static double random_uniform( const double min, const double max ) {
216+
double v = (double)rand() / ( (double)RAND_MAX + 1.0 );
217+
return min + ( v * ( max - min ) );
218+
}
219+
215220
int main( void ) {
216221
double r;
217222
double p;
218223
double y;
219224
int i;
220225
221226
for ( i = 0; i < 10; i++ ) {
222-
r = (double)rand() / ( (double)RAND_MAX + 1.0 );
223-
p = (double)rand() / ( (double)RAND_MAX + 1.0 );
227+
r = random_uniform( 0.0, 1.0 );
228+
p = random_uniform( 0.0, 1.0 );
224229
y = stdlib_base_dists_bernoulli_quantile( r, p );
225230
printf( "r: %lf, p: %lf, Q(r;p): %lf\n", r, p, y );
226231
}

lib/node_modules/@stdlib/stats/base/dists/bernoulli/quantile/examples/c/example.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,20 @@
2020
#include <stdlib.h>
2121
#include <stdio.h>
2222

23+
static double random_uniform( const double min, const double max ) {
24+
double v = (double)rand() / ( (double)RAND_MAX + 1.0 );
25+
return min + ( v * ( max - min ) );
26+
}
27+
2328
int main( void ) {
2429
double r;
2530
double p;
2631
double y;
2732
int i;
2833

2934
for ( i = 0; i < 10; i++ ) {
30-
r = (double)rand() / ( (double)RAND_MAX + 1.0 );
31-
p = (double)rand() / ( (double)RAND_MAX + 1.0 );
35+
r = random_uniform( 0.0, 1.0 );
36+
p = random_uniform( 0.0, 1.0 );
3237
y = stdlib_base_dists_bernoulli_quantile( r, p );
3338
printf( "r: %lf, p: %lf, Q(r;p): %lf\n", r, p, y );
3439
}

lib/node_modules/@stdlib/stats/base/dists/bernoulli/quantile/src/main.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
* @return evaluated quantile function
2828
*
2929
* @example
30-
* double y = stdlib_base_bernoulli_quantile( 0.8, 0.4 );
30+
* double y = stdlib_base_dists_bernoulli_quantile( 0.8, 0.4 );
3131
* // returns 1
3232
*/
3333
double stdlib_base_dists_bernoulli_quantile( const double r, const double p ) {
@@ -41,7 +41,7 @@ double stdlib_base_dists_bernoulli_quantile( const double r, const double p ) {
4141
) {
4242
return 0.0/0.0; // NaN
4343
}
44-
if( r <= 1.0 - p ) {
44+
if ( r <= 1.0 - p ) {
4545
return 0.0;
4646
}
4747
return 1.0;

0 commit comments

Comments
 (0)