Skip to content

Commit 18f0198

Browse files
committed
fix: correct return types
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 3767801 commit 18f0198

File tree

5 files changed

+34
-37
lines changed

5 files changed

+34
-37
lines changed

lib/node_modules/@stdlib/math/base/special/minmaxf/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,20 +46,20 @@ Returns the minimum and maximum of two single-precision floating-point numbers i
4646

4747
```javascript
4848
var v = minmaxf( 4.2, 3.14 );
49-
// returns <Float32Array>[ 3.14, 4.2 ]
49+
// returns [ 3.14, 4.2 ]
5050

5151
v = minmaxf( +0.0, -0.0 );
52-
// returns <Float32Array>[ -0.0, +0.0 ]
52+
// returns [ -0.0, +0.0 ]
5353
```
5454

5555
If any argument is `NaN`, the function returns `NaN` for both the minimum value and the maximum value.
5656

5757
```javascript
5858
var v = minmaxf( 4.2, NaN );
59-
// returns <Float32Array>[ NaN, NaN ]
59+
// returns [ NaN, NaN ]
6060

6161
v = minmaxf( NaN, 3.14 );
62-
// returns <Float32Array>[ NaN, NaN ]
62+
// returns [ NaN, NaN ]
6363
```
6464

6565
#### minmaxf.assign( x, y, out, stride, offset )

lib/node_modules/@stdlib/math/base/special/minmaxf/lib/assign.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,22 +38,22 @@ var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
3838
* @returns {Collection} minimum and maximum values
3939
*
4040
* @example
41-
* var out = new Float32Array( 2 );
41+
* var out = [ 0.0, 0.0 ];
4242
* var v = minmaxf( 3.14, 4.2, out, 1, 0 );
43-
* // returns <Float32Array>[ 3.14, 4.2 ]
43+
* // returns [ 3.14, 4.2 ]
4444
*
4545
* var bool = ( v === out );
4646
* // returns true
4747
*
4848
* @example
49-
* var out = new Float32Array( 2 );
49+
* var out = [ 0.0, 0.0 ];
5050
* var v = minmaxf( 3.14, NaN, out, 1, 0 );
51-
* // returns <Float32Array>[ NaN, NaN ]
51+
* // returns [ NaN, NaN ]
5252
*
5353
* @example
54-
* var out = new Float32Array( 2 );
54+
* var out = [ 0.0, 0.0 ];
5555
* var v = minmaxf( +0.0, -0.0, out, 1, 0 );
56-
* // returns <Float32Array>[ -0.0, 0.0 ]
56+
* // returns [ -0.0, 0.0 ]
5757
*/
5858
function minmaxf( x, y, out, stride, offset ) {
5959
if ( isnanf( x ) || isnanf( y ) ) {

lib/node_modules/@stdlib/math/base/special/minmaxf/lib/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@
2727
* var minmaxf = require( '@stdlib/math/base/special/minmaxf' );
2828
*
2929
* var v = minmaxf( 3.14, 4.2 );
30-
* // returns <Float32Array>[ 3.14, 4.2 ]
30+
* // returns [ 3.14, 4.2 ]
3131
*
3232
* v = minmaxf( 3.14, NaN );
33-
* // returns <Float32Array>[ NaN, NaN ]
33+
* // returns [ NaN, NaN ]
3434
*
3535
* v = minmaxf( +0.0, -0.0 );
36-
* // returns <Float32Array>[ -0.0, 0.0 ]
36+
* // returns [ -0.0, 0.0 ]
3737
*
3838
*/
3939

lib/node_modules/@stdlib/math/base/special/minmaxf/lib/main.js

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
// MODULES //
2222

2323
var assign = require( './assign.js' );
24-
var Float32Array = require( '@stdlib/array/float32' );
2524

2625

2726
// MAIN //
@@ -31,23 +30,22 @@ var Float32Array = require( '@stdlib/array/float32' );
3130
*
3231
* @param {number} x - first number
3332
* @param {number} y - second number
34-
* @returns {Float32Array} minimum and maximum values
33+
* @returns {Array<number>} minimum and maximum values
3534
*
3635
* @example
3736
* var v = minmaxf( 3.14, 4.2 );
38-
* // returns <Float32Array>[ 3.14, 4.2 ]
37+
* // returns [ 3.14, 4.2 ]
3938
*
4039
* @example
4140
* var v = minmaxf( 3.14, NaN );
42-
* // returns <Float32Array>[ NaN, NaN ]
41+
* // returns [ NaN, NaN ]
4342
*
4443
* @example
4544
* var v = minmaxf( +0.0, -0.0 );
46-
* // returns <Float32Array>[ -0.0, 0.0 ]
45+
* // returns [ -0.0, 0.0 ]
4746
*/
4847
function minmaxf( x, y ) {
49-
var out = new Float32Array( 2 );
50-
return assign( x, y, out, 1, 0 );
48+
return assign( x, y, [ 0.0, 0.0 ], 1, 0 );
5149
}
5250

5351

lib/node_modules/@stdlib/math/base/special/minmaxf/test/test.main.js

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ var tape = require( 'tape' );
2424
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
2525
var isNegativeZerof = require( '@stdlib/math/base/assert/is-negative-zerof' );
2626
var isPositiveZerof = require( '@stdlib/math/base/assert/is-positive-zerof' );
27-
var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
2827
var PINF = require( '@stdlib/constants/float32/pinf' );
2928
var NINF = require( '@stdlib/constants/float32/ninf' );
3029
var minmaxf = require( './../lib/main.js' );
@@ -41,11 +40,11 @@ tape( 'main export is a function', function test( t ) {
4140
tape( 'the function returns `NaN` for both the minimum and maximum value if provided a `NaN`', function test( t ) {
4241
var v;
4342

44-
v = minmaxf( NaN, float64ToFloat32( 3.14 ) );
43+
v = minmaxf( NaN, 3.14 );
4544
t.strictEqual( isnanf( v[ 0 ] ), true, 'returns expected value' );
4645
t.strictEqual( isnanf( v[ 1 ] ), true, 'returns expected value' );
4746

48-
v = minmaxf( float64ToFloat32( 3.14 ), NaN );
47+
v = minmaxf( 3.14, NaN );
4948
t.strictEqual( isnanf( v[ 0 ] ), true, 'returns expected value' );
5049
t.strictEqual( isnanf( v[ 1 ] ), true, 'returns expected value' );
5150

@@ -59,26 +58,26 @@ tape( 'the function returns `NaN` for both the minimum and maximum value if prov
5958
tape( 'the function returns `-Infinity` as the minimum value if provided `-Infinity`', function test( t ) {
6059
var v;
6160

62-
v = minmaxf( NINF, float64ToFloat32( 3.14 ) );
61+
v = minmaxf( NINF, 3.14 );
6362
t.strictEqual( v[ 0 ], NINF, 'returns expected value' );
64-
t.strictEqual( v[ 1 ], float64ToFloat32( 3.14 ), 'returns expected value' );
63+
t.strictEqual( v[ 1 ], 3.14, 'returns expected value' );
6564

66-
v = minmaxf( float64ToFloat32( 3.14 ), NINF );
65+
v = minmaxf( 3.14, NINF );
6766
t.strictEqual( v[ 0 ], NINF, 'returns expected value' );
68-
t.strictEqual( v[ 1 ], float64ToFloat32( 3.14 ), 'returns expected value' );
67+
t.strictEqual( v[ 1 ], 3.14, 'returns expected value' );
6968

7069
t.end();
7170
});
7271

7372
tape( 'the function returns `+Infinity` as the maximum value if provided `+Infinity`', function test( t ) {
7473
var v;
7574

76-
v = minmaxf( PINF, float64ToFloat32( 3.14 ) );
77-
t.strictEqual( v[ 0 ], float64ToFloat32( 3.14 ), 'returns expected value' );
75+
v = minmaxf( PINF, 3.14 );
76+
t.strictEqual( v[ 0 ], 3.14, 'returns expected value' );
7877
t.strictEqual( v[ 1 ], PINF, 'returns expected value' );
7978

80-
v = minmaxf( float64ToFloat32( 3.14 ), PINF );
81-
t.strictEqual( v[ 0 ], float64ToFloat32( 3.14 ), 'returns expected value' );
79+
v = minmaxf( 3.14, PINF );
80+
t.strictEqual( v[ 0 ], 3.14, 'returns expected value' );
8281
t.strictEqual( v[ 1 ], PINF, 'returns expected value' );
8382

8483
t.end();
@@ -109,13 +108,13 @@ tape( 'the function returns correctly signed zeros', function test( t ) {
109108
tape( 'the function returns the minimum and maximum values', function test( t ) {
110109
var v;
111110

112-
v = minmaxf( float64ToFloat32( 4.2 ), float64ToFloat32( 3.14 ) );
113-
t.strictEqual( v[ 0 ], float64ToFloat32( 3.14 ), 'returns expected value' );
114-
t.strictEqual( v[ 1 ], float64ToFloat32( 4.2 ), 'returns expected value' );
111+
v = minmaxf( 4.2, 3.14 );
112+
t.strictEqual( v[ 0 ], 3.14, 'returns expected value' );
113+
t.strictEqual( v[ 1 ], 4.2, 'returns expected value' );
115114

116-
v = minmaxf( -float64ToFloat32( 4.2 ), float64ToFloat32( 3.14 ) );
117-
t.strictEqual( v[ 0 ], -float64ToFloat32( 4.2 ), 'returns expected value' );
118-
t.strictEqual( v[ 1 ], float64ToFloat32( 3.14 ), 'returns expected value' );
115+
v = minmaxf( -4.2, 3.14 );
116+
t.strictEqual( v[ 0 ], -4.2, 'returns expected value' );
117+
t.strictEqual( v[ 1 ], 3.14, 'returns expected value' );
119118

120119
t.end();
121120
});

0 commit comments

Comments
 (0)