Fix clippy 1.67.0 warnings (#555)

## Description

Fix warnings of clippy 1.67.0. We have not bumped yet but I'm fixing them early on
Please review commits individually

Author: sbernauer

src/builder/pod/container.rs

@@ -323,8 +323,8 @@ impl fmt::Display for FieldPathEnvVar {
             FieldPathEnvVar::Name => write!(f, "metadata.name"),
             FieldPathEnvVar::Namespace => write!(f, "metadata.namespace"),
             FieldPathEnvVar::UID => write!(f, "metadata.uid"),
-            FieldPathEnvVar::Labels(name) => write!(f, "metadata.labels['{}']", name),
-            FieldPathEnvVar::Annotations(name) => write!(f, "metadata.annotations['{}']", name),
+            FieldPathEnvVar::Labels(name) => write!(f, "metadata.labels['{name}']"),
+            FieldPathEnvVar::Annotations(name) => write!(f, "metadata.annotations['{name}']"),
         }
     }
 }

src/cli.rs

@@ -224,7 +224,9 @@ impl ProductConfigPath {
             self.path.as_deref(),
             default_search_paths,
         )?)
-        .map_err(|source| error::Error::ProductConfigLoadError { source })
+        .map_err(|source| error::Error::ProductConfigLoadError {
+            source: source.into(),
+        })
     }
 }
 

src/client.rs

@@ -57,7 +57,7 @@ impl Client {
         // According to https://kubernetes.io/docs/reference/using-api/server-side-apply/#using-server-side-apply-in-a-controller we should always force conflicts in controllers.
         params.force = true;
         if let Some(manager) = &mut params.field_manager {
-            *manager = format!("{}/{}", manager, field_manager_scope);
+            *manager = format!("{manager}/{field_manager_scope}");
         }
         params
     }

src/commons/opa.rs

@@ -319,11 +319,10 @@ mod tests {
             apiVersion: test/v1
             kind: TestCluster
             metadata:
-              name: {}
+              name: {CLUSTER_NAME}
             spec:
               test: 100
-            ",
-            CLUSTER_NAME
+            "
         ))
         .unwrap()
     }

src/error.rs

@@ -55,7 +55,7 @@ pub enum Error {
     #[error("Failed to load ProductConfig: {source}")]
     ProductConfigLoadError {
         #[source]
-        source: product_config::error::Error,
+        source: Box<product_config::error::Error>,
     },
 
     #[error("ProductConfig Framework reported error: {source}")]

src/label_selector.rs

@@ -18,7 +18,7 @@ pub fn convert_label_selector_to_query_string(
         query_string.push_str(
             &label_map
                 .iter()
-                .map(|(key, value)| format!("{}={}", key, value))
+                .map(|(key, value)| format!("{key}={value}"))
                 .collect::<Vec<_>>()
                 .join(","),
         );
@@ -51,8 +51,7 @@ pub fn convert_label_selector_to_query_string(
                     )),
                     _ => Err(Error::InvalidLabelSelector {
                         message: format!(
-                            "LabelSelector has no or empty values for [{}] operator",
-                            operator
+                            "LabelSelector has no or empty values for [{operator}] operator"
                         ),
                     }),
                 },
@@ -75,7 +74,7 @@ pub fn convert_label_selector_to_query_string(
                 op => {
                     Err(
                         Error::InvalidLabelSelector {
-                            message: format!("LabelSelector has illegal/unknown operator [{}]", op)
+                            message: format!("LabelSelector has illegal/unknown operator [{op}]")
                         })
                 }
             })

src/logging/k8s_events.rs

@@ -21,7 +21,7 @@ fn error_to_event<E: ReconcilerError>(err: &E) -> Event {
         loop {
             err = match err.source() {
                 Some(err) => {
-                    write!(buf, ": {}", err).unwrap();
+                    write!(buf, ": {err}").unwrap();
                     err
                 }
                 None => break buf,

src/memory.rs

@@ -128,7 +128,7 @@ pub fn to_java_heap_value(
     if scaled.value < 1.0 {
         Err(Error::CannotConvertToJavaHeapValue {
             value: q.0.to_owned(),
-            target_unit: format!("{:?}", target_unit),
+            target_unit: format!("{target_unit:?}"),
         })
     } else {
         Ok(scaled.value as u32)

src/product_config_utils.rs

@@ -111,7 +111,7 @@ pub type ValidatedRoleConfigByPropertyKind =
 /// # Arguments
 /// - `role`        - The role name.
 /// - `group`       - The role group name.
-/// - `role_config` - The validated product configuration for each role and group.  
+/// - `role_config` - The validated product configuration for each role and group.
 pub fn config_for_role_and_group<'a>(
     role: &str,
     group: &str,
@@ -166,7 +166,7 @@ where
 }
 
 /// Validates a product configuration for all roles and role_groups. Requires a valid product config
-/// and [`RoleConfigByPropertyKind`] which can be obtained via `transform_all_roles_to_config`.  
+/// and [`RoleConfigByPropertyKind`] which can be obtained via `transform_all_roles_to_config`.
 ///
 /// # Arguments
 /// - `version`            - The version of the product to be configured.
@@ -209,7 +209,7 @@ pub fn validate_all_roles_and_groups_config(
 
 /// Calculates and validates a product configuration for a role and group. Requires a valid
 /// product config and existing [`RoleConfigByPropertyKind`] that can be obtained via
-/// `transform_all_roles_to_config`.  
+/// `transform_all_roles_to_config`.
 ///
 /// # Arguments
 /// - `role`               - The name of the role
@@ -1223,46 +1223,37 @@ mod tests {
             spec:
               units: []
             properties:
-              - property: 
+              - property:
                   propertyNames:
-                    - name: \"{}\"
+                    - name: \"{pc_name}\"
                       kind:
                         type: \"file\"
-                        file: \"{}\"
+                        file: \"{file_name}\"
                   datatype:
                     type: \"string\"
                   recommendedValues:
-                    - value: \"{}\"
+                    - value: \"{pc_value}\"
                   roles:
-                    - name: \"{}\"
+                    - name: \"{role_1}\"
                       required: true
-                    - name: \"{}\"
+                    - name: \"{role_2}\"
                       required: true
                   asOfVersion: \"0.0.0\"
-              - property: 
+              - property:
                   propertyNames:
-                    - name: \"{}\"
+                    - name: \"{pc_bad_version}\"
                       kind:
                         type: \"file\"
-                        file: \"{}\"
+                        file: \"{file_name}\"
                   datatype:
                     type: \"string\"
                   recommendedValues:
-                    - value: \"{}\"
+                    - value: \"{pc_bad_version_value}\"
                   roles:
-                    - name: \"{}\"
+                    - name: \"{role_1}\"
                       required: true
                   asOfVersion: \"0.5.0\"
-            ",
-            pc_name,
-            file_name,
-            pc_value,
-            role_1,
-            role_2,
-            pc_bad_version,
-            file_name,
-            pc_bad_version_value,
-            role_1
+            "
         );
 
         let product_config = ProductConfigManager::from_str(config).unwrap();

src/utils.rs

@@ -37,7 +37,7 @@ pub fn print_startup_string(
 ) {
     let git_information = match git_version {
         None => "".to_string(),
-        Some(git) => format!(" (Git information: {})", git),
+        Some(git) => format!(" (Git information: {git})"),
     };
     info!("Starting {}", pkg_description);
     info!(

src/validation.rs

@@ -32,16 +32,16 @@ const RFC_1035_LABEL_MAX_LENGTH: usize = 63;
 
 lazy_static! {
     static ref RFC_1123_SUBDOMAIN_REGEX: Regex =
-        Regex::new(&format!("^{}$", RFC_1123_SUBDOMAIN_FMT)).unwrap();
+        Regex::new(&format!("^{RFC_1123_SUBDOMAIN_FMT}$")).unwrap();
     static ref RFC_1123_LABEL_REGEX: Regex =
-        Regex::new(&format!("^{}$", RFC_1123_SUBDOMAIN_FMT)).unwrap();
+        Regex::new(&format!("^{RFC_1123_SUBDOMAIN_FMT}$")).unwrap();
     static ref RFC_1035_LABEL_REGEX: Regex =
-        Regex::new(&format!("^{}$", RFC_1035_LABEL_FMT)).unwrap();
+        Regex::new(&format!("^{RFC_1035_LABEL_FMT}$")).unwrap();
 }
 
 /// Returns a formatted error message for maximum length violations.
 fn max_len_error(length: usize) -> String {
-    format!("must be no more than {} characters", length)
+    format!("must be no more than {length} characters")
 }
 
 /// Returns a formatted error message for regex violations.
@@ -53,7 +53,7 @@ fn max_len_error(length: usize) -> String {
 /// * `examples` - are optional well, formed examples that would match the regex
 fn regex_error(msg: &str, fmt: &str, examples: &[&str]) -> String {
     if examples.is_empty() {
-        return format!("{} (regex used for validation is '{}')", msg, fmt);
+        return format!("{msg} (regex used for validation is '{fmt}')");
     }
 
     let mut msg = msg.to_string();