Skip to content

Commit 038a830

Browse files
committed
chore: Remove instrumentation from trivial functions
Note: These functions are not cpu/io bound, so they are rather uninteresting in the context of tracing.
1 parent d62914b commit 038a830

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

crates/stackable-operator/src/builder/pod/container.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ use k8s_openapi::api::core::v1::{
77
SecurityContext, VolumeMount,
88
};
99
use snafu::{ResultExt as _, Snafu};
10-
use tracing::instrument;
1110
#[cfg(doc)]
1211
use {k8s_openapi::api::core::v1::PodSpec, std::collections::BTreeMap};
1312

@@ -211,7 +210,6 @@ impl ContainerBuilder {
211210
///
212211
/// Previously, this function unconditionally added [`VolumeMount`]s, which resulted in invalid
213212
/// [`PodSpec`]s.
214-
#[instrument(skip(self))]
215213
fn add_volume_mount_impl(&mut self, volume_mount: VolumeMount) -> Result<&mut Self> {
216214
if let Some(existing_volume_mount) = self.volume_mounts.get(&volume_mount.mount_path) {
217215
if existing_volume_mount != &volume_mount {

crates/stackable-operator/src/builder/pod/mod.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ use k8s_openapi::{
1010
apimachinery::pkg::{api::resource::Quantity, apis::meta::v1::ObjectMeta},
1111
};
1212
use snafu::{OptionExt, ResultExt, Snafu};
13-
use tracing::{instrument, warn};
13+
use tracing::warn;
1414

1515
use crate::{
1616
builder::{
@@ -291,7 +291,6 @@ impl PodBuilder {
291291
///
292292
/// Previously, this function unconditionally added [`Volume`]s, which resulted in invalid
293293
/// [`PodSpec`]s.
294-
#[instrument(skip(self))]
295294
pub fn add_volume(&mut self, volume: Volume) -> Result<&mut Self> {
296295
if let Some(existing_volume) = self.volumes.get(&volume.name) {
297296
if existing_volume != &volume {

0 commit comments

Comments
 (0)