Skip to content

Commit 2913081

Browse files
committed
Remove version from persistent PVCs
It broke upgrading
1 parent 853d5f1 commit 2913081

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

rust/operator-binary/src/kafka_controller.rs

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -797,6 +797,16 @@ fn build_broker_rolegroup_statefulset(
797797
);
798798
let recommended_labels =
799799
Labels::recommended(recommended_object_labels.clone()).context(LabelBuildSnafu)?;
800+
// Used for PVC templates that cannot be modified once they are deployed
801+
let unversioned_recommended_labels = Labels::recommended(build_recommended_labels(
802+
kafka,
803+
KAFKA_CONTROLLER_NAME,
804+
// A version value is required, and we do want to use the "recommended" format for the other desired labels
805+
"none",
806+
&rolegroup_ref.role,
807+
&rolegroup_ref.role_group,
808+
))
809+
.context(LabelBuildSnafu)?;
800810

801811
let kcat_prober_container_name = Container::KcatProber.to_string();
802812
let mut cb_kcat_prober =
@@ -824,7 +834,7 @@ fn build_broker_rolegroup_statefulset(
824834
pvcs.push(
825835
ListenerOperatorVolumeSourceBuilder::new(
826836
&ListenerReference::ListenerName(kafka.bootstrap_service_name(rolegroup_ref)),
827-
&recommended_labels,
837+
&unversioned_recommended_labels,
828838
)
829839
.and_then(|builder| builder.build_pvc(LISTENER_BOOTSTRAP_VOLUME_NAME))
830840
.unwrap(),

0 commit comments

Comments
 (0)