Skip to content

Commit f256324

Browse files
committed
Clarify resource rules
1 parent 499cbb1 commit f256324

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

modules/contributor/pages/code-style-guide.adoc

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,12 +380,16 @@ We follow the Kubernetes convention described {k8s-quantity}[here].
380380
[source,rust]
381381
----
382382
// Biggest matching unit
383+
let memory: MemoryQuantity = "100Mi".parse();
383384
let memory: MemoryQuantity = "1.5Gi".parse();
384385
let memory: MemoryQuantity = "1Gi".parse();
386+
let memory: MemoryQuantity = "10Gi".parse();
385387
386388
// Always Mi
387-
let memory: MemoryQuantity = "1536Mi".parse();
389+
let memory: MemoryQuantity = "100Mi".parse();
388390
let memory: MemoryQuantity = "1024Mi".parse();
391+
let memory: MemoryQuantity = "1536Mi".parse();
392+
let memory: MemoryQuantity = "10240Mi".parse();
389393
390394
// No unit at all
391395
let memory: MemoryQuantity = "12345678".parse();
@@ -414,16 +418,22 @@ let memory: MemoryQuantity = "10Gi".parse();
414418
[source,rust]
415419
----
416420
// Biggest matching unit
421+
let memory: CpuQuantity = "100m".parse();
417422
let memory: CpuQuantity = "500m".parse();
418423
let memory: CpuQuantity = "1".parse();
424+
let memory: CpuQuantity = "2".parse();
419425
420426
// Always m
427+
let memory: CpuQuantity = "100m".parse();
421428
let memory: CpuQuantity = "500m".parse();
422429
let memory: CpuQuantity = "1000m".parse();
430+
let memory: CpuQuantity = "2000m".parse();
423431
424432
// Floating points
433+
let memory: CpuQuantity = "0.1".parse();
425434
let memory: CpuQuantity = "0.5".parse();
426435
let memory: CpuQuantity = "1".parse();
436+
let memory: CpuQuantity = "2".parse();
427437
----
428438
429439
====

0 commit comments

Comments
 (0)