Skip to content

Commit 387268d

Browse files
sbernaueradwk67maltesander
authored
Apply suggestions from code review
Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com> Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
1 parent 3a79d64 commit 387268d

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

modules/concepts/pages/overrides.adoc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -155,20 +155,20 @@ They will *not* be applied to:
155155
== JVM argument overrides
156156

157157
You can configure the JVM arguments used by JVM based tools.
158-
This is often times needed to e.g. configure a HTTP proxy or other network settings.
158+
This is often needed to e.g. configure a HTTP proxy or other network settings.
159159

160-
As with other overrides, the operator generates a set of JVM arguments that are needed to run the tool, you can specify additional arguments, which are merged on top of the ones the operator generated.
161-
As some JVm arguments are mutually exclusive (think of `-Xmx123m` and `-Xmx456m`), you also have the option to remove JVM arguments - either by specifying the exact argument or a regex.
160+
As with other overrides, the operator generates a set of JVM arguments that are needed to run the tool. You can specify additional arguments which are merged on top of the ones the operator generated.
161+
As some JVM arguments are mutually exclusive (think of `-Xmx123m` and `-Xmx456m`), you also have the option to remove JVM arguments - either by specifying the exact argument or a regex.
162162

163-
The merging mechanism is applied <operator-generated> <- <role user specified> <- <rolegroup user specified> and works as following:
163+
The merging mechanism is applied <operator-generated> <- <role user specified> <- <rolegroup user specified> and works as follows:
164164

165165
Let user be the user-specified arguments and operator be the arguments generated by the operator.
166166

167167
1. All arguments listed in user `remove` are removed from operator
168168
2. All arguments matching any regex from user `removeRegex` are removed from operator
169169
3. All arguments from user `add` are added to operator
170170
171-
You can check the resulting effective JVM arguments by looking at the ConfigMap containing the config for the roleGroup (although some tools read the JVM arguments from environmental variable).
171+
You can check the resulting effective JVM arguments by looking at the ConfigMap containing the config for the roleGroup (although some tools read the JVM arguments from environmental variables).
172172

173173
=== Simple example
174174

0 commit comments

Comments
 (0)