Skip to content

Commit 1d4836d

Browse files
committed
renamed options
1 parent 04d4247 commit 1d4836d

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

modules/contributor/pages/adr/ADR030-reduce-pod-disruptions.adoc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ spec:
9292

9393
NOTE: In the discussion the option of having the PDB directly in the role without a `roleConfig` was briefly discussed but not considered as an option due to being too messy, so it is not listed as an explicit option here.
9494

95-
=== Option 2a - PDB in `config`, but only at role level
95+
=== Option 2 - PDB in `config`, but only at role level
9696

9797
Instead of inventing a new `roleConfig` setting, put the PDB in the `config`. This might seem better at first, but usually settings in `config` can also be set at role group level, and in this case, that would not be true.
9898

@@ -123,9 +123,9 @@ spec:
123123
* Still no option to configure role group level PDBs
124124
* Possibly complicated to implement, due to `config` usually being identical at role and role group level
125125

126-
=== Option 2b: PDB in config with elaborate merge mechanism
126+
=== Option 3: PDB in config with elaborate merge mechanism
127127

128-
Similar to Option 2a, the PDB setting is located in the `config` but it is actually possible to use it at both role and role group level.
128+
Similar to Option 2, the PDB setting is located in the `config` but it is actually possible to use it at both role and role group level.
129129
We develop a semantic merge mechanism that would prevent overlapping PDBs.
130130

131131
.CRD Example
@@ -212,7 +212,7 @@ spec:
212212
* Complex merge mechanism possibly difficult to understand and therefore easy to use the wrong way
213213
* Complex mechanism also not trivial to implement
214214

215-
=== Option 2c - PDB in config with normal "shared role group config" behaviour
215+
=== Option 4 - PDB in config with normal "shared role group config" behaviour
216216

217217
Again we put the PDB in the `config` section but simply use the normal "copy" behaviour for this setting.
218218
This would be simple and easy to understand, but does not allow for true role level PDBs.

0 commit comments

Comments
 (0)