Skip to content

ES index names configurables #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 14, 2023
Merged

ES index names configurables #128

merged 4 commits into from
Jan 14, 2023

Conversation

ahuarte47
Copy link
Contributor

Related Issue(s):

Description:

Allows to define custom ES index name for "collections" and "items"

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the changelog

@jonhealy1 jonhealy1 self-requested a review January 13, 2023 21:20
jonhealy1
jonhealy1 requested changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I think. Could you add a note to the changelog? Also, it looks like pre-commit is failing. Could you run pre-commit again? Thanks

@ahuarte47
Copy link
Contributor Author

Looks good I think. Could you add a note to the changelog? Also, it looks like pre-commit is failing. Could you run pre-commit again? Thanks

Changed, thanks for your review

@jonhealy1 jonhealy1 merged commit dd6935e into stac-utils:main Jan 14, 2023
@ahuarte47
Copy link
Contributor Author

Thank you very much @jonhealy1 !!!

@ahuarte47 ahuarte47 deleted the main_indexnames_variables branch January 15, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhealy1 jonhealy1 jonhealy1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahuarte47 @jonhealy1