Skip to content

Commit 9a51574

Browse files
authored
Fix make test (#287)
**Description:** `make test` references an undefined variable, `APP_PORT`, which causes the the `docker-compose` command's `-p` argument to be malformed: ``` docker-compose run -p :8080 ... ^--- missing the left-side port! ``` **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [x] Tests pass (run `make test`) _The test failure in CI appears to be unrelated to this change._ - [ ] Documentation has been updated to reflect changes, if applicable - [ ] Changes are added to the changelog
1 parent 516e968 commit 9a51574

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!make
22
APP_HOST ?= 0.0.0.0
3-
EXTERNAL_APP_PORT ?= ${APP_PORT}
3+
EXTERNAL_APP_PORT ?= 8080
44

55
ES_APP_PORT ?= 8080
66
ES_HOST ?= docker.for.mac.localhost

0 commit comments

Comments
 (0)