Skip to content

Commit 11fcf4f

Browse files
squidfunksquidfunk
committed
Added aria labels to language and version selector
1 parent 2a5ba14 commit 11fcf4f

File tree

16 files changed

+41
-20
lines changed

16 files changed

+41
-20
lines changed

‎.github/ISSUE_TEMPLATE/translate.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,18 +30,23 @@ assignees: ''
3030
"search.config.separator": "[\s\-]+",
3131
"search.placeholder": "Search",
3232
"search.reset": "Clear",
33+
"search.result.initializer": "Initializing search",
3334
"search.result.placeholder": "Type to start searching",
3435
"search.result.none": "No matching documents",
3536
"search.result.one": "1 matching document",
3637
"search.result.other": "# matching documents",
3738
"search.result.more.one": "1 more on this page",
3839
"search.result.more.other": "# more on this page",
40+
"search.result.term.missing": "Missing",
41+
"select.language.title": "Select language",
42+
"select.version.title": "Select version",
3943
"skip.link.title": "Skip to content",
4044
"source.link.title": "Go to repository",
4145
"source.file.date.updated": "Last update",
4246
"source.file.date.created": "Created",
4347
"tabs.title": "Tabs",
44-
"toc.title": "Table of contents"
48+
"toc.title": "Table of contents",
49+
"top.title": "Back to top"
4550
}[key] }}{% endmacro %}
4651
```
4752

‎material/assets/javascripts/bundle.f8da964b.min.js renamed to ‎material/assets/javascripts/bundle.76f349be.min.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎material/assets/javascripts/bundle.f8da964b.min.js.map renamed to ‎material/assets/javascripts/bundle.76f349be.min.js.map

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎material/base.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,8 @@ <h1>{{ page.title | d(config.site_name, true)}}</h1>
214214
"search.result.other",
215215
"search.result.more.one",
216216
"search.result.more.other",
217-
"search.result.term.missing"
217+
"search.result.term.missing",
218+
"select.version.title"
218219
] -%}
219220
{%- set _ = translations.update({ key: lang.t(key) }) -%}
220221
{%- endfor -%}
@@ -223,7 +224,7 @@ <h1>{{ page.title | d(config.site_name, true)}}</h1>
223224
</script>
224225
{% endblock %}
225226
{% block scripts %}
226-
<script src="{{ 'assets/javascripts/bundle.f8da964b.min.js' | url }}"></script>
227+
<script src="{{ 'assets/javascripts/bundle.76f349be.min.js' | url }}"></script>
227228
{% for path in config["extra_javascript"] %}
228229
<script src="{{ path | url }}"></script>
229230
{% endfor %}

‎material/overrides/assets/javascripts/bundle.7a44c2b0.min.js renamed to ‎material/overrides/assets/javascripts/bundle.f989075e.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎material/overrides/assets/javascripts/bundle.7a44c2b0.min.js.map renamed to ‎material/overrides/assets/javascripts/bundle.f989075e.min.js.map

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎material/overrides/main.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,5 @@
3535
{% endblock %}
3636
{% block scripts %}
3737
{{ super() }}
38-
<script src="{{ 'overrides/assets/javascripts/bundle.7a44c2b0.min.js' | url }}"></script>
38+
<script src="{{ 'overrides/assets/javascripts/bundle.f989075e.min.js' | url }}"></script>
3939
{% endblock %}

‎material/partials/header.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
<div class="md-header__option">
4646
<div class="md-select">
4747
{% set icon = config.theme.icon.alternate or "material/translate" %}
48-
<button class="md-header__button md-icon" aria-label="{{ lang.t('language.select') }}">
48+
<button class="md-header__button md-icon" aria-label="{{ lang.t('select.language.title') }}">
4949
{% include ".icons/" ~ icon ~ ".svg" %}
5050
</button>
5151
<div class="md-select__inner">

‎material/partials/languages/de.html

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
"search.result.more.one": "1 weiteres Suchergebnis auf dieser Seite",
2121
"search.result.more.other": "# weitere Suchergebnisse auf dieser Seite",
2222
"search.result.term.missing": "Es fehlt",
23+
"select.language.title": "Sprache wechseln",
24+
"select.version.title": "Version auswählen",
2325
"skip.link.title": "Zum Inhalt",
2426
"source.link.title": "Quellcode",
2527
"source.revision.date": "Letztes Update",

‎material/partials/languages/en.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
"footer.next": "Next",
1212
"footer.title": "Footer",
1313
"header.title": "Header",
14-
"language.select": "Select language",
1514
"meta.comments": "Comments",
1615
"meta.source": "Source",
1716
"nav.title": "Navigation",
@@ -28,6 +27,8 @@
2827
"search.result.more.one": "1 more on this page",
2928
"search.result.more.other": "# more on this page",
3029
"search.result.term.missing": "Missing",
30+
"select.language.title": "Select language",
31+
"select.version.title": "Select version",
3132
"skip.link.title": "Skip to content",
3233
"source.link.title": "Go to repository",
3334
"source.revision.date": "Last update",

‎src/assets/javascripts/_/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ export type Translation =
5757
| "search.result.more.one" /* 1 more on this page */
5858
| "search.result.more.other" /* # more on this page */
5959
| "search.result.term.missing" /* Missing */
60+
| "select.version.title" /* Version selector */
6061

6162
/**
6263
* Translations

‎src/assets/javascripts/templates/version/index.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
* IN THE SOFTWARE.
2121
*/
2222

23-
import { configuration } from "~/_"
23+
import { configuration, translation } from "~/_"
2424
import { h } from "~/utilities"
2525

2626
/* ----------------------------------------------------------------------------
@@ -85,7 +85,10 @@ export function renderVersionSelector(versions: Version[]): HTMLElement {
8585
/* Render version selector */
8686
return (
8787
<div class="md-version">
88-
<button class="md-version__current">
88+
<button
89+
class="md-version__current"
90+
aria-label={translation("select.version.title")}
91+
>
8992
{active.title}
9093
</button>
9194
<ul class="md-version__list">

‎src/base.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,8 @@ <h1>{{ page.title | d(config.site_name, true)}}</h1>
386386
"search.result.other",
387387
"search.result.more.one",
388388
"search.result.more.other",
389-
"search.result.term.missing"
389+
"search.result.term.missing",
390+
"select.version.title"
390391
] -%}
391392
{%- set _ = translations.update({ key: lang.t(key) }) -%}
392393
{%- endfor -%}

‎src/partials/header.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,10 @@
103103
<div class="md-header__option"></form>
104104
<div class="md-select">
105105
{% set icon = config.theme.icon.alternate or "material/translate" %}
106-
<button class="md-header__button md-icon" aria-label="{{ lang.t('language.select') }}"">
106+
<button
107+
class="md-header__button md-icon"
108+
aria-label="{{ lang.t('select.language.title') }}"
109+
>
107110
{% include ".icons/" ~ icon ~ ".svg" %}
108111
</button>
109112
<div class="md-select__inner">

‎src/partials/languages/de.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,13 @@
4040
"search.result.more.one": "1 weiteres Suchergebnis auf dieser Seite",
4141
"search.result.more.other": "# weitere Suchergebnisse auf dieser Seite",
4242
"search.result.term.missing": "Es fehlt",
43+
"select.language.title": "Sprache wechseln",
44+
"select.version.title": "Version auswählen",
4345
"skip.link.title": "Zum Inhalt",
4446
"source.link.title": "Quellcode",
4547
"source.revision.date": "Letztes Update",
4648
"source.file.date.updated": "Letztes Update",
4749
"source.file.date.created": "Erstellt",
48-
"toc.title": "Inhaltsverzeichnis"
50+
"toc.title": "Inhaltsverzeichnis",
51+
"top.title": "Zurück zum Seitenanfang"
4952
}[key] }}{% endmacro %}

‎src/partials/languages/en.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
"footer.next": "Next",
3232
"footer.title": "Footer",
3333
"header.title": "Header",
34-
"language.select": "Select language",
3534
"meta.comments": "Comments",
3635
"meta.source": "Source",
3736
"nav.title": "Navigation",
@@ -48,6 +47,8 @@
4847
"search.result.more.one": "1 more on this page",
4948
"search.result.more.other": "# more on this page",
5049
"search.result.term.missing": "Missing",
50+
"select.language.title": "Select language",
51+
"select.version.title": "Select version",
5152
"skip.link.title": "Skip to content",
5253
"source.link.title": "Go to repository",
5354
"source.revision.date": "Last update",

0 commit comments

Comments
 (0)