From 36b91d9d7f6eedcd290adc869088de3b97477822 Mon Sep 17 00:00:00 2001 From: Oleksandr Redko Date: Fri, 7 Feb 2025 16:16:05 +0200 Subject: [PATCH 1/2] examples: Add missing Close calls --- examples/authors/sqlite/db_test.go | 1 + examples/booktest/sqlite/db_test.go | 1 + examples/ondeck/sqlite/db_test.go | 2 ++ internal/sqltest/sqlite.go | 3 +++ 4 files changed, 7 insertions(+) diff --git a/examples/authors/sqlite/db_test.go b/examples/authors/sqlite/db_test.go index 84f1939599..e10ce46069 100644 --- a/examples/authors/sqlite/db_test.go +++ b/examples/authors/sqlite/db_test.go @@ -12,6 +12,7 @@ import ( func TestAuthors(t *testing.T) { sdb, cleanup := sqltest.SQLite(t, []string{"schema.sql"}) + defer sdb.Close() defer cleanup() ctx := context.Background() diff --git a/examples/booktest/sqlite/db_test.go b/examples/booktest/sqlite/db_test.go index b9490245b3..a7d24060a4 100644 --- a/examples/booktest/sqlite/db_test.go +++ b/examples/booktest/sqlite/db_test.go @@ -18,6 +18,7 @@ const ( func TestBooks(t *testing.T) { db, cleanup := sqltest.SQLite(t, []string{"schema.sql"}) + defer sdb.Close() defer cleanup() ctx := context.Background() diff --git a/examples/ondeck/sqlite/db_test.go b/examples/ondeck/sqlite/db_test.go index 39264c26d4..e4bb4e4195 100644 --- a/examples/ondeck/sqlite/db_test.go +++ b/examples/ondeck/sqlite/db_test.go @@ -149,6 +149,7 @@ func TestPrepared(t *testing.T) { t.Parallel() sdb, cleanup := sqltest.SQLite(t, []string{"schema"}) + defer sdb.Close() defer cleanup() q, err := Prepare(context.Background(), sdb) @@ -163,6 +164,7 @@ func TestQueries(t *testing.T) { t.Parallel() sdb, cleanup := sqltest.SQLite(t, []string{"schema"}) + defer sdb.Close() defer cleanup() runOnDeckQueries(t, New(sdb)) diff --git a/internal/sqltest/sqlite.go b/internal/sqltest/sqlite.go index 72a154d0e1..0e5161967d 100644 --- a/internal/sqltest/sqlite.go +++ b/internal/sqltest/sqlite.go @@ -16,6 +16,9 @@ func SQLite(t *testing.T, migrations []string) (*sql.DB, func()) { if err != nil { t.Fatal(err) } + if err := source.Close(); err != nil { + t.Fatal(err) + } return CreateSQLiteDatabase(t, source.Name(), migrations) } From 0196e19b540d3013072d7749f4bb6758e626d0fb Mon Sep 17 00:00:00 2001 From: Kyle Gray Date: Fri, 7 Feb 2025 09:42:46 -0800 Subject: [PATCH 2/2] Update db_test.go --- examples/booktest/sqlite/db_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/booktest/sqlite/db_test.go b/examples/booktest/sqlite/db_test.go index a7d24060a4..42a8b396b1 100644 --- a/examples/booktest/sqlite/db_test.go +++ b/examples/booktest/sqlite/db_test.go @@ -18,7 +18,7 @@ const ( func TestBooks(t *testing.T) { db, cleanup := sqltest.SQLite(t, []string{"schema.sql"}) - defer sdb.Close() + defer db.Close() defer cleanup() ctx := context.Background()