From dafb1aa4a69d426b342ef4d7c1ced929463d1389 Mon Sep 17 00:00:00 2001 From: Kyle Conroy Date: Thu, 22 Feb 2024 09:07:33 -0800 Subject: [PATCH] fix(endtoend): Fix unsafe paths test on Windows Allow for OS specific stderr files --- internal/endtoend/case_test.go | 2 ++ .../wasm_plugin_sqlc_gen_unsafe_paths/stderr_windows.txt | 2 ++ 2 files changed, 4 insertions(+) create mode 100644 internal/endtoend/testdata/wasm_plugin_sqlc_gen_unsafe_paths/stderr_windows.txt diff --git a/internal/endtoend/case_test.go b/internal/endtoend/case_test.go index 8299647745..4389a4da28 100644 --- a/internal/endtoend/case_test.go +++ b/internal/endtoend/case_test.go @@ -5,6 +5,7 @@ import ( "fmt" "os" "path/filepath" + "runtime" "strings" "testing" ) @@ -34,6 +35,7 @@ func parseStderr(t *testing.T, dir, testctx string) []byte { t.Helper() paths := []string{ filepath.Join(dir, "stderr", fmt.Sprintf("%s.txt", testctx)), + filepath.Join(dir, fmt.Sprintf("stderr_%s.txt", runtime.GOOS)), filepath.Join(dir, "stderr.txt"), } for _, path := range paths { diff --git a/internal/endtoend/testdata/wasm_plugin_sqlc_gen_unsafe_paths/stderr_windows.txt b/internal/endtoend/testdata/wasm_plugin_sqlc_gen_unsafe_paths/stderr_windows.txt new file mode 100644 index 0000000000..33d32af53a --- /dev/null +++ b/internal/endtoend/testdata/wasm_plugin_sqlc_gen_unsafe_paths/stderr_windows.txt @@ -0,0 +1,2 @@ +# package test +error generating code: invalid file output path: D:/tmp/unsafe.txt