From e8fe6cdfd0ff5cc4a33de430d1e06f283c21c2a2 Mon Sep 17 00:00:00 2001 From: Kyle Conroy Date: Fri, 22 Sep 2023 14:33:22 -0700 Subject: [PATCH] chore(endtoend): Skip tests missing secrets GitHub does not populate secrets on pull requests sent from a forked repository. Skip tests that require these secrets when they aren't present. --- internal/endtoend/ddl_test.go | 7 +------ internal/endtoend/vet_test.go | 5 +++++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/internal/endtoend/ddl_test.go b/internal/endtoend/ddl_test.go index 123a503ce1..46ec73b75c 100644 --- a/internal/endtoend/ddl_test.go +++ b/internal/endtoend/ddl_test.go @@ -23,13 +23,8 @@ func TestValidSchema(t *testing.T) { projectID := os.Getenv("CI_SQLC_PROJECT_ID") authToken := os.Getenv("CI_SQLC_AUTH_TOKEN") - if projectID == "" || authToken == "" { - if os.Getenv("CI") == "" { - t.Skip("skiping ddl tests outside of CI") - } else { - t.Fatal("missing project id and auth token") - } + t.Skip("missing project id or auth token") } client, err := quickdb.NewClient(projectID, authToken) diff --git a/internal/endtoend/vet_test.go b/internal/endtoend/vet_test.go index 74f3ea9031..f5fc47ac92 100644 --- a/internal/endtoend/vet_test.go +++ b/internal/endtoend/vet_test.go @@ -31,6 +31,11 @@ func TestExamplesVet(t *testing.T) { t.Parallel() ctx := context.Background() + authToken := os.Getenv("SQLC_AUTH_TOKEN") + if authToken == "" { + t.Skip("missing auth token") + } + examples, err := filepath.Abs(filepath.Join("..", "..", "examples")) if err != nil { t.Fatal(err)