Skip to content

Commit f88ddd5

Browse files
authored
internal/dinosql: Return parser errors first (#207)
1 parent a7689ef commit f88ddd5

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

internal/cmd/cmd.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ var genCmd = &cobra.Command{
161161
fmt.Fprintf(os.Stderr, "%s:%d:%d: %s\n", fileErr.Filename, fileErr.Line, fileErr.Column, fileErr.Err)
162162
}
163163
} else {
164-
fmt.Fprintf(os.Stderr, "error parsing schema: %s\n", err)
164+
fmt.Fprintf(os.Stderr, "error parsing queries: %s\n", err)
165165
}
166166
errored = true
167167
continue

internal/dinosql/parser.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -236,12 +236,12 @@ func ParseQueries(c core.Catalog, settings GenerateSettings, pkg PackageSettings
236236
}
237237
}
238238
}
239-
if len(q) == 0 {
240-
return nil, fmt.Errorf("path %s contains no queries", pkg.Queries)
241-
}
242239
if len(merr.Errs) > 0 {
243240
return nil, merr
244241
}
242+
if len(q) == 0 {
243+
return nil, fmt.Errorf("path %s contains no queries", pkg.Queries)
244+
}
245245
return &Result{Catalog: c, Queries: q, Settings: settings}, nil
246246
}
247247

0 commit comments

Comments
 (0)