fix: Search from Rexpr if not found from Lexpr (#2056)

* fix: Search from Rexpr if not found from Lexpr

* regenerated existing testdata

* add params_placeholder_in_left_expr test

Author: zaneli

internal/compiler/resolve.go

@@ -113,6 +113,12 @@ func (comp *Compiler) resolveCatalogRefs(qc *QueryCatalog, rvs []*ast.RangeVar,
 				_, ok := node.(*ast.ColumnRef)
 				return ok
 			})
+			if len(list.Items) == 0 {
+				list = astutils.Search(n.Rexpr, func(node ast.Node) bool {
+					_, ok := node.(*ast.ColumnRef)
+					return ok
+				})
+			}
 
 			if len(list.Items) == 0 {
 				// TODO: Move this to database-specific engine package
@@ -135,9 +141,9 @@ func (comp *Compiler) resolveCatalogRefs(qc *QueryCatalog, rvs []*ast.RangeVar,
 				continue
 			}
 
-			switch left := list.Items[0].(type) {
+			switch node := list.Items[0].(type) {
 			case *ast.ColumnRef:
-				items := stringSlice(left.Fields)
+				items := stringSlice(node.Fields)
 				var key, alias string
 				switch len(items) {
 				case 1:
@@ -165,7 +171,7 @@ func (comp *Compiler) resolveCatalogRefs(qc *QueryCatalog, rvs []*ast.RangeVar,
 							return nil, &sqlerr.Error{
 								Code:     "42703",
 								Message:  fmt.Sprintf("table alias \"%s\" does not exist", alias),
-								Location: left.Location,
+								Location: node.Location,
 							}
 						}
 					}
@@ -204,14 +210,14 @@ func (comp *Compiler) resolveCatalogRefs(qc *QueryCatalog, rvs []*ast.RangeVar,
 					return nil, &sqlerr.Error{
 						Code:     "42703",
 						Message:  fmt.Sprintf("column \"%s\" does not exist", key),
-						Location: left.Location,
+						Location: node.Location,
 					}
 				}
 				if found > 1 {
 					return nil, &sqlerr.Error{
 						Code:     "42703",
 						Message:  fmt.Sprintf("column reference \"%s\" is ambiguous", key),
-						Location: left.Location,
+						Location: node.Location,
 					}
 				}
 			}

internal/endtoend/testdata/params_duplicate/mysql/go/query.sql.go

@@ -0,0 +1,10 @@
+CREATE TABLE users (
+    id INTEGER NOT NULL AUTO_INCREMENT PRIMARY KEY,
+    name VARCHAR(255)
+) ENGINE=InnoDB;
+
+-- name: FindByID :many
+SELECT * FROM users WHERE ? = id;
+
+-- name: FindByIDAndName :many
+SELECT * FROM users WHERE ? = id AND ? = name;

internal/endtoend/testdata/params_duplicate/postgresql/go/query.sql.go

@@ -0,0 +1,12 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "path": "go",
+      "engine": "mysql",
+      "name": "querytest",
+      "schema": "query.sql",
+      "queries": "query.sql"
+    }
+  ]
+}

internal/endtoend/testdata/params_placeholder_in_left_expr/mysql/go/db.go

@@ -0,0 +1,10 @@
+CREATE TABLE users (
+    id INT PRIMARY KEY,
+    name VARCHAR(255)
+);
+
+-- name: FindByID :many
+SELECT * FROM users WHERE ? = id;
+
+-- name: FindByIDAndName :many
+SELECT * FROM users WHERE ? = id AND ? = name;

internal/endtoend/testdata/params_placeholder_in_left_expr/mysql/go/models.go

@@ -0,0 +1,12 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "path": "go",
+      "engine": "postgresql",
+      "name": "querytest",
+      "schema": "query.sql",
+      "queries": "query.sql"
+    }
+  ]
+}