Skip to content

Commit e3c657d

Browse files
authored
fix(mysql)!: Generate unsigned param (#2522)
A fix to the original change (#1746) that added support for unsigned integers. While this is a breaking change, it's impact should be smaller than the previous change. * fix missing unsigned param * add end-to-end test for unsigned_params
1 parent b9c3af4 commit e3c657d

File tree

7 files changed

+79
-1
lines changed

7 files changed

+79
-1
lines changed

internal/compiler/resolve.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -458,6 +458,7 @@ func (comp *Compiler) resolveCatalogRefs(qc *QueryCatalog, rvs []*ast.RangeVar,
458458
OriginalName: c.Name,
459459
DataType: dataType(&c.Type),
460460
NotNull: p.NotNull(),
461+
Unsigned: c.IsUnsigned,
461462
IsArray: c.IsArray,
462463
Table: &ast.TableName{Schema: schema, Name: rel},
463464
Length: c.Length,

internal/endtoend/testdata/schema_scoped_create/mysql/go/query.sql.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/unsigned_params/mysql/go/db.go

Lines changed: 31 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/unsigned_params/mysql/go/models.go

Lines changed: 11 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/unsigned_params/mysql/go/query.sql.go

Lines changed: 19 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
CREATE TABLE foo (id INT UNSIGNED NOT NULL);
2+
3+
-- name: CreateFoo :exec
4+
INSERT INTO foo (id) VALUES (?);
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
{
2+
"version": "1",
3+
"packages": [
4+
{
5+
"path": "go",
6+
"engine": "mysql",
7+
"name": "querytest",
8+
"schema": "query.sql",
9+
"queries": "query.sql"
10+
}
11+
]
12+
}

0 commit comments

Comments
 (0)