Skip to content

Commit dfc8ab5

Browse files
committed
fix json tag naming for embeds
1 parent d3f6b2c commit dfc8ab5

File tree

5 files changed

+23
-19
lines changed

5 files changed

+23
-19
lines changed

internal/codegen/golang/result.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ func buildStructs(req *plugin.CodeGenRequest) []Struct {
6969
s := Struct{
7070
Table: plugin.Identifier{Schema: schema.Name, Name: table.Rel.Name},
7171
Name: StructName(structName, req.Settings),
72+
TagName: structName,
7273
Comment: table.Comment,
7374
}
7475
for _, column := range table.Columns {
@@ -343,7 +344,7 @@ func columnsToStruct(req *plugin.CodeGenRequest, name string, embeds []goEmbed,
343344
for _, em := range embeds {
344345

345346
fieldName := em.Model.Name
346-
tagName := fieldName
347+
tagName := em.Model.TagName
347348

348349
seen, ok := seenEmbeds[fieldName]
349350
if !ok {

internal/codegen/golang/struct.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
type Struct struct {
1212
Table plugin.Identifier
1313
Name string
14+
TagName string
1415
EmbedFields []EmbedField
1516
Fields []Field
1617
Comment string

internal/endtoend/testdata/sqlc_embed/postgresql/pgx/go/models.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/sqlc_embed/postgresql/pgx/go/query.sql.go

Lines changed: 12 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/sqlc_embed/postgresql/pgx/sqlc.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
"sql_package": "pgx/v4",
88
"name": "querytest",
99
"schema": "query.sql",
10-
"queries": "query.sql"
10+
"queries": "query.sql",
11+
"emit_json_tags": true,
12+
"emit_db_tags": true
1113
}
1214
]
1315
}

0 commit comments

Comments
 (0)