fix(compiler): Check delete statements for CTEs (#1329)

Author: wabain

internal/compiler/query_catalog.go

@@ -15,6 +15,8 @@ type QueryCatalog struct {
 func buildQueryCatalog(c *catalog.Catalog, node ast.Node) (*QueryCatalog, error) {
 	var with *ast.WithClause
 	switch n := node.(type) {
+	case *ast.DeleteStmt:
+		with = n.WithClause
 	case *ast.InsertStmt:
 		with = n.WithClause
 	case *ast.UpdateStmt:

internal/endtoend/testdata/cte_in_delete/mysql/go/db.go

@@ -0,0 +1,7 @@
+CREATE TABLE bar (id integer NOT NULL AUTO_INCREMENT PRIMARY KEY, ready bool not null);
+
+-- name: DeleteReadyWithCTE :exec
+WITH ready_ids AS (
+	SELECT id FROM bar WHERE ready
+)
+DELETE FROM bar WHERE id IN (SELECT * FROM ready_ids);

internal/endtoend/testdata/cte_in_delete/mysql/go/models.go

@@ -0,0 +1,12 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "engine": "mysql",
+      "path": "go",
+      "name": "querytest",
+      "schema": "query.sql",
+      "queries": "query.sql"
+    }
+  ]
+}

internal/endtoend/testdata/cte_in_delete/mysql/go/query.sql.go

@@ -0,0 +1,8 @@
+CREATE TABLE bar (id serial primary key not null, ready bool not null);
+
+-- name: DeleteReadyWithCTE :many
+WITH ready_ids AS (
+	SELECT id FROM bar WHERE ready
+)
+DELETE FROM bar WHERE id IN (SELECT * FROM ready_ids)
+RETURNING id;

internal/endtoend/testdata/cte_in_delete/mysql/query.sql

@@ -0,0 +1,13 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "path": "go",
+      "engine": "postgresql",
+      "sql_package": "pgx/v4",
+      "name": "querytest",
+      "schema": "query.sql",
+      "queries": "query.sql"
+    }
+  ]
+}

internal/endtoend/testdata/cte_in_delete/mysql/sqlc.json

@@ -0,0 +1,8 @@
+CREATE TABLE bar (id serial primary key not null, ready bool not null);
+
+-- name: DeleteReadyWithCTE :many
+WITH ready_ids AS (
+	SELECT id FROM bar WHERE ready
+)
+DELETE FROM bar WHERE id IN (SELECT * FROM ready_ids)
+RETURNING id;

internal/endtoend/testdata/cte_in_delete/pgx/go/db.go

@@ -0,0 +1,11 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "path": "go",
+      "name": "querytest",
+      "schema": "query.sql",
+      "queries": "query.sql"
+    }
+  ]
+}