compiler: Apply rename rules to enum constants (#523)

* compiler: Apply rename rules to enum constants

* endtoend: Add rename test case

* endtoend: Don't test rename via old parser

Author: kyleconroy

internal/codegen/golang/enum.go

@@ -19,6 +19,13 @@ type Enum struct {
 	Constants []Constant
 }
 
+func EnumReplace(value string) string {
+	id := strings.Replace(value, "-", "_", -1)
+	id = strings.Replace(id, ":", "_", -1)
+	id = strings.Replace(id, "/", "_", -1)
+	return IdentPattern.ReplaceAllString(id, "")
+}
+
 func EnumValueName(value string) string {
 	name := ""
 	id := strings.Replace(value, "-", "_", -1)

internal/compiler/result.go

@@ -101,7 +101,7 @@ func (r *Result) Enums(settings config.CombinedSettings) []golang.Enum {
 			}
 			for _, v := range enum.Vals {
 				e.Constants = append(e.Constants, golang.Constant{
-					Name:  e.Name + golang.EnumValueName(v),
+					Name:  golang.StructName(enumName+"_"+golang.EnumReplace(v), settings),
 					Value: v,
 					Type:  e.Name,
 				})

internal/endtoend/testdata/rename/endtoend.json

@@ -0,0 +1,3 @@
+{
+  "experimental_parser_only": true
+}

internal/endtoend/testdata/rename/go/db.go

@@ -0,0 +1,12 @@
+CREATE TYPE ip_protocol AS enum('tcp', 'ip', 'icmp');
+
+CREATE TABLE bar_old (id_old serial not null, ip_old ip_protocol NOT NULL);
+
+-- name: ListFoo :many
+SELECT id_old as foo_old, id_old as baz_old
+FROM bar_old
+WHERE ip_old = $1 AND id_old = $2;
+
+-- name: ListBar :many
+SELECT * FROM bar_old;
+

internal/endtoend/testdata/rename/go/models.go

@@ -0,0 +1,18 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "path": "go",
+      "name": "querytest",
+      "schema": "query.sql",
+      "queries": "query.sql"
+    }
+  ],
+  "rename": {
+    "id_old": "IDNew",
+    "bar_old": "BarNew",
+    "foo_old": "FooNew",
+    "ip_protocol": "IPProtocol",
+    "ip_protocol_tcp": "IPProtocolTCP"
+  }
+}