Skip to content

Commit 8a931ec

Browse files
authored
config: Remove "emit_single_file" option (#367)
I figured out a better way to do the playground, so this short-lived option is no longer needed.
1 parent 3978046 commit 8a931ec

File tree

7 files changed

+2
-451
lines changed

7 files changed

+2
-451
lines changed

internal/config/config.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ type SQLGo struct {
8181
EmitInterface bool `json:"emit_interface" yaml:"emit_interface"`
8282
EmitJSONTags bool `json:"emit_json_tags" yaml:"emit_json_tags"`
8383
EmitPreparedQueries bool `json:"emit_prepared_queries" yaml:"emit_prepared_queries":`
84-
EmitSingleFile bool `json:"emit_single_file" yaml:"emit_single_file":`
8584
Package string `json:"package" yaml:"package"`
8685
Out string `json:"out" yaml:"out"`
8786
Overrides []Override `json:"overrides,omitempty" yaml:"overrides"`

internal/config/v_one.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ type v1PackageSettings struct {
2424
EmitInterface bool `json:"emit_interface" yaml:"emit_interface"`
2525
EmitJSONTags bool `json:"emit_json_tags" yaml:"emit_json_tags"`
2626
EmitPreparedQueries bool `json:"emit_prepared_queries" yaml:"emit_prepared_queries"`
27-
EmitSingleFile bool `json:"emit_single_file" yaml:"emit_single_file"`
2827
Overrides []Override `json:"overrides" yaml:"overrides"`
2928
}
3029

@@ -104,7 +103,6 @@ func (c *V1GenerateSettings) Translate() Config {
104103
EmitInterface: pkg.EmitInterface,
105104
EmitJSONTags: pkg.EmitJSONTags,
106105
EmitPreparedQueries: pkg.EmitPreparedQueries,
107-
EmitSingleFile: pkg.EmitSingleFile,
108106
Package: pkg.Name,
109107
Out: pkg.Path,
110108
Overrides: pkg.Overrides,

internal/dinosql/gen.go

Lines changed: 2 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -222,15 +222,6 @@ func mergeImports(imps ...fileImports) [][]string {
222222

223223
func Imports(r Generateable, settings config.CombinedSettings) func(string) [][]string {
224224
return func(filename string) [][]string {
225-
if filename == "all.go" {
226-
var imps []fileImports
227-
imps = append(imps, dbImports(r, settings))
228-
imps = append(imps, modelImports(r, settings))
229-
imps = append(imps, interfaceImports(r, settings))
230-
imps = append(imps, queryImports(r, settings, filename))
231-
return mergeImports(imps...)
232-
}
233-
234225
if filename == "db.go" {
235226
return mergeImports(dbImports(r, settings))
236227
}
@@ -401,7 +392,7 @@ func queryImports(r Generateable, settings config.CombinedSettings, filename str
401392
// }
402393
var gq []GoQuery
403394
for _, query := range r.GoQueries(settings) {
404-
if query.SourceName == filename || settings.Go.EmitSingleFile {
395+
if query.SourceName == filename {
405396
gq = append(gq, query)
406397
}
407398
}
@@ -1272,26 +1263,6 @@ func (q *Queries) {{.MethodName}}(ctx context.Context, {{.Arg.Pair}}) (int64, er
12721263
{{end}}
12731264
{{end}}
12741265
{{end}}
1275-
1276-
{{define "singleFile"}}// Code generated by sqlc. DO NOT EDIT.
1277-
1278-
package {{.Package}}
1279-
1280-
import (
1281-
{{range imports "all.go"}}
1282-
{{range .}}"{{.}}"
1283-
{{end}}
1284-
{{end}}
1285-
)
1286-
1287-
{{template "modelsCode" . }}
1288-
1289-
{{template "queryCode" . }}
1290-
1291-
{{template "dbCode" . }}
1292-
1293-
{{template "interfaceCode" . }}
1294-
{{end}}
12951266
`
12961267

12971268
type tmplCtx struct {
@@ -1308,11 +1279,10 @@ type tmplCtx struct {
13081279
EmitJSONTags bool
13091280
EmitPreparedQueries bool
13101281
EmitInterface bool
1311-
EmitSingleFile bool
13121282
}
13131283

13141284
func (t *tmplCtx) OutputQuery(sourceName string) bool {
1315-
return t.SourceName == sourceName || t.EmitSingleFile
1285+
return t.SourceName == sourceName
13161286
}
13171287

13181288
func LowerTitle(s string) string {
@@ -1340,7 +1310,6 @@ func Generate(r Generateable, settings config.CombinedSettings) (map[string]stri
13401310
EmitInterface: golang.EmitInterface,
13411311
EmitJSONTags: golang.EmitJSONTags,
13421312
EmitPreparedQueries: golang.EmitPreparedQueries,
1343-
EmitSingleFile: golang.EmitSingleFile,
13441313
Q: "`",
13451314
Package: golang.Package,
13461315
GoQueries: r.GoQueries(settings),
@@ -1371,14 +1340,6 @@ func Generate(r Generateable, settings config.CombinedSettings) (map[string]stri
13711340
return nil
13721341
}
13731342

1374-
// Output a single file with all code
1375-
if golang.EmitSingleFile {
1376-
if err := execute("db.go", "singleFile"); err != nil {
1377-
return nil, err
1378-
}
1379-
return output, nil
1380-
}
1381-
13821343
if err := execute("db.go", "dbFile"); err != nil {
13831344
return nil, err
13841345
}

0 commit comments

Comments
 (0)