fix(analyzer): Error on unexpanded star expression (#2882)

* fix(analyzer): Error on unexpanded star expression

If a query includes a star reference, error if we're unable to expand
that reference. The new analyzer will happily anaylyze that code. If
executed at runtime, these queries could change values.

* Update config

Author: kyleconroy

internal/compiler/parse.go

@@ -84,6 +84,18 @@ func (c *Compiler) parseQuery(stmt ast.Node, src string, o opts.Parser) (*Query,
 			return nil, err
 		}
 
+		// If the query uses star expansion, verify that it was edited. If not,
+		// return an error.
+		stars := astutils.Search(raw, func(node ast.Node) bool {
+			_, ok := node.(*ast.A_Star)
+			return ok
+		})
+		hasStars := len(stars.Items) > 0
+		unchanged := inference.Query == rawSQL
+		if unchanged && hasStars {
+			return nil, fmt.Errorf("star expansion failed for query")
+		}
+
 		// FOOTGUN: combineAnalysis mutates inference
 		anlys = combineAnalysis(inference, result)
 	} else {

internal/endtoend/testdata/case_value_param/postgresql/exec.json

@@ -0,0 +1,3 @@
+{
+    "contexts": ["base"]
+}

internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/exec.json

@@ -0,0 +1,3 @@
+{
+  "contexts": ["managed-db"]
+}

internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/go/db.go

@@ -0,0 +1,13 @@
+-- name: GetLatestVersionWithSubquery :one
+SELECT * 
+FROM versions
+WHERE versions.id IN (
+  WITH RECURSIVE search_tree(id) AS (
+	SELECT id, 0 as chain_id, 0 as chain_counter
+    FROM versions
+  )
+  SELECT DISTINCT ON (search_tree.chain_id) 
+	search_tree.id
+  FROM search_tree   
+  ORDER BY search_tree.chain_id, chain_counter DESC
+);

internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/go/models.go

@@ -0,0 +1,6 @@
+-- Example queries for sqlc
+CREATE TABLE versions (
+  id   BIGSERIAL PRIMARY KEY,
+  name TEXT,
+  previous_version_id bigint NOT NULL
+);

internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/go/query.sql.go

@@ -0,0 +1,10 @@
+version: "2"
+sql:
+  - engine: "postgresql"
+    schema: "schema.sql"
+    queries: "query.sql"
+    gen:
+      go:
+        package: "querytest"
+        out: "go"
+        sql_package: "pgx/v5"

internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/query.sql

@@ -0,0 +1,2 @@
+# package querytest
+query.sql:1:1: star expansion failed for query