Skip to content

Commit 5ffeed0

Browse files
committed
move validation after rewriting named parameters
1 parent 157bc65 commit 5ffeed0

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

internal/compiler/parse.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,10 @@ func (c *Compiler) parseQuery(stmt ast.Node, src string, o opts.Parser) (*Query,
8080
if err != nil {
8181
return nil, err
8282
}
83+
raw, namedParams, edits := rewrite.NamedParameters(c.conf.Engine, raw, numbers, dollar)
8384
if err := validate.Cmd(raw.Stmt, name, cmd); err != nil {
8485
return nil, err
8586
}
86-
87-
raw, namedParams, edits := rewrite.NamedParameters(c.conf.Engine, raw, numbers, dollar)
8887
rvs := rangeVars(raw.Stmt)
8988
refs, err := findParameters(raw.Stmt)
9089
if err != nil {

internal/sql/validate/cmd.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ import (
66

77
"github.com/kyleconroy/sqlc/internal/metadata"
88
"github.com/kyleconroy/sqlc/internal/sql/ast"
9-
"github.com/kyleconroy/sqlc/internal/sql/astutils"
10-
"github.com/kyleconroy/sqlc/internal/sql/named"
119
)
1210

1311
func validateCopyfrom(n ast.Node) error {
@@ -47,11 +45,6 @@ func validateCopyfrom(n ast.Node) error {
4745
}
4846

4947
func validateBatch(n ast.Node) error {
50-
namedFunc := astutils.Search(n, named.IsParamFunc)
51-
namedSign := astutils.Search(n, named.IsParamSign)
52-
if len(namedFunc.Items)+len(namedSign.Items) > 0 {
53-
return nil
54-
}
5548
nums, _, _ := ParamRef(n)
5649
if len(nums) == 0 {
5750
return errors.New(":batch* commands require parameters")

0 commit comments

Comments
 (0)