internal/dinosql: Filter out invalid characters (#198)

* internal/dinosql: Filter out invalid characters

Ensure that enum identifiers are valid

* Ignore certain values when picking names

Author: kyleconroy

internal/dinosql/gen.go

@@ -7,6 +7,7 @@ import (
 	"go/format"
 	"log"
 	"path/filepath"
+	"regexp"
 	"sort"
 	"strings"
 	"text/template"
@@ -17,6 +18,8 @@ import (
 	"github.com/jinzhu/inflection"
 )
 
+var identPattern = regexp.MustCompile("[^a-zA-Z0-9]+")
+
 type GoConstant struct {
 	Name  string
 	Type  string
@@ -404,7 +407,11 @@ func (r Result) Enums() []GoEnum {
 			}
 			for _, v := range enum.Vals {
 				name := ""
-				for _, part := range strings.Split(strings.Replace(v, "-", "_", -1), "_") {
+				id := strings.Replace(v, "-", "_", -1)
+				id = strings.Replace(id, ":", "_", -1)
+				id = strings.Replace(id, "/", "_", -1)
+				id = identPattern.ReplaceAllString(id, "")
+				for _, part := range strings.Split(id, "_") {
 					name += strings.Title(part)
 				}
 				e.Constants = append(e.Constants, GoConstant{

internal/dinosql/testdata/ondeck/models.go

@@ -1,4 +1,4 @@
-CREATE TYPE status AS ENUM ('open', 'closed');
+CREATE TYPE status AS ENUM ('op!en', 'clo@sed');
 COMMENT ON TYPE status IS 'Venues can be either open or closed';
 
 CREATE TABLE venues (