returning errors instead of nil

dominikbraun · dominikbraun · commit 3ccee3348d2e · 2019-12-16T00:38:32.000+01:00
diff --git a/internal/dinosql/parser.go b/internal/dinosql/parser.go
@@ -371,7 +371,7 @@ func parseQuery(c core.Catalog, stmt nodes.Node, source string) (*Query, error)
 	}
 	raw, ok := stmt.(nodes.RawStmt)
 	if !ok {
-		return nil, nil
+		return nil, errors.New("node is not a statement")
 	}
 	switch n := raw.Stmt.(type) {
 	case nodes.SelectStmt:
@@ -382,7 +382,7 @@ func parseQuery(c core.Catalog, stmt nodes.Node, source string) (*Query, error)
 		}
 	case nodes.UpdateStmt:
 	default:
-		return nil, nil
+		return nil, fmt.Errorf("parseQuery: unsupported statement type: %T", n)
 	}
 
 	rawSQL, err := pluckQuery(source, raw)

Original file line number	Diff line number	Diff line change
`@@ -371,7 +371,7 @@ func parseQuery(c core.Catalog, stmt nodes.Node, source string) (*Query, error)`
`371`	`371`	`}`
`372`	`372`	`raw, ok := stmt.(nodes.RawStmt)`
`373`	`373`	`if !ok {`
`374`		`- return nil, nil`
	`374`	`+ return nil, errors.New("node is not a statement")`
`375`	`375`	`}`
`376`	`376`	`switch n := raw.Stmt.(type) {`
`377`	`377`	`case nodes.SelectStmt:`
`@@ -382,7 +382,7 @@ func parseQuery(c core.Catalog, stmt nodes.Node, source string) (*Query, error)`
`382`	`382`	`}`
`383`	`383`	`case nodes.UpdateStmt:`
`384`	`384`	`default:`
`385`		`- return nil, nil`
	`385`	`+ return nil, fmt.Errorf("parseQuery: unsupported statement type: %T", n)`
`386`	`386`	`}`
`387`	`387`
`388`	`388`	`rawSQL, err := pluckQuery(source, raw)`